Re: [DISCUSS]: KIP-230: Name Windowing Joins

2018-09-30 Thread Matthias J. Sax
With KIP-372 accepted, we can retire this KIP, because it's subsumed. https://cwiki.apache.org/confluence/display/KAFKA/KIP-372%3A+Naming+Repartition+Topics+for+Joins+and+Grouping I'll update the wiki pages accordingly. Thanks for initiating this KIP Florian! -Matthias On 6/10/18 5:24 PM, Mat

Re: [DISCUSS]: KIP-230: Name Windowing Joins

2018-06-10 Thread Matthias J. Sax
What is the status of this KIP? I also want to point out, that it seems that there is some overlap with KIP-307 that was proposed recently (I cc'ed Florian who proposed KIP-307). KIP-230 might even be subsumed. I any case, it would be good to sync up and collaborate for both KIPs. -Matthias O

Re: [DISCUSS]: KIP-230: Name Windowing Joins

2018-02-28 Thread Guozhang Wang
Hi Matthias, I've also made a pass over the KIP, aside from the-other-Matthias's comment, I'm wondering if you have scenarios that want to distinguish the two internal topics of the join? Currently we use "-this" and "-other" suffix for the topics. So for example: stream1.join(stream2, ...) //

Re: [DISCUSS]: KIP-230: Name Windowing Joins

2018-02-13 Thread Matthias Margush
Thanks for the reminder! I need to do some wordsmithing based on the feedback I’ve gotten. I’ll do that soon (hopefully). On Tue, Feb 13, 2018 at 1:45 PM Matthias J. Sax wrote: > Is there any updates for this KIP? > > -Matthias > > On 12/28/17 12:27 PM, Matthias J. Sax wrote: > > Thanks for updat

Re: [DISCUSS]: KIP-230: Name Windowing Joins

2018-02-13 Thread Matthias J. Sax
Is there any updates for this KIP? -Matthias On 12/28/17 12:27 PM, Matthias J. Sax wrote: > Thanks for updating the KIP. > > The code-diff is a little hard to read. It's better to so something > similar as in this KIP: > https://cwiki.apache.org/confluence/display/KAFKA/KIP-245%3A+Use+Propertie

Re: [DISCUSS]: KIP-230: Name Windowing Joins

2017-12-28 Thread Matthias J. Sax
Thanks for updating the KIP. The code-diff is a little hard to read. It's better to so something similar as in this KIP: https://cwiki.apache.org/confluence/display/KAFKA/KIP-245%3A+Use+Properties+instead+of+StreamsConfig+in+KafkaStreams+constructor (Just as an example. Maybe take a look as othe

Re: [DISCUSS]: KIP-230: Name Windowing Joins

2017-12-26 Thread Matthias Margush
Greetings. Thanks for the comments and suggestions. I updated the KIP with these proposals for the questions posed by Matt & Matthias: *Can you please c&p the corresponding content instead of just putting links? A KIP should be a self-contained Wiki page. Also, if we add a optional config paramet

Re: [DISCUSS]: KIP-230: Name Windowing Joins

2017-12-04 Thread Matthias J. Sax
Matthias, thanks for the KIP. Can you please c&p the corresponding content instead of just putting links? A KIP should be a self-contained Wiki page. Also, if we add a optional config parameter, how would we specify it? Please list all changes to want to apply to `Joined` class. Furthermore, `J

Re: [DISCUSS]: KIP-230: Name Windowing Joins

2017-11-29 Thread Matt Farmer
Hi Matthias, I certainly have found the auto-generated names unwieldy while doing cluster administration. I will point out that your KIP doesn't outline what would happen if you picked a name that resulted in a non unique topic name? What would be the error handling behavior there? On Wed, Nov 2

[DISCUSS]: KIP-230: Name Windowing Joins

2017-11-29 Thread Matthias Margush
Hi everyone, I created this KIP to allow windowing joins to be named. If named, then the associated internal topic names would be derived from that, instead of being randomly generated. https://cwiki.apache.org/confluence/display/KAFKA/KIP+230%3A+Name+Windowing+Joins Thanks, Matthias