Re: [VOTE] KIP-622 Add currentSystemTimeMs and currentStreamTimeMs to ProcessorContext

2021-03-05 Thread Rohit Deshpande
kProcessorContext#setRecordTimestamp which does the same work. Please let me know if you have any thoughts or concerns with this change. Thanks, Roohit On Fri, Dec 4, 2020 at 7:31 PM Rohit Deshpande wrote: > Hello all, > I am closing the vote for this KIP: > https://cwiki.apache.org/confluence/di

[jira] [Resolved] (KAFKA-10871) StreamTask shouldn't take WallClockTime as input parameter in process method

2020-12-23 Thread Rohit Deshpande (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Deshpande resolved KAFKA-10871. - Resolution: Not A Bug > StreamTask shouldn't take WallClockTime as input para

[jira] [Created] (KAFKA-10871) StreamTask shouldn't take WallClockTime as input parameter in process method

2020-12-20 Thread Rohit Deshpande (Jira)
Rohit Deshpande created KAFKA-10871: --- Summary: StreamTask shouldn't take WallClockTime as input parameter in process method Key: KAFKA-10871 URL: https://issues.apache.org/jira/browse/KAFKA-

Re: [VOTE] KIP-622 Add currentSystemTimeMs and currentStreamTimeMs to ProcessorContext

2020-12-04 Thread Rohit Deshpande
Hello all, I am closing the vote for this KIP: https://cwiki.apache.org/confluence/display/KAFKA/KIP-622%3A+Add+currentSystemTimeMs+and+currentStreamTimeMs+to+ProcessorContext Summary of the KIP: Planning to add two new methods to ProcessorContext: 1. long currentSystemTimeMs() to fetch wall-cloc

Re: [VOTE] KIP-680: TopologyTestDriver should not require a Properties argument

2020-12-01 Thread Rohit Deshpande
pull/9660> Thanks, Rohit On Mon, Nov 23, 2020 at 9:58 AM Rohit Deshpande wrote: > Thanks John and Matthias. > Waiting for 1 more binding vote. > Thanks, > Rohit > > On Sat, Nov 21, 2020 at 11:01 AM Matthias J. Sax wrote: > >> +1 (binding) >> >> On 11/2

Re: [DISCUSS] KIP-622 Add currentSystemTimeMs and currentStreamTimeMs to ProcessorContext

2020-11-27 Thread Rohit Deshpande
Hi, I would like to revive this KIP. 1. As per proposed solution, we want to add following method in ProcessorContext class /** * Returns current cached wall-clock system timestamp in milliseconds. * * @return the current cached wall-clock system timestamp in milliseconds */ long currentSystem

Re: [VOTE] KIP-680: TopologyTestDriver should not require a Properties argument

2020-11-23 Thread Rohit Deshpande
; > Sorry, I missed your vote thread. > > > > -John > > > > On Fri, Nov 20, 2020, at 21:35, Rohit Deshpande wrote: > >> Thanks Guozhang. > >> Waiting for binding votes. > >> Thanks, > >> Rohit > >> > >> On Tue, Nov 17, 202

Re: [VOTE] KIP-680: TopologyTestDriver should not require a Properties argument

2020-11-20 Thread Rohit Deshpande
Thanks Guozhang. Waiting for binding votes. Thanks, Rohit On Tue, Nov 17, 2020 at 10:13 AM Guozhang Wang wrote: > +1, thanks Rohit. > > > Guozhang > > On Sun, Nov 15, 2020 at 11:53 AM Rohit Deshpande > wrote: > > > Hello all, > > I would like to start v

[VOTE] KIP-680: TopologyTestDriver should not require a Properties argument

2020-11-15 Thread Rohit Deshpande
Hello all, I would like to start voting on KIP-680: TopologyTestDriver should not require a Properties argument. https://cwiki.apache.org/confluence/display/KAFKA/KIP-680%3A+TopologyTestDriver+should+not+require+a+Properties+argument Discuss thread: https://lists.apache.org/thread.html/r5d3d0afc6f

Re: [DISCUSS] KIP-680: TopologyTestDriver should not require a Properties argument

2020-11-11 Thread Rohit Deshpande
Hi John and Matthias, I have updated the wiki with your suggestions. https://cwiki.apache.org/confluence/display/KAFKA/KIP-680%3A+TopologyTestDriver+should+not+require+a+Properties+argument Thanks, Rohit On Fri, Nov 6, 2020 at 3:23 PM Rohit Deshpande wrote: > Thanks John, I will go ahead

Re: [DISCUSS] KIP-680: TopologyTestDriver should not require a Properties argument

2020-11-06 Thread Rohit Deshpande
ssue as part of your KIP. What > > > I’m thinking is this: if no state directory is specified, then we > create a > > > new, unique temp directory and register it for cleanup when the JVM > exits. > > > Additionally, we would set a flag and clean up the state dir whe

Re: [DISCUSS] KIP-680: TopologyTestDriver should not require a Properties argument

2020-11-06 Thread Rohit Deshpande
o reject this idea, in which case I can file a separate ticket for > it. > > Thanks! > -John > > On Tue, Nov 3, 2020, at 18:59, Rohit Deshpande wrote: > > Hi Matthias, > > Thank you for the review and the suggestion. > > Considering at most 3 parameters to the const

Re: [DISCUSS] KIP-680: TopologyTestDriver should not require a Properties argument

2020-11-03 Thread Rohit Deshpande
also add `TopologyTestDriver(Topology, > Instant)`? Not totally sure, as having too many overload could also be > annoying. > > > -Matthias > > On 11/3/20 10:02 AM, Rohit Deshpande wrote: > > Hello all, > > I have created KIP-680: TopologyTestDriver should not requir

[DISCUSS] KIP-680: TopologyTestDriver should not require a Properties argument

2020-11-03 Thread Rohit Deshpande
Hello all, I have created KIP-680: TopologyTestDriver should not require a Properties argument. https://cwiki.apache.org/confluence/display/KAFKA/KIP-680%3A+TopologyTestDriver+should+not+require+a+Properties+argument Jira for the KIP: https://issues.apache.org/jira/browse/KAFKA-10629 If we end up

Re: Permission for contribution

2020-11-02 Thread Rohit Deshpande
Hi Boyang, My wiki id is rohitdeshaws Thanks, Rohit On Thu, Oct 29, 2020 at 1:59 PM Rohit Deshpande wrote: > I don't know how to create wiki id. I am following this documentation: > https://kafka.apache.org/contributing > > On Thu, Oct 29, 2020 at 1:40 PM Boyang Chen > w

Re: Permission for contribution

2020-10-29 Thread Rohit Deshpande
I don't know how to create wiki id. I am following this documentation: https://kafka.apache.org/contributing On Thu, Oct 29, 2020 at 1:40 PM Boyang Chen wrote: > Added you to the JIRA. What's your id for wiki? > > On Thu, Oct 29, 2020 at 1:23 PM rohit deshpande > >

Re: Permission for contribution

2020-10-29 Thread rohit deshpande
I forgot to provide details. My email id: rohitmdeshpa...@gmail.com This request is regarding code contribution. Thanks, Rohit On Thu, Oct 29, 2020 at 11:58 AM rohit deshpande wrote: > Hi, > I would like to get permission for the contribution. > My jira id: rohitdeshaws > > Thanks, > Rohit >

Permission for contribution

2020-10-29 Thread rohit deshpande
Hi, I would like to get permission for the contribution. My jira id: rohitdeshaws Thanks, Rohit