[GitHub] kafka pull request #4120: Make CONSOLE_OUTPUT_FILE configurable

2017-10-23 Thread rnpridgeon
GitHub user rnpridgeon opened a pull request: https://github.com/apache/kafka/pull/4120 Make CONSOLE_OUTPUT_FILE configurable Even if Kafka is not configured without the console appender the CONSOLE_OUTPUT_FILE is generated. Allowing for this to be configurable offers more

[GitHub] kafka pull request #3608: KAFKA-5691- handle NOAUTH in zkUtils.CreateRecursi...

2017-08-01 Thread rnpridgeon
GitHub user rnpridgeon opened a pull request: https://github.com/apache/kafka/pull/3608 KAFKA-5691- handle NOAUTH in zkUtils.CreateRecursive Currently old consumers are unable to register with secure ZK installations. Handling NOAUTH prevents failures when checking /consumers You

[GitHub] kafka pull request #2714: Fix ZKSec Migrate example

2017-03-20 Thread rnpridgeon
GitHub user rnpridgeon opened a pull request: https://github.com/apache/kafka/pull/2714 Fix ZKSec Migrate example Incorrect option in example https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/admin/ZkSecurityMigrator.scala#L71 You can merge this pull

[GitHub] kafka pull request #2533: Checking the Timestamp is insufficient

2017-02-10 Thread rnpridgeon
GitHub user rnpridgeon opened a pull request: https://github.com/apache/kafka/pull/2533 Checking the Timestamp is insufficient My understanding is that the record format allots 1 bit for the timestamp type field. As a result it can be either 1 or 0 and never -1. This means

[GitHub] kafka pull request #2334: subset of KAFKA-4353: Add uuid

2017-01-09 Thread rnpridgeon
GitHub user rnpridgeon opened a pull request: https://github.com/apache/kafka/pull/2334 subset of KAFKA-4353: Add uuid Alternatively I am open to using Avro's 'Fixed' type with a 16 byte size. However most requests I have seen received wish to see UUID represented

[GitHub] kafka pull request #2248: add instrumentation to follower local time

2016-12-12 Thread rnpridgeon
Github user rnpridgeon closed the pull request at: https://github.com/apache/kafka/pull/2248 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] kafka pull request #2248: add instrumentation to follower local time

2016-12-12 Thread rnpridgeon
GitHub user rnpridgeon opened a pull request: https://github.com/apache/kafka/pull/2248 add instrumentation to follower local time You can merge this pull request into a Git repository by running: $ git pull https://github.com/junrao/kafka instrument-0.9.0 Alternatively you

[GitHub] kafka pull request #2115: KAFKA-4364: Remove secrets from DEBUG logging

2016-11-08 Thread rnpridgeon
GitHub user rnpridgeon opened a pull request: https://github.com/apache/kafka/pull/2115 KAFKA-4364: Remove secrets from DEBUG logging leverage fix from KAFKA-2690 to remove secrets from task logging You can merge this pull request into a Git repository by running: $ git pull

[GitHub] kafka pull request #1953: KAFKA-4247: remove root from traversal path

2016-10-03 Thread rnpridgeon
GitHub user rnpridgeon opened a pull request: https://github.com/apache/kafka/pull/1953 KAFKA-4247: remove root from traversal path You can merge this pull request into a Git repository by running: $ git pull https://github.com/rnpridgeon/kafka KAFKA-4247 Alternatively you

[GitHub] kafka pull request #1856: Allow underscores in hostname

2016-09-14 Thread rnpridgeon
GitHub user rnpridgeon opened a pull request: https://github.com/apache/kafka/pull/1856 Allow underscores in hostname Technically this does not strictly adhere to RFC-952 however it is valid for domain names, urls and uris so we should loosen the requirements a tad. You can merge

[GitHub] kafka pull request #1658: Kafka 3689 - process only distinct connectionIds w...

2016-07-24 Thread rnpridgeon
GitHub user rnpridgeon opened a pull request: https://github.com/apache/kafka/pull/1658 Kafka 3689 - process only distinct connectionIds within processDisconnected() @ijuma discovered a possible scenario in which connectionQuotas may be [doubly-decremented](https

[GitHub] kafka pull request #1657: Kafka 3986

2016-07-23 Thread rnpridgeon
GitHub user rnpridgeon opened a pull request: https://github.com/apache/kafka/pull/1657 Kafka 3986 Add null check to guard against the unlikely event where a channel has been closed but not yet removed from completedReceives You can merge this pull request into a Git repository

[GitHub] kafka pull request #1648: KAFKA-3983 - Add additional information to debug

2016-07-21 Thread rnpridgeon
GitHub user rnpridgeon opened a pull request: https://github.com/apache/kafka/pull/1648 KAFKA-3983 - Add additional information to debug Add additional information to Acceptor debug message upon connection acceptance You can merge this pull request into a Git repository by

[GitHub] kafka pull request: KAFKA-3754 Add GC log retention policy to limi...

2016-05-25 Thread rnpridgeon
GitHub user rnpridgeon opened a pull request: https://github.com/apache/kafka/pull/1431 KAFKA-3754 Add GC log retention policy to limit size of log Add a default log retention policy to keep GC logs from growing too large You can merge this pull request into a Git repository by

[GitHub] kafka pull request: KAFKA-3667:

2016-05-13 Thread rnpridgeon
GitHub user rnpridgeon opened a pull request: https://github.com/apache/kafka/pull/1384 KAFKA-3667: By default Kafka is configured to allow ssl communication without hostname verification. This docs has been amended to include instructions on how to set that up in the event

[GitHub] kafka pull request: KAFKA-3533: Incorrect logic

2016-04-08 Thread rnpridgeon
Github user rnpridgeon closed the pull request at: https://github.com/apache/kafka/pull/1205 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] kafka pull request: KAFKA-3533: Incorrect logic

2016-04-08 Thread rnpridgeon
GitHub user rnpridgeon opened a pull request: https://github.com/apache/kafka/pull/1205 KAFKA-3533: Incorrect logic Incorrect logic in Config Validation for KafkaConsumer. https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/clients/consumer

[GitHub] kafka pull request: KAFKA-3445

2016-03-24 Thread rnpridgeon
GitHub user rnpridgeon opened a pull request: https://github.com/apache/kafka/pull/1132 KAFKA-3445 Currently the property TASKS_MAX_CONFIG is not validated against nonsensical values such as 0. This patch leverages the Range.atLeast() method to ensure value is at least 1. You