[GitHub] kafka pull request #2944: KAFKA-3940: Replaced File.mkdir/mkdirs/delete by t...

2017-12-11 Thread mimaison
Github user mimaison closed the pull request at: https://github.com/apache/kafka/pull/2944 ---

[GitHub] kafka pull request #4231: MINOR: Small cleanups/refactoring in kafka.control...

2017-11-18 Thread mimaison
GitHub user mimaison opened a pull request: https://github.com/apache/kafka/pull/4231 MINOR: Small cleanups/refactoring in kafka.controller - Updated logging to use string templates - Minor refactors - Fixed a few typos ### Committer Checklist (excluded from commit

[GitHub] kafka pull request #4217: MINOR: Updated KafkaZkClient.pathExists() to use E...

2017-11-15 Thread mimaison
GitHub user mimaison opened a pull request: https://github.com/apache/kafka/pull/4217 MINOR: Updated KafkaZkClient.pathExists() to use ExistsRequest rather than using GetDataRequest You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] kafka pull request #4196: MINOR: KafkaZkClient refactor. Use match instead o...

2017-11-08 Thread mimaison
GitHub user mimaison opened a pull request: https://github.com/apache/kafka/pull/4196 MINOR: KafkaZkClient refactor. Use match instead of if/else chains Follow up from https://github.com/apache/kafka/pull/4111 You can merge this pull request into a Git repository by running

[GitHub] kafka pull request #4111: KAFKA-6073: Use ZookeeperClient in KafkaApis

2017-10-21 Thread mimaison
GitHub user mimaison opened a pull request: https://github.com/apache/kafka/pull/4111 KAFKA-6073: Use ZookeeperClient in KafkaApis I kept zkUtils for the call to AdminUtils.createTopic(). AdminUtils can be done in another PR You can merge this pull request into a Git repository by

[GitHub] kafka pull request #4058: MINOR: Fixed format string

2017-10-11 Thread mimaison
GitHub user mimaison opened a pull request: https://github.com/apache/kafka/pull/4058 MINOR: Fixed format string Use Scala string templates instead of format You can merge this pull request into a Git repository by running: $ git pull https://github.com/mimaison/kafka

[GitHub] kafka pull request #3906: KAFKA-5735: KIP-190: Handle client-ids consistentl...

2017-09-19 Thread mimaison
GitHub user mimaison opened a pull request: https://github.com/apache/kafka/pull/3906 KAFKA-5735: KIP-190: Handle client-ids consistently Developed with @edoardocomar You can merge this pull request into a Git repository by running: $ git pull https://github.com/mimaison

[GitHub] kafka pull request #3785: KAFKA-5830: kafka-configs.sh should allow deletion...

2017-09-04 Thread mimaison
GitHub user mimaison opened a pull request: https://github.com/apache/kafka/pull/3785 KAFKA-5830: kafka-configs.sh should allow deletion of all configs for… … an entity Added a --delete-all-configs flag to delete all configurations for a given entity You can merge

[GitHub] kafka pull request #3780: MINOR: Updated KafkaConsumer.commitSync() javadoc

2017-09-03 Thread mimaison
GitHub user mimaison opened a pull request: https://github.com/apache/kafka/pull/3780 MINOR: Updated KafkaConsumer.commitSync() javadoc Throws IllegalArgumentException is the offset is negative You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] kafka pull request #3684: KIP-81: KAFKA-4133: Bound memory usage of the Cons...

2017-08-17 Thread mimaison
GitHub user mimaison opened a pull request: https://github.com/apache/kafka/pull/3684 KIP-81: KAFKA-4133: Bound memory usage of the Consumer This is in-progress but there should be enough to start the reviews. Although the KIP doesn't mention metrics, I think we s

[GitHub] kafka pull request #3670: MINOR: fixed StickyAssignor javadoc

2017-08-15 Thread mimaison
GitHub user mimaison opened a pull request: https://github.com/apache/kafka/pull/3670 MINOR: fixed StickyAssignor javadoc StickyAssignor javadoc has a bunch of formatting issues which make it pretty hard to read: http://kafka.apache.org/0110/javadoc/org/apache/kafka/clients

[GitHub] kafka pull request #3635: KAFKA-3417: Quote client-id and wrap reporter call...

2017-08-07 Thread mimaison
GitHub user mimaison opened a pull request: https://github.com/apache/kafka/pull/3635 KAFKA-3417: Quote client-id and wrap reporter calls in try/catch blocks You can merge this pull request into a Git repository by running: $ git pull https://github.com/mimaison/kafka KAFKA

[GitHub] kafka pull request #3452: KAFKA-5483: Shutdown of scheduler should come afte...

2017-06-28 Thread mimaison
GitHub user mimaison opened a pull request: https://github.com/apache/kafka/pull/3452 KAFKA-5483: Shutdown of scheduler should come after LogManager Close the scheduler after all components using it have been shutdown @hachikuji Can you have a look ? You can merge this

[GitHub] kafka pull request #3296: KAFKA-3123: Follower Broker cannot start if offset...

2017-06-10 Thread mimaison
GitHub user mimaison opened a pull request: https://github.com/apache/kafka/pull/3296 KAFKA-3123: Follower Broker cannot start if offsets are already out o… …f range From https://github.com/apache/kafka/pull/1716#discussion_r112000498, ensure the cleaner is restarted

[GitHub] kafka pull request #3295: KAFKA-5418: ZkUtils.getAllPartitions() may fail if...

2017-06-10 Thread mimaison
GitHub user mimaison opened a pull request: https://github.com/apache/kafka/pull/3295 KAFKA-5418: ZkUtils.getAllPartitions() may fail if a topic is marked for deletion Skip topics that don't have any partitions in zkUtils.getAllPartitions() You can merge this pull request i

[GitHub] kafka pull request #3105: KAFKA-5294: PlainSaslServerFactory should allow a ...

2017-05-19 Thread mimaison
GitHub user mimaison opened a pull request: https://github.com/apache/kafka/pull/3105 KAFKA-5294: PlainSaslServerFactory should allow a null Map in getMech… …anismNames If props is null, use POLICY_NOPLAINTEXT default value: false As far as I can tell, none of

[GitHub] kafka pull request #3036: KAFKA-3356: Remove ConsumerOffsetChecker

2017-05-12 Thread mimaison
GitHub user mimaison opened a pull request: https://github.com/apache/kafka/pull/3036 KAFKA-3356: Remove ConsumerOffsetChecker You can merge this pull request into a Git repository by running: $ git pull https://github.com/mimaison/kafka KAFKA-3356 Alternatively you can

[GitHub] kafka pull request #3034: MINOR: Fixed testBrokerTopicMetricsBytesInOut fail...

2017-05-12 Thread mimaison
GitHub user mimaison opened a pull request: https://github.com/apache/kafka/pull/3034 MINOR: Fixed testBrokerTopicMetricsBytesInOut failures We've had to tweak the other tests to make them pass. `testBrokerTopicMetricsUnregisteredAfterDeletingTopic` seemed compl

[GitHub] kafka pull request #3003: KAFKA-5194: KIP-153: Include only client traffic i...

2017-05-09 Thread mimaison
GitHub user mimaison opened a pull request: https://github.com/apache/kafka/pull/3003 KAFKA-5194: KIP-153: Include only client traffic in BytesOutPerSec me… …tric Also added 2 new metrics to account for incoming/outgoing traffic due to internal replication

[GitHub] kafka pull request #2944: KAFKA-3940: Replaced File.mkdir/mkdirs/delete by t...

2017-04-29 Thread mimaison
GitHub user mimaison opened a pull request: https://github.com/apache/kafka/pull/2944 KAFKA-3940: Replaced File.mkdir/mkdirs/delete by their Files equivalent You can merge this pull request into a Git repository by running: $ git pull https://github.com/mimaison/kafka KAFKA

[GitHub] kafka pull request #2878: KAFKA-3070: SASL unit tests dont work with IBM JDK

2017-04-20 Thread mimaison
GitHub user mimaison opened a pull request: https://github.com/apache/kafka/pull/2878 KAFKA-3070: SASL unit tests dont work with IBM JDK Use IBM Kerberos module for SASL tests if running on IBM JDK Developed with @edoardocomar Based on https://github.com/apache/kafka

[GitHub] kafka pull request #2326: MINOR: Various small scala cleanups

2017-01-06 Thread mimaison
GitHub user mimaison opened a pull request: https://github.com/apache/kafka/pull/2326 MINOR: Various small scala cleanups - Removed unnecessary semicolons You can merge this pull request into a Git repository by running: $ git pull https://github.com/mimaison/kafka minor-fixes

[GitHub] kafka pull request #2011: KAFKA-4291: TopicCommand --describe shows topics m...

2016-10-11 Thread mimaison
GitHub user mimaison opened a pull request: https://github.com/apache/kafka/pull/2011 KAFKA-4291: TopicCommand --describe shows topics marked for deletion … …as under-replicated and unavailable TopicCommand --describe now shows if a topic is marked for deletion

[GitHub] kafka pull request #1827: KAFKA-4081: Consumer API consumer new interface co...

2016-09-21 Thread mimaison
GitHub user mimaison reopened a pull request: https://github.com/apache/kafka/pull/1827 KAFKA-4081: Consumer API consumer new interface commitSync does not v… …erify the validity of offset Commit throws InvalidOffsetException if the offset is negative You can merge

[GitHub] kafka pull request #1827: KAFKA-4081: Consumer API consumer new interface co...

2016-09-19 Thread mimaison
Github user mimaison closed the pull request at: https://github.com/apache/kafka/pull/1827 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] kafka pull request #1827: KAFKA-4081: Consumer API consumer new interface co...

2016-09-06 Thread mimaison
GitHub user mimaison opened a pull request: https://github.com/apache/kafka/pull/1827 KAFKA-4081: Consumer API consumer new interface commitSync does not v… …erify the validity of offset Commit throws InvalidOffsetException if the offset is negative You can merge this

[GitHub] kafka pull request #1754: KAFKA-4057: Allow to specify the request version a...

2016-08-23 Thread mimaison
Github user mimaison closed the pull request at: https://github.com/apache/kafka/pull/1754 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] kafka pull request #1759: KAFKA-4056: Kafka logs values of sensitive configs...

2016-08-18 Thread mimaison
GitHub user mimaison opened a pull request: https://github.com/apache/kafka/pull/1759 KAFKA-4056: Kafka logs values of sensitive configs like passwords In case of unknown configs, only list the name without the value You can merge this pull request into a Git repository by running

[GitHub] kafka pull request #1754: KAFKA-4057: Allow to specify the request version a...

2016-08-17 Thread mimaison
GitHub user mimaison opened a pull request: https://github.com/apache/kafka/pull/1754 KAFKA-4057: Allow to specify the request version and replica ID in ka… …fka.javaapi.FetchRequest - Added new arguments for versionId and replicaId in the constructor instead of using

[GitHub] kafka pull request #1680: KAFKA-3946: Protocol guide should say that Produce...

2016-07-29 Thread mimaison
GitHub user mimaison opened a pull request: https://github.com/apache/kafka/pull/1680 KAFKA-3946: Protocol guide should say that Produce request acks can o… …nly be 0, 1, or -1 Rephrased the documentation string for the Produce request Updated the acks configuration

[GitHub] kafka pull request #1675: MINOR: Fixed a few warnings in clients

2016-07-28 Thread mimaison
GitHub user mimaison opened a pull request: https://github.com/apache/kafka/pull/1675 MINOR: Fixed a few warnings in clients - Removed an unnecessary annotation - Parameterized a couple of raw types You can merge this pull request into a Git repository by running: $ git

[GitHub] kafka pull request: MINOR: Fix tracing in KafkaApis.handle()

2016-05-26 Thread mimaison
GitHub user mimaison opened a pull request: https://github.com/apache/kafka/pull/1435 MINOR: Fix tracing in KafkaApis.handle() requestObj() returns null for the o.a.k.c.requests objects so use header() for these. Once all the requests will have been replaced by

[GitHub] kafka pull request: KAFKA-3732: Add an auto accept option to kafka...

2016-05-19 Thread mimaison
GitHub user mimaison opened a pull request: https://github.com/apache/kafka/pull/1406 KAFKA-3732: Add an auto accept option to kafka-acl Added a new argument to AclCommand: --yes. When set, automatically answer yes to prompts You can merge this pull request into a Git repository

[GitHub] kafka pull request: KAFKA-3587: LogCleaner fails due to incorrect ...

2016-05-06 Thread mimaison
GitHub user mimaison opened a pull request: https://github.com/apache/kafka/pull/1332 KAFKA-3587: LogCleaner fails due to incorrect offset map computation … Removed the over pessimistic require and instead attempt to fill the dedup buffer. Use the (only) map until full; this