[GitHub] kafka-site pull request #105: Adding Trivago logo to streams page

2017-10-30 Thread miguno
Github user miguno commented on a diff in the pull request: https://github.com/apache/kafka-site/pull/105#discussion_r147804493 --- Diff: 0110/streams/index.html --- @@ -17,20 +17,20 @@

[GitHub] kafka-site issue #77: MINOR: Add streams child topics to left-hand nav

2017-10-02 Thread miguno
Github user miguno commented on the issue: https://github.com/apache/kafka-site/pull/77 Could you please edit/update the PR title then? I understand that this PR is now a change to the content pane of the main page (kafka.apache.org) only? ---

[GitHub] kafka-site issue #67: Updated docs nav and docs toc

2017-07-18 Thread miguno
Github user miguno commented on the issue: https://github.com/apache/kafka-site/pull/67 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] kafka-site pull request #66: New landing page for Streams API

2017-07-11 Thread miguno
Github user miguno commented on a diff in the pull request: https://github.com/apache/kafka-site/pull/66#discussion_r126674877 --- Diff: 0110/streams/index.html --- @@ -18,56 +18,192 @@ <!--#include virtual="../js/templateData.js" -->

[GitHub] kafka-site pull request #66: New landing page for Streams API

2017-07-11 Thread miguno
Github user miguno commented on a diff in the pull request: https://github.com/apache/kafka-site/pull/66#discussion_r126674750 --- Diff: 0110/streams/index.html --- @@ -18,56 +18,192 @@ <!--#include virtual="../js/templateData.js" -->

[GitHub] kafka pull request #2812: Improve topic management instructions for Kafka St...

2017-04-05 Thread miguno
GitHub user miguno opened a pull request: https://github.com/apache/kafka/pull/2812 Improve topic management instructions for Kafka Streams examples You can merge this pull request into a Git repository by running: $ git pull https://github.com/miguno/kafka trunk-streams

[GitHub] kafka pull request #2751: Document ordering contract of iterator for window ...

2017-03-28 Thread miguno
GitHub user miguno opened a pull request: https://github.com/apache/kafka/pull/2751 Document ordering contract of iterator for window stores and session stores You can merge this pull request into a Git repository by running: $ git pull https://github.com/miguno/kafka trunk

[GitHub] kafka pull request #2723: MyProcessor doc example should implement, not exte...

2017-03-22 Thread miguno
GitHub user miguno opened a pull request: https://github.com/apache/kafka/pull/2723 MyProcessor doc example should implement, not extend `Processor` You can merge this pull request into a Git repository by running: $ git pull https://github.com/miguno/kafka trunk-streams-docs

[GitHub] kafka pull request #2696: MINOR: Guard against NPE when throwing StreamsExce...

2017-03-16 Thread miguno
GitHub user miguno opened a pull request: https://github.com/apache/kafka/pull/2696 MINOR: Guard against NPE when throwing StreamsException on serializer mismatch You can merge this pull request into a Git repository by running: $ git pull https://github.com/miguno/kafka

[GitHub] kafka pull request #2668: MINOR: KStream: fix typo in javadoc

2017-03-10 Thread miguno
GitHub user miguno opened a pull request: https://github.com/apache/kafka/pull/2668 MINOR: KStream: fix typo in javadoc You can merge this pull request into a Git repository by running: $ git pull https://github.com/miguno/kafka trunk-kstream-javadoc-typo Alternatively you

[GitHub] kafka pull request #2651: MINOR: reduce() javadocs: clarify position of argu...

2017-03-07 Thread miguno
GitHub user miguno opened a pull request: https://github.com/apache/kafka/pull/2651 MINOR: reduce() javadocs: clarify position of arguments You can merge this pull request into a Git repository by running: $ git pull https://github.com/miguno/kafka trunk-reduce-javadocs

[GitHub] kafka pull request #2626: MINOR: Fix typo in GlobalKTable javadocs

2017-03-02 Thread miguno
GitHub user miguno opened a pull request: https://github.com/apache/kafka/pull/2626 MINOR: Fix typo in GlobalKTable javadocs You can merge this pull request into a Git repository by running: $ git pull https://github.com/miguno/kafka trunk-globalktable-typos Alternatively

[GitHub] kafka pull request #2607: MINOR: Fix typo in javadoc of `flatMapValues`

2017-02-28 Thread miguno
GitHub user miguno opened a pull request: https://github.com/apache/kafka/pull/2607 MINOR: Fix typo in javadoc of `flatMapValues` You can merge this pull request into a Git repository by running: $ git pull https://github.com/miguno/kafka trunk-flatMapValues-docstring

[GitHub] kafka pull request #2554: KAFKA-4769: Add Float serializer, deserializer, se...

2017-02-15 Thread miguno
GitHub user miguno opened a pull request: https://github.com/apache/kafka/pull/2554 KAFKA-4769: Add Float serializer, deserializer, serde You can merge this pull request into a Git repository by running: $ git pull https://github.com/miguno/kafka KAFKA-4769 Alternatively you

[GitHub] kafka pull request #1823: Fixes javadoc of Windows, fixes typo in parameter ...

2016-09-05 Thread miguno
GitHub user miguno opened a pull request: https://github.com/apache/kafka/pull/1823 Fixes javadoc of Windows, fixes typo in parameter name of KGroupedTable You can merge this pull request into a Git repository by running: $ git pull https://github.com/miguno/kafka trunk

[GitHub] kafka pull request #1822: Fix javadocs of Windowed

2016-09-05 Thread miguno
Github user miguno closed the pull request at: https://github.com/apache/kafka/pull/1822 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] kafka pull request #1822: Fix javadocs of Windowed

2016-09-05 Thread miguno
GitHub user miguno opened a pull request: https://github.com/apache/kafka/pull/1822 Fix javadocs of Windowed Previous Javadoc was referring to a 0.10.0.x method that was since removed from trunk. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] kafka pull request: MINOR: Change type of StreamsConfig.BOOTSTRAP_...

2016-05-12 Thread miguno
GitHub user miguno opened a pull request: https://github.com/apache/kafka/pull/1377 MINOR: Change type of StreamsConfig.BOOTSTRAP_SERVERS_CONFIG to List This is an improved version of https://github.com/apache/kafka/pull/1374, where we include a unit test. /cc @ijuma and

[GitHub] kafka pull request: HOTFIX: Fix equality semantics of KeyValue

2016-04-29 Thread miguno
GitHub user miguno opened a pull request: https://github.com/apache/kafka/pull/1294 HOTFIX: Fix equality semantics of KeyValue Fixes wrong KeyValue equals logic when keys not equal but values equal. Original hotfix PR at https://github.com/apache/kafka/pull/1293 (/cc

[GitHub] kafka pull request: KAFKA-3613: Consolidate TumblingWindows and Ho...

2016-04-27 Thread miguno
Github user miguno closed the pull request at: https://github.com/apache/kafka/pull/1261 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] kafka pull request: KAFKA-3613: Consolidate TumblingWindows and Ho...

2016-04-27 Thread miguno
GitHub user miguno opened a pull request: https://github.com/apache/kafka/pull/1277 KAFKA-3613: Consolidate TumblingWindows and HoppingWindows into TimeWindows This PR includes the same code as https://github.com/apache/kafka/pull/1261 but is rebased on latest trunk. You can merge

[GitHub] kafka pull request: KAFKA-3614: Consolidate duplicate code in KGro...

2016-04-23 Thread miguno
GitHub user miguno opened a pull request: https://github.com/apache/kafka/pull/1262 KAFKA-3614: Consolidate duplicate code in KGroupedTableImpl Feel free to review @guozhangwang @enothereska @mjsax . You can merge this pull request into a Git repository by running: $ git pull

[GitHub] kafka pull request: KAFKA-3613: Consolidate TumblingWindows and Ho...

2016-04-23 Thread miguno
GitHub user miguno opened a pull request: https://github.com/apache/kafka/pull/1261 KAFKA-3613: Consolidate TumblingWindows and HoppingWindows into TimeWindows @guozhangwang @enothereska @mjsax : Feel free to take a look. Beyond the consolidation of windows, I also added

[GitHub] kafka pull request: KAFKA-3411: Streams: stop using "job" terminol...

2016-03-16 Thread miguno
GitHub user miguno opened a pull request: https://github.com/apache/kafka/pull/1081 KAFKA-3411: Streams: stop using "job" terminology, rename job.id to application.id @guozhangwang @ymatsuda : please review. You can merge this pull request into a Git repository

[GitHub] kafka pull request: Generate javadocs for all Streams packages wit...

2016-03-04 Thread miguno
GitHub user miguno opened a pull request: https://github.com/apache/kafka/pull/1013 Generate javadocs for all Streams packages with the exception of internals You can merge this pull request into a Git repository by running: $ git pull https://github.com/miguno/kafka trunk

[GitHub] kafka pull request: HOTFIX: Include RocksDB dependency in release ...

2016-03-03 Thread miguno
GitHub user miguno opened a pull request: https://github.com/apache/kafka/pull/1007 HOTFIX: Include RocksDB dependency in release tarballs Without this change `./gradlew releaseTarGz` (and its variants) will not include the RocksDB jar in Kafka's `libs/` f

[GitHub] kafka pull request: KAFKA-3324: NullPointerException in StreamPart...

2016-03-03 Thread miguno
GitHub user miguno opened a pull request: https://github.com/apache/kafka/pull/1001 KAFKA-3324: NullPointerException in StreamPartitionAssignor You can merge this pull request into a Git repository by running: $ git pull https://github.com/miguno/kafka KAFKA-3324

[GitHub] kafka pull request: KAFKA-2874: shutdown ZK process reliably

2015-11-23 Thread miguno
GitHub user miguno opened a pull request: https://github.com/apache/kafka/pull/573 KAFKA-2874: shutdown ZK process reliably You can merge this pull request into a Git repository by running: $ git pull https://github.com/miguno/kafka KAFKA-2874 Alternatively you can review

[GitHub] kafka pull request: KAFKA-2740: Convert Windows bin scripts from C...

2015-11-04 Thread miguno
GitHub user miguno opened a pull request: https://github.com/apache/kafka/pull/419 KAFKA-2740: Convert Windows bin scripts from CRLF to LF line encodings There are no functional changes to the modified scripts. You can merge this pull request into a Git repository by running

[GitHub] kafka pull request: KAFKA-2470: Convert Windows bin scripts from C...

2015-11-04 Thread miguno
Github user miguno closed the pull request at: https://github.com/apache/kafka/pull/418 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] kafka pull request: KAFKA-2470: Convert Windows bin scripts from C...

2015-11-04 Thread miguno
GitHub user miguno opened a pull request: https://github.com/apache/kafka/pull/418 KAFKA-2470: Convert Windows bin scripts from CRLF to LF line encodings There are no functional changes to the modified scripts. You can merge this pull request into a Git repository by running

[GitHub] kafka pull request: KAFKA-2740: Convert Windows bin scripts from C...

2015-11-04 Thread miguno
Github user miguno closed the pull request at: https://github.com/apache/kafka/pull/417 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] kafka pull request: Convert Windows bin scripts from CRLF to LF li...

2015-11-04 Thread miguno
GitHub user miguno opened a pull request: https://github.com/apache/kafka/pull/417 Convert Windows bin scripts from CRLF to LF line encodings There are no functional changes to the modified scripts. You can merge this pull request into a Git repository by running: $ git pull