[jira] [Commented] (KAFKA-2311) Consumer's ensureNotClosed method not thread safe

[ https://issues.apache.org/jira/browse/KAFKA-2311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384483#comment-15384483 ] Tim Brooks commented on KAFKA-2311: --- Yes. Sorry, I had not been checking in

[jira] [Commented] (KAFKA-2311) Consumer's ensureNotClosed method not thread safe

[ https://issues.apache.org/jira/browse/KAFKA-2311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14619684#comment-14619684 ] Tim Brooks commented on KAFKA-2311: --- I removed the unnecessary close check as sugge

[jira] [Commented] (KAFKA-2311) Consumer's ensureNotClosed method not thread safe

[ https://issues.apache.org/jira/browse/KAFKA-2311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14619682#comment-14619682 ] Tim Brooks commented on KAFKA-2311: --- Created reviewboard https://reviews.apache.o

[jira] [Updated] (KAFKA-2311) Consumer's ensureNotClosed method not thread safe

[ https://issues.apache.org/jira/browse/KAFKA-2311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tim Brooks updated KAFKA-2311: -- Attachment: KAFKA-2311.patch > Consumer's ensureNotClosed method not thr

Review Request 36341: Patch for KAFKA-2311

--- Thanks, Tim Brooks

Review Request 36244: Patch for KAFKA-2312

iff: https://reviews.apache.org/r/36244/diff/ Testing --- Thanks, Tim Brooks

[jira] [Commented] (KAFKA-2312) Use AtomicLong opposed to AtomicReference to store currentThread in consumer

[ https://issues.apache.org/jira/browse/KAFKA-2312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14616179#comment-14616179 ] Tim Brooks commented on KAFKA-2312: --- Created reviewboard https://reviews.apache.o

[jira] [Updated] (KAFKA-2312) Use AtomicLong opposed to AtomicReference to store currentThread in consumer

[ https://issues.apache.org/jira/browse/KAFKA-2312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tim Brooks updated KAFKA-2312: -- Attachment: KAFKA-2312.patch > Use AtomicLong opposed to AtomicReference to store currentThread

[jira] [Updated] (KAFKA-2312) Use AtomicLong opposed to AtomicReference to store currentThread in consumer

[ https://issues.apache.org/jira/browse/KAFKA-2312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tim Brooks updated KAFKA-2312: -- Assignee: Tim Brooks Status: Patch Available (was: Open) > Use AtomicLong opposed

[jira] [Created] (KAFKA-2312) Use AtomicLong opposed to AtomicReference to store currentThread in consumer

Tim Brooks created KAFKA-2312: - Summary: Use AtomicLong opposed to AtomicReference to store currentThread in consumer Key: KAFKA-2312 URL: https://issues.apache.org/jira/browse/KAFKA-2312 Project: Kafka

[jira] [Commented] (KAFKA-2102) Remove unnecessary synchronization when managing metadata

[ https://issues.apache.org/jira/browse/KAFKA-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14616158#comment-14616158 ] Tim Brooks commented on KAFKA-2102: --- I can probably take another look at this l

[jira] [Updated] (KAFKA-2311) Consumer's ensureNotClosed method not thread safe

[ https://issues.apache.org/jira/browse/KAFKA-2311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tim Brooks updated KAFKA-2311: -- Assignee: Tim Brooks Status: Patch Available (was: Open) > Consumer's ensureNotClosed me

[jira] [Commented] (KAFKA-2311) Consumer's ensureNotClosed method not thread safe

[ https://issues.apache.org/jira/browse/KAFKA-2311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14616155#comment-14616155 ] Tim Brooks commented on KAFKA-2311: --- Created reviewboard https://reviews.apache.o

[jira] [Updated] (KAFKA-2311) Consumer's ensureNotClosed method not thread safe

[ https://issues.apache.org/jira/browse/KAFKA-2311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tim Brooks updated KAFKA-2311: -- Attachment: KAFKA-2311.patch > Consumer's ensureNotClosed method not thr

Review Request 36242: Patch for KAFKA-2311

--- Thanks, Tim Brooks

[jira] [Created] (KAFKA-2311) Consumer's ensureNotClosed method not thread safe

Tim Brooks created KAFKA-2311: - Summary: Consumer's ensureNotClosed method not thread safe Key: KAFKA-2311 URL: https://issues.apache.org/jira/browse/KAFKA-2311 Project: Kafka Issue Type

[jira] [Commented] (KAFKA-2129) Consumer could make multiple concurrent metadata requests

[ https://issues.apache.org/jira/browse/KAFKA-2129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14616136#comment-14616136 ] Tim Brooks commented on KAFKA-2129: --- Since post-2168 it seems to be explic

Checking in on 2101, 2102, 2129

I wanted to check in on these three tickets I opened in JIRA. I have not seen responses to them in a while.  2101 and 2129 seem like straightforward issues that need to be resolved (2129 - related the consumer not entirely being thread safe; 2101 related to a full successful update back off on

[jira] [Commented] (KAFKA-2101) Metric metadata-age is reset on a failed update

[ https://issues.apache.org/jira/browse/KAFKA-2101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14566770#comment-14566770 ] Tim Brooks commented on KAFKA-2101: --- As I mentioned earlier, this overlaps some

[jira] [Updated] (KAFKA-2101) Metric metadata-age is reset on a failed update

[ https://issues.apache.org/jira/browse/KAFKA-2101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tim Brooks updated KAFKA-2101: -- Assignee: Tim Brooks Status: Patch Available (was: Open) > Metric metadata-age is reset o

[jira] [Updated] (KAFKA-2101) Metric metadata-age is reset on a failed update

[ https://issues.apache.org/jira/browse/KAFKA-2101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tim Brooks updated KAFKA-2101: -- Attachment: KAFKA-2101.patch > Metric metadata-age is reset on a failed upd

[jira] [Commented] (KAFKA-2101) Metric metadata-age is reset on a failed update

[ https://issues.apache.org/jira/browse/KAFKA-2101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14566767#comment-14566767 ] Tim Brooks commented on KAFKA-2101: --- Created reviewboard https://reviews.apache.o

Review Request 34865: Patch for KAFKA-2101

/org/apache/kafka/clients/producer/internals/Sender.java 1e943d621732889a1c005b243920dc32cea7af66 clients/src/test/java/org/apache/kafka/clients/MetadataTest.java 928087d29deb80655ca83726c1ebc45d76468c1f Diff: https://reviews.apache.org/r/34865/diff/ Testing --- Thanks, Tim Brooks

[jira] [Updated] (KAFKA-2129) Consumer could make multiple concurrent metadata requests

[ https://issues.apache.org/jira/browse/KAFKA-2129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tim Brooks updated KAFKA-2129: -- Assignee: Tim Brooks Status: Patch Available (was: Open) > Consumer could make multi

[jira] [Updated] (KAFKA-2129) Consumer could make multiple concurrent metadata requests

[ https://issues.apache.org/jira/browse/KAFKA-2129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tim Brooks updated KAFKA-2129: -- Attachment: KAFKA-2129.patch > Consumer could make multiple concurrent metadata reque

[jira] [Commented] (KAFKA-2129) Consumer could make multiple concurrent metadata requests

[ https://issues.apache.org/jira/browse/KAFKA-2129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14517557#comment-14517557 ] Tim Brooks commented on KAFKA-2129: --- Created reviewboard https://reviews.apache.o

[jira] [Updated] (KAFKA-2129) Consumer could make multiple concurrent metadata requests

[ https://issues.apache.org/jira/browse/KAFKA-2129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tim Brooks updated KAFKA-2129: -- Priority: Major (was: Minor) > Consumer could make multiple concurrent metadata reque

Review Request 33634: Patch for KAFKA-2129

/browse/KAFKA-2129 Repository: kafka Description --- Synchronize method Diffs - clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java d301be4709f7b112e1f3a39f3c04cfa65f00fa60 Diff: https://reviews.apache.org/r/33634/diff/ Testing --- Thanks, Tim

[jira] [Commented] (KAFKA-2129) Consumer could make multiple concurrent metadata requests

[ https://issues.apache.org/jira/browse/KAFKA-2129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14517553#comment-14517553 ] Tim Brooks commented on KAFKA-2129: --- It kind of looks like this is a larger issue

[jira] [Commented] (KAFKA-2101) Metric metadata-age is reset on a failed update

[ https://issues.apache.org/jira/browse/KAFKA-2101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14516263#comment-14516263 ] Tim Brooks commented on KAFKA-2101: --- Okay. Well I made a number of changes relate

[jira] [Updated] (KAFKA-2102) Remove unnecessary synchronization when managing metadata

[ https://issues.apache.org/jira/browse/KAFKA-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tim Brooks updated KAFKA-2102: -- Attachment: KAFKA-2102_2015-04-26_17:25:21.patch > Remove unnecessary synchronization when manag

[jira] [Commented] (KAFKA-2102) Remove unnecessary synchronization when managing metadata

[ https://issues.apache.org/jira/browse/KAFKA-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14513346#comment-14513346 ] Tim Brooks commented on KAFKA-2102: --- Updated reviewboard https://reviews.apache.o

Re: Review Request 32937: Patch for KAFKA-2102

b2db91ca14bbd17fef5ce85839679144fff3f689 Diff: https://reviews.apache.org/r/32937/diff/ Testing --- Thanks, Tim Brooks

Re: Review Request 32937: Patch for KAFKA-2102

my understanding is that since the writes happen in the lock, releasing the lock ensures visability. - Tim ----------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32937/#review80298 --

[jira] [Created] (KAFKA-2129) Consumer could make multiple concurrent metadata requests

Tim Brooks created KAFKA-2129: - Summary: Consumer could make multiple concurrent metadata requests Key: KAFKA-2129 URL: https://issues.apache.org/jira/browse/KAFKA-2129 Project: Kafka Issue Type

[jira] [Updated] (KAFKA-2102) Remove unnecessary synchronization when managing metadata

[ https://issues.apache.org/jira/browse/KAFKA-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tim Brooks updated KAFKA-2102: -- Status: Patch Available (was: In Progress) > Remove unnecessary synchronization when managing metad

[jira] [Commented] (KAFKA-2102) Remove unnecessary synchronization when managing metadata

[ https://issues.apache.org/jira/browse/KAFKA-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14497396#comment-14497396 ] Tim Brooks commented on KAFKA-2102: --- Updated reviewboard https://reviews.apache.o

[jira] [Updated] (KAFKA-2102) Remove unnecessary synchronization when managing metadata

[ https://issues.apache.org/jira/browse/KAFKA-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tim Brooks updated KAFKA-2102: -- Attachment: KAFKA-2102_2015-04-15_19:55:45.patch > Remove unnecessary synchronization when manag

Re: Review Request 32937: Patch for KAFKA-2102

b7ae595f2cc46e5dfe728bc3ce6082e9cd0b6d36 clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java b91e2c52ed0acb1faa85915097d97bafa28c413a Diff: https://reviews.apache.org/r/32937/diff/ Testing --- Thanks, Tim Brooks

[jira] [Updated] (KAFKA-2102) Remove unnecessary synchronization when managing metadata

[ https://issues.apache.org/jira/browse/KAFKA-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tim Brooks updated KAFKA-2102: -- Attachment: five-threads-trunk.txt five-threads-patch.txt eight-threads

[jira] [Commented] (KAFKA-2102) Remove unnecessary synchronization when managing metadata

[ https://issues.apache.org/jira/browse/KAFKA-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14497392#comment-14497392 ] Tim Brooks commented on KAFKA-2102: --- I added an updated patch. This patch includ

[jira] [Commented] (KAFKA-2102) Remove unnecessary synchronization when managing metadata

[ https://issues.apache.org/jira/browse/KAFKA-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14485494#comment-14485494 ] Tim Brooks commented on KAFKA-2102: --- Thanks for the feedback. Unless I misunders

[jira] [Updated] (KAFKA-2102) Remove unnecessary synchronization when managing metadata

[ https://issues.apache.org/jira/browse/KAFKA-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tim Brooks updated KAFKA-2102: -- Attachment: KAFKA-2102_2015-04-08_00:20:33.patch > Remove unnecessary synchronization when manag

[jira] [Commented] (KAFKA-2102) Remove unnecessary synchronization when managing metadata

[ https://issues.apache.org/jira/browse/KAFKA-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14484737#comment-14484737 ] Tim Brooks commented on KAFKA-2102: --- I updated my WIP patch to ensure that all t

[jira] [Commented] (KAFKA-2102) Remove unnecessary synchronization when managing metadata

[ https://issues.apache.org/jira/browse/KAFKA-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14484735#comment-14484735 ] Tim Brooks commented on KAFKA-2102: --- Updated reviewboard https://reviews.apache.o

Re: Review Request 32937: Patch for KAFKA-2102

/diff/ Testing --- Thanks, Tim Brooks

[jira] [Updated] (KAFKA-2102) Remove unnecessary synchronization when managing metadata

[ https://issues.apache.org/jira/browse/KAFKA-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tim Brooks updated KAFKA-2102: -- Assignee: Tim Brooks Status: Patch Available (was: Open) > Remove unnecessary synchronizat

[jira] [Updated] (KAFKA-2102) Remove unnecessary synchronization when managing metadata

[ https://issues.apache.org/jira/browse/KAFKA-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tim Brooks updated KAFKA-2102: -- Attachment: KAFKA-2102.patch > Remove unnecessary synchronization when managing metad

[jira] [Commented] (KAFKA-2102) Remove unnecessary synchronization when managing metadata

[ https://issues.apache.org/jira/browse/KAFKA-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14484054#comment-14484054 ] Tim Brooks commented on KAFKA-2102: --- Created reviewboard https://reviews.apache.o

Review Request 32937: Patch for KAFKA-2102

/producer/KafkaProducer.java b91e2c52ed0acb1faa85915097d97bafa28c413a Diff: https://reviews.apache.org/r/32937/diff/ Testing --- Thanks, Tim Brooks

[jira] [Created] (KAFKA-2102) Remove unnecessary synchronization when managing metadata

Tim Brooks created KAFKA-2102: - Summary: Remove unnecessary synchronization when managing metadata Key: KAFKA-2102 URL: https://issues.apache.org/jira/browse/KAFKA-2102 Project: Kafka Issue Type

[jira] [Created] (KAFKA-2101) Metric metadata-age is reset on a failed update

Tim Brooks created KAFKA-2101: - Summary: Metric metadata-age is reset on a failed update Key: KAFKA-2101 URL: https://issues.apache.org/jira/browse/KAFKA-2101 Project: Kafka Issue Type: Bug

[jira] [Updated] (KAFKA-2090) Remove duplicate check to metadataFetchInProgress

[ https://issues.apache.org/jira/browse/KAFKA-2090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tim Brooks updated KAFKA-2090: -- Attachment: KAFKA-2090.patch > Remove duplicate check to metadataFetchInProgr

[jira] [Commented] (KAFKA-2090) Remove duplicate check to metadataFetchInProgress

[ https://issues.apache.org/jira/browse/KAFKA-2090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14394750#comment-14394750 ] Tim Brooks commented on KAFKA-2090: --- Created reviewboard https://reviews.apache.o

Review Request 32823: Patch for KAFKA-2090

--- Thanks, Tim Brooks

[jira] [Created] (KAFKA-2090) Remove duplicate check to metadataFetchInProgress

Tim Brooks created KAFKA-2090: - Summary: Remove duplicate check to metadataFetchInProgress Key: KAFKA-2090 URL: https://issues.apache.org/jira/browse/KAFKA-2090 Project: Kafka Issue Type

[jira] [Commented] (KAFKA-2050) Avoid calling .size() on java.util.ConcurrentLinkedQueue

[ https://issues.apache.org/jira/browse/KAFKA-2050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14381251#comment-14381251 ] Tim Brooks commented on KAFKA-2050: --- Okay. I submitted it. I had some trouble. B

[jira] [Updated] (KAFKA-2050) Avoid calling .size() on java.util.ConcurrentLinkedQueue

[ https://issues.apache.org/jira/browse/KAFKA-2050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tim Brooks updated KAFKA-2050: -- Attachment: KAFKA-2050.patch > Avoid calling .size() on java.util.ConcurrentLinkedQu

[jira] [Commented] (KAFKA-2050) Avoid calling .size() on java.util.ConcurrentLinkedQueue

[ https://issues.apache.org/jira/browse/KAFKA-2050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14381250#comment-14381250 ] Tim Brooks commented on KAFKA-2050: --- Created reviewboard https://reviews.apache.o

Review Request 32519: Patch for KAFKA-2050

/browse/KAFKA-2050 Repository: kafka Description --- Avoid calling size() on concurrent queue. Diffs - core/src/main/scala/kafka/network/SocketServer.scala 76ce41aed6e04ac5ba88395c4d5008aca17f9a73 Diff: https://reviews.apache.org/r/32519/diff/ Testing --- Thanks, Tim

[jira] [Updated] (KAFKA-2050) Avoid calling .size() on java.util.ConcurrentLinkedQueue

[ https://issues.apache.org/jira/browse/KAFKA-2050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tim Brooks updated KAFKA-2050: -- Attachment: dont_call_queue_size.patch > Avoid calling .size() on java.util.ConcurrentLinkedQu

[jira] [Created] (KAFKA-2050) Avoid calling .size() on java.util.ConcurrentLinkedQueue

Tim Brooks created KAFKA-2050: - Summary: Avoid calling .size() on java.util.ConcurrentLinkedQueue Key: KAFKA-2050 URL: https://issues.apache.org/jira/browse/KAFKA-2050 Project: Kafka Issue Type