Re: Review Request 18022: KAFKA-1012: In-built offset management in Kafka

2014-02-17 Thread Tejas Patil
fset commit. A finite retry counter might help for getting few reattempts. - Tejas Patil On Feb. 12, 2014, 7:50 p.m., Joel Koshy wrote: > > --- > This is an au

Re: Review Request 18022: KAFKA-1012: In-built offset management in Kafka

2014-02-17 Thread Tejas Patil
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18022/#review34676 --- - Tejas Patil On Feb. 12, 2014, 7:50 p.m., Joel Koshy wrote

Re: Review Request 18022: KAFKA-1012: In-built offset management in Kafka

2014-02-17 Thread Tejas Patil
tps://reviews.apache.org/r/18022/#comment64884> This is used only for DEBUG. Waste of memory for higher logging levels. Why not allocate / populate this only is DEBUG (or below logging mode) is turned on ? - Tejas Patil On Feb. 12, 2014, 7:50 p.m., Joel Koshy

Re: Review Request 18022: KAFKA-1012: In-built offset management in Kafka

2014-02-16 Thread Tejas Patil
tains unsafe check-then-act core/src/main/scala/kafka/server/OffsetManager.scala <https://reviews.apache.org/r/18022/#comment64792> currently not used anywhere in the code - Tejas Patil On Feb. 12, 2014, 7:50 p.m., Joel Koshy wrote: > > --

[jira] [Commented] (KAFKA-1012) Implement an Offset Manager and hook offset requests to it

2013-10-25 Thread Tejas Patil (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13805446#comment-13805446 ] Tejas Patil commented on KAFKA-1012: Hi Joe, >> something like

[jira] [Commented] (KAFKA-1053) Kafka patch review tool

2013-09-11 Thread Tejas Patil (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13764683#comment-13764683 ] Tejas Patil commented on KAFKA-1053: (1) In [0], "Setup" -> hyperlin

Re: review board is available

2013-09-11 Thread Tejas Patil
This is cool !!! I can't wait to use it. Some comments: (1) In [0], "Setup" -> hyperlinks on steps 1 and 2 loop to the same webpage. (2) I don't have much idea about the right place where the ".reviewboardrc" file should be, but it would be a good idea to commit it in the codebase like [1]. Also

High Level Consumer == Consumer Groups ??

2013-09-10 Thread Tejas Patil
https://cwiki.apache.org/confluence/display/KAFKA/Consumer+Group+Example this wiki page is titled as: "Using the High Level Consumer - Also known as Consumer Groups" Isn't that wrong ? Thanks, Tejas

Re: Review Request 13908: Initial patch KAFKA-1012

2013-09-05 Thread Tejas Patil
e new offset. It does not touch commitsWhileLoading since loading does > > not have the key in it. Then the 1st statement in triggerLoadOffsets is > > executed and loading gets the offsets partition added to it. It goes ahead > > and updates the offsets table with the old offset since commitsWhileLoading > > was not updated by pu

[jira] [Commented] (KAFKA-1012) Implement an Offset Manager and hook offset requests to it

2013-09-04 Thread Tejas Patil (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13758830#comment-13758830 ] Tejas Patil commented on KAFKA-1012: Sriram and Neha had concerns about

Re: Review Request 13908: Initial patch KAFKA-1012

2013-08-30 Thread Tejas Patil
bab436dcef1645b5e327a5e7e68abdbe57604745 Diff: https://reviews.apache.org/r/13908/diff/ Testing --- Manual testing with 3 brokers, 2 producers and 6 consumers. Existing junits pass Thanks, Tejas Patil

RE: Review board: Not able to tag kafka group

2013-08-29 Thread Tejas Patil
Correction: Link for [1] is https://reviews.apache.org/groups/kafka/ ~tejas From: Tejas Patil [tejas.patil...@gmail.com] Sent: Thursday, August 29, 2013 6:36 PM To: dev@kafka.apache.org Subject: Review board: Not able to tag kafka group Hi, I am tried

Review board: Not able to tag kafka group

2013-08-29 Thread Tejas Patil
Hi, I am tried out the instructions over [0] to use review board and it worked like a charm. Over RB, when I tried to tag "kafka" in the "groups" field, it said that the group does not exist. Group tagging sends out notification to all the members of a group (in this case the "kafka" developers gr

[jira] [Commented] (KAFKA-1012) Implement an Offset Manager and hook offset requests to it

2013-08-29 Thread Tejas Patil (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13754280#comment-13754280 ] Tejas Patil commented on KAFKA-1012: The initial patch has been uploaded to re

[jira] [Commented] (KAFKA-1012) Implement an Offset Manager and hook offset requests to it

2013-08-29 Thread Tejas Patil (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13754024#comment-13754024 ] Tejas Patil commented on KAFKA-1012: > zkClient, logManager are impleme

[jira] [Commented] (KAFKA-1014) Junits and system tests for inbuilt offset management

2013-08-29 Thread Tejas Patil (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13754005#comment-13754005 ] Tejas Patil commented on KAFKA-1014: Here is a plan for system tests. For

[jira] [Comment Edited] (KAFKA-1012) Implement an Offset Manager and hook offset requests to it

2013-08-27 Thread Tejas Patil (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13751802#comment-13751802 ] Tejas Patil edited comment on KAFKA-1012 at 8/27/13 10:2

[jira] [Commented] (KAFKA-1012) Implement an Offset Manager and hook offset requests to it

2013-08-27 Thread Tejas Patil (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13751802#comment-13751802 ] Tejas Patil commented on KAFKA-1012: Thanks a lot @guozhang for all your comm

[jira] [Created] (KAFKA-1027) Add documentation for system tests

2013-08-26 Thread Tejas Patil (JIRA)
Tejas Patil created KAFKA-1027: -- Summary: Add documentation for system tests Key: KAFKA-1027 URL: https://issues.apache.org/jira/browse/KAFKA-1027 Project: Kafka Issue Type: Sub-task

[jira] [Commented] (KAFKA-1012) Implement an Offset Manager and hook offset requests to it

2013-08-26 Thread Tejas Patil (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13750956#comment-13750956 ] Tejas Patil commented on KAFKA-1012: Thanks a lot [~junrao] for all the awe

[jira] [Commented] (KAFKA-1012) Implement an Offset Manager and hook offset requests to it

2013-08-26 Thread Tejas Patil (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13750549#comment-13750549 ] Tejas Patil commented on KAFKA-1012: Re transactionality: In the current patch (

[jira] [Commented] (KAFKA-1014) Junits and system tests for inbuilt offset management

2013-08-19 Thread Tejas Patil (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13744719#comment-13744719 ] Tejas Patil commented on KAFKA-1014: Currently system tests are not on trunk so w

[jira] [Commented] (KAFKA-1012) Implement an Offset Manager and hook offset requests to it

2013-08-19 Thread Tejas Patil (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13744718#comment-13744718 ] Tejas Patil commented on KAFKA-1012: (1) Currently, "KafkaApis" has to

[jira] [Updated] (KAFKA-1012) Implement an Offset Manager and hook offset requests to it

2013-08-19 Thread Tejas Patil (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tejas Patil updated KAFKA-1012: --- Attachment: KAFKA-1012-v2.patch > Implement an Offset Manager and hook offset requests to

[jira] [Comment Edited] (KAFKA-1012) Implement an Offset Manager and hook offset requests to it

2013-08-19 Thread Tejas Patil (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13744186#comment-13744186 ] Tejas Patil edited comment on KAFKA-1012 at 8/19/13 9:2

[jira] [Comment Edited] (KAFKA-1012) Implement an Offset Manager and hook offset requests to it

2013-08-19 Thread Tejas Patil (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13744186#comment-13744186 ] Tejas Patil edited comment on KAFKA-1012 at 8/19/13 8:3

[jira] [Updated] (KAFKA-1012) Implement an Offset Manager and hook offset requests to it

2013-08-19 Thread Tejas Patil (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tejas Patil updated KAFKA-1012: --- Attachment: KAFKA-1012.patch Attached KAFKA-1012-v1.patch for trunk. An overview of the

[jira] [Created] (KAFKA-1015) documentation for inbuilt offset management

2013-08-19 Thread Tejas Patil (JIRA)
Tejas Patil created KAFKA-1015: -- Summary: documentation for inbuilt offset management Key: KAFKA-1015 URL: https://issues.apache.org/jira/browse/KAFKA-1015 Project: Kafka Issue Type: Sub-task

[jira] [Created] (KAFKA-1014) Junits and system tests for inbuilt offset management

2013-08-19 Thread Tejas Patil (JIRA)
Tejas Patil created KAFKA-1014: -- Summary: Junits and system tests for inbuilt offset management Key: KAFKA-1014 URL: https://issues.apache.org/jira/browse/KAFKA-1014 Project: Kafka Issue Type

[jira] [Created] (KAFKA-1013) Modify existing tools as per the changes in KAFKA-1000

2013-08-19 Thread Tejas Patil (JIRA)
Tejas Patil created KAFKA-1013: -- Summary: Modify existing tools as per the changes in KAFKA-1000 Key: KAFKA-1013 URL: https://issues.apache.org/jira/browse/KAFKA-1013 Project: Kafka Issue Type

[jira] [Created] (KAFKA-1012) Implement an Offset Manager and hook offset requests to it

2013-08-19 Thread Tejas Patil (JIRA)
Tejas Patil created KAFKA-1012: -- Summary: Implement an Offset Manager and hook offset requests to it Key: KAFKA-1012 URL: https://issues.apache.org/jira/browse/KAFKA-1012 Project: Kafka Issue

[jira] [Updated] (KAFKA-1000) Inbuilt consumer offset management feature for kakfa

2013-08-19 Thread Tejas Patil (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tejas Patil updated KAFKA-1000: --- Description: This Jira is for tracking the phase #2 of Offset Management [0]. Joel and I have been

[jira] [Updated] (KAFKA-1000) Inbuilt consumer offset management feature for kakfa

2013-08-19 Thread Tejas Patil (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tejas Patil updated KAFKA-1000: --- Summary: Inbuilt consumer offset management feature for kakfa (was: Inbuilt consumer offset

[jira] [Updated] (KAFKA-1000) Inbuilt consumer offset management

2013-08-19 Thread Tejas Patil (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tejas Patil updated KAFKA-1000: --- Description: This Jira is for tracking the phase #2 of Offset Management [0]. After KAFKA-657 [1

[jira] [Created] (KAFKA-1000) Inbuilt consumer offset management

2013-08-05 Thread Tejas Patil (JIRA)
Tejas Patil created KAFKA-1000: -- Summary: Inbuilt consumer offset management Key: KAFKA-1000 URL: https://issues.apache.org/jira/browse/KAFKA-1000 Project: Kafka Issue Type: New Feature

[jira] [Updated] (KAFKA-559) Garbage collect old consumer metadata entries

2013-07-08 Thread Tejas Patil (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tejas Patil updated KAFKA-559: -- Attachment: KAFKA-559.v2.patch _1. Passing a groupId for cleanup will make the cleanup job tedious

[jira] [Updated] (KAFKA-559) Garbage collect old consumer metadata entries

2013-07-03 Thread Tejas Patil (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tejas Patil updated KAFKA-559: -- Attachment: KAFKA-559.v1.patch Attached KAFKA-559.v1.patch above. - It has been developed to work do