[jira] [Commented] (KAFKA-717) scala 2.10 build support

2013-07-16 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13710343#comment-13710343 ] Scott Carey commented on KAFKA-717: --- The latter plan looks good t

[jira] [Commented] (KAFKA-717) scala 2.10 build support

2013-07-16 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13709915#comment-13709915 ] Scott Carey commented on KAFKA-717: --- {quote}that would be easiest for us would be

[jira] [Commented] (KAFKA-717) scala 2.10 build support

2013-07-16 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13709904#comment-13709904 ] Scott Carey commented on KAFKA-717: --- {quote}As it stands now folks are already run

[jira] [Commented] (KAFKA-717) scala 2.10 build support

2013-07-15 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13708973#comment-13708973 ] Scott Carey commented on KAFKA-717: --- {quote} looking at the simple patch not

[jira] [Updated] (KAFKA-717) scala 2.10 build support

2013-06-14 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Carey updated KAFKA-717: -- Attachment: 0004-Fix-cross-compile-of-tests-update-to-2.10.2-and-set-.patch 0003-add

[jira] [Commented] (KAFKA-133) Publish kafka jar to a public maven repository

2013-04-29 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13645053#comment-13645053 ] Scott Carey commented on KAFKA-133: --- The build is using SBT, whic is using Ivy be

[jira] [Updated] (KAFKA-717) scala 2.10 build support

2013-04-23 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Carey updated KAFKA-717: -- Attachment: 0003-add-2.9.3.patch 0002-java-conversions-changes.patch

[jira] [Commented] (KAFKA-873) Consider replacing zkclient with curator (with zkclient-bridge)

2013-04-23 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13639553#comment-13639553 ] Scott Carey commented on KAFKA-873: --- The way the in-memory ZK is used needs to ch

[jira] [Commented] (KAFKA-717) scala 2.10 build support

2013-04-23 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13639349#comment-13639349 ] Scott Carey commented on KAFKA-717: --- The patch was meant to apply to the 0.8 br

Re: Kafka 0.8 release schedule?

2013-04-18 Thread Scott Carey
Stein, > >Could you confirm? > >Thanks, > >Jun > > >On Wed, Apr 17, 2013 at 1:46 PM, Scott Carey >wrote: > >> I think https://issues.apache.org/jira/browse/KAFKA-854, at least in the >> form of upgrading minor versions of log4j, zookeeper, slf4j, and >

[jira] [Commented] (KAFKA-865) Mavenize and separate the client.

2013-04-18 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13635478#comment-13635478 ] Scott Carey commented on KAFKA-865: --- I'm a big fan of Maven (It has some big f

Re: Kafka 0.8 release schedule?

2013-04-17 Thread Scott Carey
I think https://issues.apache.org/jira/browse/KAFKA-854, at least in the form of upgrading minor versions of log4j, zookeeper, slf4j, and jopt-simple should be considered for 0.8. The log4j upgrade especially simplifies things by dropping transitive dependencies on cruft. The build in 0.8 does no

[jira] [Commented] (KAFKA-156) Messages should not be dropped when brokers are unavailable

2013-04-14 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13631474#comment-13631474 ] Scott Carey commented on KAFKA-156: --- Jay -- I agree, the duplication issue does

[jira] [Commented] (KAFKA-854) Upgrade dependencies for 0.8

2013-04-12 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13630579#comment-13630579 ] Scott Carey commented on KAFKA-854: --- 1. It is probably easier to review by lookin

[jira] [Commented] (KAFKA-843) Re-add the release-zip sbt target

2013-04-12 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13630562#comment-13630562 ] Scott Carey commented on KAFKA-843: --- Another suggestion: What if buildNumber was

[jira] [Updated] (KAFKA-854) Upgrade dependencies for 0.8

2013-04-11 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Carey updated KAFKA-854: -- Attachment: KAFKA-854.patch This patch has been rebased after the commit to KAFKA-843

[jira] [Commented] (KAFKA-843) Re-add the release-zip sbt target

2013-04-11 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13629400#comment-13629400 ] Scott Carey commented on KAFKA-843: --- The final release artifact version will be ver

[jira] [Commented] (KAFKA-843) Re-add the release-zip sbt target

2013-04-11 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13629221#comment-13629221 ] Scott Carey commented on KAFKA-843: --- This seems to require that there be a "bu

Re: sbt organization name "org.apache.kafka" instead of "org.apache"

2013-04-11 Thread Scott Carey
Yes. As part of my proposed sbt cleanup in KAFKA-854 I have made that change. I am currently trying to rebase that change on current 0.8 On 4/11/13 10:01 AM, "Cosmin Lehene" wrote: >Shouldn't organization be set to "org.apache.kafka" instead of >"org.apache" in Build.scala? > >Thanks, >Cosmin >

[jira] [Updated] (KAFKA-854) Upgrade dependencies for 0.8

2013-04-09 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Carey updated KAFKA-854: -- Attachment: KAFKA-854.patch Rebased to 0.8 branch, 6dbf9212ae4dc6ed7f91fc99135b8a3b35ab5edb Big

[jira] [Updated] (KAFKA-854) Upgrade dependencies for 0.8

2013-04-08 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Carey updated KAFKA-854: -- Attachment: KAFKA-854.patch Cleans up dependencies and SBT build in general (~350 lines fewer than

[jira] [Commented] (KAFKA-826) Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x

2013-04-08 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13626135#comment-13626135 ] Scott Carey commented on KAFKA-826: --- Can a committer look at this? This would be g

Re: Thoughts on using Ant+Ivy for the build?

2013-04-08 Thread Scott Carey
calling ant tasks from within them, if necessary. In general, any tool will work if maintained and used properly, and any tool can be abused and poorly organized for maintenance. On 4/8/13 2:09 PM, "Scott Carey" wrote: >Gradle is also gaining a lot of popularity, and has a good

Re: Thoughts on using Ant+Ivy for the build?

2013-04-08 Thread Scott Carey
ng too much into a Maven/Ant+Ivy/SBT debate, it is >>>clear >>> that there are issues with the current build. I'm proposing Ant+Ivy, if >>> enough people buy into this - great we'll use Ant. If not, also great >>>- I'm >>> simply forcing the di

Re: Kafka and Scala versions

2013-04-08 Thread Scott Carey
rder to support scala >2.10. >What are the things that you are looking for in scala 2.10? > >Thanks, > >Jun > > >On Fri, Apr 5, 2013 at 1:10 PM, Scott Carey >wrote: > >> Kafka 0.8 and trunk by default have SBT set up to cross-compile 2.8.0, >> 2.8.2, 2.9.1

Re: Thoughts on using Ant+Ivy for the build?

2013-04-08 Thread Scott Carey
My first reaction to looking at the current build was that I could do a lot better with Maven and I'd get a lot of free stuff with that (dependency:tree, versions:display-dependency-updates), except that cross scala versions would be uglier. Modularization is trivial with maven (the stuff outside

[jira] [Commented] (KAFKA-854) Upgrade dependencies for 0.8

2013-04-08 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13625652#comment-13625652 ] Scott Carey commented on KAFKA-854: --- {quote} While you're at it you could als

[jira] [Commented] (KAFKA-854) Upgrade dependencies for 0.8

2013-04-08 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13625601#comment-13625601 ] Scott Carey commented on KAFKA-854: --- The problem is I'm an SBT neophyte, a

[jira] [Updated] (KAFKA-717) scala 2.10 build support

2013-04-07 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Carey updated KAFKA-717: -- Attachment: KAFKA-717-complex.patch KAFKA-717-simple.patch The patches here implement

[jira] [Commented] (KAFKA-854) Upgrade dependencies for 0.8

2013-04-05 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13624264#comment-13624264 ] Scott Carey commented on KAFKA-854: --- Ick, worse, some dependencies are listed t

[jira] [Comment Edited] (KAFKA-854) Upgrade dependencies for 0.8

2013-04-05 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13624255#comment-13624255 ] Scott Carey edited comment on KAFKA-854 at 4/6/13 1:07 AM: ---

[jira] [Comment Edited] (KAFKA-854) Upgrade dependencies for 0.8

2013-04-05 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13624255#comment-13624255 ] Scott Carey edited comment on KAFKA-854 at 4/6/13 1:06 AM: ---

[jira] [Commented] (KAFKA-854) Upgrade dependencies for 0.8

2013-04-05 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13624255#comment-13624255 ] Scott Carey commented on KAFKA-854: --- Why are dependencies repeated? project/b

[jira] [Commented] (KAFKA-854) Upgrade dependencies for 0.8

2013-04-05 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13624250#comment-13624250 ] Scott Carey commented on KAFKA-854: --- Also, upgrading log4j means that all of the

[jira] [Commented] (KAFKA-717) scala 2.10 build support

2013-04-05 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13624220#comment-13624220 ] Scott Carey commented on KAFKA-717: --- To support all versions concurrently, we ne

Kafka and Scala versions

2013-04-05 Thread Scott Carey
Kafka 0.8 and trunk by default have SBT set up to cross-compile 2.8.0, 2.8.2, 2.9.1 and 2.9.2, and it defaults to 2.8.0. I assume that one of the major contributors requires 2.8.0. Any approximation on how long will that last? Dropping 2.8.0 would be beneficial because some uses of Java Conversio

[jira] [Created] (KAFKA-854) Upgrade dependencies for 0.8

2013-04-05 Thread Scott Carey (JIRA)
Scott Carey created KAFKA-854: - Summary: Upgrade dependencies for 0.8 Key: KAFKA-854 URL: https://issues.apache.org/jira/browse/KAFKA-854 Project: Kafka Issue Type: Improvement Affects

[jira] [Comment Edited] (KAFKA-717) scala 2.10 build support

2013-04-04 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13623232#comment-13623232 ] Scott Carey edited comment on KAFKA-717 at 4/5/13 1:19 AM: ---

[jira] [Commented] (KAFKA-717) scala 2.10 build support

2013-04-04 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13623232#comment-13623232 ] Scott Carey commented on KAFKA-717: --- The patch is already attached to this ticket, i

[jira] [Commented] (KAFKA-826) Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x

2013-04-04 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13622650#comment-13622650 ] Scott Carey commented on KAFKA-826: --- Sounds good to me. > Mak

[jira] [Commented] (KAFKA-156) Messages should not be dropped when brokers are unavailable

2013-04-03 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13621665#comment-13621665 ] Scott Carey commented on KAFKA-156: --- To support lossless transmission, the prod

[jira] [Commented] (KAFKA-264) Change the consumer side load balancing and distributed co-ordination to use a consumer co-ordinator

2013-04-03 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13621563#comment-13621563 ] Scott Carey commented on KAFKA-264: --- I found it browsing "fix ve

[jira] [Commented] (KAFKA-156) Messages should not be dropped when brokers are unavailable

2013-04-03 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13621433#comment-13621433 ] Scott Carey commented on KAFKA-156: --- I am positive that the producer wire protocol

[jira] [Commented] (KAFKA-826) Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x

2013-04-03 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13621426#comment-13621426 ] Scott Carey commented on KAFKA-826: --- Given the volume of work that has been don

[jira] [Commented] (KAFKA-826) Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x

2013-04-03 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13621416#comment-13621416 ] Scott Carey commented on KAFKA-826: --- My main complaint prior to this was two-

[jira] [Commented] (KAFKA-264) Change the consumer side load balancing and distributed co-ordination to use a consumer co-ordinator

2013-04-03 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13621242#comment-13621242 ] Scott Carey commented on KAFKA-264: --- Is this still going into 0.8? Is it alread

[jira] [Commented] (KAFKA-826) Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x

2013-03-29 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13617539#comment-13617539 ] Scott Carey commented on KAFKA-826: --- The only real trouble with 3.0.x is if:

Re: Any update on the "distributed commit" problem?

2013-03-25 Thread Scott Carey
In order to succeed in a client with two phase commit one needs the "coordinates" of the current batch of records from the client perspective of the batch (which may be many SimpleConsumer smaller batches). I believe this is the range of offsets plus any partition information that describe the bat

[jira] [Commented] (KAFKA-826) Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x

2013-03-25 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13613192#comment-13613192 ] Scott Carey commented on KAFKA-826: --- Thank you! We will be able to test and vali

[jira] [Commented] (KAFKA-717) scala 2.10 build support

2013-03-04 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13592900#comment-13592900 ] Scott Carey commented on KAFKA-717: --- I take that back, scala.annotation.StaticAnnota

[jira] [Commented] (KAFKA-717) scala 2.10 build support

2013-03-04 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13592862#comment-13592862 ] Scott Carey commented on KAFKA-717: --- It appears that the changes are back-compat

[jira] [Commented] (KAFKA-133) Publish kafka jar to a public maven repository

2013-01-23 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13561104#comment-13561104 ] Scott Carey commented on KAFKA-133: --- Additionally, 0.8.x can not be an official Ap

[jira] [Commented] (KAFKA-133) Publish kafka jar to a public maven repository

2013-01-23 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13561100#comment-13561100 ] Scott Carey commented on KAFKA-133: --- 0.8.x needs to depend on a released versio

[jira] [Commented] (KAFKA-374) Move to java CRC32 implementation

2012-12-13 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13531328#comment-13531328 ] Scott Carey commented on KAFKA-374: --- I was thinking of using Akka Actors, as they

[jira] [Commented] (KAFKA-374) Move to java CRC32 implementation

2012-12-12 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13530654#comment-13530654 ] Scott Carey commented on KAFKA-374: --- Awesome. I was just profiling some Kafka 0