Re: [VOTE] KIP 771: KRaft brokers should not expose controller metrics

2021-09-21 Thread Ryan Dielhenn
Hello all, Thank you all for the votes! With 3 binding and 1 non-binding vote this KIP will be accepted. Regards, Ryan Dielhenn On Tue, Sep 21, 2021 at 11:44 AM Ismael Juma wrote: > Thanks for the KIP, +1 (binding). > > Ismael > > On Thu, Sep 2, 2021 at 1:20 PM Ryan Die

Re: [DISCUSS] KIP-771: KRaft broker should not expose controller metrics

2021-09-17 Thread Ryan Dielhenn
KIP: https://cwiki.apache.org/confluence/pages/diffpagesbyversion.action?pageId=188743985&selectedPageVersions=16&selectedPageVersions=14 Regards, Ryan Dielhenn On Fri, Aug 27, 2021 at 2:19 PM Ryan Dielhenn wrote: > Hello kafka devs, > > I would like to start a discussion on a K

Re: [DISCUSS] KIP-771: KRaft broker should not expose controller metrics

2021-09-07 Thread Ryan Dielhenn
Thanks for the suggestions Colin, I updated the KIP, here are the changes: https://cwiki.apache.org/confluence/pages/diffpagesbyversion.action?pageId=188743985&selectedPageVersions=14&selectedPageVersions=13 Regards, Ryan Dielhenn On 2021/09/07 16:46:13, "Colin McCabe" wr

[VOTE] KIP 771: KRaft brokers should not expose controller metrics

2021-09-02 Thread Ryan Dielhenn
/r74432034527fab13cc973ad5187ef5881a642500d77b0d275dd7f018%40%3Cdev.kafka.apache.org%3E Regards, Ryan Dielhenn

Re: [DISCUSS] KIP-771: KRaft broker should not expose controller metrics

2021-09-01 Thread Ryan Dielhenn
Thank you Ron & Colin for the comments. I have updated the KIP with the suggested changes: https://cwiki.apache.org/confluence/pages/diffpagesbyversion.action?pageId=188743985&selectedPageVersions=6&selectedPageVersions=5 Regards, Ryan Dielhenn On 2021/08/31 22:41:21, "Col

[DISCUSS] KIP-771: KRaft broker should not expose controller metrics

2021-08-27 Thread Ryan Dielhenn
Hello kafka devs, I would like to start a discussion on a KIP I have created to change how controller metrics are exposed for KRaft brokers. Here is the KIP: https://cwiki.apache.org/confluence/display/KAFKA/KIP+771%3A+KRaft+brokers+should+not+expose+controller+metrics Regards, Ryan Dielhenn

[jira] [Created] (KAFKA-13245) KIP 771: Change behavior of how controller metrics are exposed when using KRaft.

2021-08-27 Thread Ryan Dielhenn (Jira)
Ryan Dielhenn created KAFKA-13245: - Summary: KIP 771: Change behavior of how controller metrics are exposed when using KRaft. Key: KAFKA-13245 URL: https://issues.apache.org/jira/browse/KAFKA-13245

Re: [DISCUSS] Apache Kafka 3.0.0 release plan with new updated dates

2021-08-03 Thread Ryan Dielhenn
broker configuration. I filed a JIRA: https://issues.apache.org/jira/browse/KAFKA-13160 I also have a PR to fix this: https://github.com/apache/kafka/pull/11168 I think that this should be a blocker for 3.0 because dynamic default broker configs will not be usable in KRaft otherwise. Best, Ryan D

[jira] [Created] (KAFKA-13160) Fix BrokerConfigHandler to expect empty string as the resource name for dynamic default broker configs in KRaft

2021-08-03 Thread Ryan Dielhenn (Jira)
Ryan Dielhenn created KAFKA-13160: - Summary: Fix BrokerConfigHandler to expect empty string as the resource name for dynamic default broker configs in KRaft Key: KAFKA-13160 URL: https://issues.apache.org/jira

[jira] [Resolved] (KAFKA-13153) Disallow KRaft broker registration if the node.id is already in use

2021-07-31 Thread Ryan Dielhenn (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Dielhenn resolved KAFKA-13153. --- Resolution: Won't Fix This would render colocated Kraft useless. > Disallow KRaf

[jira] [Created] (KAFKA-13153) Disallow KRaft broker registration if the node.id is already in use

2021-07-31 Thread Ryan Dielhenn (Jira)
Ryan Dielhenn created KAFKA-13153: - Summary: Disallow KRaft broker registration if the node.id is already in use Key: KAFKA-13153 URL: https://issues.apache.org/jira/browse/KAFKA-13153 Project: Kafka

Re: [DISCUSS] Apache Kafka 3.0.0 release plan with new updated dates

2021-07-30 Thread Ryan Dielhenn
Hey Konstantine, Thanks for the question. If these configs are not validated the user's experience will be affected and upgrades from 3.0 will be harder. Best, Ryan Dielhenn On Thu, Jul 29, 2021 at 3:59 PM Konstantine Karantasis < kkaranta...@apache.org> wrote: > Thanks for

Re: [DISCUSS] Apache Kafka 3.0.0 release plan with new updated dates

2021-07-29 Thread Ryan Dielhenn
Hi, Disregard log.clean.policy being included in this blocker. Best, Ryan Dielhenn On Thu, Jul 29, 2021 at 2:38 PM Ryan Dielhenn wrote: > Hey Konstantine, > > I'd like to report another bug in KRaft. > > log.cleanup.policy, alter.config.policy.class.name, and > create.

Re: [DISCUSS] Apache Kafka 3.0.0 release plan with new updated dates

2021-07-29 Thread Ryan Dielhenn
hould fail startup if any of these are configured. I do not have a PR yet but will soon. On another note, I have a PR for the dynamic broker configuration fix here: https://github.com/apache/kafka/pull/11141 Best, Ryan Dielhenn On Wed, May 26, 2021 at 2:48 PM Konstantine Karantasis wrote: >

[jira] [Created] (KAFKA-13151) KRaft does not support Policies (e.g. AlterConfigPolicy). The server should fail startup if any are configured.

2021-07-29 Thread Ryan Dielhenn (Jira)
Ryan Dielhenn created KAFKA-13151: - Summary: KRaft does not support Policies (e.g. AlterConfigPolicy). The server should fail startup if any are configured. Key: KAFKA-13151 URL: https://issues.apache.org/jira

Re: [DISCUSS] Apache Kafka 3.0.0 release plan with new updated dates

2021-07-27 Thread Ryan Dielhenn
Hello, I would like to report a bug in KRaft. Dynamic broker configs are not being validated on the brokers before being forwarded to the controller and persisted in the metadata quorum. This is a blocker because a core requirement of KRaft mode in 3.0 is that it should support upgrades from 3.0.

[jira] [Created] (KAFKA-13142) KRaft controller does not validate dynamic configs

2021-07-27 Thread Ryan Dielhenn (Jira)
Ryan Dielhenn created KAFKA-13142: - Summary: KRaft controller does not validate dynamic configs Key: KAFKA-13142 URL: https://issues.apache.org/jira/browse/KAFKA-13142 Project: Kafka Issue

[jira] [Created] (KAFKA-13051) Require Principal Serde to be defined for 3.0

2021-07-08 Thread Ryan Dielhenn (Jira)
Ryan Dielhenn created KAFKA-13051: - Summary: Require Principal Serde to be defined for 3.0 Key: KAFKA-13051 URL: https://issues.apache.org/jira/browse/KAFKA-13051 Project: Kafka Issue Type

[jira] [Created] (KAFKA-12953) Bump Zookeeper version to 3.6.3

2021-06-15 Thread Ryan Dielhenn (Jira)
Ryan Dielhenn created KAFKA-12953: - Summary: Bump Zookeeper version to 3.6.3 Key: KAFKA-12953 URL: https://issues.apache.org/jira/browse/KAFKA-12953 Project: Kafka Issue Type: Task

Re: [DISCUSS] KIP-748: Add Broker Count Metrics

2021-06-15 Thread Ryan Dielhenn
Hey all, I removed the table for the ZK metric and specified that `kafka.controller:type=KafkaController` is used by both ZK and Quorum controllers. Best, Ryan Dielhenn On 2021/06/14 17:56:59, Xavier Léauté wrote: > Any reason we need two different metrics for ZK an Quorum based controll

[VOTE] KIP-748: Add Broker Count Metrics

2021-06-10 Thread Ryan Dielhenn
Hello, I would like to start a vote on KIP-748: Add Broker Count Metrics. Here is the KIP: https://cwiki.apache.org/confluence/display/KAFKA/KIP-748:+Add+Broker+Count+Metrics Here is the discussion thread: https://lists.apache.org/thread.html/r308364dfbb3020e6151cef47237c28a4a540e187b8af84ddafec

Re: [DISCUSS] KIP-748: Add Broker Count Metrics

2021-06-07 Thread Ryan Dielhenn
Hey Colin and David, I added another table for the ZK version of RegisteredBrokerCount. Best, Ryan Dielhenn On 2021/06/04 08:21:27, David Jacot wrote: > Hi Ryan, > > Thanks for the KIP. > > +1 for adding RegisteredBrokerCount to the ZK controller as well. This > would

[DISCUSS] KIP-748: Add Broker Count Metrics

2021-06-03 Thread Ryan Dielhenn
Hey kafka-dev, I created KIP-748 as a proposal to add broker count metrics to the Quorum Controller. https://cwiki.apache.org/confluence/display/KAFKA/KIP-748%3A+Add+Broker+Count+Metrics#KIP748:AddBrokerCountMetrics Best, Ryan Dielhenn

[DISCUSS] KIP-748 Kafka Consumer Record Latency Metric

2021-06-02 Thread Ryan Dielhenn
Hey kafka-dev, I created KIP-748 as a proposal to add broker count metrics to the Quorum Controller. https://cwiki.apache.org/confluence/display/KAFKA/KIP-748%3A+Add+Broker+Count+Metrics#KIP748:AddBrokerCountMetrics Best, Ryan Dielhenn

[jira] [Created] (KAFKA-12882) Add RegisteredBrokerCount and UnfencedBrokerCount metrics to the QuorumController

2021-06-02 Thread Ryan Dielhenn (Jira)
Ryan Dielhenn created KAFKA-12882: - Summary: Add RegisteredBrokerCount and UnfencedBrokerCount metrics to the QuorumController Key: KAFKA-12882 URL: https://issues.apache.org/jira/browse/KAFKA-12882

[jira] [Created] (KAFKA-12697) Add GlobalTopicCount and GlobalPartitionCount metrics to QuorumController

2021-04-20 Thread Ryan Dielhenn (Jira)
Ryan Dielhenn created KAFKA-12697: - Summary: Add GlobalTopicCount and GlobalPartitionCount metrics to QuorumController Key: KAFKA-12697 URL: https://issues.apache.org/jira/browse/KAFKA-12697 Project

[jira] [Created] (KAFKA-12692) Enforce config types in ConfigurationControlManager

2021-04-19 Thread Ryan Dielhenn (Jira)
Ryan Dielhenn created KAFKA-12692: - Summary: Enforce config types in ConfigurationControlManager Key: KAFKA-12692 URL: https://issues.apache.org/jira/browse/KAFKA-12692 Project: Kafka Issue

Permission to Assign Jiras

2021-04-06 Thread Ryan Dielhenn
Hello, May I have permission to assign Jiras to myself? I just got this done https://issues.apache.org/jira/browse/KAFKA-12265 but don't have access to reassign it. Best, Ryan Dielhenn

Re: [DISCUSS] KIP-649: Dynamic Client Configuration

2020-08-10 Thread Ryan Dielhenn
client. 4. Updated the compatibility, deprecation, and migration plan to address the issue of adding support for dynamic configs over time. I am still working on changing the behavior of JoinGroup to avoid a rebalance when updating the timeout. Best, Ryan Dielhenn On Wed, Aug 5, 2020 at 5:23

Re: [DISCUSS] KIP-649: Dynamic Client Configuration

2020-08-07 Thread Ryan Dielhenn
session timeout is sent to the group coordinator in the JoinGroup request. > I'm wondering if we need to change the JoinGroup behavior so that it can be > used to update the session timeout without triggering a rebalance. > > Thanks, > Jason > > > > > On Mon, Aug 3, 2020

Re: [DISCUSS] KIP-649: Dynamic Client Configuration

2020-08-03 Thread Ryan Dielhenn
nfig up to the clients via dynamic configs? > > Also, minor note, in ConfigResource#Type, I think the byte values are used > for bit masking somewhere, so 9 won't work -- you'd need to bump up to 16 > > -David > > On Fri, Jul 31, 2020 at 6:06 PM Ryan Dielhenn > wrote:

Re: [DISCUSS] KIP-649: Dynamic Client Configuration

2020-08-03 Thread Ryan Dielhenn
? > > Also, minor note, in ConfigResource#Type, I think the byte values are used > for bit masking somewhere, so 9 won't work -- you'd need to bump up to 16 > > -David > > On Fri, Jul 31, 2020 at 6:06 PM Ryan Dielhenn > wrote: > > > Thanks Jose, &

Re: [DISCUSS] KIP-649: Dynamic Client Configuration

2020-07-31 Thread Ryan Dielhenn
Thanks Jose, Here are the changes to the KIP: https://cwiki.apache.org/confluence/pages/diffpagesbyversion.action?pageId=158869615&selectedPageVersions=10&selectedPageVersions=9 1. Done. 2. Done. 3. Done. 4. Yes metadata.max.age.ms will be use, I updated the KIP with this. > 5. > The Consumer C

[DISCUSS] KIP-649: Dynamic Client Configuration

2020-07-29 Thread Ryan Dielhenn
and consumer configurations that we would like to provide dynamic support for and they are outlined in this KIP. Please reply with any comments or suggestions. Thank you! Ryan Dielhenn

[jira] [Created] (KAFKA-10325) Implement KIP-649: Dynamic Client Configuration

2020-07-29 Thread Ryan Dielhenn (Jira)
Ryan Dielhenn created KAFKA-10325: - Summary: Implement KIP-649: Dynamic Client Configuration Key: KAFKA-10325 URL: https://issues.apache.org/jira/browse/KAFKA-10325 Project: Kafka Issue Type