Re: [DISCUSS] KIP-184 Rename LogCleaner and related classes to LogCompactor

2017-08-25 Thread Pranav Maniar
te painful to users, since they'd have to > > deal with deprecation warnings and multiple names for the same > > configuration. In general I think Jason and Ismael's point is valid: do > > we have evidence that "log cleaner" is causing confusion? If not, it &g

[jira] [Resolved] (KAFKA-1944) Rename LogCleaner and related classes to LogCompactor

2017-08-25 Thread Pranav Maniar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pranav Maniar resolved KAFKA-1944. -- Resolution: Won't Fix As discussed on Mailing List and KIP-184 discussion. This name ch

Re: [DISCUSS] KIP-184 Rename LogCleaner and related classes to LogCompactor

2017-08-21 Thread Pranav Maniar
is an implementation detail which probably > doesn't need to be included in the KIP. > > -Jason > > On Wed, Aug 9, 2017 at 10:47 AM, Pranav Maniar > wrote: > > > Thanks Ismael, Jason for the suggestion. > > My bad. I should have followed up on mail-list disc

Re: [DISCUSS] KIP-184 Rename LogCleaner and related classes to LogCompactor

2017-08-09 Thread Pranav Maniar
uot;compact" and "delete," in which case the > LogCleaner also handles removal of old segments. Hence the more general > LogCleaner name is more appropriate in my opinion. > > -Jason > > On Wed, Aug 9, 2017 at 9:49 AM, Pranav Maniar > wrote: > > > Tha

Re: [DISCUSS] KIP-184 Rename LogCleaner and related classes to LogCompactor

2017-08-09 Thread Pranav Maniar
an > implementation detail. > > -Ewen > > On Tue, Aug 8, 2017 at 10:17 PM, Pranav Maniar > wrote: > > > Thanks Guozhang for the suggestion. > > > > For now, I have updated KIP incorporating your suggestion. > > Personally I think implicitly enabling c

Re: [DISCUSS] KIP-184 Rename LogCleaner and related classes to LogCompactor

2017-08-08 Thread Pranav Maniar
iscussion is to deprecate the " > log.cleaner.enable" and always turn on compaction for those topics that > have compact policies? > > > Guozhang > > On Sat, Aug 5, 2017 at 9:36 AM, Pranav Maniar > wrote: > > > Hi All, > > > > Following a d

[DISCUSS] KIP-184 Rename LogCleaner and related classes to LogCompactor

2017-08-05 Thread Pranav Maniar
Hi All, Following a discussion on JIRA KAFKA-1944 . I have created KIP-184 as it will require configuration change. As per the pr

Re: [DISCUSS] KAFKA-1944 Rename LogCleaner to LogCompactor

2017-08-03 Thread Pranav Maniar
nd some of the core components depend on it. > I would support a KIP which did just that. > > -Jason > > On Tue, Aug 1, 2017 at 11:52 PM, Pranav Maniar > wrote: > > > Hi All, > > > > I am planning to take up [KAFKA-1944 > > <https://issues.ap

[DISCUSS] KAFKA-1944 Rename LogCleaner to LogCompactor

2017-08-01 Thread Pranav Maniar
Hi All, I am planning to take up [KAFKA-1944 ] : Rename LogCleaner to LogCompactor. Renaming will cover LogCleander, LogCleanerManager, related Testcases and all method/variable/documentations inside it. It also requires configuration name change

Re: Requesting permission to create KIP

2017-07-31 Thread Pranav Maniar
l 31, 2017 at 7:13 AM, Pranav Maniar > wrote: > > > Hi All, > > > > I am trying to create KIP for KAFKA-1944 > > <https://issues.apache.org/jira/browse/KAFKA-1944> . > > But it seems that I don't have permission to access/create KIP template. > >

Requesting permission to create KIP

2017-07-31 Thread Pranav Maniar
Hi All, I am trying to create KIP for KAFKA-1944 . But it seems that I don't have permission to access/create KIP template. Can you please assign me permission for that. My JIRA Username is : pranav.maniar Email Id : pranav9...@gmail.com Thanks,