Thanks for the +1s. I'll send out a PR shortly.
Thanks
Piyush Vijay
On Mon, May 21, 2018 at 8:59 AM, Guozhang Wang wrote:
> Thanks for the KIP, +1 from me (binding).
>
>
> Guozhang
>
> On Mon, May 21, 2018 at 5:22 AM, Damian Guy wrote:
>
> > +1 (binding)
>
Hi Ron,
I've incorporated both of your suggestions.
Thanks
Piyush Vijay
On Sat, May 19, 2018 at 4:07 AM, Ron Dagostino wrote:
> Hi Piyush. I think it would be better to match the flag in kafka-acls.sh
> to the new enum. Instead of stating “–wildcard-suffixed-resource true
because
resources like consumer groups don't have defined naming convention and can
have '*' in their names.
Please take a look.
Thanks
Piyush Vijay
because
resources like consumer groups don't have defined naming convention and can
have '*' in their names.
Please take a look.
Thanks
Piyush Vijay
;.
Looks ready to me for the vote, will start voting thread now. Thanks
everyone for the valuable feedback.
Piyush Vijay
Piyush Vijay
On Fri, May 18, 2018 at 6:07 PM, Andy Coates wrote:
> Hi Piyush,
>
> We're fast approaching the KIP deadline. Are you actively working on this?
Piyush Vijay
On Fri, May 18, 2018 at 1:55 PM, Andy Coates wrote:
> Hey Piyush,
>
> Thanks for getting this in! :D
>
> About to read now. But just quickly...
>
> 1. I'll read up on the need for getMatchingAcls - but just playing devils
> advocate for a moment - i
Ready to review. Let me know if something looks missing or not clear.
Thanks
Piyush Vijay
On Fri, May 18, 2018 at 12:54 PM, Piyush Vijay
wrote:
> Andy,
>
> 1. Updated the KIP about need for getMatchingAcls(). Basically, it's
> required to add an inspection method
Good point about moving everything to a v2 path. We might still have to
support snowflakes but I will this better.
I'm giving it a final read. I'll update here once I think it's ready.
Thanks
Piyush Vijay
On Fri, May 18, 2018 at 12:18 PM, Piyush Vijay
wrote:
> On it, Andy.
sn't leave much room for resolving any issues any committers find.
> Also, we now require at least three committers to review this KIP today
> _and_ find no issues if we're to get this KIP accepted.
>
> Thanks,
>
> Andy
>
> On 18 May 2018 at 01:21, Piyush Vijay
Hi Andy,
I still have some minor changes left to the KIP. I'll make them in the
morning. I'm sorry I got caught up in some other things today. But that
would still give us 72 hours before the deadline :)
Thanks
Piyush Vijay
On Thu, May 17, 2018 at 1:27 PM, Andy Coates wrote:
&g
It's still not complete. I'll drop a message here when I'm done with the
updates.
Thanks
Piyush Vijay
On Thu, May 17, 2018 at 12:04 PM, Andy Coates wrote:
> Thanks for the update to the KIP Piyush!
>
> Reading it through again, I've a couple of questions:
>
&g
o escape consumer
> group names and other names. So you can feed this method your "foo\*"
> consumer group name, and it will give you "foo\\\*", which is what you
> would need to use to create an ACL for this consumer group in AdminClient.
> I think that's the
Hi Rajini/Colin,
I will remove the wildcard principals from the scope for now, updating KIP
right now and will open it for vote.
Thanks
Piyush Vijay
On Thu, May 17, 2018 at 6:59 AM, Rajini Sivaram
wrote:
> Hi Piyush,
>
> I have added a PR (https://github.com/apache/kafka/pull/5
change? This will be a
one-time breaking change in APIs marked as "Evolving", but makes sense in
the long term? Am I missing something here?
Piyush Vijay
On Tue, May 15, 2018 at 9:01 AM, Colin McCabe wrote:
> Hi Piyush,
>
> I think AclBinding should operate the same way as AclBi
);
public abstract DeleteAclsResult
deleteAcls(Collection filters, DeleteAclsOptions
options);
Thanks
Piyush Vijay
On Mon, May 14, 2018 at 9:26 AM, Andy Coates wrote:
> +1
>
> On 11 May 2018 at 17:14, Colin McCabe wrote:
>
> > Hi Andy,
> >
> > I see what you mea
Makes sense. I'll update the KIP.
Does anyone have any other comments? :)
Thanks
Piyush Vijay
On Thu, May 3, 2018 at 11:55 AM, Colin McCabe wrote:
> Yeah, I guess that's a good point. It probably makes sense to support the
> prefix scheme for consumer groups and transacti
teration.
Best,
Piyush
Piyush Vijay
On Wed, May 2, 2018 at 1:33 PM, Andy Coates wrote:
> > Perhaps there is a simpler way. It seems like the resource that people
> really want to use prefixed ACLs with is topic names. Because topic names
> can't contain "*", ther
Piyush Vijay created KAFKA-6841:
---
Summary: Add support for wildcard suffixed ACLs
Key: KAFKA-6841
URL: https://issues.apache.org/jira/browse/KAFKA-6841
Project: Kafka
Issue Type: New Feature
is an open question about the way to add the support in the
AdminClient, which I can discuss here in more detail once everyone has
taken a first look at the KIP.
Looking forward to discuss the change.
Best,
Piyush Vijay
Hi,
Can someone please grant me permission to open a KIP? My id is piyushvijay.
Thanks
Piyush Vijay
Hi,
Can someone please help/guide me here? I really appreciate it.
Thanks
Piyush Vijay
On Thu, Apr 26, 2018 at 6:37 PM, Piyush Vijay
wrote:
> Ping :)
>
>
> Piyush Vijay
>
> On Wed, Apr 25, 2018 at 7:45 PM, Piyush Vijay
> wrote:
>
>>
>> I want to open
Ping :)
Piyush Vijay
On Wed, Apr 25, 2018 at 7:45 PM, Piyush Vijay
wrote:
>
> I want to open a JIRA and a KIP. Can someone please grant me the necessary
> permissions?
> My username is *piyushvijay*.
>
> Thank you
> Piyush Vijay
>
>
I want to open a JIRA and a KIP. Can someone please grant me the necessary
permissions?
My username is *piyushvijay*.
Thank you
Piyush Vijay
[
https://issues.apache.org/jira/browse/KAFKA-4185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15570070#comment-15570070
]
Piyush Vijay commented on KAFKA-4185:
-
comments [~ecomar], [~ijuma]?
> Abstr
[
https://issues.apache.org/jira/browse/KAFKA-4185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15530580#comment-15530580
]
Piyush Vijay commented on KAFKA-4185:
-
[~ecomar], even though I agree that proce
[
https://issues.apache.org/jira/browse/KAFKA-4185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15497494#comment-15497494
]
Piyush Vijay commented on KAFKA-4185:
-
[~junrao], [~gwenshap], [~ijuma] Any thou
Piyush Vijay created KAFKA-4185:
---
Summary: Abstract out password verifier in SaslServer as an
injectable dependency
Key: KAFKA-4185
URL: https://issues.apache.org/jira/browse/KAFKA-4185
Project: Kafka
27 matches
Mail list logo
