[jira] [Commented] (KAFKA-3587) LogCleaner fails due to incorrect offset map computation on a replica

2016-05-06 Thread Manas Alekar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15274534#comment-15274534 ] Manas Alekar commented on KAFKA-3587: - [~junrao] During cleaning the offset stored in

[jira] [Commented] (KAFKA-3587) LogCleaner fails due to incorrect offset map computation on a replica

2016-05-06 Thread Manas Alekar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15274513#comment-15274513 ] Manas Alekar commented on KAFKA-3587: - [~guozhang] Like your idea, I'll wait for us to

[jira] [Commented] (KAFKA-3587) LogCleaner fails due to incorrect offset map computation on a replica

2016-05-06 Thread Manas Alekar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15274500#comment-15274500 ] Manas Alekar commented on KAFKA-3587: - The issue with just building the map till it is

[jira] [Issue Comment Deleted] (KAFKA-3587) LogCleaner fails due to incorrect offset map computation on a replica

2016-05-06 Thread Manas Alekar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manas Alekar updated KAFKA-3587: Comment: was deleted (was: The issue with just building the map till it is full as proposed in pull

[jira] [Commented] (KAFKA-3587) LogCleaner fails due to incorrect offset map computation on a replica

2016-05-06 Thread Manas Alekar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15274483#comment-15274483 ] Manas Alekar commented on KAFKA-3587: - The issue with just building the map till it is

[jira] [Commented] (KAFKA-3587) LogCleaner fails due to incorrect offset map computation on a replica

2016-05-05 Thread Manas Alekar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15273626#comment-15273626 ] Manas Alekar commented on KAFKA-3587: - [~junrao] That will create the same pairs in c

[jira] [Commented] (KAFKA-3587) LogCleaner fails due to incorrect offset map computation on a replica

2016-05-05 Thread Manas Alekar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15273481#comment-15273481 ] Manas Alekar commented on KAFKA-3587: - 1. I believe this should happen when any scratc

[jira] [Commented] (KAFKA-3587) LogCleaner fails due to incorrect offset map computation on a replica

2016-05-05 Thread Manas Alekar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15273466#comment-15273466 ] Manas Alekar commented on KAFKA-3587: - [~ecomar] I used 1/2 because the worst case fo

[jira] [Commented] (KAFKA-3587) LogCleaner fails due to incorrect offset map computation on a replica

2016-05-05 Thread Manas Alekar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15273325#comment-15273325 ] Manas Alekar commented on KAFKA-3587: - It was easier to explain a fix in code than in

[jira] [Commented] (KAFKA-3587) LogCleaner fails due to incorrect offset map computation on a replica

2016-05-05 Thread Manas Alekar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15273293#comment-15273293 ] Manas Alekar commented on KAFKA-3587: - I have attached a patch which explains one feas

[jira] [Updated] (KAFKA-3587) LogCleaner fails due to incorrect offset map computation on a replica

2016-05-05 Thread Manas Alekar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manas Alekar updated KAFKA-3587: Attachment: 0001-POC-improving-deduping-segments.patch > LogCleaner fails due to incorrect offset ma