Re: [VOTE] KIP-446: Add changelog topic configuration to KTable suppress

2019-04-22 Thread Maarten Duijn
binding). >> > >> > Thanks. >> > >> > On Thu, Apr 18, 2019 at 10:48 AM John Roesler wrote: >> > >> >> Thanks, Maarten! >> >> >> >> +1 (non-binding) >> >> >> >> -John >> >> >

Re: [VOTE] KIP-446: Add changelog topic configuration to KTable suppress

2019-04-17 Thread Maarten Duijn
For those interested, a WIP PR is now available at: https://github.com/apache/kafka/pull/6593 Maarten

[VOTE] KIP-446: Add changelog topic configuration to KTable suppress

2019-04-17 Thread Maarten Duijn
Hello all, There has been informal agreement so I would like to call for a vote on KIP-446: Add changelog topic configuration to KTable suppress. This will allow users to configure internal topics created by the suppress operator via the streams DSL. KIP: https://cwiki.apache.org/confluence/d

Re: [DISCUSS] KIP-446: Add changelog topic configuration to KTable suppress

2019-04-04 Thread Maarten Duijn
Thank you for the explanation regarding the internals, I have edited the KIP accordingly and updated the Javadoc. About the possible data loss when altering changelog config, I think we can improve by doing (one of) the following. 1) Add a warning in the comments that clearly states what might h

[DISCUSS] KIP-446: Add changelog topic configuration to KTable suppress

2019-04-02 Thread Maarten Duijn
Kafka Streams currently does not allow configuring the internal changelog topic created by KTable.suppress. This KIP introduces a design for adding topic configurations to the suppress API. https://cwiki.apache.org/confluence/display/KAFKA/KIP-446%3A+Add+changelog+topic+configuration+to+KTable+sup

[DISCUSS] KIP-446: Add changelog topic configuration to KTable suppress

2019-04-02 Thread Maarten Duijn
Kafka Streams currently does not allow configuring the internal changelog topic created by KTable.suppress. This KIP introduces a design for adding topic configurations to the suppress API. https://cwiki.apache.org/confluence/display/KAFKA/KIP-446%3A+Add+changelog+topic+configuration+to+KTable+sup