[GitHub] kafka pull request #4226: MINOR: Arrays.toList replaced with Collections.sin...

2017-11-16 Thread KoenDG
GitHub user KoenDG opened a pull request: https://github.com/apache/kafka/pull/4226 MINOR: Arrays.toList replaced with Collections.singletonList() where possible. This is something I did after my working hours, I would ask people reviewing this do the same, don't take tim

[GitHub] kafka pull request #3891: [WIP input needed] MINOR: Further code cleanup inv...

2017-11-16 Thread KoenDG
Github user KoenDG closed the pull request at: https://github.com/apache/kafka/pull/3891 ---

[GitHub] kafka pull request #3904: [MINOR] Added equals() method to Stamped

2017-11-16 Thread KoenDG
Github user KoenDG closed the pull request at: https://github.com/apache/kafka/pull/3904 ---

[GitHub] kafka pull request #3919: [MINOR] Where possible, introduce EnumMap.

2017-09-20 Thread KoenDG
GitHub user KoenDG opened a pull request: https://github.com/apache/kafka/pull/3919 [MINOR] Where possible, introduce EnumMap. Very simple PR, introduce EnumMap in 2 places of the code. EnumMap: https://docs.oracle.com/javase/7/docs/api/java/util/EnumMap.html

[GitHub] kafka pull request #3904: [MINOR] Added equals() method to Stamped

2017-09-19 Thread KoenDG
GitHub user KoenDG opened a pull request: https://github.com/apache/kafka/pull/3904 [MINOR] Added equals() method to Stamped Please don't let analyzing this PR take away from actual working time. I did this in my spare time, it's not intended to take away from your work

[GitHub] kafka pull request #3891: [WIP] MINOR: Further code cleanup involving log st...

2017-09-18 Thread KoenDG
GitHub user KoenDG opened a pull request: https://github.com/apache/kafka/pull/3891 [WIP] MINOR: Further code cleanup involving log statements First of all, terribly sorry for not having included this in the previous PR, that one only focused on the streams folder, this one is on

[GitHub] kafka pull request #3886: Code cleanup, subject: log statements.

2017-09-18 Thread KoenDG
GitHub user KoenDG opened a pull request: https://github.com/apache/kafka/pull/3886 Code cleanup, subject: log statements. I'm doing this in my spare time, so don't let reviewing this PR take away actual work time. This is just me going over the code with the Intellij an