[jira] [Created] (KAFKA-19308) Improve OAuth unit testing based on code coverage analysis

2025-05-18 Thread Kirk True (Jira)
Kirk True created KAFKA-19308: - Summary: Improve OAuth unit testing based on code coverage analysis Key: KAFKA-19308 URL: https://issues.apache.org/jira/browse/KAFKA-19308 Project: Kafka Issue

[jira] [Created] (KAFKA-19307) Improve OAuthCompatibilityTool ergonomics

2025-05-18 Thread Kirk True (Jira)
Kirk True created KAFKA-19307: - Summary: Improve OAuthCompatibilityTool ergonomics Key: KAFKA-19307 URL: https://issues.apache.org/jira/browse/KAFKA-19307 Project: Kafka Issue Type: Improvement

[jira] [Created] (KAFKA-19297) Refactor AsyncKafkaConsumer's use of Java Streams APIs in critical sections

2025-05-16 Thread Kirk True (Jira)
Kirk True created KAFKA-19297: - Summary: Refactor AsyncKafkaConsumer's use of Java Streams APIs in critical sections Key: KAFKA-19297 URL: https://issues.apache.org/jira/browse/KAFKA-19297 Project:

[jira] [Created] (KAFKA-19296) Revise AsyncKafkaConsumer event wakeup approach

2025-05-16 Thread Kirk True (Jira)
Kirk True created KAFKA-19296: - Summary: Revise AsyncKafkaConsumer event wakeup approach Key: KAFKA-19296 URL: https://issues.apache.org/jira/browse/KAFKA-19296 Project: Kafka Issue Type

[jira] [Created] (KAFKA-19295) Remove AsyncKafkaConsumer event ID generation

2025-05-16 Thread Kirk True (Jira)
Kirk True created KAFKA-19295: - Summary: Remove AsyncKafkaConsumer event ID generation Key: KAFKA-19295 URL: https://issues.apache.org/jira/browse/KAFKA-19295 Project: Kafka Issue Type

[jira] [Resolved] (KAFKA-19206) ConsumerNetworkThread.cleanup() throws NullPointerException if initializeResources() previously failed

2025-05-15 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True resolved KAFKA-19206. --- Resolution: Fixed > ConsumerNetworkThread.cleanup() throws NullPointerException

Re: [DISCUSS] Apache Kafka 4.1.0 release

2025-05-07 Thread Kirk True
Hi Mickael, Can we add KIP-1139 (https://cwiki.apache.org/confluence/x/uIxEF) to the 4.1.0 "Planned KIP Content" list? It was approved yesterday. Thanks, Kirk On Wed, Mar 19, 2025, at 4:58 AM, Mickael Maison wrote: > Hi, > > I'd like to volunteer to be the release manager for the Apache Kafka

Re: [VOTE] KIP-1139: Add support for OAuth jwt-bearer grant type

2025-05-06 Thread Kirk True
anet > > > On Tue, May 6, 2025, 4:23 a.m. Manikumar wrote: > > > Thanks for the detailed KIP. > > +1 (binding) > > > > Thanks, > > > > On Tue, May 6, 2025 at 3:24 AM Jun Rao wrote: > > > > > Hi, Kirk, > > > > >

Re: [DISCUSS] KIP-1139: Add support for OAuth jwt-bearer grant type

2025-05-05 Thread Kirk True
t kind of error is returned in Java client in case the > configured JOSE algorithm isn't compatible with the private key? > > Thanks! > Emanuele > > On 2025/03/14 18:51:18 Kirk True wrote: > > Hi all, > > > > I would like to start a discussion for KIP-1139: A

[VOTE] KIP-1139: Add support for OAuth jwt-bearer grant type

2025-05-02 Thread Kirk True
Hi, Thanks to all who provided feedback on KIP-1139: Add support for OAuth jwt-bearer grant type: https://cwiki.apache.org/confluence/x/uIxEF I would like to call for a vote for inclusion in the Apache Kafka 4.1.0 release. If you have comments or questions please use the existing discussion th

Re: [DISCUSS] KIP-1159: Large message reference based Serializer

2025-05-01 Thread Kirk True
Hi Omnia, A very interesting KIP! Thanks for the write up and discussion thus far! A few questions: KT1: In PayloadReferenceValue, Is "payloadStoreClass" intended to be a fully-qualified Java class name, or something else? I'm considering the case where a Producer and/or Consumer are using a n

[jira] [Created] (KAFKA-19214) Clean up use of Optionals in RequestManagers.entries()

2025-04-29 Thread Kirk True (Jira)
Kirk True created KAFKA-19214: - Summary: Clean up use of Optionals in RequestManagers.entries() Key: KAFKA-19214 URL: https://issues.apache.org/jira/browse/KAFKA-19214 Project: Kafka Issue Type

Re: [DISCUSS] KIP-1139: Add support for OAuth jwt-bearer grant type

2025-04-29 Thread Kirk True
all a vote soon, so if you have additional feedback, please let me know. Thank you for your feedback and help! Kirk On Fri, Apr 25, 2025, at 12:26 PM, Kirk True wrote: > Hi Lianet, > > On Fri, Apr 25, 2025, at 10:03 AM, Lianet M. wrote: > > Hey Kirk, thanks for the updates. Ack on

Re: [VOTE] KIP-1140: Avoid to return null value in Map from public api of consumer

2025-04-26 Thread Kirk True
+1 (non-binding) Thanks! On Sat, Apr 26, 2025, at 3:14 AM, PoAn Yang wrote: > +1 (non-binding) > > Thanks, > PoAn > > > On Apr 26, 2025, at 4:10 PM, Chia-Ping Tsai wrote: > > > > +1 (binding) > > > > 黃竣陽 於 2025年4月26日 週六 下午1:37寫道: > > > >> Hello all > >> > >> I would like to call a vote on

[jira] [Created] (KAFKA-19206) AsyncKafkaConsumer hangs when NetworkClient fails authentication

2025-04-25 Thread Kirk True (Jira)
Kirk True created KAFKA-19206: - Summary: AsyncKafkaConsumer hangs when NetworkClient fails authentication Key: KAFKA-19206 URL: https://issues.apache.org/jira/browse/KAFKA-19206 Project: Kafka

Re: [DISCUSS] KIP-1139: Add support for OAuth jwt-bearer grant type

2025-04-25 Thread Kirk True
ns for that vary across the matrix of languages and OSes they support. Any suggestions as how to handle that in the KIP? Thanks, Kirk > Thanks! > > On Thu, Apr 24, 2025 at 7:46 PM Kirk True wrote: > > > Hi Manikumar, > > > > Update on the use of Keycloak for i

Re: [VOTE] KIP-1152: Add transactional ID pattern filter to ListTransactions API

2025-04-24 Thread Kirk True
+1 (non-binding) Thanks! On Thu, Apr 24, 2025, at 10:11 AM, Jun Rao wrote: > Hi, Calvin, > > Thanks for the KIP. +1 > > Jun > > On Thu, Apr 24, 2025 at 8:30 AM Calvin Liu > wrote: > > > Hi, > > I would like to start a vote on KIP-1152, thank you! > > KIP: > > > > https://cwiki.apache.org/con

Re: [DISCUSS] KIP-1139: Add support for OAuth jwt-bearer grant type

2025-04-24 Thread Kirk True
, Kirk On Tue, Apr 22, 2025, at 11:31 AM, Kirk True wrote: > Also, Keycloak is MIT licensed. Is that OK to include in Kafka? > > On Tue, Apr 22, 2025, at 10:49 AM, Kirk True wrote: > > Hi Manikumar, > > > > You mentioned using Keycloak for integration tests. Everything

Re: [DISCUSS] KIP-1140: Avoid to return null value in Map from public api of consumer

2025-04-22 Thread Kirk True
w config right away > >>>> - remove the config and old behavior in 5.0 > >>>> > >>>> > >>>> I admit, that adding a new config, and deprecating it, plus telling > >>>> users "please use this new/deprecated config", is a li

Re: [DISCUSS] KIP-1139: Add support for OAuth jwt-bearer grant type

2025-04-22 Thread Kirk True
Also, Keycloak is MIT licensed. Is that OK to include in Kafka? On Tue, Apr 22, 2025, at 10:49 AM, Kirk True wrote: > Hi Manikumar, > > You mentioned using Keycloak for integration tests. Everything I'm seeing > online suggests that this is best done via Testcontainers. I don&

Re: [DISCUSS] KIP-1139: Add support for OAuth jwt-bearer grant type

2025-04-22 Thread Kirk True
> > Jun > > > > On Tue, Apr 15, 2025 at 1:04 PM Kirk True wrote: > > > Hi Jun! > > > > I really appreciate your feedback. > > > > Responses below... > > > > On Fri, Apr 11, 2025, at 1:47 PM, Jun Rao wrote: > > > Hi, Ki

Re: [DISCUSS] KIP-1139: Add support for OAuth jwt-bearer grant type

2025-04-22 Thread Kirk True
Keycloak-based integration tests to ensure > compatibility with standard OAuth providers. > > 5. We currently lack user-facing documentation for OAuth. As part of the > implementation, it would be helpful to include: > - Example client configurations > - A full end-to-end usage gu

Re: [DISCUSS] Apache Kafka 4.1.0 release

2025-04-18 Thread Kirk True
+1 to Matthias' comment about fixed dates. Given that the release schedule has a fixed cadence, there shouldn't need to be much discussion around dates for each release. Kirk On Thu, Apr 17, 2025, at 2:54 PM, Matthias J. Sax wrote: > Thanks! > > I am wondering if we should set more or less "f

Re: [DISCUSS] KIP-1140: Avoid to return null value in Map from public api of consumer

2025-04-17 Thread Kirk True
Hi Colin, If so, is 5.0 the earliest this 'allow.nulls.in.consumer' configuration can be changed and marked as deprecated? And if that holds, is 6.0 the earliest it can be removed? Thanks, Kirk On Mon, Apr 14, 2025, at 1:10 PM, Colin McCabe wrote: > I would suggest adding a configuration key w

Re: [DISCUSS] KIP-1140: Avoid to return null value in Map from public api of consumer

2025-04-17 Thread Kirk True
Hi Chia-Ping, An "enable unreleased behavior" flag is an interesting idea; basically a feature flag. The main benefit (coarsely grained) is also its biggest weakness. I'm not really sure the target audience that would enable it. Thanks, Kirk On Mon, Apr 14, 2025, at 9:39 PM, Chia-Ping Tsai wro

Re: [DISCUSS] KIP-1139: Add support for OAuth jwt-bearer grant type

2025-04-15 Thread Kirk True
uthbearer.scope too? Good catch. "scope" in the sasl.jaas.config configuration is deprecated in favor of the sasl.oauthbearer.scope configuration. I'll update the KIP. Thanks, Kirk > Thanks, > > Jun > > On Fri, Mar 14, 2025 at 11:52 AM Kirk True wrote: > > &

Re: [DISCUSS] KIP-1139: Add support for OAuth jwt-bearer grant type

2025-04-15 Thread Kirk True
ng Keycloak-based integration tests to ensure > > compatibility with standard OAuth providers. > > > > 5. We currently lack user-facing documentation for OAuth. As part of the > > implementation, it would be helpful to include: > > - Example client confi

Re: [DISCUSS] KIP-1139: Add support for OAuth jwt-bearer grant type

2025-04-15 Thread Kirk True
include: > - Example client configurations > - A full end-to-end usage guide for the JWT bearer grant flow in Kafka Yes, this is a big gap. I've added https://issues.apache.org/jira/browse/KAFKA-19152 to track that. Thanks, Kirk > > Thanks, > Manikumar > > On

[jira] [Created] (KAFKA-19153) Add OAuth integration tests using Keycloak

2025-04-15 Thread Kirk True (Jira)
Kirk True created KAFKA-19153: - Summary: Add OAuth integration tests using Keycloak Key: KAFKA-19153 URL: https://issues.apache.org/jira/browse/KAFKA-19153 Project: Kafka Issue Type: Improvement

[jira] [Created] (KAFKA-19152) Add top-level documentation for OAuth flows

2025-04-15 Thread Kirk True (Jira)
Kirk True created KAFKA-19152: - Summary: Add top-level documentation for OAuth flows Key: KAFKA-19152 URL: https://issues.apache.org/jira/browse/KAFKA-19152 Project: Kafka Issue Type

Re: [ANNOUNCE] New committer: Apoorv Mittal

2025-04-12 Thread Kirk True
Congratulations Apoorv. Justly deserved! On Sat, Apr 12, 2025, at 12:22 AM, Kamal Chandraprakash wrote: > Congratulations, Apoorv! > > On Sat, Apr 12, 2025 at 8:23 AM Kuan Po Tseng wrote: > > > Congrats Apoorv! > > > > On Sat, Apr 12, 2025 at 9:50 AM Guozhang Wang > > wrote: > > > > > Congratu

Re: [ANNOUNCE] New committer: TengYao Chi

2025-04-12 Thread Kirk True
Congratulations TengYao! On Sat, Apr 12, 2025, at 12:21 AM, Kamal Chandraprakash wrote: > Congrats, TengYao! Well deserved!! > > On Sat, Apr 12, 2025 at 7:19 AM Guozhang Wang > wrote: > > > Congratulations TengYao! > > > > On Fri, Apr 11, 2025 at 4:36 PM Christo Lolov > > wrote: > > > > > > Co

Re: [DISCUSS] KIP-1152: Add transactional ID prefix filter to ListTransactions API

2025-04-08 Thread Kirk True
Hi Calvin, Thanks for the KIP! This is not an area of understanding (yet!) but had a few questions: KT01: I agree with David's DJ03. Would transactionalIdPattern or transactionalIdFilter still convey the idea? KT02: Can we change the command line option -transactionalIdPatternFilter to someth

Re: [VOTE] KIP-1133: AK Documentation and Website in Markdown

2025-04-05 Thread Kirk True
+1 (non-binding) On Thu, Apr 3, 2025, at 6:43 AM, TaiJu Wu wrote: > Thanks for this KIP, > > +1(non-binding) > > Best, > TaiJuWu > > On Thu, Apr 3, 2025 at 9:42 PM Kuan Po Tseng wrote: > > > Hi Harish, > > > > Thank you for improving the documentation! > > > > +1 (non-binding) > > > > Best, >

Re: [VOTE] KIP-1143: Deprecated Optional and return String from public Endpoint#listenerName

2025-04-03 Thread Kirk True
+1 (non-binding) Thanks! On Thu, Apr 3, 2025, at 9:58 AM, Andrew Schofield wrote: > +1 (binding) > > Thanks, > Andrew > > > From: Chia-Ping Tsai > > Sent: 03 April 2025 15:46 > > To: dev@kafka.apache.org > > Subject: Re: [VOTE] KIP-1143: Deprecated Opti

Re: [DISCUSS] Git commits and metadata

2025-03-26 Thread Kirk True
Hi David, In general, I'm in favor of adding information where reasonably possible. How are these header values populated by the merging committer? Magic or manual? I agree with others that adding so many additional "*-by" headers could be confusing, leading to inconsistent usage. Is the equiva

Re: [DISCUSS] KIP-1136: Make ConsumerGroupMetadata an interface

2025-03-24 Thread Kirk True
Hi Paweł, We can't change the existing (public) constructors to private in 4.1 as that would break users. Yes, we can argue that users shouldn't be instantiating the ConsumerGroupMetadata in the first place, but as of 4.0 those constructors are part of the published API. For 4.1, at most we co

Re: [DISCUSS] KIP-1143: Deprecated Optional and return String from public Endpoint#listenerName

2025-03-24 Thread Kirk True
Hi PoAn, Thanks for the KIP. I have two uneducated questions based regarding expected usage by the client layer: KT1. Can you elaborate on the statement from the Motivation section, "However, we don't fully utilized this approach?" Is "we" the Kafka project's internals, or the community? KT

Re: [DISCUSS] KIP-1140: Avoid to return null value in Map from public api of consumer

2025-03-24 Thread Kirk True
Hi Jiunn-Yang, Regardless of what form the KIP takes and when it's implemented, near term it would be good to see a PR with some of these null edge cases clearly spelled out in the JavaDoc. Then, once the KIP is accepted, those comments could be updated with the intended future changes. Thanks

Re: [DISCUSS] KIP-1140: Avoid to return null value in Map from public api of consumer

2025-03-19 Thread Kirk True
Hi Jiunn-Yang, Response inline... On Wed, Mar 19, 2025, at 5:28 AM, 黃竣陽 wrote: > Hello Kirk True, > > Thanks for your comments. > > KT1: In fact, while reviewing projects on GitHub, I haven't found any that > would be affected by this change. Most developers simply ret

Re: [DISCUSS] KIP-1140: Avoid to return null value in Map from public api of consumer

2025-03-17 Thread Kirk True
Hi Jiunn-Yang, Thanks for the KIP! I agree that this oddity should be fixed. It's a bit of a funny case, KIP-wise, in that the API signature itself isn't changing, but the documentation and behavior are. Some questions: KT1: The KIP specifically calls out "The scenarios that will be impacted"

[DISCUSS] KIP-1139: Add support for OAuth jwt-bearer grant type

2025-03-14 Thread Kirk True
Hi all, I would like to start a discussion for KIP-1139: Add support for OAuth jwt-bearer grant type: https://cwiki.apache.org/confluence/x/uIxEF The proposal is twofold: * Add support for the OAuth 2.0 JWT Bearer grant type to avoid use of plaintext client secrets * Promote internal APIs for

[jira] [Created] (KAFKA-18951) Validate client code and documentation in examples/ directory

2025-03-09 Thread Kirk True (Jira)
Kirk True created KAFKA-18951: - Summary: Validate client code and documentation in examples/ directory Key: KAFKA-18951 URL: https://issues.apache.org/jira/browse/KAFKA-18951 Project: Kafka

Re: [DISCUSS] KIP-1136: Make ConsumerGroupMetadata an interface

2025-03-05 Thread Kirk True
future different implementations as it is simple data > > struct. > > KT3. It will be place in producer/internals package and default java scope > > for constructor and whole class. > > > > @Matthias J. Sax having those KT1 and KT2 in mind, > > should we move forw

Re: [VOTE] 4.0.0 RC0

2025-02-27 Thread Kirk True
Hi David, I focused on testing the clients using Java 11: My steps: 1. Start the broker via the native Docker image (apache/kafka-native:4.0.0-rc0) 2. Wrote a simple client to write and read messages, using kafka-clients 4.0.0 from https://repository.apache.org/content/groups/staging 3. Ran my

Re: Metadata requests for subset of partitions

2025-02-27 Thread Kirk True
Hi Michał, On Thu, Feb 27, 2025, at 3:44 AM, Michał Łowicki wrote: > Hi there! > > Is there any reason why Metadata requests > do not > support fetching metadata for subsets of the partitions? If a certain > client is interested only

Re: Support for other OAuth2 grant types in Kafka

2025-02-27 Thread Kirk True
o a > custom implementation as mentioned by you) That is correct. If you do end up writing another implementation, it would be great if it could be contributed back to the community. I'd love to see more additions in this area. Thanks, Kirk > On Wed, Feb 26, 2025 at 11:46 PM Kirk True

Re: [DISCUSS] KIP-1136: Make ConsumerGroupMetadata an interface

2025-02-26 Thread Kirk True
Hi Paweł, Thanks for the KIP! My questions: KT1. What will prevent developers from implementing their own ConsumerGroupMetadata and passing that to sendOffsetsToTransaction()? I assume the code will check the incoming object is of type DefaultConsumerGroupMetadata? KT2. To me, the use of the

Re: kafka producer exception due to TimeoutException:

2025-02-26 Thread Kirk True
Hi Giri, The first question I would ask is: what happens when you run the producer with the default configuration? Producer timeouts are usually caused by client misconfiguration, network issues, broker load/topology changes, or a combination of those. Try to remove as many configuration overr

Re: Support for other OAuth2 grant types in Kafka

2025-02-26 Thread Kirk True
Hi Subra, I'm one of the authors of the OAuth support in Kafka. Answers to your questions are below... On Tue, Feb 25, 2025, at 3:05 AM, Subra I wrote: > Hello All, > > I see that Kafka by itself supports client credentials as grant type for > OAuth2. I see this mentioned in one of the kafka KI

[jira] [Created] (KAFKA-18847) Refactor OAuth layer to improve reusability

2025-02-21 Thread Kirk True (Jira)
Kirk True created KAFKA-18847: - Summary: Refactor OAuth layer to improve reusability Key: KAFKA-18847 URL: https://issues.apache.org/jira/browse/KAFKA-18847 Project: Kafka Issue Type

[jira] [Created] (KAFKA-18574) Quarantined test list should be sorted

2025-01-16 Thread Kirk True (Jira)
Kirk True created KAFKA-18574: - Summary: Quarantined test list should be sorted Key: KAFKA-18574 URL: https://issues.apache.org/jira/browse/KAFKA-18574 Project: Kafka Issue Type: Improvement

[jira] [Created] (KAFKA-18573) Improve OAuth client logic to support more use cases

2025-01-16 Thread Kirk True (Jira)
Kirk True created KAFKA-18573: - Summary: Improve OAuth client logic to support more use cases Key: KAFKA-18573 URL: https://issues.apache.org/jira/browse/KAFKA-18573 Project: Kafka Issue Type

[jira] [Created] (KAFKA-18571) Investigate the use of metadata caching to improve fetch request generation performance

2025-01-16 Thread Kirk True (Jira)
Kirk True created KAFKA-18571: - Summary: Investigate the use of metadata caching to improve fetch request generation performance Key: KAFKA-18571 URL: https://issues.apache.org/jira/browse/KAFKA-18571

Re: [DISCUSS] KIP-1101: Trigger rebalance on rack topology changes

2025-01-14 Thread Kirk True
Hi all, Hopefully a quick question... KT01. Will clients calculate the topic hash on the client? Based on the current state of the KIP and PR, I would have thought "no", but I ask based on the discussion around the possible use of Guava on client. Thanks, Kirk On Mon, Jan 6, 2025, at 9:11 AM

[DISCUSS] Does changing help messages for tools require a KIP?

2025-01-08 Thread Kirk True
Hi all, Do we consider the CLI help/usage message as part of the publicly documented API? Background: There's a bug in the help/usage message in some of the Kafka CLI tools. For some of the tools that accept a timestamp, the help message instructs the user to provide a date in a '-MM-DDTHH

Re: [DISCUSS]KIP-1107: Adding record-level acks for producers

2025-01-06 Thread Kirk True
Hi TaiJu! I will echo the concerns about the likelihood of gotchas arising in an effort to work around the existing API and protocol design. If the central concern is the performance impact and/or resource overhead of multiple client instances, I'd rather attack that in a more direct manner. T

[jira] [Created] (KAFKA-18400) Don't use YYYY when formatting dates in Java client

2025-01-03 Thread Kirk True (Jira)
Kirk True created KAFKA-18400: - Summary: Don't use when formatting dates in Java client Key: KAFKA-18400 URL: https://issues.apache.org/jira/browse/KAFKA-18400 Project: Kafka Issue

[jira] [Resolved] (KAFKA-18176) Consumer system tests failure due to unsupported protocol configs

2024-12-23 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True resolved KAFKA-18176. --- Resolution: Won't Fix > Consumer system tests failure due to unsupported protocol

Re: [VOTE] KIP-1118: Add Deadlock Protection on Producer Network Thread

2024-12-13 Thread Kirk True
+1 (non-binding) On Sun, Dec 8, 2024, at 6:32 PM, TengYao Chi wrote: > Hi everyone, > > Based on our discussion > regarding > KIP-1118 >

[jira] [Resolved] (KAFKA-15284) Implement GroupProtocolResolver to dynamically determine consumer group protocol

2024-12-09 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True resolved KAFKA-15284. --- Resolution: Won't Fix > Implement GroupProtocolResolver to dynamically determine consum

[jira] [Created] (KAFKA-18189) CoordinatorRequestManager log of time disconnected from coordinator is incorrect

2024-12-09 Thread Kirk True (Jira)
Kirk True created KAFKA-18189: - Summary: CoordinatorRequestManager log of time disconnected from coordinator is incorrect Key: KAFKA-18189 URL: https://issues.apache.org/jira/browse/KAFKA-18189 Project

Re: [DISCUSS] KIP-1118: Add Deadlock Protection on Producer Network Thread

2024-12-04 Thread Kirk True
rely sure if we should add > > constraints simply because something is considered an anti-pattern or not a > > best practice. That said, I’m open to the idea and would like to hear > > others’ opinions as well. > > > > Best, > > TengYao > > > > > >

Re: [DISCUSS] KIP-1118: Add Deadlock Protection on Producer Network Thread

2024-12-03 Thread Kirk True
Hi TengYao, Thanks for the KIP. I want to ask Andrew's question in an inverted perspective: Which—if any—Producer APIs should users be allowed to invoke from within a Callback? I agree about transactions being off limits. Just... no. But should users be able to call either send() variant from

Re: [ANNOUNCE] New committer: Andrew Schofield

2024-12-02 Thread Kirk True
Congratulations Andrew Well-deserved. On Mon, Dec 2, 2024, at 6:13 AM, David Arthur wrote: > The Project Management Committee (PMC) for Apache Kafka is pleased to > announce Andrew Schofield as a new Kafka committer. > > Andrew has been active in the project since May of 2023 and has contribu

[jira] [Created] (KAFKA-18087) Revert unnecessary integration testing of Consumers using both group protocols

2024-11-25 Thread Kirk True (Jira)
Kirk True created KAFKA-18087: - Summary: Revert unnecessary integration testing of Consumers using both group protocols Key: KAFKA-18087 URL: https://issues.apache.org/jira/browse/KAFKA-18087 Project

[jira] [Resolved] (KAFKA-16176) Flaky test: testSendToPartitionWithFollowerShutdownShouldNotTimeout – kafka.api.PlaintextProducerSendTest

2024-11-19 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True resolved KAFKA-16176. --- Resolution: Fixed > Flaky test: testSendToPartitionWithFollowerShutdownShouldNotTime

[jira] [Created] (KAFKA-18040) PlaintextProducerSendTest.testSendToPartitionWithFollowerShutdownShouldNotTimeout fails with CONSUMER group protocol

2024-11-19 Thread Kirk True (Jira)
Kirk True created KAFKA-18040: - Summary: PlaintextProducerSendTest.testSendToPartitionWithFollowerShutdownShouldNotTimeout fails with CONSUMER group protocol Key: KAFKA-18040 URL: https://issues.apache.org/jira

[jira] [Resolved] (KAFKA-16460) New consumer times out consuming records in multiple consumer_test.py system tests

2024-11-19 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True resolved KAFKA-16460. --- Reviewer: Lianet Magrans Resolution: Fixed > New consumer times out consuming records

Re: [DISCUSS] KIP-1030: Change constraints and default values for various configurations

2024-11-18 Thread Kirk True
Hi Divij, Thanks for the KIP! My only question: KT1. In the case where we change the constraints so that a user's previously valid configuration is now invalid, do we do anything other than throw a ConfigException? Thanks, Kirk On Mon, Nov 18, 2024, at 2:13 AM, Divij Vaidya wrote: > Hey folk

[jira] [Resolved] (KAFKA-17519) Define and validate correctness of Consumer.close() and its timeout when thread is interrupted

2024-11-14 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True resolved KAFKA-17519. --- Assignee: Kirk True (was: PoAn Yang) Resolution: Fixed > Define and validate correctness

[jira] [Reopened] (KAFKA-17962) test_pause_and_resume_sink fails with "Failed to consume messages after resuming sink connector" with CONSUMER group protocol

2024-11-13 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reopened KAFKA-17962: --- > test_pause_and_resume_sink fails with "Failed to consume messages after > resuming sin

[jira] [Reopened] (KAFKA-16949) System test test_dynamic_logging in connect_distributed_test is failing

2024-11-12 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reopened KAFKA-16949: --- > System test test_dynamic_logging in connect_distributed_test is fail

[jira] [Resolved] (KAFKA-17681) Fix unstable consumer_test.py#test_fencing_static_consumer

2024-11-12 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True resolved KAFKA-17681. --- Resolution: Cannot Reproduce > Fix unstable consumer_test.py#test_fencing_static_consu

[jira] [Resolved] (KAFKA-17962) test_pause_and_resume_sink fails with "Failed to consume messages after resuming sink connector" with CONSUMER group protocol

2024-11-12 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True resolved KAFKA-17962. --- Resolution: Cannot Reproduce > test_pause_and_resume_sink fails with "Failed to consume

[jira] [Created] (KAFKA-18002) Upgrade connect_distributed_test.py's test_exactly_once_source to support different group.protocol values

2024-11-12 Thread Kirk True (Jira)
Kirk True created KAFKA-18002: - Summary: Upgrade connect_distributed_test.py's test_exactly_once_source to support different group.protocol values Key: KAFKA-18002 URL: https://issues.apache.org/jira/browse/

[jira] [Created] (KAFKA-17964) TransactionsTest.testSendOffsetsWithGroupId fails with CONSUMER group protocol

2024-11-07 Thread Kirk True (Jira)
Kirk True created KAFKA-17964: - Summary: TransactionsTest.testSendOffsetsWithGroupId fails with CONSUMER group protocol Key: KAFKA-17964 URL: https://issues.apache.org/jira/browse/KAFKA-17964 Project

[jira] [Created] (KAFKA-17962) test_pause_and_resume_sink fails with "Failed to consume messages after resuming sink connector" with CONSUMER group protocol

2024-11-07 Thread Kirk True (Jira)
Kirk True created KAFKA-17962: - Summary: test_pause_and_resume_sink fails with "Failed to consume messages after resuming sink connector" with CONSUMER group protocol Key: KAFKA-17962 URL: https://issues.

[jira] [Created] (KAFKA-17961) TransactionsBounceTest.testWithGroupId fails with CONSUMER group protocol

2024-11-07 Thread Kirk True (Jira)
Kirk True created KAFKA-17961: - Summary: TransactionsBounceTest.testWithGroupId fails with CONSUMER group protocol Key: KAFKA-17961 URL: https://issues.apache.org/jira/browse/KAFKA-17961 Project: Kafka

[jira] [Created] (KAFKA-17960) PlaintextAdminIntegrationTest.testConsumerGroups fails when using AsyncKafkaConsumer

2024-11-07 Thread Kirk True (Jira)
Kirk True created KAFKA-17960: - Summary: PlaintextAdminIntegrationTest.testConsumerGroups fails when using AsyncKafkaConsumer Key: KAFKA-17960 URL: https://issues.apache.org/jira/browse/KAFKA-17960

[jira] [Created] (KAFKA-17947) Update currentLag(), pause(), and resume() to perform logic in background thread

2024-11-05 Thread Kirk True (Jira)
Kirk True created KAFKA-17947: - Summary: Update currentLag(), pause(), and resume() to perform logic in background thread Key: KAFKA-17947 URL: https://issues.apache.org/jira/browse/KAFKA-17947 Project

[jira] [Created] (KAFKA-17925) Convert Kafka Client integration tests to use KRaft

2024-11-02 Thread Kirk True (Jira)
Kirk True created KAFKA-17925: - Summary: Convert Kafka Client integration tests to use KRaft Key: KAFKA-17925 URL: https://issues.apache.org/jira/browse/KAFKA-17925 Project: Kafka Issue Type

[jira] [Reopened] (KAFKA-15284) Implement ConsumerGroupProtocolVersionResolver to determine consumer group protocol

2024-10-22 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reopened KAFKA-15284: --- Assignee: Kirk True > Implement ConsumerGroupProtocolVersionResolver to determine consumer gr

[jira] [Created] (KAFKA-17823) Refactor GroupRebalanceConfig to remove unused configuration

2024-10-17 Thread Kirk True (Jira)
Kirk True created KAFKA-17823: - Summary: Refactor GroupRebalanceConfig to remove unused configuration Key: KAFKA-17823 URL: https://issues.apache.org/jira/browse/KAFKA-17823 Project: Kafka

[jira] [Reopened] (KAFKA-16444) Run KIP-848 unit tests under code coverage

2024-10-16 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reopened KAFKA-16444: --- > Run KIP-848 unit tests under code cover

[jira] [Resolved] (KAFKA-16444) Run KIP-848 unit tests under code coverage

2024-10-07 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True resolved KAFKA-16444. --- Resolution: Won't Do > Run KIP-848 unit tests under code

Re: [VOTE] KIP-1092: Extend Consumer#close with an option to leave the group or not

2024-10-07 Thread Kirk True
Hi TengYao, +1 (non-binding) Thanks for all the work so far on this. Kirk On Mon, Oct 7, 2024, at 4:09 AM, TengYao Chi wrote: > Hi Andrew, > > Thanks for reviewing and participating in the vote. > I have corrected the issue as you pointed out. > > Sincerely, > TengYao > > Andrew Schofield 於

[jira] [Resolved] (KAFKA-16272) Update connect_distributed_test.py to support KIP-848’s group protocol config

2024-10-06 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True resolved KAFKA-16272. --- Resolution: Fixed > Update connect_distributed_test.py to support KIP-848’s group protocol con

Re: [VOTE] KIP-1094 Add a new constructor method with nextOffsets to ConsumerRecords

2024-10-03 Thread Kirk True
+1 (non-binding) On Wed, Oct 2, 2024, at 12:41 PM, Alieh Saeedi wrote: > Hi all > > I would like to call a vote for KIP-1094. Please take a moment to review > the proposal and submit your vote. > > KIP: > https://cwiki.apache.org/confluence/display/KAFKA/KIP-1094%3A+Add+a+new+constructor+method+

[jira] [Created] (KAFKA-17686) PlaintextAdminIntegrationTest’s testOffsetsForTimesAfterDeleteRecords fails with NPE with new consumer

2024-10-02 Thread Kirk True (Jira)
Kirk True created KAFKA-17686: - Summary: PlaintextAdminIntegrationTest’s testOffsetsForTimesAfterDeleteRecords fails with NPE with new consumer Key: KAFKA-17686 URL: https://issues.apache.org/jira/browse/KAFKA-17686

Re: [DISCUSS] KIP-1094 Add a new constructor method with nextOffsets to ConsumerRecords

2024-09-30 Thread Kirk True
Hi Alieh, Thanks for the KIP! Questions: KT1: In the second paragraph of the Motivation section, it mentions that in some cases the consumer does not return the correct next offset. Can you add a link to the bug here? I'm curious if that still happens with the "new" consumer. KT2: There's a c

Re: [DISCUSS] KIP-1092: Extend Consumer#close with an option to leave the group or not

2024-09-30 Thread Kirk True
irk On Mon, Sep 30, 2024, at 1:44 PM, Kirk True wrote: > Hi all, > > On Sun, Sep 29, 2024, at 12:08 PM, Chia-Ping Tsai wrote: > > > From an API POV, I think the new `CloseOptions` class should not have > > any "getters" and thus, it's irrelevant how we represe

Re: [DISCUSS] KIP-1092: Extend Consumer#close with an option to leave the group or not

2024-09-30 Thread Kirk True
Hi all, On Sun, Sep 29, 2024, at 12:08 PM, Chia-Ping Tsai wrote: > > From an API POV, I think the new `CloseOptions` class should not have > any "getters" and thus, it's irrelevant how we represent the different > cases in code internally (even if I believe using `Optional` might be a > good way t

Re: [DISCUSS] KIP-1092: Extend Consumer#close with an option to leave the group or not

2024-09-26 Thread Kirk True
antages: >>>> >>>> 1. It addresses the needs of Kafka Streams (if they start to use new >>>> consumer) >>>> 2. It simplifies the new coordinator, protocol, and consumer, as >> they no >>>> longer need to ha

Re: So long, Jenkins 👋

2024-09-25 Thread Kirk True
This is amazing work David! You leveled up every contributor and committer on the project. Thanks > On Sep 25, 2024, at 6:27 PM, Chris Egerton wrote: > > David, you're a legend. Thanks for spearheading this effort! > > On Wed, Sep 25, 2024, 20:51 David Arthur wrote: > >> Today, we disa

Re: [DISCUSS] KIP-1092: Extend Consumer#close with an option to leave the group or not

2024-09-23 Thread Kirk True
Hi TengYao, Thanks for writing up this KIP :) Questions: KT1: Why would a non-Kafka Streams application want to set leaveGroup=false? Because Kafka Streams manages the group membership assignment under the covers, it can re-assign partitions to a new Consumer when the old one closes. But in a

Re: [VOTE] KIP-1079: Deprecate `delete-config` of TopicCommand

2024-09-16 Thread Kirk True
Hi TengYao, +1 (non-binding). Using KAFKA-17087 to track the actual removal in 5.0 is going to help this not fall through the cracks. One minor point is that the description for the Jira states that "we should deprecate it in 3.9 and then remove it from 4.0” which should be "we should deprecat

Re: [VOTE] KIP-1082: Require Client-Generated IDs over the ConsumerGroupHeartbeat RPC

2024-09-16 Thread Kirk True
Hi TengYao, +1 (non-binding) Thanks for all the hard work with the tricky edge cases :) Kirk > On Sep 16, 2024, at 6:47 AM, TengYao Chi wrote: > > Hi everyone, > > Based on our discussion > > regarding KIP-1082

[jira] [Created] (KAFKA-17536) Ensure clear error message when "new" consumer used with incompatible cluster

2024-09-12 Thread Kirk True (Jira)
Kirk True created KAFKA-17536: - Summary: Ensure clear error message when "new" consumer used with incompatible cluster Key: KAFKA-17536 URL: https://issues.apache.org/jira/browse/KAFKA-17536

[jira] [Created] (KAFKA-17519) Review intended behavior of Consumer.close() and its timeout on interrupt

2024-09-10 Thread Kirk True (Jira)
Kirk True created KAFKA-17519: - Summary: Review intended behavior of Consumer.close() and its timeout on interrupt Key: KAFKA-17519 URL: https://issues.apache.org/jira/browse/KAFKA-17519 Project: Kafka

  1   2   3   4   >