Re: [DISCUSS] KIP-247: Add public test utils for Kafka Streams

2018-01-16 Thread Jeff Klukas
>From what I can tell, global state stores are managed separately from other state stores and are accessed via different methods. Do the proposed methods on TopologyTestDriver (such as getStateStore) cover global stores? If not, can we add an interface for accessing and testing global stores in th

Re: [VOTE] KIP-215: Add topic regex support for Connect sinks

2017-11-15 Thread Jeff Klukas
wrote: > > > +1! The S3 or hdfs connector will now be super powerful ! > > > > On 4 Nov. 2017 11:27 am, "Konstantine Karantasis" < > > konstant...@confluent.io> > > wrote: > > > > > Nice addition! > > > > > > +1 (

Re: [VOTE] KIP-215: Add topic regex support for Connect sinks

2017-11-03 Thread Jeff Klukas
to weigh in. > > Again thanks for the KIP and we can move any final discussion over to the > PR! > > -Ewen > > On Fri, Nov 3, 2017 at 4:43 PM, Jeff Klukas wrote: > > > Looks like we've achieved lazy majority, so I'll move the KIP to > approved. > > &

Re: [VOTE] KIP-215: Add topic regex support for Connect sinks

2017-11-03 Thread Jeff Klukas
; > > > +1 (non-binding) > > > > > > > > Thanks for pushing this through. Great work! > > > > > > > > Randall Hauch > > > > > > > > On Wed, Nov 1, 2017 at 9:40 AM, Jeff Klukas > > wrote: > > > > > > > > &

[VOTE] KIP-215: Add topic regex support for Connect sinks

2017-11-01 Thread Jeff Klukas
I haven't heard any additional concerns over the proposal, so I'd like to get the voting process started for: https://cwiki.apache.org/confluence/display/KAFKA/KIP-215%3A+Add+topic+regex+support+for+Connect+sinks It adds a topics.regex option for Kafka Connect sinks as an alternative to the exist

Re: [DISCUSS] KIP-215: Add topic regex support for Connect sinks

2017-10-31 Thread Jeff Klukas
bout which to use since the error message is clear anyway and > will just end up in logs / the REST API for the user to sort out. > > -Ewen > > On Fri, Oct 27, 2017 at 6:39 PM, Jeff Klukas wrote: > > > I've updated the KIP to use the topics.regex name and opened a WIP P

Re: [DISCUSS] KIP-215: Add topic regex support for Connect sinks

2017-10-27 Thread Jeff Klukas
more design discussion needs to happen in the KIP. https://github.com/apache/kafka/pull/4151 On Fri, Oct 27, 2017 at 7:50 AM, Jeff Klukas wrote: > I added a note in the KIP about ConfigException being thrown. I also > changed the proposed default for the new config to empty string rather

Re: [DISCUSS] KIP-215: Add topic regex support for Connect sinks

2017-10-27 Thread Jeff Klukas
gt; > Otherwise LGTM, and thanks for helping fill in a longstanding gap! > > -Ewen > > On Thu, Oct 26, 2017 at 7:56 PM, Ted Yu wrote: > > > bq. Users may specify only one of 'topics' or 'topics.pattern'. > > > > Can you fill in which exception

[DISCUSS] KIP-215: Add topic regex support for Connect sinks

2017-10-26 Thread Jeff Klukas
Looking for feedback on https://cwiki.apache.org/confluence/display/KAFKA/KIP-215%3A+Add+topic+regex+support+for+Connect+sinks

[jira] [Updated] (KAFKA-4932) Add UUID Serde

2017-03-22 Thread Jeff Klukas (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Klukas updated KAFKA-4932: --- Description: I propose adding serializers and deserializers for the java.util.UUID class. I have

[jira] [Updated] (KAFKA-4932) Add UUID Serde

2017-03-22 Thread Jeff Klukas (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Klukas updated KAFKA-4932: --- Summary: Add UUID Serde (was: Add UUID Serdes) > Add UUID Se

[jira] [Created] (KAFKA-4932) Add UUID Serdes

2017-03-22 Thread Jeff Klukas (JIRA)
Jeff Klukas created KAFKA-4932: -- Summary: Add UUID Serdes Key: KAFKA-4932 URL: https://issues.apache.org/jira/browse/KAFKA-4932 Project: Kafka Issue Type: Improvement Components

[jira] [Resolved] (KAFKA-4257) Inconsistencies in 0.10.1 upgrade docs

2016-10-07 Thread Jeff Klukas (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Klukas resolved KAFKA-4257. Resolution: Fixed Ismael's PR addresses these questions. > Inconsistencies in 0.10.1 upgr

[jira] [Commented] (KAFKA-4257) Inconsistencies in 0.10.1 upgrade docs

2016-10-05 Thread Jeff Klukas (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15548729#comment-15548729 ] Jeff Klukas commented on KAFKA-4257: The pull request definitely helps. Thanks

[jira] [Created] (KAFKA-4257) Inconsistencies in 0.10.1 upgrade docs

2016-10-05 Thread Jeff Klukas (JIRA)
Jeff Klukas created KAFKA-4257: -- Summary: Inconsistencies in 0.10.1 upgrade docs Key: KAFKA-4257 URL: https://issues.apache.org/jira/browse/KAFKA-4257 Project: Kafka Issue Type: Bug

[jira] [Commented] (KAFKA-3895) Implement a default queue for expired messages

2016-09-29 Thread Jeff Klukas (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15533221#comment-15533221 ] Jeff Klukas commented on KAFKA-3895: It's not clear to me how the concepts

Re: [DISCUSS] Java 8 as a minimum requirement

2016-06-17 Thread Jeff Klukas
On Thu, Jun 16, 2016 at 5:20 PM, Ismael Juma wrote: > On Thu, Jun 16, 2016 at 11:13 PM, Stephen Boesch > wrote: > > > @Jeff Klukas What is the concern about scala 2.11 vs 2.12? 2.11 runs on > > both java7 and java8 > > > > Scala 2.10.5 and 2.10.6 also support

Re: [DISCUSS] Java 8 as a minimum requirement

2016-06-16 Thread Jeff Klukas
Would the move to Java 8 be for all modules? I'd have some concern about removing Java 7 compatibility for kafka-clients and for kafka streams (though less so since it's still so new). I don't know how hard it will be to transition a Scala 2.11 application to Scala 2.12. Are we comfortable with the

[jira] [Updated] (KAFKA-3753) Add approximateNumEntries() to the StateStore interface for metrics reporting

2016-06-10 Thread Jeff Klukas (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Klukas updated KAFKA-3753: --- Summary: Add approximateNumEntries() to the StateStore interface for metrics reporting (was: Add

[jira] [Commented] (KAFKA-3801) Provide static serialize() and deserialize() for use as method references

2016-06-10 Thread Jeff Klukas (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15325270#comment-15325270 ] Jeff Klukas commented on KAFKA-3801: I like concise code that you get from a st

[jira] [Commented] (KAFKA-3801) Provide static serialize() and deserialize() for use as method references

2016-06-09 Thread Jeff Klukas (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15323718#comment-15323718 ] Jeff Klukas commented on KAFKA-3801: Let me give more context for the example

[jira] [Commented] (KAFKA-3753) Add size() to the StateStore interface for metrics reporting

2016-06-09 Thread Jeff Klukas (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15323342#comment-15323342 ] Jeff Klukas commented on KAFKA-3753: I agree that {{size}} is a bit ambiguous.

[jira] [Created] (KAFKA-3817) KTableRepartitionMap should handle null inputs

2016-06-09 Thread Jeff Klukas (JIRA)
Jeff Klukas created KAFKA-3817: -- Summary: KTableRepartitionMap should handle null inputs Key: KAFKA-3817 URL: https://issues.apache.org/jira/browse/KAFKA-3817 Project: Kafka Issue Type: Bug

[jira] [Commented] (KAFKA-3753) Metrics for StateStores

2016-06-09 Thread Jeff Klukas (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15322683#comment-15322683 ] Jeff Klukas commented on KAFKA-3753: Since there's refactoring going on

[jira] [Created] (KAFKA-3801) Provide static serialize() and deserialize() for use as method references

2016-06-07 Thread Jeff Klukas (JIRA)
Jeff Klukas created KAFKA-3801: -- Summary: Provide static serialize() and deserialize() for use as method references Key: KAFKA-3801 URL: https://issues.apache.org/jira/browse/KAFKA-3801 Project: Kafka

[jira] [Commented] (KAFKA-3711) Allow configuration of MetricsReporter subclasses

2016-06-07 Thread Jeff Klukas (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15318768#comment-15318768 ] Jeff Klukas commented on KAFKA-3711: I submitted a PR above to call {{origi

[jira] [Commented] (KAFKA-3711) Allow configuration of MetricsReporter subclasses

2016-06-07 Thread Jeff Klukas (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15318546#comment-15318546 ] Jeff Klukas commented on KAFKA-3711: I would love to see this fixed as well. I&#x

[jira] [Commented] (KAFKA-3753) Metrics for StateStores

2016-06-07 Thread Jeff Klukas (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15318521#comment-15318521 ] Jeff Klukas commented on KAFKA-3753: It's good to know about MeteredKeyV

[jira] [Created] (KAFKA-3753) Metrics for StateStores

2016-05-25 Thread Jeff Klukas (JIRA)
Jeff Klukas created KAFKA-3753: -- Summary: Metrics for StateStores Key: KAFKA-3753 URL: https://issues.apache.org/jira/browse/KAFKA-3753 Project: Kafka Issue Type: Improvement

[jira] [Updated] (KAFKA-3714) Allow users greater access to register custom streams metrics

2016-05-16 Thread Jeff Klukas (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Klukas updated KAFKA-3714: --- Issue Type: Improvement (was: Bug) > Allow users greater access to register custom streams metr

[jira] [Commented] (KAFKA-3715) Higher granularity streams metrics

2016-05-16 Thread Jeff Klukas (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15284706#comment-15284706 ] Jeff Klukas commented on KAFKA-3715: It would be interesting to work on this, b

[jira] [Created] (KAFKA-3715) Higher granularity streams metrics

2016-05-16 Thread Jeff Klukas (JIRA)
Jeff Klukas created KAFKA-3715: -- Summary: Higher granularity streams metrics Key: KAFKA-3715 URL: https://issues.apache.org/jira/browse/KAFKA-3715 Project: Kafka Issue Type: Improvement

[jira] [Created] (KAFKA-3714) Allow users greater access to register custom streams metrics

2016-05-16 Thread Jeff Klukas (JIRA)
Jeff Klukas created KAFKA-3714: -- Summary: Allow users greater access to register custom streams metrics Key: KAFKA-3714 URL: https://issues.apache.org/jira/browse/KAFKA-3714 Project: Kafka

[jira] [Created] (KAFKA-3711) Allow configuration of MetricsReporter subclasses

2016-05-13 Thread Jeff Klukas (JIRA)
Jeff Klukas created KAFKA-3711: -- Summary: Allow configuration of MetricsReporter subclasses Key: KAFKA-3711 URL: https://issues.apache.org/jira/browse/KAFKA-3711 Project: Kafka Issue Type

[jira] [Created] (KAFKA-3701) Expose KafkaStreams metrics in public API

2016-05-11 Thread Jeff Klukas (JIRA)
Jeff Klukas created KAFKA-3701: -- Summary: Expose KafkaStreams metrics in public API Key: KAFKA-3701 URL: https://issues.apache.org/jira/browse/KAFKA-3701 Project: Kafka Issue Type: Improvement

[jira] [Commented] (KAFKA-3625) Move kafka-streams test fixtures into a published package

2016-04-26 Thread Jeff Klukas (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15258338#comment-15258338 ] Jeff Klukas commented on KAFKA-3625: I would be willing to submit this patch if f

[jira] [Created] (KAFKA-3625) Move kafka-streams test fixtures into a published package

2016-04-26 Thread Jeff Klukas (JIRA)
Jeff Klukas created KAFKA-3625: -- Summary: Move kafka-streams test fixtures into a published package Key: KAFKA-3625 URL: https://issues.apache.org/jira/browse/KAFKA-3625 Project: Kafka Issue