the current KIP.
> >
> > But as I said: It's your call.
> >
> > Best,
> > Bruno
> >
> > On 11.05.22 11:01, François Rosière wrote:
> >> To be clear, there is no problem for me to update the current KIP with
> the
> >> builder
nks,
> Kirk
>
> On Wed, May 18, 2022, at 10:11 AM, François Rosière wrote:
> > Hi all,
> >
> > KIP to create builders for
> >
> >- KafkaProducer
> >- KafkaConsumer
> >- KafkaStreams
> >
> >
> > This KIP can be seen as th
Hi all,
KIP to create builders for
- KafkaProducer
- KafkaConsumer
- KafkaStreams
This KIP can be seen as the continuity of the KIP-832.
KIP details:
https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=211884640
Jira issue: https://issues.apache.org/jira/browse/KAFKA-13
>>> }
>> >>>
>> >>> // Use these interceptors (has no effect if null)
>> >>> // Each must already be configured
>> >>> // Will be combined with any interceptor classes also specified
>> in
>> >>
> >
> > That aside, given the three binding votes already cast on the vote
> thread,
> > it's probably too late to be worth changing direction at this point.
> Thanks
> > for entertaining the proposal, and congratulations on your KIP!
> >
> > Cheers,
>
lean up a little bit the KIP since it has still
> > parts that refer to its first version? For example, "Compatibility,
> > Deprecation, and Migration Plan" still mentions only two constructors.
> > IMO you can also remove section "Public Interfaces" since it do
Can a PR be dropped on Github or do we still need some approval first?
Le dim. 8 mai 2022 à 06:08, John Roesler a écrit :
> Thanks, François!
>
> Those changes look good to me.
>
> Thanks,
> -John
>
> On Fri, May 6, 2022, at 13:51, François Rosière wrote:
> > The K
The KIP has been updated to reflect the last discussion
https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=211882578#KIP832:Allowcreatingaproducer/consumerusingaproducer/consumerconfig-ProposedChanges
Le ven. 6 mai 2022 à 20:44, François Rosière a
écrit :
> Hello,
>
> N
prove it.
>
> Since KIP-378 didn't make it over the finish line, and it
> seems like a small expansion to your proposal, do you
> mind also adding the StreamsConfig to the
> TopologyTestDriver constructors? That way, we can go
> ahead and resolve both KIPs at once.
>
> Th
To stay consistent with existing code, we should simply add 2 constructors.
One with ser/deser and one without.
So that, users have the choice to use one or the other.
I updated the KIP accordingly.
Le ven. 6 mai 2022 à 12:55, François Rosière a
écrit :
> On the other hand, the KafkaConsu
seems it's easier to have the constructor with 3 parameters. But in
any case, it will work if the config can be accessed...
Le ven. 6 mai 2022 à 12:14, François Rosière a
écrit :
> Hello,
>
> We may create a constructor with a single parameter which is the config
> but then, I w
t;> 2. Why do you only want to change/add the constructors that take the
> >> properties objects and de/serializers and you do not also want to
> >> add/change the constructors that take only the properties?
>
>
> Best,
> Bruno
>
> On 05.05.22 23:15, François
maining topology test driver API changes
> in your KIP.
> Some related links:
> - https://github.com/apache/kafka/pull/5344#issuecomment-413350338
> - https://github.com/apache/kafka/pull/10484
> - https://issues.apache.org/jira/browse/KAFKA-6386
>
> Best,
> Bruno
>
>
> On 0
, proposal, vote for this KIP would be more than welcome.
Kind regards,
Francois R.
Le lun. 2 mai 2022 à 21:05, François Rosière a
écrit :
> Kip link:
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=211882578
>
>
Kip link:
https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=211882578
16 matches
Mail list logo
