Re: [VOTE] KIP-1064 - Upgrade slf4j to 2.x

2025-03-25 Thread Farid Zakaria
Logging always seem "easy" but then I remember reading https://google.github.io/flogger/anatomy.html Even the variadic approach of some logging implementations comes at a non-negative cost On Tue, Mar 25, 2025 at 6:12 AM Federico Valeri wrote: > > Hi Clayton, thanks for raising this point. I thin

Re: [VOTE] KIP-1064 - Upgrade slf4j to 2.x

2025-03-20 Thread Farid Zakaria
AFAIR SLF4J you don't have to remove the other backends; merely make sure yours is first on the CLASSPATH list :P (SLF4J pre 2.0 would always emit a warning that it found 2+ StaticBinders) Interestingly, you could still whatever backend (i.e. Log4J) and pipe it through to another backend via anoth

Re: Simplifying Java import order tooling

2025-02-21 Thread Farid Zakaria
o probably tree-wide formatting which a good first step is adopting import sorting from a Java formatter (in this case google-java-format). On Thu, Feb 20, 2025 at 6:54 PM Chia-Ping Tsai wrote: > > hi Farid > > I'm curious, what is the problem with the current import order? > &g

Simplifying Java import order tooling

2025-02-20 Thread Farid Zakaria
Hi Kafka developers, I've seen some previous discussions in the past about "adopting formatting" for the Kafka codebase a la google-java-format. While such a discussion may be ongoing and require further iterations; I was wondering if we could start somewhere smaller. google-java-format has the

Re: [DISCUSS] KIP-1115: Bazel Builds

2024-11-22 Thread Farid Zakaria
On Fri, Nov 22, 2024 at 10:47 AM David Arthur wrote: > > Thanks for the KIP, Vince and Farid! > > A few comments on the KIP > > DA1: The motivation mentioned historical build times in Apache Kafka, but > we should really just consider the current situation. I would like to see > the motivation/bac

Re: [DISCUSS] KIP-1115: Bazel Builds

2024-11-22 Thread Farid Zakaria
Hi! I'm one of the co-authors of the KIP. Let me answer a few questions (the thread is a bit long so I won't opt for inline). * Many of the comments touch on the aspect that having multiple BUILD files looks like to be higher cognitive requirement than what is currently required by Gradle which s