I have also created the pull request for the behaviour change.
https://github.com/apache/kafka/pull/13455
Thanks again,
Dan
On Thu, Mar 23, 2023 at 11:40 PM Dan S wrote:
> I have created the jira, the PR will follow within the next few days.
> https://issues.apache.org/jira/browse/KAFKA
I have created the jira, the PR will follow within the next few days.
https://issues.apache.org/jira/browse/KAFKA-14841
Thanks again
On Thu, Mar 23, 2023 at 7:33 PM Philip Nee wrote:
> Awesome!
>
> On Thu, Mar 23, 2023 at 12:31 PM Dan S wrote:
>
> > I'll pick it up, than
I'll pick it up, thanks!
On Thu, Mar 23, 2023, 19:27 Philip Nee wrote:
> Hey Dan,
>
> Your analysis looks right. I do see TODO item there to implement the
> rebalance callback. Would you like to create a jira issue and work on that?
>
> Thanks,
> P
>
> On Thu
s indeed
desired behavior.
On Thu, Mar 23, 2023, 18:17 Philip Nee wrote:
> Hey Dan,
>
> Thanks for looking into this. Are you talking about MockConsumer? If you
> invoke subscribe(Collection topics), it actually registers a Noop
> callback. Perhaps this is what you are seeing?
>
&
Hello all,
It seems to me based on reading the code, that the consumer rebalance
listener that is passed into the mock consumer when subscribing to a topic
is not actually called when a rebalance is simulated. My understanding is
that the consumer rebalance listener is called from the consumer
coo
ethod name.
> >
> > People seem to typically file tickets with “flaky” in the title and
> > then the test name.
> >
> > Thanks again for your interest in improving the situation!
> > -John
> >
> > On Thu, Nov 24, 2022, at 10:08, Dan S wrote:
> >
.
>
> Thanks,
> John
>
> On Thu, Nov 24, 2022, at 02:38, Dan S wrote:
> > Hello all,
> >
> > I've had a pr that has been open for a little over a month (several
> > feedback cycles happened), and I've never seen a fully passing build
> (tests
>
Hello all,
I've had a pr that has been open for a little over a month (several
feedback cycles happened), and I've never seen a fully passing build (tests
in completely different parts of the codebase seemed to fail, often
timeouts). A cursory look at open PRs seems to indicate that mine is not
th
ype with defaults for and
> consumers/producers.
>
> On Thu, Nov 10, 2022, 6:35 PM Dan S wrote:
>
> > Hello all,
> >
> > I think that adding builders for the producer and the consumer in kafka
> > client would make it much easier for developers to instantiate
Hello all,
I think that adding builders for the producer and the consumer in kafka
client would make it much easier for developers to instantiate new
producers and consumers, especially if they are using an IDE with
intellisense, and using the IDE to navigate to the documentation which
could be ad
Hello all,
I think that adding builders for the producer and the consumer in kafka
client would make it much easier for developers to instantiate new
producers and consumers, especially if they are using an IDE with
intellisense, and using the IDE to navigate to the documentation which
could be ad
Hello,
I would really appreciate another review on
https://github.com/apache/kafka/pull/12753/files as I think it would be
great to add a bit more documentation on the behaviour of seek, as well as
some tests around invalid offsets (I found this very confusing when
developing for it).
Thanks,
Da
Hello,
I would like to contribute to kafka,
my wiki id, jira id, and github username are all "scanteianu"
Thanks,
Dan
Hello all,
I'd love to get this reviewed and ideally merged, it's just adding some
documentation around seek() that I would have found helpful while
developing. The tests which are failing seem to be from a completely
different part of the codebase (mostly around consensus mechanism).
https://git
Hello,
I opened a PR to add slightly more detailed documentation to seek(), as I
had spent hours googling when I wanted to use it. After some great reviews
from @showuon, I added some integration tests, and I noticed very odd
behaviour:
https://github.com/apache/kafka/pull/12753/files#r1007760016
Hello,
I opened a PR to add slightly more detailed documentation to seek(), as I
had spent hours googling when I wanted to use it. After some great reviews
from @showuon, I added some integration tests, and I noticed very odd
behaviour:
https://github.com/apache/kafka/pull/12753/files#r1007760016
16 matches
Mail list logo