Re: [DISCUSS] KIP-554: Add Broker-side SCRAM Config API

2020-05-01 Thread Aneel Nazareth
Hi Colin, Thanks for the KIP. Is it also in scope to add support for the new API to the Admin interface and the implementation in KafkaAdminClient? On Fri, May 1, 2020 at 1:18 AM Colin McCabe wrote: > > Hi all, > > I posted a KIP about adding a new SCRAM configuration API on the broker. > Chec

Re: [VOTE] KIP-577: Allow HTTP Response Headers Configured for Kafka Connect

2020-04-17 Thread Aneel Nazareth
Thanks Jeff, this seems like it addresses a user need. +1 (non-binding) On Fri, Apr 17, 2020 at 1:28 PM Zhiguo Huang wrote: > > Thanks to everyone for their input. I've incorporated the changes, and I > think this is ready for voting. > > To summarize, the KIP simply proposes to add a feature wh

Re: [DISCUSS] KIP-574: CLI Dynamic Configuration with file input

2020-04-13 Thread Aneel Nazareth
Thanks to David Jacot for his suggestions. Would it be possible for a committer to have a look at this PR? Thanks! https://github.com/apache/kafka/pull/8184 On Wed, Apr 1, 2020 at 12:30 PM Aneel Nazareth wrote: > > I have a PR that I think is ready for review here: > https://github.c

Re: [DISCUSS] KIP-574: CLI Dynamic Configuration with file input

2020-04-01 Thread Aneel Nazareth
; best, > Colin > > > On Fri, Mar 27, 2020, at 07:46, Aneel Nazareth wrote: > > Update: I have simplified the KIP down to just adding the single new > > --add-config-file option. Thanks for your input, everyone! > > > > On Thu, Mar 26, 2020 at 10:13 AM Aneel

Re: [VOTE] KIP-574: CLI Dynamic Configuration with file input

2020-04-01 Thread Aneel Nazareth
16 PM Gwen Shapira wrote: > > > > > Vote is still good. We can always add things later if needed. > > > > > > On Fri, Mar 27, 2020, 8:15 AM Aneel Nazareth wrote: > > > > > > > Hi Colin and Gwen, > > > > > > > > I

Re: [VOTE] KIP-574: CLI Dynamic Configuration with file input

2020-03-27 Thread Aneel Nazareth
> > > > Thanks, Aneel. > > > > > > best, > > > Colin > > > > > > On Wed, Mar 18, 2020, at 00:04, David Jacot wrote: > > > > +1 (non-binding), thanks for the KIP! > > > > > > > > David > > > > >

Re: [DISCUSS] KIP-574: CLI Dynamic Configuration with file input

2020-03-27 Thread Aneel Nazareth
Update: I have simplified the KIP down to just adding the single new --add-config-file option. Thanks for your input, everyone! On Thu, Mar 26, 2020 at 10:13 AM Aneel Nazareth wrote: > > Hi Kamal, > > Thanks for taking a look at this KIP. > > Unfortunately the user actua

Re: [DISCUSS] KIP-574: CLI Dynamic Configuration with file input

2020-03-26 Thread Aneel Nazareth
te: > > > > > Hi Aneel, > > > > > > Thanks for the updated KIP. I have made a second pass over it and the > > > KIP looks good to me. > > > > > > Best, > > > David > > > > > > On Tue, Mar 10, 2020 at 9:39 PM Aneel Nazareth

Re: [DISCUSS] KIP-574: CLI Dynamic Configuration with file input

2020-03-26 Thread Aneel Nazareth
le-consumer.sh, kafka-console-producer.sh and kafka-acls.sh > > > > in which the props file is accepted via consumer.config / > > > producer.config / > > > > command-config parameter. > > > > > > > > Shouldn't we have to m

[VOTE] KIP-574: CLI Dynamic Configuration with file input

2020-03-16 Thread Aneel Nazareth
Hello all, Thanks to the folks who have given feedback. I've incorporated the suggestions, and think that this is now ready for a vote: https://cwiki.apache.org/confluence/display/KAFKA/KIP-574%3A+CLI+Dynamic+Configuration+with+file+input Thank you, Aneel

Re: [DISCUSS] KIP-577: Allow HTTP Response Headers Configured for Kafka Connect

2020-03-13 Thread Aneel Nazareth
imeTypes - CSV of mime types to include > excludedMimeTypes - CSV of mime types to exclude > includedHttpMethods - CSV of http methods to include > excludedHttpMethods - CSV of http methods to exclude > > Jeff. > > On 2020/03/13 14:28:11, Aneel Nazareth wrote: > > Hi Jeff,

Re: [DISCUSS] KIP-577: Allow HTTP Response Headers Configured for Kafka Connect

2020-03-13 Thread Aneel Nazareth
Hi Jeff, Thanks for the KIP. Will users always want to set identical headers on all responses? Does it make sense to also allow configuration of the HeaderFilter init parameters like "includedPaths", "excludedHttpMethods", etc.? Does it make sense to allow multiple configurations (so that eg. dif

Re: [DISCUSS] KIP-574: CLI Dynamic Configuration with file input

2020-03-10 Thread Aneel Nazareth
AFKA/KIP-574%3A+CLI+Dynamic+Configuration+with+file+input And updated my sample PR: https://github.com/apache/kafka/pull/8184 If there are no further comments, I'll request a vote in a few days. Thanks for the feedback! On Mon, Mar 9, 2020 at 1:24 PM Aneel Nazareth wrote: > > Hi

Re: [DISCUSS] KIP-574: CLI Dynamic Configuration with file input

2020-03-09 Thread Aneel Nazareth
eating a > file with blank values, or just passing the keys to --delete-config? > > best, > Colin > > > > > David > > > > On Thu, Feb 27, 2020 at 11:15 PM Aneel Nazareth wrote: > > > > > I've created a PR for a potential implem

Re: [DISCUSS] KIP-574: CLI Dynamic Configuration with file input

2020-03-09 Thread Aneel Nazareth
think it might be confusing to > > users to supply a file, and then have the values supplied in that file be > > ignored. Is there really a case where we need to do this (as opposed to > > creating a file with blank values, or just passing the keys to > > --delete-config? &

Re: JIRA permissions request

2020-02-28 Thread Aneel Nazareth
Thanks, Jun! I've successfully assigned the ticket to myself. On Fri, Feb 28, 2020 at 1:30 PM Jun Rao wrote: > Hi, Aneel, > > Thanks for your interest in Kafka. Just gave you the jira permission. > > Jun > > On Fri, Feb 28, 2020 at 7:41 AM Aneel Nazareth wrote: &

JIRA permissions request

2020-02-28 Thread Aneel Nazareth
Hi. I've created this https://issues.apache.org/jira/browse/KAFKA-9612 to capture the work if we decide to do KIP-574 ( https://cwiki.apache.org/confluence/display/KAFKA/KIP-574%3A+CLI+Dynamic+Configuration+with+file+input ). The contributing page says: "To avoid conflicts, assign the JIRA ticket

Re: [DISCUSS] KIP-574: CLI Dynamic Configuration with file input

2020-02-27 Thread Aneel Nazareth
I've created a PR for a potential implementation of this: https://github.com/apache/kafka/pull/8184 if we decide to go ahead with this KIP. On Wed, Feb 26, 2020 at 12:36 PM Aneel Nazareth wrote: > Hi, > > I'd like to discuss adding a new argument to kafka-configs.sh >

[DISCUSS] KIP-574: CLI Dynamic Configuration with file input

2020-02-26 Thread Aneel Nazareth
Hi, I'd like to discuss adding a new argument to kafka-configs.sh (ConfigCommand.scala). Recently I've been working on some things that require complex configurations. I've chosen to represent them as JSON strings in my server.properties. This works well, and I'm able to update the configurations

[jira] [Created] (KAFKA-9612) CLI Dynamic Configuration with file input

2020-02-26 Thread Aneel Nazareth (Jira)
Aneel Nazareth created KAFKA-9612: - Summary: CLI Dynamic Configuration with file input Key: KAFKA-9612 URL: https://issues.apache.org/jira/browse/KAFKA-9612 Project: Kafka Issue Type

Permission to create KIP

2020-02-26 Thread Aneel Nazareth
Hi, I'd like to create a KIP. Would you please give user "aneel" permission to do so? Thanks, Aneel Nazareth