Re: [DISCUSS] KIP-1161: cleanup.policy shouldn't be empty

2025-05-11 Thread Chia-Ping Tsai
hi Luke We can print warnings for empty cleanup.policy in 4.x and in 5.0 we throw exception directly to make it fail fast Jiunn: WDYT? Best, Chia-Ping > Luke Chen 於 2025年5月12日 上午10:52 寫道: > > Hi Jiunn-Yang, > > Thanks for the KIP. > > Comments: > 1. "it is acceptable because an empty cl

Re: [DISCUSS] KIP-1161: cleanup.policy shouldn't be empty

2025-05-11 Thread Luke Chen
Hi Jiunn-Yang, Thanks for the KIP. Comments: 1. "it is acceptable because an empty cleanup.policy is considered invalid in Kafka. Therefore, this trade-off is justified." Could you explain more about this? Why is this trade-off justified? If we think the empty cleanup.policy is invalid in kafka,

Re: [VOTE] KIP-1148: Remove log.cleaner.enable configuration

2025-05-11 Thread TengYao Chi
Hi everyone, Chia-Ping has raised a concern for another configuration, `log.cleaner.threads`, which is highly related to `log.cleaner.enable` Given that the user cannot close the log cleaner, `log.cleaner.threads` should also have a lower bound of 1. I have updated the KIP. Please take a look. Be

Jenkins build is still unstable: Kafka » Kafka PowerPC Daily » test-powerpc #295

2025-05-11 Thread Apache Jenkins Server
See

[jira] [Resolved] (KAFKA-18695) Remove quorum=kraft and kip932 from all integration tests

2025-05-11 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-18695. Fix Version/s: 4.1.0 Resolution: Fixed > Remove quorum=kraft and kip932 from all in

Re: [DISCUSS] KIP-1148: Remove log.cleaner.enable configuration

2025-05-11 Thread Chia-Ping Tsai
hi TengYao please sync the update to the vote thread. thanks Best, Chia-Ping TengYao Chi 於 2025年5月12日 週一 上午12:07寫道: > Hi Chia-Ping > Nice catch! > I have updated the KIP. > > Best, > TengYao > > Chia-Ping Tsai 於 2025年5月11日 週日 下午4:34寫道: > > > hi Teng > > > > Sorry for raising issue on the acce

[jira] [Created] (KAFKA-19267) the min version used by ListOffsetsRequest should be 1 rather than 0

2025-05-11 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-19267: -- Summary: the min version used by ListOffsetsRequest should be 1 rather than 0 Key: KAFKA-19267 URL: https://issues.apache.org/jira/browse/KAFKA-19267 Project: Kaf

Re: [DISCUSS] KIP-1148: Remove log.cleaner.enable configuration

2025-05-11 Thread TengYao Chi
Hi Chia-Ping Nice catch! I have updated the KIP. Best, TengYao Chia-Ping Tsai 於 2025年5月11日 週日 下午4:34寫道: > hi Teng > > Sorry for raising issue on the accepted KIP. > > In 5.0 the log cleaner should be always enabled and so the config > log.cleaner.threads should NOT accept min value of zero, rig

[jira] [Resolved] (KAFKA-19264) Remove fallback for thread pool sizes in RemoteLogManagerConfig

2025-05-11 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-19264. Fix Version/s: 4.1.0 Resolution: Fixed > Remove fallback for thread pool sizes in R

[jira] [Created] (KAFKA-19266) Eliminate flakiness in test SharePartitionTest.testAcquisitionLockTimeoutForBatchesPostStartOffsetMovement

2025-05-11 Thread Abhinav Dixit (Jira)
Abhinav Dixit created KAFKA-19266: - Summary: Eliminate flakiness in test SharePartitionTest.testAcquisitionLockTimeoutForBatchesPostStartOffsetMovement Key: KAFKA-19266 URL: https://issues.apache.org/jira/browse/K

[jira] [Created] (KAFKA-19265) Use snapshotting of remote log metedata topic that is used when a broker is restarted.

2025-05-11 Thread Satish Duggana (Jira)
Satish Duggana created KAFKA-19265: -- Summary: Use snapshotting of remote log metedata topic that is used when a broker is restarted. Key: KAFKA-19265 URL: https://issues.apache.org/jira/browse/KAFKA-19265

[jira] [Created] (KAFKA-19264) Remove fallback for thread pool sizes in RemoteLogManagerConfig

2025-05-11 Thread Kuan Po Tseng (Jira)
Kuan Po Tseng created KAFKA-19264: - Summary: Remove fallback for thread pool sizes in RemoteLogManagerConfig Key: KAFKA-19264 URL: https://issues.apache.org/jira/browse/KAFKA-19264 Project: Kafka

[jira] [Created] (KAFKA-19263) The docs of delete.topic.enable used by Admin#deletetopics is out-of-date

2025-05-11 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-19263: -- Summary: The docs of delete.topic.enable used by Admin#deletetopics is out-of-date Key: KAFKA-19263 URL: https://issues.apache.org/jira/browse/KAFKA-19263 Projec

Re: KIP-1135: Deprecated "org.apache.kafka.disallowed.login.modules"

2025-05-11 Thread 龚宣璋
Hi everyone, Just checking in — does anyone have any further thoughts or comments on this discussion thread? If there are no objections, I’ll go ahead and send out the voting notification tomorrow. Best regards, Xuan-Zhang Gong

Re: [DISCUSS] KIP-1148: Remove log.cleaner.enable configuration

2025-05-11 Thread Chia-Ping Tsai
hi Teng Sorry for raising issue on the accepted KIP. In 5.0 the log cleaner should be always enabled and so the config log.cleaner.threads should NOT accept min value of zero, right? Hence, could you please add the behavior changes “the min value should be 1” to this KIP? Best, Chia-Ping On

Re: [DISCUSS] KIP-1148: Remove log.cleaner.enable configuration

2025-05-11 Thread Chia-Ping Tsai
hi Teng Sorry for raising issue on the accepted KIP. In 5.0 the log cleaner should be always enabled and so the config log.cleaner.threads should NOT accept min value of zero, right? Hence, could you please add the behavior changes “the min value should be 1” to this KIP? Best, Chia-Ping On

Re: [DISCUSS] KIP-1100: Consider renaming org.apache.kafka.server:type=AssignmentsManager

2025-05-11 Thread 黃竣陽
Hi chia, File a Jira to trace it https://issues.apache.org/jira/browse/KAFKA-19262 Best Regards, Jiunn-Yang > 黃竣陽 於 2025年5月11日 下午1:41 寫道: > > Hi Ismael, chia, > > Thanks for all the feedback. I’ve updated the KIP. > >> 2. Given that we regressed in two different instances (that we found so >

[jira] [Created] (KAFKA-19262) Add a test to verify all metrics naming pattern

2025-05-11 Thread Jira
黃竣陽 created KAFKA-19262: --- Summary: Add a test to verify all metrics naming pattern Key: KAFKA-19262 URL: https://issues.apache.org/jira/browse/KAFKA-19262 Project: Kafka Issue Type: Improvement

Re: [DISCUSS] KIP-1100: Consider renaming org.apache.kafka.server:type=AssignmentsManager

2025-05-11 Thread Chia-Ping Tsai
hi Jiunn-Yang Could you please file a ticket to address Ismael comment? That can be addressed even though this KIP is still in progress. Best, Chia-Ping > 黃竣陽 於 2025年5月11日 下午1:42 寫道: > > Jiunn-Yang

[jira] [Resolved] (KAFKA-19139) Plugin#wrapInstance should use LinkedHashMap instead of Map

2025-05-11 Thread TaiJuWu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TaiJuWu resolved KAFKA-19139. - Resolution: Fixed > Plugin#wrapInstance should use LinkedHashMap instead of Map > -