[jira] [Resolved] (KAFKA-17657) Replace the "consumer-fetch-manager-metrics" by groupName

2024-10-01 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17657. Fix Version/s: 4.0.0 Resolution: Fixed > Replace the "consumer-fetch-manager-metric

Re: [VOTE] KIP-1090 Flaky Test Management

2024-10-01 Thread David Arthur
I will close the vote now. This KIP has been accepted with the following results: 6 binding +1 3 non-binding +1 no -1 votes Thanks to everyone who voted and participated in the discussion! David A On Mon, Sep 30, 2024 at 6:12 AM TengYao Chi wrote: > +1 (non-binding) > > Thank you, David >

[jira] [Created] (KAFKA-17677) Consider removing `atomicGetOrUpdate`

2024-10-01 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-17677: -- Summary: Consider removing `atomicGetOrUpdate` Key: KAFKA-17677 URL: https://issues.apache.org/jira/browse/KAFKA-17677 Project: Kafka Issue Type: Sub-tas

Re: [VOTE] KIP-1043: Administration of groups

2024-10-01 Thread David Arthur
+1 binding Cheers, David A On Mon, Sep 23, 2024 at 6:43 AM Apoorv Mittal wrote: > Hi Andrew, > Thanks for the KIP, this will be very helpful. > > +1 (non-binding) > > Regards, > Apoorv Mittal > > > On Mon, Sep 23, 2024 at 11:38 AM Lianet M. wrote: > > > Hello Andrew, > > > > Thanks for the KIP

Re: [DISCUSS] KIP-1092: Extend Consumer#close with an option to leave the group or not

2024-10-01 Thread Chia-Ping Tsai
hi Matthias Thanks for sharing your POV, and you do remind me that this KIP should not be blocked due to this verbose discussion. Those protected methods are not Public APIs, so they can reverted without deprecation cycle. Those variables can be exposed publicly when users do need them. +1 t

Build failed in Jenkins: Kafka » Kafka Branch Builder » 3.9 #80

2024-10-01 Thread Apache Jenkins Server
See Changes: -- [...truncated 418994 lines...] [2024-10-01T21:56:11.445Z] Gradle Test Run :core:test > Gradle Test Executor 99 > ZkMigrationClientTest > testEmptyWrite() START

Re: [DISCUSS] KIP-1092: Extend Consumer#close with an option to leave the group or not

2024-10-01 Thread Matthias J. Sax
Yes, it requires an internal class. But I would rather optimize for a clean user facing API. Personally, I don't think it will make our code base significantly more complex, so I think it's worth the tradeoff. And yes, we would need to take user provided `CloseOption` object and create `CloseO

[jira] [Resolved] (KAFKA-17646) Fix flaky KafkaStreamsTest.testStateGlobalThreadClose

2024-10-01 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17646. Fix Version/s: 4.0.0 Resolution: Fixed > Fix flaky KafkaStreamsTest.testStateGlobal

[jira] [Resolved] (KAFKA-16769) Delete deprecated add.source.alias.to.metrics configuration

2024-10-01 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-16769. Resolution: Fixed > Delete deprecated add.source.alias.to.metrics configuration >

Re: [DISCUSS] KIP-1022 Formatting and Updating Features

2024-10-01 Thread Justine Olshan
Thanks Jiunn-Yang for the update. It makes sense to me. I also wanted to provide my own update. While working on KAFKA-16308, we ran into a few issues with feature validation. Thus we made the following changes to the UpdateFeaturesResponse 1. Any update request will fail fast if a single fea

[jira] [Resolved] (KAFKA-17656) Use parameterized logging for PartitionChangeBuilder

2024-10-01 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17656. Fix Version/s: 4.0.0 Resolution: Fixed > Use parameterized logging for PartitionCha

[jira] [Created] (KAFKA-17676) fix flaky SslTransportLayerTest#testSelectorPollReadSize

2024-10-01 Thread Jira
黃竣陽 created KAFKA-17676: --- Summary: fix flaky SslTransportLayerTest#testSelectorPollReadSize Key: KAFKA-17676 URL: https://issues.apache.org/jira/browse/KAFKA-17676 Project: Kafka Issue Type: Test A

[jira] [Created] (KAFKA-17675) Add tests to RaftEventSimulationTest

2024-10-01 Thread Alyssa Huang (Jira)
Alyssa Huang created KAFKA-17675: Summary: Add tests to RaftEventSimulationTest Key: KAFKA-17675 URL: https://issues.apache.org/jira/browse/KAFKA-17675 Project: Kafka Issue Type: Sub-task

Re: [DISCUSS] KIP-1092: Extend Consumer#close with an option to leave the group or not

2024-10-01 Thread TengYao Chi
Hi Kirk, Thanks for reviewing the KIP and providing detailed feedback. KT4: I would prefer to keep the name as `timeout` since its type is `Duration`, and `Duration` provides various ways to create an instance, not just using milliseconds. KT5: Good point! I’ve added some additional description a

Re: [DISCUSS] KIP-1092: Extend Consumer#close with an option to leave the group or not

2024-10-01 Thread Chia-Ping Tsai
@Matthias > From an impl POV, the internal member can be either (1) package-private to allow direct access within the same package, or (2) protected in combination with an internal sub-class in an internal package to add the necessary getters. As an example cf `Consumed` and `ConsumedInternal` I

Build Updates for Week of Sept 30, 2024

2024-10-01 Thread David Arthur
Progress has continued over the past weeks to improve our builds. Thanks to everyone who has contributed to this effort so far. Here is an update. *Jenkins Build Disabled* We have removed the Jenkinsfile from trunk which has disabled the Jenkins build. There was much rejoicing throughout the land.

[jira] [Created] (KAFKA-17674) New consumer reset positions for newly added partitions before retrieving committed offsets

2024-10-01 Thread Lianet Magrans (Jira)
Lianet Magrans created KAFKA-17674: -- Summary: New consumer reset positions for newly added partitions before retrieving committed offsets Key: KAFKA-17674 URL: https://issues.apache.org/jira/browse/KAFKA-17674

Re: [ANNOUNCE] New committer: Kamal Chandraprakash

2024-10-01 Thread Jorge Esteban Quilcate Otoya
Congrats Kamal!! On Tue 1. Oct 2024 at 7.54, Kamal Chandraprakash < kamal.chandraprak...@gmail.com> wrote: > Thank you all for your warm wishes! > > -- > Kamal > > On Tue, Oct 1, 2024 at 12:11 AM Viktor Somogyi-Vass > wrote: > > > Congrats Kamal! :) > > > > On Mon, Sep 30, 2024, 19:21 Matthias J

Re: [DISCUSS] KIP-1094 Add a new constructor method with nextOffsets to ConsumerRecords

2024-10-01 Thread Alieh Saeedi
Thanks, Sophie and Kirk. You raised good points, Kirk. Regarding your first question: KAFKA-17622 (one of the linked jira tickets) points to one reported bug