Re: [VOTE] KIP-794: Strictly Uniform Sticky Partitioner

2022-03-26 Thread Lucas Bradstreet
Hi Artem, Thank you for all the work on this. I think it'll be quite impactful. +1 non-binding from me. Lucas On Wed, Mar 23, 2022 at 8:27 PM Luke Chen wrote: > Hi Artem, > > Thanks for the KIP and the patience during discussion! > +1 binding from me. > > Luke > > On Thu, Mar 24, 2022 at 3:43

Re: [VOTE] KIP-824 Allowing dumping segmentlogs limiting the batches in the output

2022-03-26 Thread John Roesler
Thanks for the KIP, Sergio! I’m +1 (binding) Thanks, John On Sat, Mar 26, 2022, at 03:32, David Jacot wrote: > +1 (binding). Thanks for the KIP. > > Best, > David > > Le ven. 25 mars 2022 à 07:11, Luke Chen a écrit : > >> Hi Sergio, >> >> Thanks for the KIP! >> +1(binding) from me. >> >> Thank

Re: [DISCUSS] KIP-660: Pluggable ReplicaPlacer

2022-03-26 Thread Luke Chen
Hi Mickael, Thanks for the KIP! It's indeed a pain point for the Kafka admins. I have some comments: 1. Typo in motivation section: When administrators [when to] remove brokers from a cluster, 2. If different `replica.placer.class.name` configs are set in all controllers, I think only the con

Re: Potential bugs in resizing kafka thread

2022-03-26 Thread Feiyan Yu
I fixed some ambiguous expression in the output of unit test, and also open a bug in JIRA with a pull request Thank you for your help and suggestions! Feiyan Yu 于2022年3月26日周六 16:18写道: > Than

[jira] [Created] (KAFKA-13772) Unevenly distribute topic partitions for threads after resizing thread number

2022-03-26 Thread Feiyan Yu (Jira)
Feiyan Yu created KAFKA-13772: - Summary: Unevenly distribute topic partitions for threads after resizing thread number Key: KAFKA-13772 URL: https://issues.apache.org/jira/browse/KAFKA-13772 Project: Kaf

Re: [VOTE] KIP-824 Allowing dumping segmentlogs limiting the batches in the output

2022-03-26 Thread David Jacot
+1 (binding). Thanks for the KIP. Best, David Le ven. 25 mars 2022 à 07:11, Luke Chen a écrit : > Hi Sergio, > > Thanks for the KIP! > +1(binding) from me. > > Thank you. > Luke > > On Fri, Mar 25, 2022 at 1:40 PM Sergio Daniel Troiano > wrote: > > > Hi lads, > > > > I would like to start the

Re: Potential bugs in resizing kafka thread

2022-03-26 Thread Feiyan Yu
Thank you, I will make it an issue. Luke Chen 于2022年3月26日周六 16:03写道: > Hi Feiyan, > > It did look like a bug. Could you open a bug in JIRA here > < > https://issues.apache.org/jira/projects/KAFKA/issues/KAFKA-13735?filter=allopenissues > > > ? > One thing I don't fully understand from the unit t

Re: Potential bugs in resizing kafka thread

2022-03-26 Thread Luke Chen
Hi Feiyan, It did look like a bug. Could you open a bug in JIRA here ? One thing I don't fully understand from the unit test is that, you have output "error distributions: $tpsWithoutResize". I thought the bug