Re: [DISCUSS] KIP-813: Replace KafkaConsumer with AdminClient in GetOffsetShell

2022-01-14 Thread Luke Chen
Hi Ziming, Thanks for the KIP! It's good to support fetch max timestamp in GetOffsetShell. Some comments to the KIP: 1. It might be good and clear to list (some) current options in `GetOffsetShell`, and the changes you want to make. You can refer to the KIP-635 here

Re: [DISCUSS] KIP-591: Add Kafka Streams config to set default state store

2022-01-14 Thread Luke Chen
Hi Matthias, Thanks for the comments. 1. The config name: `default.dsl.store` looks good to me. Updated! 2. the KIP still contains a view case of the originally proposed config name `default.dsl.store.type` which should be updated. --> Updated. Thanks. 3. About `TopologyConfig`: we should add all

Re: [VOTE] KIP-811: Add config min.repartition.purge.interval.ms to Kafka Streams

2022-01-14 Thread Matthias J. Sax
+1 (binding) On 1/14/22 06:32, John Roesler wrote: Thanks for the KIP, Nick! +1 (binding) -John On Fri, Jan 14, 2022, at 07:40, Bruno Cadonna wrote: Hi Nick, Since the title of the KIP slightly changed after the vote was opened also the link to the KIP changed as a result. This is should be

Re: [VOTE] KIP-811: Add config min.repartition.purge.interval.ms to Kafka Streams

2022-01-14 Thread John Roesler
Thanks for the KIP, Nick! +1 (binding) -John On Fri, Jan 14, 2022, at 07:40, Bruno Cadonna wrote: > Hi Nick, > > Since the title of the KIP slightly changed after the vote was opened > also the link to the KIP changed as a result. This is should be a > working link: > > https://cwiki.apache.or

[DISCUSS] KIP-813: Replace KafkaConsumer with AdminClient in GetOffsetShell

2022-01-14 Thread deng ziming
Hi everyone, I would like to start a discussion for KIP-813 https://cwiki.apache.org/confluence/display/KAFKA/KIP-813%3A+Replace+KafkaConsumer+with+AdminClient+in+GetOffsetShell

Re: [VOTE] KIP-811: Add config min.repartition.purge.interval.ms to Kafka Streams

2022-01-14 Thread Bruno Cadonna
Hi Nick, Since the title of the KIP slightly changed after the vote was opened also the link to the KIP changed as a result. This is should be a working link: https://cwiki.apache.org/confluence/x/JY-kCw Anyways, Thanks for the KIP! I am +1 (binding) Best, Bruno On 12.01.22 16:34, Nick

Jenkins build is still unstable: Kafka » Kafka Branch Builder » trunk #615

2022-01-14 Thread Apache Jenkins Server
See

Re: Permission to contribute

2022-01-14 Thread David Jacot
Hey, Done. Thanks for your interest! Best, David On Fri, Jan 14, 2022 at 10:58 AM Daan Gertis wrote: > > Hey everyone, > > I would like to contribute a KIP that I think makes sense when building > event-driven architectures at scale. I have been working with kafka for the > past 6 years or so

Permission to contribute

2022-01-14 Thread Daan Gertis
Hey everyone, I would like to contribute a KIP that I think makes sense when building event-driven architectures at scale. I have been working with kafka for the past 6 years or so (I know, a shame I wasn’t on here sooner) and currently with a startup building a data-platform at peta-scale. We