Re: [VOTE] KIP-740: Use TaskId instead of String for the taskId field in TaskMetadata

2021-05-19 Thread Guozhang Wang
A quick note: since we changed the constructor of TaskMetadata as well in the PR, we'd need to add that in the KIP wiki as well. Personally I think it is okay to just replace the constructor as you did in the PR rather than adding/deprecating --- I would even advocate for replacing the `taskId` fun

Re: [VOTE] KIP-740: Use TaskId instead of String for the taskId field in TaskMetadata

2021-05-19 Thread Guozhang Wang
Thanks Sophie, I like the current proposal better compared to adding a new TaskInfo class. +1 ! Guozhang On Wed, May 19, 2021 at 4:58 PM Sophie Blee-Goldman wrote: > Just a friendly ping to please check out the finalized proposal of the KIP > and (re)cast your votes > > Thanks! > Sophie > > On

Re: [DISCUSS] KIP-741: Change default serde to be null

2021-05-19 Thread Guozhang Wang
Thanks Sophie. I think not piggy-backing on TopologyException makes sense. It just occurs to me that today we already have similar situations even with this config default to Bytes, that is the other `DEFAULT_WINDOWED_KEY/VALUE_SERDE_INNER_CLASS` config, whose default is actually null. Quickly che

Jenkins build is still unstable: Kafka » Kafka Branch Builder » trunk #145

2021-05-19 Thread Apache Jenkins Server
See

[jira] [Created] (KAFKA-12816) Add tier storage configs.

2021-05-19 Thread Satish Duggana (Jira)
Satish Duggana created KAFKA-12816: -- Summary: Add tier storage configs. Key: KAFKA-12816 URL: https://issues.apache.org/jira/browse/KAFKA-12816 Project: Kafka Issue Type: Sub-task

Jenkins build is unstable: Kafka » Kafka Branch Builder » trunk #144

2021-05-19 Thread Apache Jenkins Server
See

Re: [VOTE] KIP-740: Use TaskId instead of String for the taskId field in TaskMetadata

2021-05-19 Thread Sophie Blee-Goldman
Just a friendly ping to please check out the finalized proposal of the KIP and (re)cast your votes Thanks! Sophie On Sun, May 16, 2021 at 7:28 PM Sophie Blee-Goldman wrote: > Thanks John. I have moved the discussion over to a [DISCUSS] thread, where > it should have been taking place all > alon

Re: [DISCUSS] KIP-741: Change default serde to be null

2021-05-19 Thread Sophie Blee-Goldman
To be honest I'm not really a fan of reusing the TopologyException since it feels like a bit of a stretch from a user point of view to classify Serde misconfiguration as a topology issue. I personally think a StreamsException would be acceptable, but I would also propose to introduce a new type of

Build failed in Jenkins: Kafka » Kafka Branch Builder » trunk #143

2021-05-19 Thread Apache Jenkins Server
See Changes: -- [...truncated 479778 lines...] [2021-05-19T22:22:48.212Z] DescribeConsumerGroupTest > testDescribeNonExistingGroup() STARTED [2021-05-19T22:22:52.511Z] [20

[jira] [Resolved] (KAFKA-12815) KTable.transformValue might have incorrect record metadata

2021-05-19 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax resolved KAFKA-12815. - Resolution: Fixed > KTable.transformValue might have incorrect record metadata > ---

[jira] [Created] (KAFKA-12815) KTable.transformValue might have incorrect record metadata

2021-05-19 Thread Matthias J. Sax (Jira)
Matthias J. Sax created KAFKA-12815: --- Summary: KTable.transformValue might have incorrect record metadata Key: KAFKA-12815 URL: https://issues.apache.org/jira/browse/KAFKA-12815 Project: Kafka

Re: [DISCUSS] KIP-618: Atomic commit of source connector records and offsets

2021-05-19 Thread Chris Egerton
Hey Jeremy, Thanks for taking a look! Always nice to have input from connector developers, especially ones as prolific as you. I was hoping to leave connector-defined transaction boundaries for future work as the use cases for them were unclear. For example, with transactions in an upstream data

Build failed in Jenkins: Kafka » Kafka Branch Builder » trunk #142

2021-05-19 Thread Apache Jenkins Server
See Changes: -- [...truncated 341848 lines...] [2021-05-19T15:27:06.246Z] AdminZkClientTest > testTopicCreationWithCollision() PASSED [2021-05-19T15:27:06.246Z] [2021-05-1

Re: [VOTE] 2.7.1 RC2

2021-05-19 Thread Upesh Desai
Excuse me if this is the wrong thread to ask, but I was curious as to if there was an updated timeline for the release of 2.7.1? Thanks in advance, Upesh Upesh Desai Senior Software Developer ude...@itrsgroup.com www.itrsgroup.com Internet communications are not secure and therefore the ITRS Gr

[jira] [Created] (KAFKA-12814) Remove Deprecated method StreamsConfig#getConsumerConfig

2021-05-19 Thread Josep Prat (Jira)
Josep Prat created KAFKA-12814: -- Summary: Remove Deprecated method StreamsConfig#getConsumerConfig Key: KAFKA-12814 URL: https://issues.apache.org/jira/browse/KAFKA-12814 Project: Kafka Issue Ty

Re: [DISCUSS] KIP-618: Atomic commit of source connector records and offsets

2021-05-19 Thread Jeremy Custenborder
Hey Chris! Nice work on this KIP! What are the thoughts about letting the connector developer control the boundaries of the transaction? For example kafka-connect-spooldir is used to parse and import files to kafka. It would be amazing if I could begin and end the transaction as I open and close

Re: [DISCUSS] KIP-739: Block Less on KafkaProducer#send

2021-05-19 Thread Nakamura
@Ryanne: In my mind's eye I slightly prefer the throwing the "cannot enqueue" exception to satisfying the future immediately with the "cannot enqueue" exception? But I agree, it would be worth doing more research. @Matthew: > 3. Using multiple thread pools is definitely recommended for different

Re: [DISCUSS] KIP-741: Change default serde to be null

2021-05-19 Thread Guozhang Wang
Leah, thanks for the KIP. It looks good to me overall, just following up on @br...@confluent.io 's question about exception: what about using the `TopologyException` class? I know that currently it is only thrown during the topology parsing phase, not at the streams construction, but I feel we ca

Re: [DISCUSS] KIP-741: Change default serde to be null

2021-05-19 Thread Leah Thomas
Hi Sophie, Thanks for catching that. These are existing methods inside of `StreamsConfig` that will return null (the new default) instead of byte array serde (the old default). Both `StreamsConfig` and `defaultKeySerde`/`defaultValueSerde` are public, so I assume these still count as part of the p

Pull Requests About Removal of Deprecated Methods in Streams for 3.0

2021-05-19 Thread Josep Prat
Hi all, I recently found several methods that were deprecated before 2.5 version and that could, if I understood the rules correctly, be removed for the upcoming 3.0 release. I created 1 pull request and corresponding Jira ticket for each group. I would highly appreciate it if somebody would have t

Re: [DISCUSS] KIP-739: Block Less on KafkaProducer#send

2021-05-19 Thread Matthew de Detrich
Here are my two cents here (note that I am only seeing this on a surface level) 1. If we are going this road it makes sense to do this "properly" (i.e. using queues as Ryan suggested). The reason I am saying this is that it seems that the original goal of the KIP is for it to be used in other asy

Re: [DISCUSS] KIP-737 Add canTrackSource to ReplicationPolicy

2021-05-19 Thread Matthew de Detrich
Hey Ryanne, Thanks for the reply, personally I have a slight preference for my implementation since it doesn't require the "cheating" with the remote.topic.suffix as you mentioned (this also makes my implementation a bit more clean/simple) but I am definitely not opposed to adjusting to use your m

Jenkins build is still unstable: Kafka » Kafka Branch Builder » trunk #141

2021-05-19 Thread Apache Jenkins Server
See

[jira] [Created] (KAFKA-12813) Remove Deprecated schedule method in ProcessorContext

2021-05-19 Thread Josep Prat (Jira)
Josep Prat created KAFKA-12813: -- Summary: Remove Deprecated schedule method in ProcessorContext Key: KAFKA-12813 URL: https://issues.apache.org/jira/browse/KAFKA-12813 Project: Kafka Issue Type:

Re: [DISCUSS] KIP-741: Change default serde to be null

2021-05-19 Thread Bruno Cadonna
Hey Leah, > what I think should be a small discussion Dangerous words, indeed! It seems like they trigger something in people ;-) Jokes apart! Did you consider throwing a more specific exception instead of a StreamsException? Something that describes better the issue at hand. Best, Bruno