Hey Guozhang,
I'm late to the game, again, but if it is not too late I'd recommend that
instead
of having a single error code for all failed records, instead provide
per-record
error codes by having an array of [relative_offset, error_code], where
they're
both varint-encoded for space-efficiency.
Thank you Clement and Colin for shading light on the process for me. I will
probably start working on a new kip for pluggable SslEngine.
Side note: The pull request is from my fork to my fork to make it easier to
see what changes I am making. I have no intention to getting it reviewed as
a pull re
Hi, Rajini,
Thanks for the reply. The 4-step approach that you outlined seems to work.
Overall, I can see that the async authorize() api could lead to an overall
more efficient implementation. The tradeoff is that we have to code every
request with an extra stage. To me, this optimization seems to
Hey,
Since modifying ApiVersionsRequest seems to be quite involved, do we
want to re-examine the rejected option of adding another
request/response pair? It will add another roundtrip, but Kafka
already expects client connections to be long-lived, so the overhead
is probably negligible.
In additi
Rajini Sivaram created KAFKA-8887:
-
Summary: Use purgatory for CreateAcls and DeleteAcls if
implementation is async
Key: KAFKA-8887
URL: https://issues.apache.org/jira/browse/KAFKA-8887
Project: Kafka
Rajini Sivaram created KAFKA-8886:
-
Summary: Make Authorizer create/delete methods asynchronous
Key: KAFKA-8886
URL: https://issues.apache.org/jira/browse/KAFKA-8886
Project: Kafka
Issue Type
Thanks Ismael. That is good point. I have updated the javadoc.
On Sun, Sep 8, 2019 at 5:38 PM Ismael Juma wrote:
> Hi Rajini,
>
> Can you please update the javadoc for every sync method to be explicit
> about the fact that they should not block and the reasoning?
>
> Ismael
>
> On Sun, Sep 8, 20
Hi Rajini,
Can you please update the javadoc for every sync method to be explicit
about the fact that they should not block and the reasoning?
Ismael
On Sun, Sep 8, 2019, 9:21 AM Rajini Sivaram wrote:
> Hi all,
>
> Thanks everyone for the very useful discussion. I have updated the KIP to
> mak
Hi all,
Thanks everyone for the very useful discussion. I have updated the KIP to
make *createAcls()* and *deleteAcls()* asynchronous. Also added a section
under `*Rejected Alternatives*` for async *authorize()*, which we can
revisit in future if requirement arises.
Regards,
Rajini
On Fri, Sep
