Re: [VOTE] KIP-476: Add Java AdminClient interface

2019-07-01 Thread Matthias J. Sax
Not sure, if I understand the argument? Why would anyone need to support multiple client side versions? Clients/brokers are forward/backward compatible anyway. Also, if one really supports multiple client side versions, won't they use multiple shaded dependencies for different versions? Last, it

Re: [ANNOUNCE] Apache Kafka 2.3.0

2019-07-01 Thread Colin McCabe
Hi Mickael, Thanks for pointing this out. It should be fixed now. best, Colin On Mon, Jul 1, 2019, at 09:14, Mickael Maison wrote: > Colin, > > The javadocs links are broken: > The requested URL /23/javadoc/index.html was not found on this server. > > It's the 3rd time in a row this happens (

[jira] [Created] (KAFKA-8620) Fix potential race condition in StreamThread state change

2019-07-01 Thread Boyang Chen (JIRA)
Boyang Chen created KAFKA-8620: -- Summary: Fix potential race condition in StreamThread state change Key: KAFKA-8620 URL: https://issues.apache.org/jira/browse/KAFKA-8620 Project: Kafka Issue Typ

Build failed in Jenkins: kafka-trunk-jdk11 #668

2019-07-01 Thread Apache Jenkins Server
See Changes: [github] MINOR: Assert ExecutionException details in testCreatePartitions (#7017) -- [...truncated 2.56 MB...] org.apache.kafka.connect.json.JsonConverterTe

Re: [DISCUSS] KIP-444: Augment Metrics for Kafka Streams

2019-07-01 Thread Boyang Chen
Hey Guozhang, do we plan to add per partition latency in this KIP? On Mon, Jul 1, 2019 at 7:08 AM Bruno Cadonna wrote: > Hi Guozhang, > > Thank you for the KIP. > > 1) As far as I understand, the StreamsMetrics interface is there for > user-defined processors. Would it make sense to also add a

Re: [DISCUSS] KIP-484: Expose metrics for group and transaction metadata loading duration

2019-07-01 Thread Anastasia Vela
Hey Gwen! Thanks for reviewing my KIP! 1. I did consider adding an Avg metric as well. Anna and I decided that a max would provide the crucial information. We just need to know if there was a long load time, and expose what that duration was so we understand there's downtime for such a long time.

Re: [ANNOUNCE] Apache Kafka 2.3.0

2019-07-01 Thread Mickael Maison
Colin, The javadocs links are broken: The requested URL /23/javadoc/index.html was not found on this server. It's the 3rd time in a row this happens (2.1 and 2.2 had the same issue at release). Last time, Guozhang confirmed this step is in the release process but maybe this needs to be highlighte

Build failed in Jenkins: kafka-trunk-jdk8 #3761

2019-07-01 Thread Apache Jenkins Server
See Changes: [github] MINOR: Assert ExecutionException details in testCreatePartitions (#7017) -- Started by an SCM change [EnvInject] - Loading node environment variable

Re: [DISCUSS] KIP-444: Augment Metrics for Kafka Streams

2019-07-01 Thread Bruno Cadonna
Hi Guozhang, Thank you for the KIP. 1) As far as I understand, the StreamsMetrics interface is there for user-defined processors. Would it make sense to also add a method to the interface to specify a sensor that records skipped records? 2) What are the semantics of active-task-process and stand

Running Kafka from source in Windows

2019-07-01 Thread Manish G
Hi, I am trying to run Kafka(in Windows 10) from source code I cloned from github. I start with command: .\bin\windows\zookeeper-server-start.bat .\config\zookeeper.properties I get error: The input line is too long. The syntax of the command is incorrect. What mistake am I making? My aim is

Re: [VOTE] KIP-476: Add Java AdminClient interface

2019-07-01 Thread Andy Coates
Done. I've not deprecated the factory methods on the AdminClient for the same reason the AdminClient itself is not deprecated, i.e. this would cause unavoidable warnings for libraries / platforms that support multiple versions of Kafka. However, I think we add a note to the Java docs of `AdminClien

Re: [VOTE] KIP-476: Add Java AdminClient interface

2019-07-01 Thread Andy Coates
Done. On Thu, 27 Jun 2019 at 23:21, Matthias J. Sax wrote: > @Andy: > > What about the factory methods of `AdminClient` class? Should they be > deprecated? > > One nit about the KIP: can you maybe insert "code blocks" to highlight > the API changes? Code blocks would simplify to read the KIP a l

[jira] [Created] (KAFKA-8619) Allow instances to be passed instead of Classes or Strings for configuration

2019-07-01 Thread Graeme Rocher (JIRA)
Graeme Rocher created KAFKA-8619: Summary: Allow instances to be passed instead of Classes or Strings for configuration Key: KAFKA-8619 URL: https://issues.apache.org/jira/browse/KAFKA-8619 Project: K

Re: [DISCUSS] KIP-221: Repartition Topic Hints in Streams

2019-07-01 Thread Levani Kokhreidze
Actually, giving it more though - maybe enhancing Produced with num of partitions configuration is not the best approach. Let me explain why: 1) If we enhance Produced class with this configuration, this will also affect KStream#to operation. Since KStream#to is the final sink of the topology, f