Re: Possible implementation for KAFKA-560

2019-06-23 Thread Carlos Manuel Duclos-Vergara
Hi, Thanks for the answer. Looking at high water mark, then the logic would be to flag the partitions that have high_watermark == log_start_offset In addition, I'm thinking that having the leader fulfill that criteria is enough to flag a partition, maybe check the replicas only if requested by th

Re: [VOTE] 2.3.0 RC3

2019-06-23 Thread Gwen Shapira
+1 (binding) Verified signatures, verified good build on jenkins, built from sources anyway and ran quickstart on the 2.11 binary. Looks good! On Sun, Jun 23, 2019 at 3:06 PM Jakub Scholz wrote: > > +1 (non-binding). I used the binaries and run some of my tests against them. > > On Thu, Jun 20,

Re: [VOTE] KIP-476: Add Java AdminClient interface

2019-06-23 Thread Colin McCabe
Just to give a little context here, the main reason for having the AdminClient#create method is so that end-users didn't have to import KafkaAdminClient. In general, users should be interacting with the AdminClient API, not with the implementation class(es). Also, I have to grudgingly agree th

Re: [DISCUSS] KIP-447: Producer scalability for exactly once semantics

2019-06-23 Thread Guozhang Wang
Hello Boyang, Thanks for the KIP, I have some comments below: 1. "Once transactions are complete, the call will return." This seems different from the existing behavior, in which we would return a retriable CONCURRENT_TRANSACTIONS and let the client to retry, is this intentional? 2. "an overload

Re: [DISCUSS] KIP-479: Add Materialized to Join

2019-06-23 Thread Guozhang Wang
Hi Bill, I think by giving a Materialized param into stream-stream join, it's okay (though still ideal) to say "we still would not expose the store for queries", but it would sound a bit awkward to say "we would also ignore whatever the passed in store supplier but just use our default ones" -- ag

Re: [DISCUSS] KIP-478 Strongly Typed Processor API

2019-06-23 Thread Guozhang Wang
Hello John, Thanks for your detailed explanation, I've done some quick checks on some existing examples that heavily used Processor and the results also makes me worried about my previous statements that "the breakage would not be big". I agree we should maintain compatibility. About the naming i

[jira] [Created] (KAFKA-8590) Replace TxnOffsetCommitRequest request/response with automated protocol

2019-06-23 Thread Boyang Chen (JIRA)
Boyang Chen created KAFKA-8590: -- Summary: Replace TxnOffsetCommitRequest request/response with automated protocol Key: KAFKA-8590 URL: https://issues.apache.org/jira/browse/KAFKA-8590 Project: Kafka

Re: Permissions for creating KIP

2019-06-23 Thread Guozhang Wang
Hello Levani, You should be able to create new wiki page now. Thanks, Guozhang On Sun, Jun 23, 2019 at 3:18 PM Levani Kokhreidze wrote: > Hi, > > Please give me permission for creating KIP < > https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals>. > You can find link t

Permissions for creating KIP

2019-06-23 Thread Levani Kokhreidze
Hi, Please give me permission for creating KIP . You can find link to my profile on confluence here . Kind regards, Levani

Re: Preliminary blog post for the Apache Kafka 2.3.0 release

2019-06-23 Thread Stephane Maarek
The video is ready :) waiting for the release of Kafka 2.3 to make it public. @colin if you want to link it in the blog at some point that'd be great! On Wed., 19 Jun. 2019, 4:03 pm Ron Dagostino, wrote: > Looks great, Colin. > > I have also enjoyed Stephane Maarek's "What's New in Kafka..." ser

Re: [VOTE] 2.3.0 RC3

2019-06-23 Thread Jakub Scholz
+1 (non-binding). I used the binaries and run some of my tests against them. On Thu, Jun 20, 2019 at 12:03 AM Colin McCabe wrote: > Hi all, > > We discovered some problems with the second release candidate (RC2) of > 2.3.0. Specifically, KAFKA-8564. I've created a new RC which includes the > f

[jira] [Created] (KAFKA-8589) Flakey test ResetConsumerGroupOffsetTest#testResetOffsetsExistingTopic

2019-06-23 Thread Boyang Chen (JIRA)
Boyang Chen created KAFKA-8589: -- Summary: Flakey test ResetConsumerGroupOffsetTest#testResetOffsetsExistingTopic Key: KAFKA-8589 URL: https://issues.apache.org/jira/browse/KAFKA-8589 Project: Kafka

Re: [VOTE] KIP-475: New Metric to Measure Number of Tasks on a Connector

2019-06-23 Thread Andrew Schofield
+1 (non-binding). Nice KIP. On 23/06/2019, 17:27, "Gwen Shapira" wrote: +1 from me too On Tue, Jun 18, 2019, 10:30 AM Guozhang Wang wrote: > Cyrus, thanks for the updates, +1. > > On Mon, Jun 17, 2019 at 10:58 PM Cyrus Vafadari > wrote: > > > Many tha

Re: [VOTE] KIP-475: New Metric to Measure Number of Tasks on a Connector

2019-06-23 Thread Gwen Shapira
+1 from me too On Tue, Jun 18, 2019, 10:30 AM Guozhang Wang wrote: > Cyrus, thanks for the updates, +1. > > On Mon, Jun 17, 2019 at 10:58 PM Cyrus Vafadari > wrote: > > > Many thanks for the feedback. Per Gwen's suggestion, I've updated the KIP > > to specify that the task count will be per-wor

Jenkins build is back to normal : kafka-trunk-jdk8 #3747

2019-06-23 Thread Apache Jenkins Server
See

Re: PR review

2019-06-23 Thread M. Manna
I have updated it with my comments - @mjsax could you kindly comment I stopped watching the issue since it sends all updates to all issues to my inbox :) Thanks, On Sat, 22 Jun 2019 at 10:48, M. Manna wrote: > Thanks Matthias. Moved to dev DL now. > > I saw your comment on the PR regarding impo

[jira] [Created] (KAFKA-8588) Leader should stop accepting requests when disconnected from ZK

2019-06-23 Thread jacky (JIRA)
jacky created KAFKA-8588: Summary: Leader should stop accepting requests when disconnected from ZK Key: KAFKA-8588 URL: https://issues.apache.org/jira/browse/KAFKA-8588 Project: Kafka Issue Type: Bu