[jira] [Resolved] (KAFKA-8171) callback needs to be null when addStopReplicaRequestForBrokers when replica state transits to offline

[ https://issues.apache.org/jira/browse/KAFKA-8171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-8171. Resolution: Fixed This was fixed by KAFKA-8237. > callback needs to be null when addStopRe

[jira] [Resolved] (KAFKA-8332) Regression in handling of JoinGroupRequest disallows deterministic protocol selection based on order of preference

[ https://issues.apache.org/jira/browse/KAFKA-8332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-8332. Resolution: Fixed Assignee: Bob Barrett (was: Konstantine Karantasis) > Regression i

Re: backporting KIP-417 to 2.2.1 (secure RMI port)

Agree on that Guozhang, that we should be careful with these behavioral changes But I asked as it is defaulting jmx-ssl-enable and jmx-auth-prop to false and that way maintaining the behavior and any user upgrading to bug-fix shouldn't see any change regarding JMX unless they enable those flags

Build failed in Jenkins: kafka-2.0-jdk8 #263

See Changes: [rhauch] KAFKA-8352 : Fix Connect System test failure 404 Not Found (#6713) -- [...truncated 671.38 KB...] kafka.api.SaslSslAdminClientIntegrationTest > testAclD

Build failed in Jenkins: kafka-2.2-jdk8 #111

See Changes: [rhauch] KAFKA-8352 : Fix Connect System test failure 404 Not Found (#6713) -- [...truncated 2.71 MB...] kafka.coordinator.group.GroupCoordinatorTest > testVali

Re: [VOTE] KIP-455: Create an Administrative API for Replica Reassignment

On Fri, May 10, 2019, at 17:34, Colin McCabe wrote: > On Fri, May 10, 2019, at 16:43, Jason Gustafson wrote: > > Hi Colin, > > > > I think storing reassignment state at the partition level is the right move > > and I also agree that replicas should understand that there is a > > reassignment in pr

Build failed in Jenkins: kafka-trunk-jdk8 #3619

See Changes: [rhauch] KAFKA-8352 : Fix Connect System test failure 404 Not Found (#6713) -- [...truncated 2.41 MB...] org.apache.kafka.streams.processor.internals.GlobalS

Re: backporting KIP-417 to 2.2.1 (secure RMI port)

Hello, For any changes that is KIP-related we usually would not cherry-pick to old bug-fix releases since they usually means API changes, like new configs. On the other hand users upgrading to bug-fix releases are not expecting to see any behavioral or public API changes. Guozhang On Fri, May

Re: [VOTE] KIP-455: Create an Administrative API for Replica Reassignment

On Fri, May 10, 2019, at 16:43, Jason Gustafson wrote: > Hi Colin, > > I think storing reassignment state at the partition level is the right move > and I also agree that replicas should understand that there is a > reassignment in progress. This makes KIP-352 a trivial follow-up for > example. Th

Re: [VOTE] KIP-455: Create an Administrative API for Replica Reassignment

Hi Colin, I think storing reassignment state at the partition level is the right move and I also agree that replicas should understand that there is a reassignment in progress. This makes KIP-352 a trivial follow-up for example. The only doubt I have is whether the leader and isr znode is the righ

[jira] [Resolved] (KAFKA-8352) Connect System Tests are failing with 404

[ https://issues.apache.org/jira/browse/KAFKA-8352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch resolved KAFKA-8352. -- Resolution: Fixed Thanks, [~mageshn]! > Connect System Tests are failing with 404 > --

Build failed in Jenkins: kafka-trunk-jdk11 #509

See Changes: [rhauch] KAFKA-8352 : Fix Connect System test failure 404 Not Found (#6713) -- Started by an SCM change [EnvInject] - Loading node environment variables. Buil

[jira] [Created] (KAFKA-8355) Add static membership to Range assignor

Boyang Chen created KAFKA-8355: -- Summary: Add static membership to Range assignor Key: KAFKA-8355 URL: https://issues.apache.org/jira/browse/KAFKA-8355 Project: Kafka Issue Type: Sub-task

[jira] [Created] (KAFKA-8356) Add static membership to Round Robin assignor

Boyang Chen created KAFKA-8356: -- Summary: Add static membership to Round Robin assignor Key: KAFKA-8356 URL: https://issues.apache.org/jira/browse/KAFKA-8356 Project: Kafka Issue Type: Sub-task

[jira] [Created] (KAFKA-8354) Replace SyncGroup request/response with automated protocol

Boyang Chen created KAFKA-8354: -- Summary: Replace SyncGroup request/response with automated protocol Key: KAFKA-8354 URL: https://issues.apache.org/jira/browse/KAFKA-8354 Project: Kafka Issue Ty

[jira] [Created] (KAFKA-8353) org.apache.kafka.common.errors.TimeoutException: Failed to update metadata after 60000 ms after enabling SASL PLAINTEXT authentication

goutham created KAFKA-8353: -- Summary: org.apache.kafka.common.errors.TimeoutException: Failed to update metadata after 6 ms after enabling SASL PLAINTEXT authentication Key: KAFKA-8353 URL: https://issues.apache.org/

[jira] [Created] (KAFKA-8352) Connect System Tests are failing with 404

Magesh kumar Nandakumar created KAFKA-8352: -- Summary: Connect System Tests are failing with 404 Key: KAFKA-8352 URL: https://issues.apache.org/jira/browse/KAFKA-8352 Project: Kafka I

Re: [VOTE] 2.2.1 RC0

Hi Jason, Sure. I'll wait for your PR to merge before cutting another RC. Thanks! --Vahid On Fri, May 10, 2019 at 9:34 AM Jason Gustafson wrote: > Hi Vahid, > > I'd like to make the case for > https://issues.apache.org/jira/browse/KAFKA-8335. This issue can cause > unbounded growth in the __co

Re: Cleaning up command line tools argument parsing a little

Hi Viktor, I'll admit I've only had an extremely brief look at your code and jira, but it sounds absolutely awesome! Plus it will give us a chance at a fresh start without worrying about breaking existing code using the tools. Of course...at the risk of code duplication.. I'd be absolutely in fav

Re: [VOTE] KIP-464: Defaults for AdminClient#createTopic

Thanks everyone for the comments and discussion! Closing the voting out for this KIP: * 4 Binding (Randall, Manikumar, Colin, Gwen) * 2 Non-Binding (Ryanne, Mickael) Cheers, Almog On Fri, May 10, 2019 at 11:55 AM Gwen Shapira wrote: > +1 (binding) > > On Fri, May 10, 2019 at 9:32 AM Almog Gav

Re: [VOTE] KIP-464: Defaults for AdminClient#createTopic

Thanks, Almog. +1 (binding) for this simpler KIP. On Fri, May 10, 2019 at 11:37 AM Manikumar wrote: > Hi Almog, > > +1 (binding), Thanks for the KIP. > > Thanks, > Manikumar > > On Fri, May 10, 2019 at 10:02 PM Almog Gavra wrote: > > > I'm happy pulling it out into a separate KIP to target the

Re: [VOTE] KIP-464: Defaults for AdminClient#createTopic

+1 (binding) On Fri, May 10, 2019 at 9:32 AM Almog Gavra wrote: > I'm happy pulling it out into a separate KIP to target the discussion. This > one can just introduce the "default" constructor for no partitions or > replicas since we'll need that one whether or not we add the builder. > > Update

[jira] [Resolved] (KAFKA-8339) At-least-once delivery guarantee seemingly not met due to async commit / produce failure race condition

[ https://issues.apache.org/jira/browse/KAFKA-8339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] tdp resolved KAFKA-8339. Resolution: Not A Problem Marking as resolved. This is working as expected from the streams side and the bug is in

backporting KIP-417 to 2.2.1 (secure RMI port)

Hi, thanks for providing a fix for KIP-417 that enables a secure connection to RMI port. This is really a good fix from the security point of view and would be nice to backport to the 2.2.1 Is that planned already?

Kafka 2.3 release update

Hi all, Let's extend the KIP freeze deadline until tomorrow (Saturday) to give the current in-progress votes time to finish. This should be the last extension. Thanks to everyone who voted and reviewed! Feature freeze is coming up soon. Since we normally have it a week after KIP freeze, let

Re: [VOTE] KIP-455: Create an Administrative API for Replica Reassignment

+1 (binding) Looks great, and will be awesome to have this new capability. On Wed, May 8, 2019 at 10:23 PM Colin McCabe wrote: > Hi all, > > I'd like to start the vote for KIP-455: Create an Administrative API for > Replica Reassignment. I think this KIP is important since it will unlock > many

Re: [VOTE] KIP-464: Defaults for AdminClient#createTopic

I'm happy pulling it out into a separate KIP to target the discussion. This one can just introduce the "default" constructor for no partitions or replicas since we'll need that one whether or not we add the builder. Updated the KIP moving the builder to a section in "Rejected Alternatives - Follow

Re: [VOTE] 2.2.1 RC0

Hi Vahid, I'd like to make the case for https://issues.apache.org/jira/browse/KAFKA-8335. This issue can cause unbounded growth in the __consumer_offsets topic when using transactions. I will have a patch ready today. Can we do another RC? Thanks, Jason On Wed, May 8, 2019 at 1:26 PM Vahid Hashe

Build failed in Jenkins: kafka-trunk-jdk8 #3618

See Changes: [matthias] KAFKA-8348: Fix KafkaStreams JavaDocs (#6707) -- [...truncated 4.83 MB...] org.apache.kafka.streams.test.OutputVerifierTest > shouldFailIfKeyIsDif

Re: [VOTE] KIP-464: Defaults for AdminClient#createTopic

Hi Almog, +1 (binding), Thanks for the KIP. Thanks, Manikumar On Fri, May 10, 2019 at 10:02 PM Almog Gavra wrote: > I'm happy pulling it out into a separate KIP to target the discussion. This > one can just introduce the "default" constructor for no partitions or > replicas since we'll need th

Re: [VOTE] KIP-458: Connector Client Config Override Policy

Thanks a lot, Colin. This KIP has now passed voting with 3 binding votes ( Randall, Rajini & Colin) and 1 non-binding vote (Chris). Thanks a lot, everyone for the feedback & discussion on this KIP. On Fri, May 10, 2019 at 9:12 AM Colin McCabe wrote: > +1 (binding). Thanks, Magesh. > > cheers,

Re: [VOTE] KIP-464: Defaults for AdminClient#createTopic

Given that there are still some open questions about the builder, maybe we should put it in a separate KIP? best, Colin On Fri, May 10, 2019, at 09:00, Ryanne Dolan wrote: > +1 (non-binding) for the core feature, but I could take or leave the > builder. > > Ryanne > > On Fri, May 10, 2019 at

Re: [VOTE] KIP-458: Connector Client Config Override Policy

+1 (binding). Thanks, Magesh. cheers, Colin On Thu, May 9, 2019, at 18:31, Randall Hauch wrote: > I'm still +1 and like the simplification. > > Randall > > On Thu, May 9, 2019 at 5:54 PM Magesh Nandakumar > wrote: > > > I have updated the KIP to remove the `Ignore` policy and also the > > us

Re: [VOTE] KIP-464: Defaults for AdminClient#createTopic

+1 (non-binding) for the core feature, but I could take or leave the builder. Ryanne On Fri, May 10, 2019 at 10:43 AM Almog Gavra wrote: > @Ismael - I agree that the methods are a little random. They were just > ported from what's currently in the connect builder. I think a better > option migh

[jira] [Resolved] (KAFKA-7858) Replace JoinGroup request/response with automated protocol

[ https://issues.apache.org/jira/browse/KAFKA-7858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Chen resolved KAFKA-7858. Resolution: Fixed > Replace JoinGroup request/response with automated protocol > --

[jira] [Created] (KAFKA-8351) Log cleaner must handle transactions spanning multiple segments

Jason Gustafson created KAFKA-8351: -- Summary: Log cleaner must handle transactions spanning multiple segments Key: KAFKA-8351 URL: https://issues.apache.org/jira/browse/KAFKA-8351 Project: Kafka

Re: [VOTE] KIP-464: Defaults for AdminClient#createTopic

@Ismael - I agree that the methods are a little random. They were just ported from what's currently in the connect builder. I think a better option might be to keep the connect builder around and have extend from this builder, and make this builder only implement the "critical" methods (e.g. replic

Re: [DISCUSS] KIP-464 Default Replication Factor for AdminClient#createTopic

The cut-off line for the builder was to just port whatever is currently in connect so that we don't break the APIs there. Perhaps it's better to just introduce the critical methods (partitions/replicas/configs) and have the one in connect just extend the new one. On Fri, May 10, 2019 at 3:24 AM Ma

Re: [VOTE] KIP-464: Defaults for AdminClient#createTopic

The current builder includes random methods like uncleanLeaderElection. That doesn't make sense to me since it's a topic config (and we don't include methods for other topic configs). Also, I'm not sure about the naming convention, should we have a `with` prefix? It would be good to check existing

Jenkins build is back to normal : kafka-2.1-jdk8 #186

See

Re: [VOTE] KIP-464: Defaults for AdminClient#createTopic

+! (binding) on the current KIP with the builder, based on the fact that the builder simplifies usage vs adding other constructors and is more easily extended over time. Randall On Thu, May 9, 2019 at 5:38 PM Almog Gavra wrote: > Thanks Colin! Since the discussion around the builder is here I'l

Re: [DISCUSS] KIP-466: Add support for List serialization and deserialization

Good observation, Daniyar. Maybe we should just not implement support for serdeFrom. We can always add it later, but I think you're right, we need some kind of more sophisticated support, or at least a second argument for the inner class. For now, it seems like most use cases would be satisfied

Jenkins build is back to normal : kafka-2.2-jdk8 #110

See

Re: [DISCUSS] KIP-466: Add support for List serialization and deserialization

Hi, I was trying to add some test cases for the list serde, and it led me to this class `org.apache.kafka.common.serialization.SerializationTest`. I saw that it relies on method `org.apache.kafka.common.serialization.serdeFrom(Class type)` Now, I’m not sure how to adapt List serde for this met

Jenkins build is back to normal : kafka-2.0-jdk8 #262

See

Build failed in Jenkins: kafka-1.1-jdk7 #263

See Changes: [matthias] KAFKA-8348: Fix KafkaStreams JavaDocs (#6707) -- [...truncated 427.30 KB...] kafka.server.KafkaConfigTest > testValidCompressionType STARTED kafka.s

Build failed in Jenkins: kafka-trunk-jdk8 #3617

See Changes: [cshapi] MINOR: docs typo in '--zookeeper myhost:2181--execute' [cshapi] KAFKA-8344; Fix vagrant-up.sh to work with AWS properly [cshapi] MINOR: Add missing option for running vagrant-up.sh with AW

Jenkins build is back to normal : kafka-1.0-jdk7 #269

See

Build failed in Jenkins: kafka-trunk-jdk11 #508

See Changes: [matthias] KAFKA-8348: Fix KafkaStreams JavaDocs (#6707) -- Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on H3

Re: [DISCUSS] KIP-464 Default Replication Factor for AdminClient#createTopic

I minor comment about `.compacted()` method: It might be better to change to `cleanupPolicy(CleanupPolicy)` and add an enum `CleanupPolicy` with fields `DELETE`, `COMPACT`, `DELETE_COMPACT`. Also, for the cleanup policy, what about retention time vs size? I am also wondering, what the cut-off li

[jira] [Resolved] (KAFKA-8348) Document of kafkaStreams improvement

[ https://issues.apache.org/jira/browse/KAFKA-8348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lifei Chen resolved KAFKA-8348. --- Resolution: Fixed > Document of kafkaStreams improvement > > >

[jira] [Created] (KAFKA-8350) Splitting batches should consider topic-level message size

huxihx created KAFKA-8350: - Summary: Splitting batches should consider topic-level message size Key: KAFKA-8350 URL: https://issues.apache.org/jira/browse/KAFKA-8350 Project: Kafka Issue Type: Improv

[jira] [Created] (KAFKA-8349) Add Windows batch files corresponding to kafka-delete-records.sh and kafka-log-dirs.sh

Kengo Seki created KAFKA-8349: - Summary: Add Windows batch files corresponding to kafka-delete-records.sh and kafka-log-dirs.sh Key: KAFKA-8349 URL: https://issues.apache.org/jira/browse/KAFKA-8349 Projec

Build failed in Jenkins: kafka-2.2-jdk8 #109

See Changes: [rhauch] MINOR: Remove header and key/value converter config value logging -- [...truncated 2.67 MB...] kafka.controller.PartitionLeaderElectionAlgorithmsTest >

Build failed in Jenkins: kafka-trunk-jdk8 #3616

See Changes: [rhauch] KAFKA-8231: Expansion of ConnectClusterState interface (#6584) [rhauch] MINOR: Remove header and key/value converter config value logging -- [...tru