Re: [DISCUSS] KIP-388 Add observer interface to record request and response

2018-11-17 Thread Patrick Huang
Hi Lincong, Thanks for the KIP. If I understand correctly, the reason for having RequestInfo and ResponseInfo is that you want to pre-define what information can be exposed to the observer. Users cannot implement RequestAdapter/ResponseAdapter and they are just internal helper classes to extra

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-11-17 Thread Dong Lin
Hey Boyang, Thanks for the proposal! This is very useful. I have some comments below: 1) The motivation currently explicitly states that the goal is to improve performance for heavy state application. It seems that the motivation can be stronger with the following use-case. Currently for MirrorMa

Re: [VOTE] 2.1.0 RC1

2018-11-17 Thread Jakub Scholz
+1 (non-binding) ... I used the staged artifacts and binaries and run my tests On Sat, Nov 10, 2018 at 12:33 AM Dong Lin wrote: > Hello Kafka users, developers and client-developers, > > This is the second candidate for feature release of Apache Kafka 2.1.0. > > This is a major version release o

Re: [DISCUSS] KIP-378: Enable Dependency Injection for Kafka Streams handlers

2018-11-17 Thread Guozhang Wang
Hello folks, I'd like to revive this thread for discussion. After reading the previous emails I think I'm still a bit leaning towards re-enabling to pass in StreamsConfig to Kafka Streams constructors compared with a ConfiguredStreamsFactory as additional parameters to overloaded KafkaStreams cons

Re: [DISCUSS] KIP-388 Add observer interface to record request and response

2018-11-17 Thread Dong Lin
Hey Lincong, The main concern for the original version of the KIP is that, if we expose internal classes such as RequestChannel.Request and AbstractResponse, it will be difficult to make change to those internal classes in the future. In the latest version of the KIP, it seems that user is going

[jira] [Created] (KAFKA-7652) Kafka Streams Session store performance degradation from 0.10.2.2 to 0.11.0.0

2018-11-17 Thread Jonathan Gordon (JIRA)
Jonathan Gordon created KAFKA-7652: -- Summary: Kafka Streams Session store performance degradation from 0.10.2.2 to 0.11.0.0 Key: KAFKA-7652 URL: https://issues.apache.org/jira/browse/KAFKA-7652 Proje

Re: [VOTE] 2.1.0 RC1

2018-11-17 Thread Manikumar
+1 I've verified signature, docs, built from sources, ran unit tests (no test failures observed) ran quick start. Thanks for running the release!. Thanks, Manikumar On Sat, Nov 17, 2018 at 1:10 PM Dong Lin wrote: > Hey Eno, Vahid and everyone, > > Thanks for reporting the test error! > https: