Re: Throwing away prefetched records optimisation.

2018-10-23 Thread Zahari Dichev
Colin, I agree I will take a closer looks at the Fetcher itself and see whether that is feasible and update my KIP accordingly. I guess we can label this one, the official discussion thread for it or should I start another one ? Zahari On Wed, Oct 24, 2018 at 6:43 AM Colin McCabe wrote: > On T

Kafka-node: Kafka client keeps sending request to broker which went down

2018-10-23 Thread Shashank Sah
When a broker host goes down/restarts, the kafka client keeps sending the new requests to the same hosts address. As a result, the requests are failing with this error: Request timed out after 3ms. Node version: v6.8.1 Kafka-node version: 3.0.1 Kafka version: 2.11-2.0.0 Number of Brokers: 3 Nu

Jenkins build is back to normal : kafka-2.1-jdk8 #38

2018-10-23 Thread Apache Jenkins Server
See

Re: Throwing away prefetched records optimisation.

2018-10-23 Thread Colin McCabe
On Tue, Oct 23, 2018, at 12:38, Zahari Dichev wrote: > Hi there Matthias, I looked through the code of Kafka Streams. Quite > impressive work ! If I have to put the logic of buffering within the > context of what we are doing in Akka though, I might end up with the > following situation. > > 1. Po

Jenkins build is back to normal : kafka-trunk-jdk8 #3156

2018-10-23 Thread Apache Jenkins Server
See

Build failed in Jenkins: kafka-trunk-jdk11 #51

2018-10-23 Thread Apache Jenkins Server
See Changes: [github] MINOR: fix docs typo (#5827) -- [...truncated 2.36 MB...] org.apache.kafka.streams.test.OutputVerifierTest > shouldFailIfKeyIsDifferentWithNullRever

[jira] [Created] (KAFKA-7536) TopologyTestDriver cannot pre-populate GlobalKTable

2018-10-23 Thread Dmitry Minkovsky (JIRA)
Dmitry Minkovsky created KAFKA-7536: --- Summary: TopologyTestDriver cannot pre-populate GlobalKTable Key: KAFKA-7536 URL: https://issues.apache.org/jira/browse/KAFKA-7536 Project: Kafka Issue

Re: Throwing away prefetched records optimisation.

2018-10-23 Thread Matthias J. Sax
Thanks for the detailed explanation. -Matthias On 10/23/18 12:38 PM, Zahari Dichev wrote: > Hi there Matthias, I looked through the code of Kafka Streams. Quite > impressive work ! If I have to put the logic of buffering within the > context of what we are doing in Akka though, I might end up wit

Re: [DISCUSS] KIP-382: MirrorMaker 2.0

2018-10-23 Thread Ryanne Dolan
Alex, thanks for the feedback. > Would it be possible to utilize the > Message Headers feature to prevent infinite recursion This isn't necessary due to the topic renaming feature which already prevents infinite recursion. If you turn off topic renaming you lose cycle detection, so maybe we coul

Re: Throwing away prefetched records optimisation.

2018-10-23 Thread Zahari Dichev
Hi there Matthias, I looked through the code of Kafka Streams. Quite impressive work ! If I have to put the logic of buffering within the context of what we are doing in Akka though, I might end up with the following situation. 1. Poll is called with two partition being active *TP1, TP2* 2. We get

Re: [VOTE] KIP-331 Add default implementation to close() and configure() for Serializer, Deserializer and Serde

2018-10-23 Thread Chia-Ping Tsai
We have following votes: non-binding 1. John Roesler 2. vito jeng 3. Richard Yu 4. Bill Bejeck 5. Satish Duggana binding 1. Matthias J. Sax 2. Ismael Juma 3. Damian Guy KIP-331 has passed. Thanks for all votes -- Chia-Ping On 2018/07/05 14:45:01, Chia-Ping Tsai wrote: > hi all, > > I would

[jira] [Resolved] (KAFKA-5824) Cannot write to key value store provided by ProcessorTopologyTestDriver

2018-10-23 Thread Matthias J. Sax (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax resolved KAFKA-5824. Resolution: Won't Fix Resolving this, because `ProcessorTopologyTestDriver` is an internal

Re: [DISCUSS] KIP-386: Make Min metrics' default value consistent with Max metrics

2018-10-23 Thread Kevin Lu
Hi Stanislav, Thanks for the KIP! Standardizing this would be extremely helpful. We have been publishing client-side metrics to a time-series database using metrics reporter since 0.8, and we had to do explicit checks like "!Double.isNaN(metricValue)", "metricValue != Double.NEGATIVE_INFINITY", a

[jira] [Created] (KAFKA-7535) KafkaConsumer doesn't report records-lag if isolation.level is read_committed

2018-10-23 Thread Alexey Vakhrenev (JIRA)
Alexey Vakhrenev created KAFKA-7535: --- Summary: KafkaConsumer doesn't report records-lag if isolation.level is read_committed Key: KAFKA-7535 URL: https://issues.apache.org/jira/browse/KAFKA-7535 Pro

RE: [DISCUSS] KIP-383 Pluggable interface for SSL Factory

2018-10-23 Thread Pellerin, Clement
1) I agree that signature pattern is cleaner. To support this, we have to give up inheriting Reconfigurable. That's exactly what you propose when you want to keep reconfiguration in the non-pluggable class. 2) I agree reconfiguration and the option to validate keystores against truststores do

[jira] [Created] (KAFKA-7534) Error during CachingKeyValueStore.flush may not allow RocksDB to close

2018-10-23 Thread Bill Bejeck (JIRA)
Bill Bejeck created KAFKA-7534: -- Summary: Error during CachingKeyValueStore.flush may not allow RocksDB to close Key: KAFKA-7534 URL: https://issues.apache.org/jira/browse/KAFKA-7534 Project: Kafka

[jira] [Created] (KAFKA-7532) Missing stringification in error message "Removed ArrayBuffer() from list of shutting down brokers. (kafka.controller.KafkaController)"

2018-10-23 Thread Andreas Kohn (JIRA)
Andreas Kohn created KAFKA-7532: --- Summary: Missing stringification in error message "Removed ArrayBuffer() from list of shutting down brokers. (kafka.controller.KafkaController)" Key: KAFKA-7532 URL: https://issues

Re: [DISCUSS] KIP-383 Pluggable interface for SSL Factory

2018-10-23 Thread Rajini Sivaram
Thanks for the PR. A couple of comments: 1) For other public interfaces, we use parameters to configure instead of internal config names going into the same list of configs. Kafka has public config names and custom config names that don't conflict with public config names. These internal config na

Re: [DISCUSS] KIP-382: MirrorMaker 2.0

2018-10-23 Thread Alex Mironov
Hey Ryanne, Awesome KIP, exited to see improvements in MirrorMaker land, I particularly like the reuse of Connect framework! Would it be possible to utilize the Message Headers feature to prevent infinite recursion? For example, MM2 could stamp every message with a special header payload (e.g. MM2

Re: [DISCUSS] KIP-386: Make Min metrics' default value consistent with Max metrics

2018-10-23 Thread Stanislav Kozlovski
Hey John, I think NaN would be the better option semantically. If we were to use that, maybe it makes sense to change `Avg()`'s default value from 0.0 to NaN as well. I am a bit more concerned with backwards compatibility if we were to use NaN since we would change three types of metrics. There w

Re: [DISCUSS] KIP-380: Detect outdated control requests and bounced brokers using broker generation

2018-10-23 Thread Patrick Huang
Agreed. I have updated the PR to add czxid in ControlledShutdownRequest (https://github.com/apache/kafka/pull/5821). Appreciated if you can take a look. Btw, I also have the vote thread for this KIP: https://lists.apache.org/thread.html/3689d83db537d5aa86d10967dee7ee29578897fc123daae4f77a8605@%3

[jira] [Created] (KAFKA-7531) NPE NullPointerException at TransactionCoordinator handleEndTransaction

2018-10-23 Thread JIRA
Sebastian PuzoƄ created KAFKA-7531: -- Summary: NPE NullPointerException at TransactionCoordinator handleEndTransaction Key: KAFKA-7531 URL: https://issues.apache.org/jira/browse/KAFKA-7531 Project: Ka