Re: [DISCUSS] KIP-221: Repartition Topic Hints in Streams

2017-11-05 Thread Jan Filipiak
That would be nice I think On 05.11.2017 23:02, Matthias J. Sax wrote: My idea was, to relax the requirement for through() that a topic must be created manually before startup. Thus, if no through() call is made, a (internal) topic is created the same way we do it currently. If one uses `throu

[GitHub] kafka pull request #4180: Update kafka-server-stop.sh

2017-11-05 Thread pengkeboy
GitHub user pengkeboy opened a pull request: https://github.com/apache/kafka/pull/4180 Update kafka-server-stop.sh This script does not work on Kafka1.0. Kafka1.0 work well to use this script to stop the process. You can merge this pull request into a Git repository by running:

Re: kafka-pr-jdk9-scala2.12 keeps failing

2017-11-05 Thread Ted Yu
Logged https://issues.apache.org/jira/browse/INFRA-15448 On Thu, Nov 2, 2017 at 11:39 PM, Ismael Juma wrote: > This looks to be an issue in Jenkins, not in Kafka. Apache Infra updated > Java 9 to 9.0.1 and it seems to have broken some of the Jenkins code. > > Ismael > > On 3 Nov 2017 1:53 am, "T

Build failed in Jenkins: kafka-trunk-jdk7 #2947

2017-11-05 Thread Apache Jenkins Server
See Changes: [becket.qin] KAFKA-6157; Fix repeated words words in JavaDoc and comments. -- [...truncated 377.60 KB...] kafka.coordinator.transaction.TransactionCoordinator

Build failed in Jenkins: kafka-trunk-jdk9 #170

2017-11-05 Thread Apache Jenkins Server
See Changes: [becket.qin] KAFKA-6157; Fix repeated words words in JavaDoc and comments. -- Started by an SCM change [EnvInject] - Loading node environment variables. Buildi

Re: [DISCUSS]KIP-216: IQ should throw different exceptions for different errors

2017-11-05 Thread vito jeng
Thanks, Guozhang and Matthias. Your comments very useful for me. I'll update KIP and keep going on. --- Vito On Sun, Nov 5, 2017 at 12:30 AM, Matthias J. Sax wrote: > Thanks for the KIP Vito! > > I agree with what Guozhang said. The original idea of the Jira was, to > give different exceptio

[jira] [Resolved] (KAFKA-3908) Set SendBufferSize for socket used by Processor

2017-11-05 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin resolved KAFKA-3908. - Resolution: Not A Problem > Set SendBufferSize for socket used by Processor >

[jira] [Resolved] (KAFKA-6078) Investigate failure of ReassignPartitionsClusterTest.shouldExpandCluster

2017-11-05 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin resolved KAFKA-6078. - Resolution: Cannot Reproduce > Investigate failure of ReassignPartitionsClusterTest.shouldExpandCluster >

[jira] [Resolved] (KAFKA-5759) Allow user to specify relative path as log directory

2017-11-05 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin resolved KAFKA-5759. - Resolution: Fixed > Allow user to specify relative path as log directory > ---

[GitHub] kafka pull request #4170: KAFKA-6157: Fix repeated words words in JavaDoc an...

2017-11-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/4170 ---

Re: [VOTE] KIP-204 : adding records deletion operation to the new Admin Client API

2017-11-05 Thread Kamal
+1 (non-binding) On Thu, Nov 2, 2017 at 2:13 PM, Paolo Patierno wrote: > Thanks Jason ! > > > I have just updated the KIP with DeleteRecordsOptions definition. > > > Paolo Patierno > Senior Software Engineer (IoT) @ Red Hat > Microsoft MVP on Azure & IoT > Microsoft Azure Advisor > > Twitter : @

Re: [DISCUSS] KIP-220: Add AdminClient into Kafka Streams' ClientSupplier

2017-11-05 Thread Guozhang Wang
Thanks Matthias, 1) Updated the KIP page to include KAFKA-6126. 2) For passing configs, I agree, will make a pass over the existing configs passed to StreamsKafkaClient and update the wiki page accordingly, to capture all changes that would happen for the replacement in this single KIP. 3) For int

Re: [DISCUSS] KIP-220: Add AdminClient into Kafka Streams' ClientSupplier

2017-11-05 Thread Guozhang Wang
Thanks Ted, has updated the KIP. On Fri, Nov 3, 2017 at 8:01 PM, Ted Yu wrote: > Looks good overall. > > bq. the creation within StreamsPartitionAssignor > > Typo above: should be StreamPartitionAssignor > > On Fri, Nov 3, 2017 at 4:49 PM, Guozhang Wang wrote: > > > Hello folks, > > > > I have

Re: [DISCUSS] KIP-221: Repartition Topic Hints in Streams

2017-11-05 Thread Matthias J. Sax
My idea was, to relax the requirement for through() that a topic must be created manually before startup. Thus, if no through() call is made, a (internal) topic is created the same way we do it currently. If one uses `through(String topicName)` we keep the current behavior and require users to cr

[GitHub] kafka pull request #4179: KAFKA-6175; AbstractIndex should cache index file ...

2017-11-05 Thread lindong28
GitHub user lindong28 opened a pull request: https://github.com/apache/kafka/pull/4179 KAFKA-6175; AbstractIndex should cache index file to avoid unnecessary disk access during resize() You can merge this pull request into a Git repository by running: $ git pull https://githu

[jira] [Created] (KAFKA-6175) AbstractIndex should cache index file to avoid unnecessary disk access during resize()

2017-11-05 Thread Dong Lin (JIRA)
Dong Lin created KAFKA-6175: --- Summary: AbstractIndex should cache index file to avoid unnecessary disk access during resize() Key: KAFKA-6175 URL: https://issues.apache.org/jira/browse/KAFKA-6175 Project: K

[GitHub] kafka pull request #4178: 0.10.1

2017-11-05 Thread bbobbadi
GitHub user bbobbadi opened a pull request: https://github.com/apache/kafka/pull/4178 0.10.1 You can merge this pull request into a Git repository by running: $ git pull https://github.com/confluentinc/kafka 0.10.1 Alternatively you can review and apply these changes as the p

[jira] [Created] (KAFKA-6174) Investigate binary incompatibility issued in DescribeClusterOptions between 0.11 and 1.0

2017-11-05 Thread Dong Lin (JIRA)
Dong Lin created KAFKA-6174: --- Summary: Investigate binary incompatibility issued in DescribeClusterOptions between 0.11 and 1.0 Key: KAFKA-6174 URL: https://issues.apache.org/jira/browse/KAFKA-6174 Project:

Re: [DISCUSS] KIP-210: Provide for custom error handling when Kafka Streams fails to produce

2017-11-05 Thread Matt Farmer
It is agreed, then. I've updated the pull request. I'm trying to also update the KIP accordingly, but cwiki is being slow and dropping connections. I'll try again a bit later but please consider the KIP updated for all intents and purposes. heh. On Sun, Nov 5, 2017 at 3:45 PM Guozhang Wang wr

Re: [DISCUSS] KIP-210: Provide for custom error handling when Kafka Streams fails to produce

2017-11-05 Thread Guozhang Wang
That makes sense. Guozhang On Sun, Nov 5, 2017 at 12:33 PM, Matt Farmer wrote: > Interesting. I'm not sure I agree. I've been bitten many times by > unintentionally shipping code that fails to properly implement logging. I > always discover this at the exact *worst* moment, too. (Normally at 3

Re: [DISCUSS] KIP-210: Provide for custom error handling when Kafka Streams fails to produce

2017-11-05 Thread Matt Farmer
Interesting. I'm not sure I agree. I've been bitten many times by unintentionally shipping code that fails to properly implement logging. I always discover this at the exact *worst* moment, too. (Normally at 3 AM during an on-call shift. Hah.) However, if others feel the same way I could probably b

Re: [DISCUSS] KIP-210: Provide for custom error handling when Kafka Streams fails to produce

2017-11-05 Thread Guozhang Wang
Thanks for the updates. I made a pass over the wiki again and it looks good. About whether record collector should still internally log the error in addition to what the customized ProductionExceptionHandler does. I personally would prefer only to log if the returned value is FAIL to indicate that

[jira] [Created] (KAFKA-6173) Leader should stop accepting requests when disconnected from ZK

2017-11-05 Thread Kostas Christidis (JIRA)
Kostas Christidis created KAFKA-6173: Summary: Leader should stop accepting requests when disconnected from ZK Key: KAFKA-6173 URL: https://issues.apache.org/jira/browse/KAFKA-6173 Project: Kafka

Re: [DISCUSS] KIP-210: Provide for custom error handling when Kafka Streams fails to produce

2017-11-05 Thread Matt Farmer
Hello, a bit later than I'd anticipated, but I've updated this KIP as outlined above. The updated KIP is now ready for review again! On Sat, Nov 4, 2017 at 1:03 PM Matt Farmer wrote: > Ah. I actually created both of those in the PR and forgot to mention them > by name in the KIP! Thanks for poin

[GitHub] kafka pull request #4177: KAFKA-6172; Cache lastEntry in TimeIndex to avoid ...

2017-11-05 Thread lindong28
GitHub user lindong28 opened a pull request: https://github.com/apache/kafka/pull/4177 KAFKA-6172; Cache lastEntry in TimeIndex to avoid unnecessary disk access You can merge this pull request into a Git repository by running: $ git pull https://github.com/lindong28/kafka KAFK

[jira] [Created] (KAFKA-6172) Cache lastEntry in TimeIndex to avoid unnecessary disk access

2017-11-05 Thread Dong Lin (JIRA)
Dong Lin created KAFKA-6172: --- Summary: Cache lastEntry in TimeIndex to avoid unnecessary disk access Key: KAFKA-6172 URL: https://issues.apache.org/jira/browse/KAFKA-6172 Project: Kafka Issue Type