Build failed in Jenkins: kafka-trunk-jdk7 #2483

2017-06-30 Thread Apache Jenkins Server
See Changes: [jason] KAFKA-5522; ListOffsets should bound timestamp search by LSO in -- [...truncated 966.00 KB...] kafka.server.ServerGenerateClusterIdTest > testAutoGen

[jira] [Created] (KAFKA-5550) Struct.put() should include the field name if validation fails

2017-06-30 Thread Jeremy Custenborder (JIRA)
Jeremy Custenborder created KAFKA-5550: -- Summary: Struct.put() should include the field name if validation fails Key: KAFKA-5550 URL: https://issues.apache.org/jira/browse/KAFKA-5550 Project: Kaf

[GitHub] kafka pull request #3474: KAFKA-5548 - Extended validation for SchemaBuilder...

2017-06-30 Thread jcustenborder
GitHub user jcustenborder opened a pull request: https://github.com/apache/kafka/pull/3474 KAFKA-5548 - Extended validation for SchemaBuilder methods. More input validation for SchemaBuilder methods. You can merge this pull request into a Git repository by running: $ git pull h

[GitHub] kafka pull request #3473: MINOR: Follow-up Streams doc changes to break into...

2017-06-30 Thread guozhangwang
GitHub user guozhangwang opened a pull request: https://github.com/apache/kafka/pull/3473 MINOR: Follow-up Streams doc changes to break into sub-pages Also fixed a bunch of broken links (details can be found in https://github.com/apache/kafka-site/commit/34f8ecea0db15523ce4b81e6b6bc

Re: [DISCUSS] KIP-173: Add prefix to StreamsConfig to enable setting default internal topic configs

2017-06-30 Thread Guozhang Wang
Thanks for the proposal Damian. The PR looks promising to me. One minor comment for the wiki page is that you can add some example on how to call the proposed interface (e.g. the ones you added in unit test in the PR). Another question is that this variable will not be included in the web docs in

[jira] [Resolved] (KAFKA-5522) ListOffset should take LSO into account when searching by timestamp

2017-06-30 Thread Jason Gustafson (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-5522. Resolution: Fixed Issue resolved by pull request 3456 [https://github.com/apache/kafka/pull/

[GitHub] kafka pull request #3456: KAFKA-5522: ListOffsets should bound timestamp sea...

2017-06-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/3456 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] kafka-site pull request #58: Break apart Streams docs

2017-06-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka-site/pull/58 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] kafka-site issue #58: Break apart Streams docs

2017-06-30 Thread guozhangwang
Github user guozhangwang commented on the issue: https://github.com/apache/kafka-site/pull/58 Merged to `asf-site`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wi

[GitHub] kafka-site pull request #58: Break apart Streams docs

2017-06-30 Thread guozhangwang
Github user guozhangwang commented on a diff in the pull request: https://github.com/apache/kafka-site/pull/58#discussion_r125140531 --- Diff: includes/_footer.htm --- @@ -32,7 +32,8 @@ 'streams', 'quickstart',

[jira] [Resolved] (KAFKA-5542) Improve Java doc for LeaderEpochFileCache.endOffsetFor()

2017-06-30 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-5542. Resolution: Fixed Fix Version/s: 0.11.1.0 Issue resolved by pull request 3468 [https://github.com/apa

[GitHub] kafka pull request #3468: KAFKA-5542: Improve Java doc for LeaderEpochFileCa...

2017-06-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/3468 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] kafka pull request #3472: MINOR: Upgraded RocksDB to 5.1.2

2017-06-30 Thread enothereska
GitHub user enothereska opened a pull request: https://github.com/apache/kafka/pull/3472 MINOR: Upgraded RocksDB to 5.1.2 You can merge this pull request into a Git repository by running: $ git pull https://github.com/enothereska/kafka minor-upgrade-rocksdb-5.1.2 Alternativel

[jira] [Created] (KAFKA-5549) Explain that `client.id` is just used as a prefix within Streams

2017-06-30 Thread Matthias J. Sax (JIRA)
Matthias J. Sax created KAFKA-5549: -- Summary: Explain that `client.id` is just used as a prefix within Streams Key: KAFKA-5549 URL: https://issues.apache.org/jira/browse/KAFKA-5549 Project: Kafka

[GitHub] kafka pull request #3454: MINOR: Compatibility and upgrade tests for 0.11.0....

2017-06-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/3454 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

Re: [DISCUSS] Streams DSL/StateStore Refactoring

2017-06-30 Thread Matthias J. Sax
On 6/30/17 10:49 AM, Damian Guy wrote: > On Fri, 30 Jun 2017 at 18:40 Matthias J. Sax wrote: > >>> Hmmm, i don't agree. Until is a property of the window. It is going to be >>> potentially different for every window operation you do in a streams app. >> >> I am not sure. >> >> (1) for me, it is

[jira] [Created] (KAFKA-5548) SchemaBuilder does not validate input.

2017-06-30 Thread Jeremy Custenborder (JIRA)
Jeremy Custenborder created KAFKA-5548: -- Summary: SchemaBuilder does not validate input. Key: KAFKA-5548 URL: https://issues.apache.org/jira/browse/KAFKA-5548 Project: Kafka Issue Type:

Re: [DISCUSS] KIP-167: Add interface for the state store restoration process

2017-06-30 Thread Bill Bejeck
Hi Eno, Thanks for the comment. Depending on how users implement the `onBatchRestore` it could potentially slow down the restoration. However IMHO it shouldn't present an issue as in practice I suspect users simply want a status update of how far along the restoration process has progressed. Bu

[GitHub] kafka-site pull request #58: Break apart Streams docs

2017-06-30 Thread derrickdoo
Github user derrickdoo commented on a diff in the pull request: https://github.com/apache/kafka-site/pull/58#discussion_r125121166 --- Diff: includes/_footer.htm --- @@ -32,7 +32,8 @@ 'streams', 'quickstart',

[GitHub] kafka-site pull request #58: Break apart Streams docs

2017-06-30 Thread guozhangwang
Github user guozhangwang commented on a diff in the pull request: https://github.com/apache/kafka-site/pull/58#discussion_r125117603 --- Diff: includes/_footer.htm --- @@ -32,7 +32,8 @@ 'streams', 'quickstart',

[GitHub] kafka pull request #3467: MINOR: InFlightRequests#isEmpty(node) method corre...

2017-06-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/3467 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] kafka pull request #3471: MINOR: Add test brokers to list as they are create...

2017-06-30 Thread rajinisivaram
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/3471 MINOR: Add test brokers to list as they are created to ensure cleanup You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka

[jira] [Created] (KAFKA-5547) Return topic authorization failed if no topic describe access

2017-06-30 Thread Jason Gustafson (JIRA)
Jason Gustafson created KAFKA-5547: -- Summary: Return topic authorization failed if no topic describe access Key: KAFKA-5547 URL: https://issues.apache.org/jira/browse/KAFKA-5547 Project: Kafka

Re: pull request #2755: request for review

2017-06-30 Thread Gwen Shapira
Sorry for the delay :) I think it is a good contribution and helpful - early feedback is great for user experience. Left few comments. On Fri, Jun 30, 2017 at 2:08 AM Sönke Liebau wrote: > The pull request has been open for a while now, can someone please have a > look at whether this is still v

[GitHub] kafka pull request #3470: MINOR: Changed javadoc on KafkaConsumer#endOffsets...

2017-06-30 Thread ekenny
GitHub user ekenny opened a pull request: https://github.com/apache/kafka/pull/3470 MINOR: Changed javadoc on KafkaConsumer#endOffsets to mention end offset for… Existing javadoc fails to mention that endOffsets returns zero for empty TopicPartitions. Just added that important l

Re: [DISCUSS] Streams DSL/StateStore Refactoring

2017-06-30 Thread Damian Guy
On Fri, 30 Jun 2017 at 18:40 Matthias J. Sax wrote: > > Hmmm, i don't agree. Until is a property of the window. It is going to be > > potentially different for every window operation you do in a streams app. > > I am not sure. > > (1) for me, it is definitely a config for the operator for how lon

Re: [DISCUSS] Streams DSL/StateStore Refactoring

2017-06-30 Thread Matthias J. Sax
> Hmmm, i don't agree. Until is a property of the window. It is going to be > potentially different for every window operation you do in a streams app. I am not sure. (1) for me, it is definitely a config for the operator for how long windows are maintained. It's not part of the window definition

Re: [DISCUSS] KIP-167: Add interface for the state store restoration process

2017-06-30 Thread Eno Thereska
Thanks Bill, My only remaining question is whether we expect that calling `onBatchRestore` after each `poll` could slow down the restoration? Thanks Eno > On Jun 30, 2017, at 4:27 PM, Bill Bejeck wrote: > > Damian, > > Thanks for comments. I've updated the KIP with the abstract classes. >

[GitHub] kafka pull request #3360: KAFKA-5020: Update message format in implementatio...

2017-06-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/3360 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] kafka pull request #3469: MINOR: remove unused eosEnabled field from Process...

2017-06-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/3469 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] kafka pull request #3469: MINOR: remove unused eosEnabled field from Process...

2017-06-30 Thread dguy
GitHub user dguy opened a pull request: https://github.com/apache/kafka/pull/3469 MINOR: remove unused eosEnabled field from ProcessorStateManager remove unused eosEnabled field from ProcessorStateManager You can merge this pull request into a Git repository by running: $ git p

Re: [DISCUSS] KIP-167: Add interface for the state store restoration process

2017-06-30 Thread Bill Bejeck
Damian, Thanks for comments. I've updated the KIP with the abstract classes. Thanks, Bill On Fri, Jun 30, 2017 at 9:57 AM, Damian Guy wrote: > Thanks for the updated KIP Bill. > > In the PR you have AbstractBatchingRestoreCallback and > AbstractNotifyingRestoreCallback which are both in publi

[jira] [Resolved] (KAFKA-5539) Kafka Connect plugin.path is not used

2017-06-30 Thread Randall Hauch (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch resolved KAFKA-5539. -- Resolution: Invalid Kafka Connect's plugin path feature was added in 0.11.0.0, and does not exis

Re: new contributor request

2017-06-30 Thread Jun Rao
Hi, Peter, Thanks for your interest. Just added you to the contributor list. Jun On Fri, Jun 30, 2017 at 5:08 AM, Peter Toth wrote: > Hi, > > Could you please add me to the kafka contributors list? My user name is: > ptoth > > Thanks, > Peter >

new contributor request

2017-06-30 Thread Peter Toth
Hi, Could you please add me to the kafka contributors list? My user name is: ptoth Thanks, Peter

Re: [DISCUSS] KIP-167: Add interface for the state store restoration process

2017-06-30 Thread Damian Guy
Thanks for the updated KIP Bill. In the PR you have AbstractBatchingRestoreCallback and AbstractNotifyingRestoreCallback which are both in public packages, so are part of the API. I think you need to add those to the KIP to round it off. Otherwise LGTM. Thanks, Damian On Fri, 30 Jun 2017 at 12:

[jira] [Created] (KAFKA-5546) Lost data when the leader is disconnected.

2017-06-30 Thread JIRA
Björn Eriksson created KAFKA-5546: - Summary: Lost data when the leader is disconnected. Key: KAFKA-5546 URL: https://issues.apache.org/jira/browse/KAFKA-5546 Project: Kafka Issue Type: Bug

[GitHub] kafka pull request #3468: KAFKA-5542: Improve Java doc for LeaderEpochFileCa...

2017-06-30 Thread benstopford
GitHub user benstopford opened a pull request: https://github.com/apache/kafka/pull/3468 KAFKA-5542: Improve Java doc for LeaderEpochFileCache.endOffsetFor() You can merge this pull request into a Git repository by running: $ git pull https://github.com/benstopford/kafka KAFKA

[GitHub] kafka pull request #3467: MINOR: InFlightRequests#isEmpty(node) method corre...

2017-06-30 Thread Kamal15
GitHub user Kamal15 opened a pull request: https://github.com/apache/kafka/pull/3467 MINOR: InFlightRequests#isEmpty(node) method corrected. - In clearAll method, get operation is removed. - variable name `requestTimeout` changed to `requestTimeoutMs` for clarity You can merge t

[DISCUSS] KIP-167: Add interface for the state store restoration process

2017-06-30 Thread Bill Bejeck
Hi, I updated the KIP yesterday and reposted on the original thread, but I think it may get lost in the shuffle. I'd like to have one more round of discussion on the KIP found here: https://cwiki.apache.org/confluence/display/KAFKA/KIP-167%3A+Add+interface+for+the+state+store+restoration+process

[DISCUSS] KIP-173: Add prefix to StreamsConfig to enable setting default internal topic configs

2017-06-30 Thread Damian Guy
Hi, I've put together what will hopefully be a not too contentious KIP to enable the setting of default configs for streams internal topics via StreamsConfig. You can find the KIP here: https://cwiki.apache.org/confluence/display/KAFKA/KIP-173%3A+Add+prefix+to+StreamsConfig+to+enable+setting+defa

[jira] [Created] (KAFKA-5545) Kafka Stream not able to successfully restart over new broker ip

2017-06-30 Thread Yogesh BG (JIRA)
Yogesh BG created KAFKA-5545: Summary: Kafka Stream not able to successfully restart over new broker ip Key: KAFKA-5545 URL: https://issues.apache.org/jira/browse/KAFKA-5545 Project: Kafka Issue

[GitHub] kafka pull request #3466: MINOR: fix InsertSource transformation properties ...

2017-06-30 Thread evis
GitHub user evis opened a pull request: https://github.com/apache/kafka/pull/3466 MINOR: fix InsertSource transformation properties in doc @guozhangwang You can merge this pull request into a Git repository by running: $ git pull https://github.com/evis/kafka insertsource-doc

pull request #2755: request for review

2017-06-30 Thread Sönke Liebau
The pull request has been open for a while now, can someone please have a look at whether this is still viable and something we want to do? I've updated and resolved conflicts yesterday.

Re: [VOTE] KIP-161: streams deserialization exception handlers

2017-06-30 Thread Eno Thereska
This has now passed. The votes where: Binding +1: Sriram, Guozhang, Damian Non-binding +1: Matthias, Bill. Thank you. The discussion moves to the actual PR: https://github.com/apache/kafka/pull/3423 Eno > On Jun 28, 2017, at 9:38 AM, Sriram Subramani

[GitHub] kafka pull request #2651: MINOR: reduce() javadocs: clarify position of argu...

2017-06-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/2651 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] kafka pull request #3390: KAFKA-5485: Streams should not suspend tasks twice

2017-06-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/3390 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] kafka pull request #3465: MINOR: Fixed the invalid link to Log Compaction

2017-06-30 Thread Kamal15
GitHub user Kamal15 opened a pull request: https://github.com/apache/kafka/pull/3465 MINOR: Fixed the invalid link to Log Compaction - variable name updated in the doc example. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Kamal

Re: [DISCUSS] Streams DSL/StateStore Refactoring

2017-06-30 Thread Damian Guy
Thanks Matthias On Fri, 30 Jun 2017 at 08:05 Matthias J. Sax wrote: > I am just catching up on this thread, so sorry for the long email in > advance... Also, it's to some extend a dump of thoughts and not always a > clear proposal. Still need to think about this in more detail. But maybe > it he

Re: [VOTE] KIP 130: Expose states of active tasks to KafkaStreams public API

2017-06-30 Thread Sriram Subramanian
+1 On Fri, Jun 30, 2017 at 12:10 AM, Damian Guy wrote: > I know i voted before, but now my vote is binding so... > > +1 (binding) > > On Thu, 18 May 2017 at 23:46 Matthias J. Sax > wrote: > > > +1 > > > > On 5/18/17 8:26 AM, Bill Bejeck wrote: > > > +1 > > > > > > On Thu, May 18, 2017 at 6:54 A

Re: [VOTE] KIP 130: Expose states of active tasks to KafkaStreams public API

2017-06-30 Thread Damian Guy
I know i voted before, but now my vote is binding so... +1 (binding) On Thu, 18 May 2017 at 23:46 Matthias J. Sax wrote: > +1 > > On 5/18/17 8:26 AM, Bill Bejeck wrote: > > +1 > > > > On Thu, May 18, 2017 at 6:54 AM, Florian Hussonnois < > fhussonn...@gmail.com> > > wrote: > > > >> Hi all, > >>

Re: [DISCUSS] Streams DSL/StateStore Refactoring

2017-06-30 Thread Matthias J. Sax
I am just catching up on this thread, so sorry for the long email in advance... Also, it's to some extend a dump of thoughts and not always a clear proposal. Still need to think about this in more detail. But maybe it helps other to get new ideas :) >> However, I don't understand your argument ab