[jira] [Updated] (KAFKA-3025) KIP-31&KIP-32 (part 1): Add timestamp field to message, configs, and Producer/ConsumerRecord

2015-12-22 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin updated KAFKA-3025: Summary: KIP-31&KIP-32 (part 1): Add timestamp field to message, configs, and Producer/ConsumerRecor

[jira] [Updated] (KAFKA-3025) KIP-32 (part 1): Add timestamp field to message, configs, and Producer/ConsumerRecord

2015-12-22 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin updated KAFKA-3025: Description: This JIRA is for changes for KIP-32 excluding broker checking and acting on timestamp

Re: [VOTE] KIP-32 Add CreateTime and LogAppendTime to Kafka message.

2015-12-22 Thread Dong Lin
Hi Neha, Yeah, I actually think the KIP is ready for vote other than some minor issues. My question is more about who should start the vote and drive the design of this KIP. Given that Jiangjie is on vacation in China with limited access to gmail, I raised the question on his behalf and hopefully

Re: [VOTE] KIP-32 Add CreateTime and LogAppendTime to Kafka message.

2015-12-22 Thread Becket Qin
Hi Anna, Thanks for initiating the voting process. I did not start the voting process because there were still some ongoing discussion with Jun about the timestamp regarding compressed messages. That is why the wiki page hasn't reflected the latest conversation as Guozhang pointed out. Like

[jira] [Commented] (KAFKA-3015) Improve JBOD data balancing

2015-12-22 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15069215#comment-15069215 ] Joe Stein commented on KAFKA-3015: -- Can we do both of these at the same time https://cwi

Re: Unifying kafka-clients call signatures

2015-12-22 Thread Joe Stein
Along with the KIP what do folks think about (if vote passes and code commits) a 0.9.0.1? We could slate the 0.9.0.1 release for second week of January maybe? It might be too soon to flip the entire "unstable" bit at once. a few more weeks might help flesh that out some. We could also keep doing t

Jenkins build is back to normal : kafka-trunk-jdk7 #924

2015-12-22 Thread Apache Jenkins Server
See

Re: [VOTE] KIP-32 Add CreateTime and LogAppendTime to Kafka message.

2015-12-22 Thread Anna Povzner
Hi Gwen, I just wanted to point out that I just started the vote. Becket wrote the proposal and led the discussions. What I understood from reading the discussion thread, the migration plan was discussed at the KIP meeting, and not much on the mailing list itself. My question about the migration

Jenkins build is back to normal : kafka-trunk-jdk8 #255

2015-12-22 Thread Apache Jenkins Server
See

Re: [VOTE] KIP-32 Add CreateTime and LogAppendTime to Kafka message.

2015-12-22 Thread Neha Narkhede
Hey Gwen, Migration plan wasn't really discussed a ton in the previous threads. So it will be great to dive deep and see if there are gaps there. I had some questions, but the details listed on the KIP are great. It is complex, though the plan outlined in the wiki assumes a zero downtime upgrade

Re: [VOTE] KIP-32 Add CreateTime and LogAppendTime to Kafka message.

2015-12-22 Thread Gwen Shapira
Hi Anna, Thanks for the KIP, especially for the details on all the alternatives and how we arrived at the proposal. Its really great! Can you point me at where the migration plan was discussed? It looks overly complex and I have a bunch of questions, but if there was a discussion, I'd like to rea

Re: [VOTE] KIP-32 Add CreateTime and LogAppendTime to Kafka message.

2015-12-22 Thread Neha Narkhede
Hey Anna, Thanks for initiating the vote and helping Becket while he is out! Hey Dong, My understanding from observing all the email threads is that there is a general agreement on the approach and the wiki is reasonably up-to-date with all the decisions. Is there a particular reason why the KIP

Build failed in Jenkins: kafka-trunk-jdk7 #923

2015-12-22 Thread Apache Jenkins Server
See Changes: [me] MINOR: Use "new line" delimeters in a portable way in a unit test -- [...truncated 2793 lines...] kafka.log.LogTest > testTruncateTo PASSED kafka.log.LogTest > testCleanShutdo

Re: Unifying kafka-clients call signatures

2015-12-22 Thread Gwen Shapira
(Moving discussion to dev) Since this is a public API change, don't we technically need a KIP + Vote? On Mon, Dec 21, 2015 at 11:38 PM, Pierre-Yves Ritschard wrote: > Hi list, > > I've been working on an issue at > https://issues.apache.org/jira/browse/KAFKA-3006 and it is now a good > time to

Build failed in Jenkins: kafka-trunk-jdk8 #254

2015-12-22 Thread Apache Jenkins Server
See Changes: [me] KAFKA-2989; System tests should verify partitions consumed after [me] MINOR: Use "new line" delimeters in a portable way in a unit test -- [...truncated 2833 lines...] kafka.l

[GitHub] kafka pull request: MINOR: Fix a typos in comments

2015-12-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/701 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[jira] [Commented] (KAFKA-3024) Remove old patch review tools

2015-12-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15069052#comment-15069052 ] ASF GitHub Bot commented on KAFKA-3024: --- Github user asfgit closed the pull request

[jira] [Updated] (KAFKA-3024) Remove old patch review tools

2015-12-22 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-3024: Resolution: Fixed Fix Version/s: 0.9.1.0 Status: Resolved (was: Patch Available)

[GitHub] kafka pull request: KAFKA-3024: Remove old patch review tools

2015-12-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/705 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[jira] [Updated] (KAFKA-3030) Remove unused scala dependencies

2015-12-22 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-3030: Resolution: Fixed Status: Resolved (was: Patch Available) Issue resolved by pull request 71

[jira] [Commented] (KAFKA-3030) Remove unused scala dependencies

2015-12-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15069041#comment-15069041 ] ASF GitHub Bot commented on KAFKA-3030: --- Github user asfgit closed the pull request

[GitHub] kafka pull request: KAFKA-3030: Remove unused scala dependencies

2015-12-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/713 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[jira] [Created] (KAFKA-3035) Transient: kafka.api.PlaintextConsumerTest > testAutoOffsetReset FAILED

2015-12-22 Thread Gwen Shapira (JIRA)
Gwen Shapira created KAFKA-3035: --- Summary: Transient: kafka.api.PlaintextConsumerTest > testAutoOffsetReset FAILED Key: KAFKA-3035 URL: https://issues.apache.org/jira/browse/KAFKA-3035 Project: Kafka

[GitHub] kafka pull request: MINOR: Tiny optimization to avoid mapping twic...

2015-12-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/714 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[jira] [Created] (KAFKA-3034) kafka.api.PlaintextConsumerTest > testSeek FAILED

2015-12-22 Thread Gwen Shapira (JIRA)
Gwen Shapira created KAFKA-3034: --- Summary: kafka.api.PlaintextConsumerTest > testSeek FAILED Key: KAFKA-3034 URL: https://issues.apache.org/jira/browse/KAFKA-3034 Project: Kafka Issue Type: Sub

Re: KIP-41: KafkaConsumer Max Records

2015-12-22 Thread Ismael Juma
On Wed, Dec 23, 2015 at 1:24 AM, Gwen Shapira wrote: > Given the background, it sounds like you'll generally want each call to > poll() to return the same number of events (which is the number you planned > on having enough memory / time for). It also sounds like tuning the number > of events wil

Jenkins build is back to normal : kafka-trunk-jdk7 #922

2015-12-22 Thread Apache Jenkins Server
See

Re: KIP-41: KafkaConsumer Max Records

2015-12-22 Thread Gwen Shapira
Given the background, it sounds like you'll generally want each call to poll() to return the same number of events (which is the number you planned on having enough memory / time for). It also sounds like tuning the number of events will be closely tied to tuning the session timeout. That is - if I

[GitHub] kafka pull request: MINOR: Use "new line" delimeters in a portable...

2015-12-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/708 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[jira] [Updated] (KAFKA-3033) Reassigning partition stuck in progress

2015-12-22 Thread Leo Xuzhang Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leo Xuzhang Lin updated KAFKA-3033: --- Description: We were trying to increase the replication factor on a test topic we've created.

Re: KIP-41: KafkaConsumer Max Records

2015-12-22 Thread Jason Gustafson
For a little more background, the problem we've found in some use cases is that it's difficult to control the processing time when handling batches of records. If processing takes longer than the consumer's session timeout, then the member is kicked out of the group, which can cause excessive rebal

[jira] [Commented] (KAFKA-2989) Verify all partitions consumed after rebalancing in system tests

2015-12-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15068946#comment-15068946 ] ASF GitHub Bot commented on KAFKA-2989: --- Github user asfgit closed the pull request

[jira] [Resolved] (KAFKA-2989) Verify all partitions consumed after rebalancing in system tests

2015-12-22 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewen Cheslack-Postava resolved KAFKA-2989. -- Resolution: Fixed Fix Version/s: 0.9.1.0 Issue resolved by pull request 7

[GitHub] kafka pull request: KAFKA-2989: system tests should verify partiti...

2015-12-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/702 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[jira] [Created] (KAFKA-3033) Reassigning partition stuck in progress

2015-12-22 Thread Leo Xuzhang Lin (JIRA)
Leo Xuzhang Lin created KAFKA-3033: -- Summary: Reassigning partition stuck in progress Key: KAFKA-3033 URL: https://issues.apache.org/jira/browse/KAFKA-3033 Project: Kafka Issue Type: Bug

[jira] [Created] (KAFKA-3032) Broken documentation link

2015-12-22 Thread Vahid Hashemian (JIRA)
Vahid Hashemian created KAFKA-3032: -- Summary: Broken documentation link Key: KAFKA-3032 URL: https://issues.apache.org/jira/browse/KAFKA-3032 Project: Kafka Issue Type: Bug Compone

KIP-41: KafkaConsumer Max Records

2015-12-22 Thread Jens Rantil
Hi Kafkaians, Me and Jason Gustafson have been working on a KIP to be able to set the maximum number of messages that a poll() call will return in the new Consumer API. You can find the KIP here: https://cwiki.apache.org/confluence/display/KAFKA/KIP-41%3A+KafkaConsumer+Max+Records It contains a fu

Re: Use of CopyOnWriteMap in RecordAccumulator.java

2015-12-22 Thread Rajini Sivaram
Jay, Ismael, Thank you, I will run some performance tests first. I will try and get this done tomorrow, otherwise, I will get onto it first thing in the new year. Thank you... Regards, Rajini On Tue, Dec 22, 2015 at 5:04 PM, Ismael Juma wrote: > Yes, definitely. We should also have automate

[GitHub] kafka pull request: MINOR: Update to Gradle 2.10

2015-12-22 Thread granthenke
GitHub user granthenke opened a pull request: https://github.com/apache/kafka/pull/715 MINOR: Update to Gradle 2.10 Some of the Improvements Include: - The Checkstyle task now produces a human friendly HTML report - Potential performance improvements - Bug Fixes You can

Re: [VOTE] KIP-32 Add CreateTime and LogAppendTime to Kafka message.

2015-12-22 Thread Dong Lin
Hi Anna, Have you talked with Jiangjie Qin before initiating the vote? Jiangjie Qin is on vocation now and he may not have time to answer question related to KIP-32 in detail. Dong On Tue, Dec 22, 2015 at 12:34 PM, Anna Povzner wrote: > Hi, > > I am opening the voting thread for KIP-32: Add Cr

Re: [VOTE] KIP-32 Add CreateTime and LogAppendTime to Kafka message.

2015-12-22 Thread Guozhang Wang
One thing I want to do before +1 is to update the migration plan on the wiki regarding latest updates as well. Currently it states that in the second phase, the broker will "fill in the time field with current server time and re-compress the message" when it gets an older versioned produce request

[GitHub] kafka pull request: MINOR: Tiny optimization to avoid mapping twic...

2015-12-22 Thread dajac
GitHub user dajac opened a pull request: https://github.com/apache/kafka/pull/714 MINOR: Tiny optimization to avoid mapping twice on the results. As pointed out by @granthenke in #196, error can be wrapped in JShort directly to avoid second map. You can merge this pull request into

[jira] [Assigned] (KAFKA-3026) KIP-32 (part 2): Changes in broker to over-write timestamp or reject message

2015-12-22 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin reassigned KAFKA-3026: --- Assignee: Jiangjie Qin (was: Anna Povzner) > KIP-32 (part 2): Changes in broker to over-writ

[jira] [Assigned] (KAFKA-3025) KIP-32 (part 1): Add timestamp field to message, configs, and Producer/ConsumerRecord

2015-12-22 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin reassigned KAFKA-3025: --- Assignee: Jiangjie Qin (was: Anna Povzner) > KIP-32 (part 1): Add timestamp field to message

[jira] [Updated] (KAFKA-2511) KIP-31 & KIP-32: message format change + adding timestamp to messages

2015-12-22 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin updated KAFKA-2511: Description: This ticket is created for KIP 31 and KIP-32. Please refer to the KIPs for details. ht

[jira] [Updated] (KAFKA-3026) KIP-32 (part 2): Changes in broker to over-write timestamp or reject message

2015-12-22 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin updated KAFKA-3026: Issue Type: Sub-task (was: Improvement) Parent: KAFKA-2511 > KIP-32 (part 2): Changes in br

[jira] [Updated] (KAFKA-3025) KIP-32 (part 1): Add timestamp field to message, configs, and Producer/ConsumerRecord

2015-12-22 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin updated KAFKA-3025: Issue Type: Sub-task (was: Improvement) Parent: KAFKA-2511 > KIP-32 (part 1): Add timestamp

[jira] [Commented] (KAFKA-3025) KIP-32 (part 1): Add timestamp field to message, configs, and Producer/ConsumerRecord

2015-12-22 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15068715#comment-15068715 ] Jiangjie Qin commented on KAFKA-3025: - [~apovzner] Thanks for creating the tickets. I

Jenkins build is back to normal : kafka-trunk-jdk8 #253

2015-12-22 Thread Apache Jenkins Server
See

[jira] [Commented] (KAFKA-3007) new Consumer should expose mechanism to fetch single message, consumer.poll(timeout, maxMessageLimit)

2015-12-22 Thread aarti gupta (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15068708#comment-15068708 ] aarti gupta commented on KAFKA-3007: Sounds good, will keep an eye out for the KIP >

[jira] [Updated] (KAFKA-2511) KIP-31 & KIP-32: message format change + adding timestamp to messages

2015-12-22 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin updated KAFKA-2511: Summary: KIP-31 & KIP-32: message format change + adding timestamp to messages (was: KIP-31 message

Build failed in Jenkins: kafka_0.9.0_jdk7 #75

2015-12-22 Thread Apache Jenkins Server
See Changes: [wangguoz] MINOR: Fix typo in documentation -- [...truncated 1542 lines...] kafka.coordinator.GroupCoordinatorResponseTest > testSyncGroupFromUnknownGroup PASSED kafka.coordinator.G

[VOTE] KIP-32 Add CreateTime and LogAppendTime to Kafka message.

2015-12-22 Thread Anna Povzner
Hi, I am opening the voting thread for KIP-32: Add CreateTime and LogAppendTime to Kafka message. For reference, here's the KIP wiki: https://cwiki.apache.org/confluence/display/KAFKA/KIP-32+-+Add+CreateTime+and+LogAppendTime+to+Kafka+message And the mailing list threads: September: http://mai

Build failed in Jenkins: kafka-trunk-jdk7 #921

2015-12-22 Thread Apache Jenkins Server
See Changes: [wangguoz] MINOR: Fix typo in documentation -- [...truncated 1389 lines...] kafka.log.LogCleanerIntegrationTest > cleanerTest[3] PASSED kafka.log.LogTest > testParseTopicPartitionN

[jira] [Commented] (KAFKA-3025) KIP-32 (part 1): Add timestamp field to message, configs, and Producer/ConsumerRecord

2015-12-22 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15068603#comment-15068603 ] Dong Lin commented on KAFKA-3025: - [~apovzner] Cool. Thanks for the update. > KIP-32 (par

[jira] [Updated] (KAFKA-3026) KIP-32 (part 2): Changes in broker to over-write timestamp or reject message

2015-12-22 Thread Anna Povzner (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anna Povzner updated KAFKA-3026: Description: The discussion about this JIRA assignment is still under discussion with [~becket_qin]

[jira] [Updated] (KAFKA-3026) KIP-32 (part 2): Changes in broker to over-write timestamp or reject message

2015-12-22 Thread Anna Povzner (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anna Povzner updated KAFKA-3026: Description: The decision about this JIRA assignment is still under discussion with [~becket_qin].

[jira] [Updated] (KAFKA-3025) KIP-32 (part 1): Add timestamp field to message, configs, and Producer/ConsumerRecord

2015-12-22 Thread Anna Povzner (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anna Povzner updated KAFKA-3025: Description: The decision about this JIRA assignment is still under discussion with [~becket_qin].

[jira] [Updated] (KAFKA-3025) KIP-32 (part 1): Add timestamp field to message, configs, and Producer/ConsumerRecord

2015-12-22 Thread Anna Povzner (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anna Povzner updated KAFKA-3025: Description: The discussion about this JIRA assignment is still under discussion with [~becket_qin]

[jira] [Commented] (KAFKA-3025) KIP-32 (part 1): Add timestamp field to message, configs, and Producer/ConsumerRecord

2015-12-22 Thread Anna Povzner (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15068580#comment-15068580 ] Anna Povzner commented on KAFKA-3025: - [~lindong] : I am in contact with [~becket_qin]

[jira] [Commented] (KAFKA-3025) KIP-32 (part 1): Add timestamp field to message, configs, and Producer/ConsumerRecord

2015-12-22 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15068553#comment-15068553 ] Dong Lin commented on KAFKA-3025: - [~apovzner], please don't create the ticket and assign

[GitHub] kafka pull request: MINOR: Fix typo in documentation

2015-12-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/707 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[jira] [Updated] (KAFKA-3031) Refactor KafkaApis to be optimal for o.a.k.c requests

2015-12-22 Thread Grant Henke (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Grant Henke updated KAFKA-3031: --- Description: The migration changes were meant to be a minimal transition. Once most of the migration

[jira] [Created] (KAFKA-3031) Refactor ReplicaManager to be optimal for o.a.k.c requests

2015-12-22 Thread Grant Henke (JIRA)
Grant Henke created KAFKA-3031: -- Summary: Refactor ReplicaManager to be optimal for o.a.k.c requests Key: KAFKA-3031 URL: https://issues.apache.org/jira/browse/KAFKA-3031 Project: Kafka Issue Ty

[jira] [Updated] (KAFKA-3031) Refactor KafkaApis to be optimal for o.a.k.c requests

2015-12-22 Thread Grant Henke (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Grant Henke updated KAFKA-3031: --- Summary: Refactor KafkaApis to be optimal for o.a.k.c requests (was: Refactor ReplicaManager to be op

[jira] [Assigned] (KAFKA-3031) Refactor KafkaApis to be optimal for o.a.k.c requests

2015-12-22 Thread Grant Henke (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Grant Henke reassigned KAFKA-3031: -- Assignee: Grant Henke > Refactor KafkaApis to be optimal for o.a.k.c requests > ---

[jira] [Resolved] (KAFKA-3027) Kafka metrics can be stale if there is no new update

2015-12-22 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-3027. Resolution: Not A Problem [~jkreps], yes, you are right. Tried the console producer and the metrics are up

[jira] [Commented] (KAFKA-3030) Remove unused scala dependencies

2015-12-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15068421#comment-15068421 ] ASF GitHub Bot commented on KAFKA-3030: --- GitHub user granthenke opened a pull reques

[jira] [Updated] (KAFKA-3030) Remove unused scala dependencies

2015-12-22 Thread Grant Henke (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Grant Henke updated KAFKA-3030: --- Status: Patch Available (was: Open) > Remove unused scala dependencies >

[GitHub] kafka pull request: KAFKA-3030: Remove unused scala dependencies

2015-12-22 Thread granthenke
GitHub user granthenke opened a pull request: https://github.com/apache/kafka/pull/713 KAFKA-3030: Remove unused scala dependencies You can merge this pull request into a Git repository by running: $ git pull https://github.com/granthenke/kafka scala-deps Alternatively you ca

Re: Use of CopyOnWriteMap in RecordAccumulator.java

2015-12-22 Thread Ismael Juma
Yes, definitely. We should also have automated alerts in case of regressions. We already run the existing performance tools on a nightly basis, which is a start: http://testing.confluent.io/kafka/latest/ One thing to keep in mind is that there have been significant changes to the implementation o

[jira] [Created] (KAFKA-3030) Remove unused scala dependencies

2015-12-22 Thread Grant Henke (JIRA)
Grant Henke created KAFKA-3030: -- Summary: Remove unused scala dependencies Key: KAFKA-3030 URL: https://issues.apache.org/jira/browse/KAFKA-3030 Project: Kafka Issue Type: Sub-task R

[jira] [Updated] (KAFKA-3022) Deduplicate common project configurations

2015-12-22 Thread Grant Henke (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Grant Henke updated KAFKA-3022: --- Status: Patch Available (was: Open) > Deduplicate common project configurations > ---

[jira] [Commented] (KAFKA-3022) Deduplicate common project configurations

2015-12-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15068380#comment-15068380 ] ASF GitHub Bot commented on KAFKA-3022: --- GitHub user granthenke opened a pull reques

[GitHub] kafka pull request: KAFKA-3022: Deduplicate common project configu...

2015-12-22 Thread granthenke
GitHub user granthenke opened a pull request: https://github.com/apache/kafka/pull/712 KAFKA-3022: Deduplicate common project configurations - Move testJar to subprojects config - Move CheckStyle to subprojects config - Move testLogging to subprojects config - Add testSou

[jira] [Commented] (KAFKA-3029) Make class org.apache.kafka.common.TopicPartition Serializable

2015-12-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15068363#comment-15068363 ] ASF GitHub Bot commented on KAFKA-3029: --- GitHub user praveend opened a pull request:

[GitHub] kafka pull request: KAFKA-3029:Marking class org.apache.kafka.comm...

2015-12-22 Thread praveend
GitHub user praveend opened a pull request: https://github.com/apache/kafka/pull/711 KAFKA-3029:Marking class org.apache.kafka.common.TopicPartition as serializable Patch for issue KAFKA-3029 Given that the fix is trivial no new test case is needed. I have run the test sui

[jira] [Created] (KAFKA-3029) Make class org.apache.kafka.common.TopicPartition Serializable

2015-12-22 Thread Praveen Devarao (JIRA)
Praveen Devarao created KAFKA-3029: -- Summary: Make class org.apache.kafka.common.TopicPartition Serializable Key: KAFKA-3029 URL: https://issues.apache.org/jira/browse/KAFKA-3029 Project: Kafka

Re: Use of CopyOnWriteMap in RecordAccumulator.java

2015-12-22 Thread Jay Kreps
My vague recollection was that those two cases were about a 15% perf difference in the producer in the small message case. For this and metrics changes we should quantify the degradation (if any) if we're making changes. -Jay On Tue, Dec 22, 2015 at 4:24 AM, Rajini Sivaram wrote: > Thank you, Is

[jira] [Commented] (KAFKA-2875) Class path contains multiple SLF4J bindings warnings when using scripts under bin

2015-12-22 Thread jin xing (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15068067#comment-15068067 ] jin xing commented on KAFKA-2875: - [~ijuma] hi ~, I modified and reopened this PR, ~ Could

Re: Use of CopyOnWriteMap in RecordAccumulator.java

2015-12-22 Thread Rajini Sivaram
Thank you, Ismael. I will switch to ConcurrentHashMap later today if there are no objections. Regards, Rajini On Tue, Dec 22, 2015 at 11:57 AM, Ismael Juma wrote: > Hi Rajini, > > Looking at git annotate, the choice of CopyOnWriteMap was done in the > original commit that introduced the Produc

Re: Use of CopyOnWriteMap in RecordAccumulator.java

2015-12-22 Thread Ismael Juma
Hi Rajini, Looking at git annotate, the choice of CopyOnWriteMap was done in the original commit that introduced the Producer. For cases where writes are very rare, it can be a win, but it's problematic as soon as this assumption changes (particularly if the map is large). We switched from CopyOnW

[GitHub] kafka pull request: MINOR: Update `config/producer.properties` to ...

2015-12-22 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/710 MINOR: Update `config/producer.properties` to have new producer properties Also include some trivial clean-ups in `ProducerConfig`and `BaseProducer`. You can merge this pull request into a Git reposito

Use of CopyOnWriteMap in RecordAccumulator.java

2015-12-22 Thread Rajini Sivaram
I was looking at removing unused partitions from org.apache.kafka.clients.producer.internals.RecordAccumulator#batches to avoid the map growing indefinitely, especially in the REST service. The PR under https://issues.apache.org/jira/browse/KAFKA-2948 has the details. With CopyOnWriteMap, removing

[jira] [Updated] (KAFKA-3010) include error code when logging an error when ack = 0

2015-12-22 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-3010: --- Reviewer: Jun Rao Status: Patch Available (was: Open) > include error code when logging an erro

[jira] [Commented] (KAFKA-3010) include error code when logging an error when ack = 0

2015-12-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15067937#comment-15067937 ] ASF GitHub Bot commented on KAFKA-3010: --- GitHub user ijuma opened a pull request:

[GitHub] kafka pull request: KAFKA-3010; Include error in log when ack 0

2015-12-22 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/709 KAFKA-3010; Include error in log when ack 0 I verified this by trying to produce to __consumer_offsets and the logged message looks like: [2015-12-22 10:34:40,897] INFO [KafkaApi-0] Closing co

[jira] [Commented] (KAFKA-2000) Delete consumer offsets from kafka once the topic is deleted

2015-12-22 Thread Stevo Slavic (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15067936#comment-15067936 ] Stevo Slavic commented on KAFKA-2000: - I'm still on 0.8.2.x and it's hurting my system

[GitHub] kafka pull request: MINOR: Use "new line" delimeters in a portable...

2015-12-22 Thread glikson
GitHub user glikson opened a pull request: https://github.com/apache/kafka/pull/708 MINOR: Use "new line" delimeters in a portable way in a unit test This fixes failure of the FileStreamSinkTaskTest unit test on Windows Signed-off-by: glikson You can merge this pull reques