[jira] [Commented] (KAFKA-2411) remove usage of BlockingChannel in the broker

2015-08-09 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14679544#comment-14679544 ] Jun Rao commented on KAFKA-2411: [~sriharsha], I wasn't thinking of replacing blocking cha

[jira] [Commented] (KAFKA-2411) remove usage of BlockingChannel in the broker

2015-08-09 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14679468#comment-14679468 ] Sriharsha Chintalapani commented on KAFKA-2411: --- [~junrao] Is this jira rela

roll-over of offset values?

2015-08-09 Thread Marina
Hi, I was wondering what is the process, if any, of "re-setting" offset values when, for example, they reach some max value?The obvious max value to think about would be the Long.MAX_VALUE =  9223372036854775807 Even though it is very large, theoretically one might generate that many events in

Re: [DISCUSS] KIP-27 - Conditional Publish

2015-08-09 Thread Jun Rao
Couple of other things. A. In the discussion, we talked about the usage of getting the latest high watermark from the broker. Currently, the high watermark in a partition can go back a bit for a short period of time during leader change. So, the high watermark returned in the getOffset api is not

[jira] [Commented] (KAFKA-1690) new java producer needs ssl support as a client

2015-08-09 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14679397#comment-14679397 ] Jun Rao commented on KAFKA-1690: [~rsivaram], this jira is getting pretty close to be comm

[jira] [Commented] (KAFKA-2406) ISR propagation should be throttled to avoid overwhelming controller.

2015-08-09 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14679395#comment-14679395 ] Jiangjie Qin commented on KAFKA-2406: - [~junrao], thanks for the review. Just updated

Re: [DISCUSSION] KIP-29 - Add an IsrPropagateIntervalMs config to KafkaConfig

2015-08-09 Thread Jiangjie Qin
Jun, Thanks for the detailed explanation. Now I understand. Yes, we might not be able leverage the group commit in this case. When I was testing the patch, I also found a potential use case for the config (not sure if that is a strong use case though). When we rolling upgrade a cluster, if the co

[jira] [Updated] (KAFKA-2406) ISR propagation should be throttled to avoid overwhelming controller.

2015-08-09 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-2406: --- Status: In Progress (was: Patch Available) Left some review comments in the PR. > ISR propagation should be

Re: [DISCUSSION] KIP-29 - Add an IsrPropagateIntervalMs config to KafkaConfig

2015-08-09 Thread Jun Rao
Jiangjie, Related to group commit, I think what Jay says is the following. Suppose the propagation of ISR is slow and also creates back pressure, you can just propagate the ISR one batch at a time as fast as you can. After one batch is sent, you just collect all ISR changes that have accumulated s

[jira] [Commented] (KAFKA-2412) Documentation bug: Add information for key.serializer and value.serializer to New Producer Config sections

2015-08-09 Thread darshan kumar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14679131#comment-14679131 ] darshan kumar commented on KAFKA-2412: -- I see key.serializer.class in the document h

[jira] [Commented] (KAFKA-2202) ConsumerPerformance reports a throughput much higher than the actual one

2015-08-09 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14679066#comment-14679066 ] Manikumar Reddy commented on KAFKA-2202: [~gwenshap] [~guozhang] pinging for revie

Re: Review Request 35867: Patch for KAFKA-1901

2015-08-09 Thread Manikumar Reddy O
> On July 21, 2015, 1:58 p.m., Ismael Juma wrote: > > clients/src/main/java/org/apache/kafka/common/utils/AppInfoParser.java, > > line 27 > > > > > > Why isn't this "unknown" like `version`? yes we can set "unknown"

Re: Review Request 35867: Patch for KAFKA-1901

2015-08-09 Thread Manikumar Reddy O
> On July 17, 2015, 4:25 p.m., Joel Koshy wrote: > > clients/src/main/java/org/apache/kafka/common/metrics/JmxReporter.java, > > line 56 > > > > > > "given `prefix` string and further qualifies the associated AppInfo

[jira] [Updated] (KAFKA-1901) Move Kafka version to be generated in code by build (instead of in manifest)

2015-08-09 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1901: --- Status: Patch Available (was: In Progress) > Move Kafka version to be generated in code by bu

[jira] [Commented] (KAFKA-1901) Move Kafka version to be generated in code by build (instead of in manifest)

2015-08-09 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14679061#comment-14679061 ] Manikumar Reddy commented on KAFKA-1901: Updated reviewboard https://reviews.apach

[jira] [Updated] (KAFKA-1901) Move Kafka version to be generated in code by build (instead of in manifest)

2015-08-09 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1901: --- Attachment: KAFKA-1901_2015-08-09_15:04:39.patch > Move Kafka version to be generated in code

Re: Review Request 35867: Patch for KAFKA-1901

2015-08-09 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35867/ --- (Updated Aug. 9, 2015, 9:37 a.m.) Review request for kafka. Bugs: KAFKA-1901

[jira] [Updated] (KAFKA-2295) Dynamically loaded classes (encoders, etc.) may not be found by Kafka Producer

2015-08-09 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-2295: --- Status: Patch Available (was: In Progress) > Dynamically loaded classes (encoders, etc.) may

[jira] [Comment Edited] (KAFKA-2412) Documentation bug: Add information for key.serializer and value.serializer to New Producer Config sections

2015-08-09 Thread darshan kumar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14663302#comment-14663302 ] darshan kumar edited comment on KAFKA-2412 at 8/9/15 7:38 AM: --

[jira] [Commented] (KAFKA-2412) Documentation bug: Add information for key.serializer and value.serializer to New Producer Config sections

2015-08-09 Thread darshan kumar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14663302#comment-14663302 ] darshan kumar commented on KAFKA-2412: -- Thank you. Sure will look into it and get bac

[jira] [Commented] (KAFKA-2412) Documentation bug: Add information for key.serializer and value.serializer to New Producer Config sections

2015-08-09 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14663294#comment-14663294 ] Gwen Shapira commented on KAFKA-2412: - Thank you. Please take a look at our contribut