Re: [Discussion] Limitations on topic names

2015-07-12 Thread Magnus Edenhill
Hi, since dots seem to be a problem on the metrics side, why not let the metrics side handle it by escaping troublesome characters? E.g. "foo.my\.topic.feh" Let's not push the problem upstream. Replacing "." with another set of allowed characters "__" seems like a bad idea since it is ambigious:

[jira] [Commented] (KAFKA-1835) Kafka new producer needs options to make blocking behavior explicit

2015-07-12 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14624238#comment-14624238 ] Jiangjie Qin commented on KAFKA-1835: - Maybe we can enforce a metadata refresh upon pr

[jira] [Commented] (KAFKA-2162) Kafka Auditing functionality

2015-07-12 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14624188#comment-14624188 ] Sriharsha Chintalapani commented on KAFKA-2162: --- [~gwenshap] I think auditi

Re: Review Request 34403: Patch for KAFKA-2198

2015-07-12 Thread Gwen Shapira
> On July 10, 2015, 4:46 p.m., Gwen Shapira wrote: > > core/src/main/scala/kafka/admin/TopicCommand.scala, lines 72-73 > > > > > > This is a bit unclean. I think its more idiomatic when the catch block > > includes t

[jira] [Commented] (KAFKA-2162) Kafka Auditing functionality

2015-07-12 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14624158#comment-14624158 ] Gwen Shapira commented on KAFKA-2162: - I like starting with requirements. So I asked f

Re: Review Request 33620: Patch for KAFKA-1690

2015-07-12 Thread Sriharsha Chintalapani
> On June 30, 2015, 5:27 p.m., Michael Herstine wrote: > > clients/src/main/java/org/apache/kafka/common/network/Channel.java, lines > > 109-114 > > > > > > So you want class `Channel` to have at most one "send" pend

Re: [Discussion] Limitations on topic names

2015-07-12 Thread Jun Rao
First, a couple of clarifications on this. 1. Currently, we allow Kafka topic to have dots, except that we disallow topic names that are exactly "." or ".." (which can cause weird problems when mapping to file directories and ZK paths as Gwen pointed out). 2. When creating the Coda Hale metrics,

[jira] [Commented] (KAFKA-2275) Add a ListTopic() API to the new consumer

2015-07-12 Thread Stevo Slavic (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14624057#comment-14624057 ] Stevo Slavic commented on KAFKA-2275: - Isn't this covered by [public List partitionsFo

Re: [Discussion] Limitations on topic names

2015-07-12 Thread Gwen Shapira
I like the "lets warn people of conflicts when creating the topic" suggestion. IMO, automatic topic creation as currently done is buggy either way (Send data and hope the topic is ready before retries run out, potentially failing with the super helpful NO_LEADER error), so I don't mind leaving it b

Re: [Discussion] Limitations on topic names

2015-07-12 Thread Joe Stein
Can we provide a tool so folks can "sync back" old topic names to new so their clusters aren't format lopsided. ~ Joestein On Jul 11, 2015 1:33 PM, "Todd Palino" wrote: > I tend to agree with this as a compromise at this point. The reality is > that this is technical debt that has built up in th

[jira] [Comment Edited] (KAFKA-1835) Kafka new producer needs options to make blocking behavior explicit

2015-07-12 Thread Stefan Miklosovic (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14623837#comment-14623837 ] Stefan Miklosovic edited comment on KAFKA-1835 at 7/12/15 2:51 PM: -

[jira] [Comment Edited] (KAFKA-1835) Kafka new producer needs options to make blocking behavior explicit

2015-07-12 Thread Stefan Miklosovic (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14623837#comment-14623837 ] Stefan Miklosovic edited comment on KAFKA-1835 at 7/12/15 2:51 PM: -

[jira] [Comment Edited] (KAFKA-1835) Kafka new producer needs options to make blocking behavior explicit

2015-07-12 Thread Stefan Miklosovic (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14623837#comment-14623837 ] Stefan Miklosovic edited comment on KAFKA-1835 at 7/12/15 2:46 PM: -

[jira] [Commented] (KAFKA-1835) Kafka new producer needs options to make blocking behavior explicit

2015-07-12 Thread Stefan Miklosovic (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14623837#comment-14623837 ] Stefan Miklosovic commented on KAFKA-1835: -- I am still hitting this issue, I need