[jira] [Commented] (KAFKA-2295) Dynamically loaded classes (encoders, etc.) may not be found by Kafka Producer

2015-07-05 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14614582#comment-14614582 ] Manikumar Reddy commented on KAFKA-2295: Updated reviewboard https://reviews.apach

[jira] [Updated] (KAFKA-2295) Dynamically loaded classes (encoders, etc.) may not be found by Kafka Producer

2015-07-05 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-2295: --- Attachment: KAFKA-2295_2015-07-06_11:32:58.patch > Dynamically loaded classes (encoders, etc.)

Re: Review Request 35880: Patch for KAFKA-2295

2015-07-05 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35880/ --- (Updated July 6, 2015, 6:05 a.m.) Review request for kafka. Bugs: KAFKA-2295

Re: Review Request 35880: Patch for KAFKA-2295

2015-07-05 Thread Guozhang Wang
> On July 3, 2015, 1:46 a.m., Guozhang Wang wrote: > > clients/src/main/java/org/apache/kafka/common/utils/Utils.java, line 496 > > > > > > How about add a createObject function in Utils.java like > > coreUtils.scala

Re: Review Request 36034: Patch for KAFKA-2306

2015-07-05 Thread Guozhang Wang
> On July 3, 2015, 1:36 a.m., Guozhang Wang wrote: > > Thanks for the patch. I have a few thoughts regarding the names of the > > metrics, since in the producer other causes can also result in dropped > > messages (i.e. rejected before it enteres the producer buffer), such as > > message-size-