Re: Checking in on 2101, 2102, 2129

2015-06-15 Thread Guozhang Wang
Hi Tim, Sorry for getting late on 2129, I will review it this week. Guozhang On Mon, Jun 15, 2015 at 6:11 PM, Jun Rao wrote: > Hi, Tim, > > 2101 looks good and I just committed it. I left a comment on 2102. > > Sorry for the delay. > > Jun > > On Mon, Jun 15, 2015 at 4:27 PM, Tim Brooks wrote

Re: Guozhang Wang elected to Kafka PMC

2015-06-15 Thread Ashish Singh
Congrats Guozhang! On Mon, Jun 15, 2015 at 10:20 PM, Sriharsha Chintalapani wrote: > Congrats Guozhang. > > -- > Harsha > > > On June 15, 2015 at 9:59:37 PM, Jun Rao (j...@confluent.io) wrote: > > Hi, Everyone, > > Guozhang Wang has been active in the Kafka community since he became a > Kafka co

Re: Guozhang Wang elected to Kafka PMC

2015-06-15 Thread Sriharsha Chintalapani
Congrats Guozhang. --  Harsha On June 15, 2015 at 9:59:37 PM, Jun Rao (j...@confluent.io) wrote: Hi, Everyone, Guozhang Wang has been active in the Kafka community since he became a Kafka committer about 7 months ago. I am glad to announce that Guozhang is now a member of Kafka PMC. C

[jira] [Updated] (KAFKA-2272) listeners endpoint parsing fails if the hostname has capital letter

2015-06-15 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriharsha Chintalapani updated KAFKA-2272: -- Attachment: KAFKA-2272.patch > listeners endpoint parsing fails if the hostname

[jira] [Commented] (KAFKA-2272) listeners endpoint parsing fails if the hostname has capital letter

2015-06-15 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14587486#comment-14587486 ] Sriharsha Chintalapani commented on KAFKA-2272: --- Created reviewboard https:/

[jira] [Updated] (KAFKA-2272) listeners endpoint parsing fails if the hostname has capital letter

2015-06-15 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriharsha Chintalapani updated KAFKA-2272: -- Status: Patch Available (was: Open) > listeners endpoint parsing fails if the h

Review Request 35489: Patch for KAFKA-2272

2015-06-15 Thread Sriharsha Chintalapani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35489/ --- Review request for kafka. Bugs: KAFKA-2272 https://issues.apache.org/jira/b

Guozhang Wang elected to Kafka PMC

2015-06-15 Thread Jun Rao
Hi, Everyone, Guozhang Wang has been active in the Kafka community since he became a Kafka committer about 7 months ago. I am glad to announce that Guozhang is now a member of Kafka PMC. Congratulations, Guozhang! Jun

[jira] [Created] (KAFKA-2272) listeners endpoint parsing fails if the hostname has capital letter

2015-06-15 Thread Sriharsha Chintalapani (JIRA)
Sriharsha Chintalapani created KAFKA-2272: - Summary: listeners endpoint parsing fails if the hostname has capital letter Key: KAFKA-2272 URL: https://issues.apache.org/jira/browse/KAFKA-2272 P

[jira] [Created] (KAFKA-2271) transient unit test failure in KafkaConfigConfigDefTest.testFromPropsToProps

2015-06-15 Thread Jun Rao (JIRA)
Jun Rao created KAFKA-2271: -- Summary: transient unit test failure in KafkaConfigConfigDefTest.testFromPropsToProps Key: KAFKA-2271 URL: https://issues.apache.org/jira/browse/KAFKA-2271 Project: Kafka

[jira] [Created] (KAFKA-2270) incorrect package name in unit tests

2015-06-15 Thread Jun Rao (JIRA)
Jun Rao created KAFKA-2270: -- Summary: incorrect package name in unit tests Key: KAFKA-2270 URL: https://issues.apache.org/jira/browse/KAFKA-2270 Project: Kafka Issue Type: Bug Components:

Re: Review Request 33614: Patch for KAFKA-2132

2015-06-15 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33614/#review88015 --- Thanks for the patch. There seems to be a compilation error. :log4j

Build failed in Jenkins: Kafka-trunk #511

2015-06-15 Thread Apache Jenkins Server
See Changes: [junrao] kafka-2101; Metric metadata-age is reset on a failed update; patched by Tim Brooks; reviewed by Jun Rao -- [...truncated 1366 lines...] kafka.log.LogTest > testTimeBasedLogRoll

Re: Checking in on 2101, 2102, 2129

2015-06-15 Thread Jun Rao
Hi, Tim, 2101 looks good and I just committed it. I left a comment on 2102. Sorry for the delay. Jun On Mon, Jun 15, 2015 at 4:27 PM, Tim Brooks wrote: > I wanted to check in on these three tickets I opened in JIRA. I have not > seen responses to them in a while. > > > 2101 and 2129 seem like

[jira] [Commented] (KAFKA-2102) Remove unnecessary synchronization when managing metadata

2015-06-15 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14587281#comment-14587281 ] Jun Rao commented on KAFKA-2102: [~timbrooks], thanks for the patch. Took a quick look at

[jira] [Updated] (KAFKA-2102) Remove unnecessary synchronization when managing metadata

2015-06-15 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-2102: --- Status: In Progress (was: Patch Available) > Remove unnecessary synchronization when managing metadata >

[jira] [Updated] (KAFKA-2101) Metric metadata-age is reset on a failed update

2015-06-15 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-2101: --- Resolution: Fixed Fix Version/s: 0.8.3 Status: Resolved (was: Patch Available) Thanks for t

Checking in on 2101, 2102, 2129

2015-06-15 Thread Tim Brooks
I wanted to check in on these three tickets I opened in JIRA. I have not seen responses to them in a while.  2101 and 2129 seem like straightforward issues that need to be resolved (2129 - related the consumer not entirely being thread safe; 2101 related to a full successful update back off on

Re: Review Request 33614: Patch for KAFKA-2132

2015-06-15 Thread Gwen Shapira
> On June 11, 2015, 10:15 p.m., Aditya Auradkar wrote: > > log4j-appender/src/main/java/org/apache/kafka/log4jappender/KafkaLog4jAppender.java, > > line 135 > > > > > > perhaps wrap this inside an isDebugEnabled check

Kafka KIP hangout June 16

2015-06-15 Thread Jun Rao
Hi, Everyone, We will have a KIP hangout at 11am PST on June 16. The following is the agenda. If you want to attend and is not on the invite, please let me know. Agenda: KIP-12 (sasl/ssl authentication): status check KIP-23: (Add JSON/CSV output and looping options to ConsumerGroupCommand) new co

Re: [VOTE] KIP-25 System test improvements

2015-06-15 Thread Geoffrey Anderson
Hi Gwen, Yes, it looks like it passed with a lazy majority :) I should be submitting a patch with a few initial tests today or tomorrow. Cheers, Geoff On Mon, Jun 15, 2015 at 2:10 PM, Gwen Shapira wrote: > I counted 3 binding votes (Jun, Neha, Joe) and two non-binding (Ewen and > I). > So I a

Re: Review Request 35347: Patch for KAFKA-2249

2015-06-15 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35347/#review87981 --- Also, could you add a main() method in KafkaConfig like that in Prod

Re: [VOTE] KIP 20 Enable log preallocate to improve consume performance under windows and some old Linux file system

2015-06-15 Thread Jun Rao
Hi, Honghai, I left some comments on the RB in KAFKA-1646. Have you seen those yet? Thanks, Jun On Mon, Jun 15, 2015 at 12:58 AM, Honghai Chen wrote: > Hi Jay, > Seemly we met the "Lazy majority " rule, push it? > > Binding +5 > Jun Rao > Neha > Jakob >

[jira] [Updated] (KAFKA-2252) Socket connection closing is logged, but not corresponding opening of socket

2015-06-15 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-2252: Assignee: Gwen Shapira Status: Patch Available (was: Open) > Socket connection closing is log

Review Request 35474: Patch for KAFKA-2252

2015-06-15 Thread Gwen Shapira
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35474/ --- Review request for kafka. Bugs: KAFKA-2252 https://issues.apache.org/jira/b

[jira] [Commented] (KAFKA-2252) Socket connection closing is logged, but not corresponding opening of socket

2015-06-15 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14586744#comment-14586744 ] Gwen Shapira commented on KAFKA-2252: - Created reviewboard https://reviews.apache.org/

[jira] [Updated] (KAFKA-2252) Socket connection closing is logged, but not corresponding opening of socket

2015-06-15 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-2252: Attachment: KAFKA-2252.patch > Socket connection closing is logged, but not corresponding opening of

Re: [VOTE] KIP-25 System test improvements

2015-06-15 Thread Gwen Shapira
I counted 3 binding votes (Jun, Neha, Joe) and two non-binding (Ewen and I). So I assume the KIP passed :) What's the next step? Are we expecting a patch with few initial tests soon? On Thu, Jun 11, 2015 at 5:41 PM, Jun Rao wrote: > +1 > > Thanks, > > Jun > > On Wed, Jun 10, 2015 at 6:10 PM, Geo

[jira] [Updated] (KAFKA-2269) Partition imbalance does not converge to 0, even with auto.leader.rebalance.enable=true

2015-06-15 Thread Patrick Lucas (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Lucas updated KAFKA-2269: - Attachment: graph.png > Partition imbalance does not converge to 0, even with > auto.leader.rebal

[jira] [Created] (KAFKA-2269) Partition imbalance does not converge to 0, even with auto.leader.rebalance.enable=true

2015-06-15 Thread Patrick Lucas (JIRA)
Patrick Lucas created KAFKA-2269: Summary: Partition imbalance does not converge to 0, even with auto.leader.rebalance.enable=true Key: KAFKA-2269 URL: https://issues.apache.org/jira/browse/KAFKA-2269

[jira] [Commented] (KAFKA-2252) Socket connection closing is logged, but not corresponding opening of socket

2015-06-15 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14586445#comment-14586445 ] Gwen Shapira commented on KAFKA-2252: - Ick! I lost your fix while working on KAFKA-192

[jira] [Commented] (KAFKA-2252) Socket connection closing is logged, but not corresponding opening of socket

2015-06-15 Thread Todd Palino (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14586437#comment-14586437 ] Todd Palino commented on KAFKA-2252: I moved the normal connection closed message to D

Re: Review Request 34789: Patch for KAFKA-2168

2015-06-15 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34789/#review87880 --- Thanks for the new patch. A few more quick comments. clients/src/m

[jira] [Commented] (KAFKA-2252) Socket connection closing is logged, but not corresponding opening of socket

2015-06-15 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14586390#comment-14586390 ] Gwen Shapira commented on KAFKA-2252: - We still have this exact issue. Only now its in

[jira] [Commented] (KAFKA-2251) "Connection reset by peer" IOExceptions should not be logged as ERROR

2015-06-15 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14586383#comment-14586383 ] Gwen Shapira commented on KAFKA-2251: - Haha, I accidentally fixed Kafka's most annoyin

Re: [Discussion] New Consumer API / Protocol

2015-06-15 Thread Guozhang Wang
Yeah I think it is better to discuss these points in the KIP meeting, or it may become a long thread. Let's do that this Tuesday. Guozhang On Thu, Jun 11, 2015 at 5:48 PM, Jun Rao wrote: > Guozhang, > > Perhaps we can discuss this in our KIP hangout next week? > > Thanks, > > Jun > > On Tue, Ju

[jira] [Created] (KAFKA-2268) New producer logs WARN if serializer supplied directly to constructor

2015-06-15 Thread Morten Lied Johansen (JIRA)
Morten Lied Johansen created KAFKA-2268: --- Summary: New producer logs WARN if serializer supplied directly to constructor Key: KAFKA-2268 URL: https://issues.apache.org/jira/browse/KAFKA-2268 Pro

[jira] [Commented] (KAFKA-2159) offsets.topic.segment.bytes and offsets.topic.retention.minutes are ignored

2015-06-15 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14585806#comment-14585806 ] Manikumar Reddy commented on KAFKA-2159: [~jjkoshy] Currently "offsets.topic.comp

[jira] [Commented] (KAFKA-2159) offsets.topic.segment.bytes and offsets.topic.retention.minutes are ignored

2015-06-15 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14585800#comment-14585800 ] Manikumar Reddy commented on KAFKA-2159: Created reviewboard https://reviews.apach

[jira] [Updated] (KAFKA-2159) offsets.topic.segment.bytes and offsets.topic.retention.minutes are ignored

2015-06-15 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-2159: --- Assignee: Manikumar Reddy Status: Patch Available (was: Open) > offsets.topic.segment.b

[jira] [Updated] (KAFKA-2159) offsets.topic.segment.bytes and offsets.topic.retention.minutes are ignored

2015-06-15 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-2159: --- Attachment: KAFKA-2159.patch > offsets.topic.segment.bytes and offsets.topic.retention.minutes

Review Request 35454: Patch for KAFKA-2159

2015-06-15 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35454/ --- Review request for kafka. Bugs: KAFKA-2159 https://issues.apache.org/jira/b

RE: [VOTE] KIP 20 Enable log preallocate to improve consume performance under windows and some old Linux file system

2015-06-15 Thread Honghai Chen
Hi Jay, Seemly we met the "Lazy majority " rule, push it? Binding +5 Jun Rao Neha Jakob Jay Kreps Sriram Subramanian Non-binding +2 Gwen Shapira JG Homan Thanks, Honghai Chen -Original Message- From: Neha Narkhede [mailt

[jira] [Commented] (KAFKA-2260) Allow specifying expected offset on produce

2015-06-15 Thread Daniel Schierbeck (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14585601#comment-14585601 ] Daniel Schierbeck commented on KAFKA-2260: -- On the mailing list we discussed a wa

[jira] [Resolved] (KAFKA-2251) "Connection reset by peer" IOExceptions should not be logged as ERROR

2015-06-15 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy resolved KAFKA-2251. Resolution: Fixed Fix Version/s: 0.8.3 This got fixed in KAFKA-1928. Log level change

[jira] [Commented] (KAFKA-2252) Socket connection closing is logged, but not corresponding opening of socket

2015-06-15 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14585519#comment-14585519 ] Manikumar Reddy commented on KAFKA-2252: Some of these logs are removed/modified a