Build failed in Jenkins: Kafka-trunk #510

See Changes: [junrao] kafka-2164; ReplicaFetcherThread: suspicious log message on reset offset; patched by Alexey Ozeritski; reviewed by Jun Rao -- [...truncated 1230 lines...] kafka.admin.DeleteTopi

Jenkins build is back to normal : KafkaPreCommit #122

See

[jira] [Updated] (KAFKA-2241) AbstractFetcherThread.shutdown() should not block on ReadableByteChannel.read(buffer)

[ https://issues.apache.org/jira/browse/KAFKA-2241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-2241: --- Reviewer: Jun Rao > AbstractFetcherThread.shutdown() should not block on > ReadableByteChannel.read(buffer) >

[jira] [Updated] (KAFKA-2165) ReplicaFetcherThread: data loss on unknown exception

[ https://issues.apache.org/jira/browse/KAFKA-2165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-2165: --- Status: In Progress (was: Patch Available) Thanks for reporting this. A couple of comments. 1. Currently, if

[jira] [Updated] (KAFKA-2164) ReplicaFetcherThread: suspicious log message on reset offset

[ https://issues.apache.org/jira/browse/KAFKA-2164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-2164: --- Resolution: Fixed Fix Version/s: 0.8.3 Status: Resolved (was: Patch Available) Thanks for t

[jira] [Commented] (KAFKA-2241) AbstractFetcherThread.shutdown() should not block on ReadableByteChannel.read(buffer)

[ https://issues.apache.org/jira/browse/KAFKA-2241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14584381#comment-14584381 ] Dong Lin commented on KAFKA-2241: - [~junrao] No, this bug is fixed in java 1.8.0. Can you

[jira] [Created] (KAFKA-2267) kafka-reassign-partitions.sh --generate doesn't work when reducing replication factor

Robin Yamaguchi created KAFKA-2267: -- Summary: kafka-reassign-partitions.sh --generate doesn't work when reducing replication factor Key: KAFKA-2267 URL: https://issues.apache.org/jira/browse/KAFKA-2267

Re: [DISCUSS] KIP-4 - Command line and centralized administrative operations (Thread 2)

Joel, Aditya, I believe we don't need another thread to do voting since affected items are not related to the core proposed changes. I agree people can explicitly down-vote in case of concerns about the things that changed. Thanks, Andrii Biletskyi On Fri, Jun 12, 2015 at 8:24 PM, Aditya Auradka

[jira] [Commented] (KAFKA-2195) Add versionId to AbstractRequest.getErrorResponse and AbstractRequest.getRequest

[ https://issues.apache.org/jira/browse/KAFKA-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14584234#comment-14584234 ] Andrii Biletskyi commented on KAFKA-2195: - Yes, thanks, I'll address it by Monday.

[jira] [Updated] (KAFKA-2217) Refactor Client Selectable Interface for Better Concurrency Options

[ https://issues.apache.org/jira/browse/KAFKA-2217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson updated KAFKA-2217: --- Resolution: Not A Problem Status: Resolved (was: Patch Available) > Refactor Client S

[jira] [Updated] (KAFKA-2235) LogCleaner offset map overflow

[ https://issues.apache.org/jira/browse/KAFKA-2235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-2235: --- Reviewer: Jay Kreps > LogCleaner offset map overflow > -- > > Key:

[jira] [Commented] (KAFKA-2217) Refactor Client Selectable Interface for Better Concurrency Options

[ https://issues.apache.org/jira/browse/KAFKA-2217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14584219#comment-14584219 ] Jason Gustafson commented on KAFKA-2217: [~junrao], we can close it. I thought it

[jira] [Updated] (KAFKA-1755) Improve error handling in log cleaner

[ https://issues.apache.org/jira/browse/KAFKA-1755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1755: --- Reviewer: Jay Kreps > Improve error handling in log cleaner > - > >

[jira] [Updated] (KAFKA-2214) kafka-reassign-partitions.sh --verify should return non-zero exit codes when reassignment is not completed yet

[ https://issues.apache.org/jira/browse/KAFKA-2214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-2214: --- Reviewer: Neha Narkhede > kafka-reassign-partitions.sh --verify should return non-zero exit codes when > reas

[jira] [Updated] (KAFKA-2107) Script to generate waiting-for-review report

[ https://issues.apache.org/jira/browse/KAFKA-2107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-2107: --- Reviewer: Neha Narkhede > Script to generate waiting-for-review report > -

[jira] [Commented] (KAFKA-2217) Refactor Client Selectable Interface for Better Concurrency Options

[ https://issues.apache.org/jira/browse/KAFKA-2217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14584216#comment-14584216 ] Jun Rao commented on KAFKA-2217: [~hachikuji], do we still need to fix this now that we wa

[jira] [Commented] (KAFKA-2229) Phase 1: Requests and KafkaApis

[ https://issues.apache.org/jira/browse/KAFKA-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14584211#comment-14584211 ] Jun Rao commented on KAFKA-2229: We probably should commit KAFKA-2195 first. > Phase 1: R

[jira] [Updated] (KAFKA-2195) Add versionId to AbstractRequest.getErrorResponse and AbstractRequest.getRequest

[ https://issues.apache.org/jira/browse/KAFKA-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-2195: --- Status: In Progress (was: Patch Available) [~abiletskyi], did you see my last comment on the RB? > Add versi

[jira] [Updated] (KAFKA-2254) The shell script should be optimized , even kafka-run-class.sh has a syntax error.

[ https://issues.apache.org/jira/browse/KAFKA-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-2254: --- Reviewer: Joe Stein > The shell script should be optimized , even kafka-run-class.sh has a syntax > error. >

Re: Review Request 35076: Patch for KAFKA-2248

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35076/#review87770 --- Thanks for the patch. Got the following error when running test.

[jira] [Updated] (KAFKA-2147) Unbalanced replication can cause extreme purgatory growth

[ https://issues.apache.org/jira/browse/KAFKA-2147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-2147: --- Resolution: Implemented Fix Version/s: 0.8.3 Status: Resolved (was: Patch Available) [~eapa

Build failed in Jenkins: KafkaPreCommit #121

See Changes: [junrao] kafka-2232; make MockProducer generic; patched by Alexander Pakulov; reviewed by Jun Rao -- [...truncated 1264 lines...] kafka.log.OffsetIndexTest > lookupExtremeCases PASSED

[jira] [Commented] (KAFKA-2241) AbstractFetcherThread.shutdown() should not block on ReadableByteChannel.read(buffer)

[ https://issues.apache.org/jira/browse/KAFKA-2241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14584140#comment-14584140 ] Jun Rao commented on KAFKA-2241: [~lindong], thanks for reporting this. Does this happen o

[jira] [Commented] (KAFKA-2232) make MockProducer generic

[ https://issues.apache.org/jira/browse/KAFKA-2232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14584125#comment-14584125 ] Alexander Pakulov commented on KAFKA-2232: -- Great, I've realized there is a prope

[jira] [Commented] (KAFKA-2232) make MockProducer generic

[ https://issues.apache.org/jira/browse/KAFKA-2232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14584121#comment-14584121 ] Alexander Pakulov commented on KAFKA-2232: -- Updated reviewboard https://reviews.a

[jira] [Updated] (KAFKA-2232) make MockProducer generic

[ https://issues.apache.org/jira/browse/KAFKA-2232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Pakulov updated KAFKA-2232: - Attachment: KAFKA-2232_2015-06-12_14:30:30.patch > make MockProducer generic > ---

Re: Review Request 35261: Patch for KAFKA-2232

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35261/ --- (Updated June 12, 2015, 9:30 p.m.) Review request for kafka. Bugs: KAFKA-2232

[jira] [Updated] (KAFKA-2168) New consumer poll() can block other calls like position(), commit(), and close() indefinitely

[ https://issues.apache.org/jira/browse/KAFKA-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-2168: --- Reviewer: Guozhang Wang > New consumer poll() can block other calls like position(), commit(), and > close()

[jira] [Resolved] (KAFKA-2232) make MockProducer generic

[ https://issues.apache.org/jira/browse/KAFKA-2232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-2232. Resolution: Fixed Assignee: Alexander Pakulov Thanks for the latest patch. +1 and committed to trunk.

Re: Review Request 35261: Patch for KAFKA-2232

> On June 12, 2015, 12:35 a.m., Jun Rao wrote: > > clients/src/main/java/org/apache/kafka/clients/consumer/MockConsumer.java, > > line 13 > > > > > > MockProducer and MockConsumer are meant for testing a Kafka > > app

[jira] [Commented] (KAFKA-2232) make MockProducer generic

[ https://issues.apache.org/jira/browse/KAFKA-2232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14583769#comment-14583769 ] Alexander Pakulov commented on KAFKA-2232: -- Created reviewboard https://reviews.a

[jira] [Updated] (KAFKA-2232) make MockProducer generic

[ https://issues.apache.org/jira/browse/KAFKA-2232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Pakulov updated KAFKA-2232: - Attachment: KAFKA-2232.patch > make MockProducer generic > - > >

Review Request 35396: Patch for KAFKA-2232

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35396/ --- Review request for kafka. Bugs: KAFKA-2232 https://issues.apache.org/jira/b

[jira] [Updated] (KAFKA-2084) byte rate metrics per client ID (producer and consumer)

[ https://issues.apache.org/jira/browse/KAFKA-2084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya A Auradkar updated KAFKA-2084: - Attachment: KAFKA-2084_2015-06-12_10:39:35.patch > byte rate metrics per client ID (produc

Re: Review Request 33049: Patch for KAFKA-2084

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33049/ --- (Updated June 12, 2015, 5:40 p.m.) Review request for kafka, Joel Koshy and Jun

[jira] [Commented] (KAFKA-2084) byte rate metrics per client ID (producer and consumer)

[ https://issues.apache.org/jira/browse/KAFKA-2084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14583750#comment-14583750 ] Aditya A Auradkar commented on KAFKA-2084: -- Updated reviewboard https://reviews.a

Re: Review Request 33049: Patch for KAFKA-2084

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33049/ --- (Updated June 12, 2015, 5:39 p.m.) Review request for kafka, Joel Koshy and Jun

RE: [DISCUSS] KIP-4 - Command line and centralized administrative operations (Thread 2)

Aside from the things I mentioned, I don't think there were other changes. I'll mark this as adopted since there don't appear to be any concerns. Aditya From: Joel Koshy [jjkosh...@gmail.com] Sent: Thursday, June 11, 2015 1:28 PM To: dev@kafka.apache.org

[jira] [Updated] (KAFKA-2266) Client Selector can drop idle connections without notifying NetworkClient

[ https://issues.apache.org/jira/browse/KAFKA-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-2266: --- Resolution: Fixed Fix Version/s: 0.8.3 Status: Resolved (was: Patch Available) Thanks for t

[jira] [Updated] (KAFKA-2266) Client Selector can drop idle connections without notifying NetworkClient

[ https://issues.apache.org/jira/browse/KAFKA-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson updated KAFKA-2266: --- Attachment: KAFKA-2266_2015-06-12_09:18:45.patch > Client Selector can drop idle connections w

Re: Review Request 35371: Patch for KAFKA-2266

> On June 12, 2015, 1:18 a.m., Jun Rao wrote: > > clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java, > > lines 256-257 > > > > > > Waiting a second on this could be long and is not always reliabl

[jira] [Commented] (KAFKA-2266) Client Selector can drop idle connections without notifying NetworkClient

[ https://issues.apache.org/jira/browse/KAFKA-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14583633#comment-14583633 ] Jason Gustafson commented on KAFKA-2266: Updated reviewboard https://reviews.apach

Re: Review Request 35371: Patch for KAFKA-2266

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35371/ --- (Updated June 12, 2015, 4:19 p.m.) Review request for kafka. Bugs: KAFKA-2266

[jira] [Commented] (KAFKA-2213) Log cleaner should write compacted messages using configured compression type

[ https://issues.apache.org/jira/browse/KAFKA-2213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14583617#comment-14583617 ] Manikumar Reddy commented on KAFKA-2213: [~jjkoshy] pinging for review > Log cle

Memcache protocol wrapper

Hi all, I would like to implement a simple Memcache protocol wrapper for Kafka for easing our transition. Based on your advice, what's the most convenient way to achieve this? Modifying KafkaServer seems like a lot of work for a feature that, maybe, is not that useful outside my case. Tha