[jira] [Commented] (KAFKA-1778) Create new re-elect controller admin function

[ https://issues.apache.org/jira/browse/KAFKA-1778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14565837#comment-14565837 ] Abhishek Nigam commented on KAFKA-1778: --- I believe what you are suggesting is that w

[jira] [Commented] (KAFKA-188) Support multiple data directories

[ https://issues.apache.org/jira/browse/KAFKA-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14565723#comment-14565723 ] chenshangan commented on KAFKA-188: --- [~jkreps] "I recommend we instead leave this as it

[jira] [Updated] (KAFKA-2226) NullPointerException in TestPurgatoryPerformance

[ https://issues.apache.org/jira/browse/KAFKA-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yasuhiro Matsuda updated KAFKA-2226: Attachment: KAFKA-2226_2015-05-29_15:10:24.patch > NullPointerException in TestPurgatoryPerf

[jira] [Commented] (KAFKA-2226) NullPointerException in TestPurgatoryPerformance

[ https://issues.apache.org/jira/browse/KAFKA-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14565538#comment-14565538 ] Yasuhiro Matsuda commented on KAFKA-2226: - Updated reviewboard https://reviews.apa

Re: Review Request 34734: Patch for KAFKA-2226

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34734/ --- (Updated May 29, 2015, 10:10 p.m.) Review request for kafka. Bugs: KAFKA-2226

Re: Review Request 33196: Patch for KAFKA-2123

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33196/#review85824 --- clients/src/main/java/org/apache/kafka/clients/consumer/Consumer.ja

Re: Review Request 34734: Patch for KAFKA-2226

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34734/ --- (Updated May 29, 2015, 10:04 p.m.) Review request for kafka. Bugs: KAFKA-2226

[jira] [Updated] (KAFKA-2226) NullPointerException in TestPurgatoryPerformance

[ https://issues.apache.org/jira/browse/KAFKA-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yasuhiro Matsuda updated KAFKA-2226: Attachment: KAFKA-2226_2015-05-29_15:04:35.patch > NullPointerException in TestPurgatoryPerf

[jira] [Commented] (KAFKA-2226) NullPointerException in TestPurgatoryPerformance

[ https://issues.apache.org/jira/browse/KAFKA-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14565522#comment-14565522 ] Yasuhiro Matsuda commented on KAFKA-2226: - Updated reviewboard https://reviews.apa

[jira] [Updated] (KAFKA-2199) Make signing artifacts optional, setting maven repository possible from command line

[ https://issues.apache.org/jira/browse/KAFKA-2199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps updated KAFKA-2199: - Resolution: Fixed Status: Resolved (was: Patch Available) Committed. > Make signing artifacts op

Re: Review Request 34369: Patch for KAFKA-2199

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34369/#review85823 --- Ship it! Ship It! - Jay Kreps On May 29, 2015, 6 p.m., Ewen Ches

Re: Review Request 34734: Patch for KAFKA-2226

> On May 29, 2015, 7:08 p.m., Jun Rao wrote: > > core/src/main/scala/kafka/utils/timer/Timer.scala, line 54 > > > > > > canceled => cancelled I will fix it. By the way, "canceled" is a legitimate spelling in American

Re: [DISCUSSION] Partition Selection and Coordination By Brokers for Producers

Hi Kafka Dev Team, I would appreciate your feedback on moving producer partition selection from producer to Broker. Also, please do let me know what is correct process of collecting feedback from Kafka Dev team and/or community. Thanks, Bhavesh On Tue, May 26, 2015 at 11:54 AM, Bhavesh Mistry

[jira] [Updated] (KAFKA-2213) Log cleaner should write compacted messages using configured compression type

[ https://issues.apache.org/jira/browse/KAFKA-2213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-2213: -- Reviewer: Joel Koshy > Log cleaner should write compacted messages using configured compression type > -

Re: Review Request 34734: Patch for KAFKA-2226

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34734/#review85764 --- Thanks for the new patch. A few more comments below. core/src/main

[jira] [Comment Edited] (KAFKA-2213) Log cleaner should write compacted messages using configured compression type

[ https://issues.apache.org/jira/browse/KAFKA-2213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14564676#comment-14564676 ] Manikumar Reddy edited comment on KAFKA-2213 at 5/29/15 6:58 PM: ---

[jira] [Updated] (KAFKA-2213) Log cleaner should write compacted messages using configured compression type

[ https://issues.apache.org/jira/browse/KAFKA-2213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-2213: --- Attachment: KAFKA-2213_2015-05-30_00:23:01.patch > Log cleaner should write compacted messages

Re: Review Request 34805: Patch for KAFKA-2213

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34805/ --- (Updated May 29, 2015, 6:55 p.m.) Review request for kafka. Bugs: KAFKA-2213

[jira] [Commented] (KAFKA-2213) Log cleaner should write compacted messages using configured compression type

[ https://issues.apache.org/jira/browse/KAFKA-2213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14565220#comment-14565220 ] Manikumar Reddy commented on KAFKA-2213: Updated reviewboard https://reviews.apach

[jira] [Commented] (KAFKA-188) Support multiple data directories

[ https://issues.apache.org/jira/browse/KAFKA-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14565181#comment-14565181 ] Jay Kreps commented on KAFKA-188: - @chenshangan The issue with using data size was that it

[jira] [Updated] (KAFKA-2123) Make new consumer offset commit API use callback + future

[ https://issues.apache.org/jira/browse/KAFKA-2123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewen Cheslack-Postava updated KAFKA-2123: - Attachment: KAFKA-2123_2015-05-29_11:11:05.patch > Make new consumer offset commit

[jira] [Commented] (KAFKA-2123) Make new consumer offset commit API use callback + future

[ https://issues.apache.org/jira/browse/KAFKA-2123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14565164#comment-14565164 ] Ewen Cheslack-Postava commented on KAFKA-2123: -- Updated reviewboard https://r

Re: Review Request 33196: Patch for KAFKA-2123

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33196/ --- (Updated May 29, 2015, 6:11 p.m.) Review request for kafka. Bugs: KAFKA-2123

Re: Review Request 34734: Patch for KAFKA-2226

> On May 28, 2015, 7:10 p.m., Jun Rao wrote: > > core/src/main/scala/kafka/utils/timer/TimerTaskList.scala, lines 64-65 > > > > > > Could you explain a bit why this is needed? It seems that we can add > > the entry eit

Re: [Bump] Code review for KIP-11

Parth, I will take a look. Thanks, Jun On Fri, May 29, 2015 at 10:49 AM, Parth Brahmbhatt < pbrahmbh...@hortonworks.com> wrote: > Hi, > > Can someone please review the following CRs: > > Public entities and interfaces with changes to KafkaAPI and KafkaServer: > https://reviews.apache.org/r/344

[jira] [Commented] (KAFKA-2199) Make signing artifacts optional, setting maven repository possible from command line

[ https://issues.apache.org/jira/browse/KAFKA-2199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14565155#comment-14565155 ] Ewen Cheslack-Postava commented on KAFKA-2199: -- Updated reviewboard https://r

Re: Review Request 34369: Patch for KAFKA-2199

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34369/ --- (Updated May 29, 2015, 6 p.m.) Review request for kafka. Bugs: KAFKA-2199

[jira] [Updated] (KAFKA-2199) Make signing artifacts optional, setting maven repository possible from command line

[ https://issues.apache.org/jira/browse/KAFKA-2199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewen Cheslack-Postava updated KAFKA-2199: - Attachment: KAFKA-2199_2015-05-29_11:00:44.patch > Make signing artifacts optional

[jira] [Commented] (KAFKA-2226) NullPointerException in TestPurgatoryPerformance

[ https://issues.apache.org/jira/browse/KAFKA-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14565133#comment-14565133 ] Yasuhiro Matsuda commented on KAFKA-2226: - Updated reviewboard https://reviews.apa

Re: Review Request 34734: Patch for KAFKA-2226

> On May 28, 2015, 7:10 p.m., Jun Rao wrote: > > core/src/main/scala/kafka/utils/timer/TimerTaskList.scala, lines 64-65 > > > > > > Could you explain a bit why this is needed? It seems that we can add > > the entry eit

[jira] [Updated] (KAFKA-2226) NullPointerException in TestPurgatoryPerformance

[ https://issues.apache.org/jira/browse/KAFKA-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yasuhiro Matsuda updated KAFKA-2226: Attachment: KAFKA-2226_2015-05-29_10:49:34.patch > NullPointerException in TestPurgatoryPerf

[Bump] Code review for KIP-11

Hi, Can someone please review the following CRs: Public entities and interfaces with changes to KafkaAPI and KafkaServer: https://reviews.apache.org/r/34492/diff/ Actual Implementation: https://reviews.apache.org/r/34493/diff/ CLI: https://reviews.apache.org/r/34494/diff/ Thanks Parth

Re: Review Request 34734: Patch for KAFKA-2226

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34734/ --- (Updated May 29, 2015, 5:49 p.m.) Review request for kafka. Bugs: KAFKA-2226

Re: Review Request 34734: Patch for KAFKA-2226

> On May 29, 2015, 1:56 a.m., Jun Rao wrote: > > core/src/main/scala/kafka/utils/timer/TimerTaskList.scala, line 106 > > > > > > Since this is under synchronized, it seems that remove should always > > return true? O

[jira] [Commented] (KAFKA-1367) Broker topic metadata not kept in sync with ZooKeeper

[ https://issues.apache.org/jira/browse/KAFKA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14565078#comment-14565078 ] Jun Rao commented on KAFKA-1367: Yes. > Broker topic metadata not kept in sync with ZooKe

[jira] [Comment Edited] (KAFKA-188) Support multiple data directories

[ https://issues.apache.org/jira/browse/KAFKA-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14564610#comment-14564610 ] chenshangan edited comment on KAFKA-188 at 5/29/15 3:49 PM: [~j

Re: [DISCUSS] KIP-4 - Command line and centralized administrative operations (Thread 2)

+1 on discussing this on next KIP hangout. I will update KIP-24 before that. On Fri, May 29, 2015 at 3:40 AM, Andrii Biletskyi < andrii.bilets...@stealth.ly> wrote: > Guys, > > I won't be able to attend next meeting. But in the latest patch for KIP-4 > Phase 1 > I didn't even evolve TopicMetadata

[jira] [Commented] (KAFKA-1367) Broker topic metadata not kept in sync with ZooKeeper

[ https://issues.apache.org/jira/browse/KAFKA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14564980#comment-14564980 ] Ashish K Singh commented on KAFKA-1367: --- [~junrao] can we add this to the agenda of

[GitHub] kafka pull request: Ignore gradle wrapper download directory

GitHub user sslavic opened a pull request: https://github.com/apache/kafka/pull/67 Ignore gradle wrapper download directory This patch adds gradle wrapper download directory to .gitignore You can merge this pull request into a Git repository by running: $ git pull https://githu

[jira] [Resolved] (KAFKA-2228) Delete me

[ https://issues.apache.org/jira/browse/KAFKA-2228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrii Biletskyi resolved KAFKA-2228. - Resolution: Duplicate > Delete me > - > > Key: KAFKA-2228 >

[jira] [Resolved] (KAFKA-2227) Delete me

[ https://issues.apache.org/jira/browse/KAFKA-2227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrii Biletskyi resolved KAFKA-2227. - Resolution: Duplicate > Delete me > - > > Key: KAFKA-2227 >

[jira] [Updated] (KAFKA-2227) Delete me

[ https://issues.apache.org/jira/browse/KAFKA-2227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrii Biletskyi updated KAFKA-2227: Summary: Delete me (was: Phase 1: Requests and KafkaApis) > Delete me > - > >

[jira] [Assigned] (KAFKA-2228) Delete me

[ https://issues.apache.org/jira/browse/KAFKA-2228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrii Biletskyi reassigned KAFKA-2228: --- Assignee: (was: Andrii Biletskyi) > Delete me > - > > Key

[jira] [Updated] (KAFKA-2228) Delete me

[ https://issues.apache.org/jira/browse/KAFKA-2228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrii Biletskyi updated KAFKA-2228: Summary: Delete me (was: Phase 1: Requests and KafkaApis) > Delete me > - > >

[jira] [Commented] (KAFKA-2213) Log cleaner should write compacted messages using configured compression type

[ https://issues.apache.org/jira/browse/KAFKA-2213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14564676#comment-14564676 ] Manikumar Reddy commented on KAFKA-2213: Uploaded a patch which writes the compact

[jira] [Commented] (KAFKA-2213) Log cleaner should write compacted messages using configured compression type

[ https://issues.apache.org/jira/browse/KAFKA-2213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14564670#comment-14564670 ] Manikumar Reddy commented on KAFKA-2213: Created reviewboard https://reviews.apach

[jira] [Updated] (KAFKA-2213) Log cleaner should write compacted messages using configured compression type

[ https://issues.apache.org/jira/browse/KAFKA-2213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-2213: --- Attachment: KAFKA-2213.patch > Log cleaner should write compacted messages using configured co

[jira] [Updated] (KAFKA-2213) Log cleaner should write compacted messages using configured compression type

[ https://issues.apache.org/jira/browse/KAFKA-2213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-2213: --- Assignee: Manikumar Reddy Status: Patch Available (was: Open) > Log cleaner should writ

Review Request 34805: Patch for KAFKA-2213

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34805/ --- Review request for kafka. Bugs: KAFKA-2213 https://issues.apache.org/jira/b

[jira] [Commented] (KAFKA-188) Support multiple data directories

[ https://issues.apache.org/jira/browse/KAFKA-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14564610#comment-14564610 ] chenshangan commented on KAFKA-188: --- @Jay Kreps I think we could provide a alternative,

Re: [DISCUSS] KIP-4 - Command line and centralized administrative operations (Thread 2)

Guys, I won't be able to attend next meeting. But in the latest patch for KIP-4 Phase 1 I didn't even evolve TopicMetadataRequest to v1 since we won't be able to change config with AlterTopicRequest, hence with this patch TMR will still return isr. Taking this into account I think yes - it would b

Re: Nagging - pending review requests :)

Hey Jai, see below On Fri, May 29, 2015 at 3:03 AM, Jaikiran Pai wrote: > Hi Joe, > > Comments inline. > > On Friday 29 May 2015 12:15 PM, Joe Stein wrote: > >> see below >> >> On Fri, May 29, 2015 at 2:25 AM, Jaikiran Pai >> wrote: >> >> Could someone please look at these few review requests

Re: Review Request 34394: Patch for KAFKA-1907

> On May 29, 2015, 7:11 a.m., Joe Stein wrote: > > core/src/main/scala/kafka/utils/ZkUtils.scala, line 39 > > > > > > if we are going to add this it should be exposed as a configuration and > > written up in a KIP. We

Re: Review Request 34394: Patch for KAFKA-1907

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34394/#review85691 --- core/src/main/scala/kafka/utils/ZkUtils.scala

Re: Nagging - pending review requests :)

Hi Joe, Comments inline. On Friday 29 May 2015 12:15 PM, Joe Stein wrote: see below On Fri, May 29, 2015 at 2:25 AM, Jaikiran Pai wrote: Could someone please look at these few review requests and let me know if any changes are needed: https://reviews.apache.org/r/34394/ related to https://