[jira] [Commented] (KAFKA-1814) FATAL Fatal error during KafkaServerStartable startup. Prepare to shutdown (kafka.server.KafkaServerStartable)

2015-05-22 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14557175#comment-14557175 ] Gwen Shapira commented on KAFKA-1814: - [~sanjubaba]: please send your problem to us...

[jira] [Commented] (KAFKA-1814) FATAL Fatal error during KafkaServerStartable startup. Prepare to shutdown (kafka.server.KafkaServerStartable)

2015-05-22 Thread sanjay (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14557171#comment-14557171 ] sanjay commented on KAFKA-1814: --- i set proper configuration but still when i start server.pr

Re: [VOTE] KIP-21 Dynamic Configuration

2015-05-22 Thread Jiangjie Qin
+1 to the updated wiki (non-binding) On 5/19/15, 2:26 PM, "Andrii Biletskyi" wrote: >Hi, > >Sorry I wasn't able to participate. I don't have objections about removing >config changes from AlterTopic (as I understand both AddedConfig and >DeletedConfig) - you are welcome to update the KIP page. >

Re: Review Request 33620: Patch for KAFKA-1690

2015-05-22 Thread Michael Herstine
> On May 22, 2015, 12:14 a.m., Michael Herstine wrote: > > clients/src/main/java/org/apache/kafka/common/security/auth/PrincipalBuilder.java, > > line 44 > > > > > > I'm trying to imagine implementing `buildPrincipal`

Re: Review Request 33620: Patch for KAFKA-1690

2015-05-22 Thread Michael Herstine
> On May 15, 2015, 10:54 p.m., Joel Koshy wrote: > > clients/src/main/java/org/apache/kafka/common/network/SSLTransportLayer.java, > > line 153 > > > > > > I think Michael meant the following which I think is valid ri

[jira] [Updated] (KAFKA-2217) Refactor Client Selectable Interface for Better Concurrency Options

2015-05-22 Thread Jason Gustafson (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson updated KAFKA-2217: --- Attachment: KAFKA-2217.patch > Refactor Client Selectable Interface for Better Concurrency Opt

[jira] [Commented] (KAFKA-2217) Refactor Client Selectable Interface for Better Concurrency Options

2015-05-22 Thread Jason Gustafson (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14556627#comment-14556627 ] Jason Gustafson commented on KAFKA-2217: Created reviewboard https://reviews.apach

Review Request 34608: Patch for KAFKA-2217

2015-05-22 Thread Jason Gustafson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34608/ --- Review request for kafka. Bugs: KAFKA-2217 https://issues.apache.org/jira/b

[jira] [Updated] (KAFKA-2217) Refactor Client Selectable Interface for Better Concurrency Options

2015-05-22 Thread Jason Gustafson (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson updated KAFKA-2217: --- Attachment: (was: KAFKA-2217.patch) > Refactor Client Selectable Interface for Better Conc

Review Request 34607: Fix SAMZA-686: adding test for max changelog partition computation

2015-05-22 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34607/ --- Review request for kafka. Bugs: SAMZA-686 https://issues.apache.org/jira/br

[jira] [Commented] (KAFKA-1737) Document required ZkSerializer for ZkClient used with AdminUtils

2015-05-22 Thread Vivek Madani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14556596#comment-14556596 ] Vivek Madani commented on KAFKA-1737: - KAFKA-1817 also points to the same issue - the

[jira] [Updated] (KAFKA-2217) Refactor Client Selectable Interface for Better Concurrency Options

2015-05-22 Thread Jason Gustafson (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson updated KAFKA-2217: --- Status: Patch Available (was: Open) > Refactor Client Selectable Interface for Better Concurr

[jira] [Updated] (KAFKA-2217) Refactor Client Selectable Interface for Better Concurrency Options

2015-05-22 Thread Jason Gustafson (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson updated KAFKA-2217: --- Attachment: KAFKA-2217.patch > Refactor Client Selectable Interface for Better Concurrency Opt

Re: Review Request 34415: Patch for KAFKA-2195

2015-05-22 Thread Andrii Biletskyi
> On May 22, 2015, 4:37 p.m., Jun Rao wrote: > > clients/src/main/java/org/apache/kafka/common/requests/AbstractRequest.java, > > lines 45-62 > > > > > > Could we change all requests to use parse(buffer, versionId)? A

[jira] [Updated] (KAFKA-2195) Add versionId to AbstractRequest.getErrorResponse and AbstractRequest.getRequest

2015-05-22 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-2195: --- Status: In Progress (was: Patch Available) > Add versionId to AbstractRequest.getErrorResponse and > Abstrac

Re: Review Request 34415: Patch for KAFKA-2195

2015-05-22 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34415/#review84850 --- Thanks for the patch. A few comments below. clients/src/main/java/

[jira] [Updated] (KAFKA-2214) kafka-reassign-partitions.sh --verify should return non-zero exit codes when reassignment is not completed yet

2015-05-22 Thread Michael Noll (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Noll updated KAFKA-2214: Description: h4. Background The admin script {{kafka-reassign-partitions.sh}} should integrat