RE: [DISCUSS] KIP-21 Configuration Management

2015-05-03 Thread Aditya Auradkar
Hey Joe, Can you elaborate what you mean by a stop the world change? In this protocol, we can target notifications to a subset of brokers in the cluster (controller if we need to). Is the AdminChangeNotification a ZK notification or a request type exposed by each broker? Thanks, Aditya _

Jenkins build is back to normal : Kafka-trunk #482

2015-05-03 Thread Apache Jenkins Server
See

Re: [KIP-DISCUSSION] KIP-22 Expose a Partitioner interface in the new producer

2015-05-03 Thread Harsha
Thanks Jay & Gianmarco for the comments. I picked the option A, if user sends a partition id than it will applied and partitioner.class method will only called if partition id is null . Please take a look at the updated KIP here https://cwiki.apache.org/confluence/display/KAFKA/KIP-+22+-+Expose+a+

Build failed in Jenkins: KafkaPreCommit #94

2015-05-03 Thread Apache Jenkins Server
See Changes: [wangguoz] KAFKA-2068 Phase 1; Merge in KAFKA-1841; reviewed by Jun Rao -- [...truncated 1262 lines...] kafka.network.SocketServerTest > testMaxConnectionsPerIPOverrides PASSED kafka.l

[jira] [Commented] (KAFKA-2068) Replace OffsetCommit Request/Response with org.apache.kafka.common.requests equivalent

2015-05-03 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14526118#comment-14526118 ] Guozhang Wang commented on KAFKA-2068: -- Committed first step patch to trunk. > Repla

[jira] [Updated] (KAFKA-2068) Replace OffsetCommit Request/Response with org.apache.kafka.common.requests equivalent

2015-05-03 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-2068: - Status: In Progress (was: Patch Available) > Replace OffsetCommit Request/Response with org.apac

Re: Review Request 33548: KAFKA-2068 Step I: merge in KAFKA-1841

2015-05-03 Thread Guozhang Wang
> On May 1, 2015, 12:01 a.m., Jun Rao wrote: > > Thanks for the patch. +1. Just a few minor comments below. Also, could you > > trying using the following test code in 0.8.1 to see if v0 > > OffsetCommitRequest still works with 0.8.3 broker? > > > > > > package kafka > > > > import kafka.uti

RE: [DISCUSS] KIP-21 Configuration Management

2015-05-03 Thread Aditya Auradkar
Hey everyone, Thanks for the comments. I'll respond to each one-by-one. In the meantime, can we put this on the agenda for the KIP hangout for next week? Thanks, Aditya From: Neha Narkhede [n...@confluent.io] Sent: Sunday, May 03, 2015 9:48 AM To: dev@ka

Re: Review Request 32650: Patch for KAFKA-2000

2015-05-03 Thread Sriharsha Chintalapani
> On April 23, 2015, 9:51 p.m., Joel Koshy wrote: > > core/src/main/scala/kafka/server/OffsetManager.scala, line 124 > > > > > > A safer fix is to proactively purge as part of UpdateMetadataRequest - > > i.e., removeP

[jira] [Commented] (KAFKA-2000) Delete consumer offsets from kafka once the topic is deleted

2015-05-03 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14525913#comment-14525913 ] Sriharsha Chintalapani commented on KAFKA-2000: --- Updated reviewboard https:/

[jira] [Updated] (KAFKA-2000) Delete consumer offsets from kafka once the topic is deleted

2015-05-03 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriharsha Chintalapani updated KAFKA-2000: -- Status: Patch Available (was: In Progress) > Delete consumer offsets from kafka

[jira] [Updated] (KAFKA-2000) Delete consumer offsets from kafka once the topic is deleted

2015-05-03 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriharsha Chintalapani updated KAFKA-2000: -- Attachment: KAFKA-2000_2015-05-03_10:39:11.patch > Delete consumer offsets from

Re: Review Request 32650: Patch for KAFKA-2000

2015-05-03 Thread Sriharsha Chintalapani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32650/ --- (Updated May 3, 2015, 5:39 p.m.) Review request for kafka. Bugs: KAFKA-2000

Re: [DISCUSS] KIP-21 Configuration Management

2015-05-03 Thread Neha Narkhede
Thanks for starting this discussion, Aditya. Few questions/comments 1. If you change the default values like it's mentioned in the KIP, do you also overwrite the local config file as part of updating the default value? If not, where does the admin look to find the default values, ZK or local Kafka