Re: Review Request 29714: Patch for KAFKA-1810

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29714/ --- (Updated March 15, 2015, 5:26 a.m.) Review request for kafka. Bugs: KAFKA-181

Re: Review Request 29714: Patch for KAFKA-1810

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29714/#review76500 --- core/src/main/scala/kafka/server/KafkaConfig.scala

[jira] [Updated] (KAFKA-1810) Add IP Filtering / Whitelists-Blacklists

[ https://issues.apache.org/jira/browse/KAFKA-1810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Holoman updated KAFKA-1810: Attachment: KAFKA-1810_2015-03-15_01:13:12.patch > Add IP Filtering / Whitelists-Blacklists > -

[jira] [Commented] (KAFKA-1810) Add IP Filtering / Whitelists-Blacklists

[ https://issues.apache.org/jira/browse/KAFKA-1810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14362217#comment-14362217 ] Jeff Holoman commented on KAFKA-1810: - Updated reviewboard https://reviews.apache.org/

Re: Review Request 29714: Patch for KAFKA-1810

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29714/ --- (Updated March 15, 2015, 5:13 a.m.) Review request for kafka. Bugs: KAFKA-181

Re: [DISCUSSION] KIP-15 close(timeout) for producer

Hi Jay, I have modified the KIP as you suggested. I thinks as long as we have consistent define for timeout across Kafka interface, there would be no problem. And I also agree it is better if we can make producer block when close() is called from sender thread so user will notice something went wr

[jira] [Commented] (KAFKA-1926) Replace kafka.utils.Utils with o.a.k.common.utils.Utils

[ https://issues.apache.org/jira/browse/KAFKA-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14362111#comment-14362111 ] Jun Rao commented on KAFKA-1926: [~tongli], thanks the for patch. I made a pass of all met

[jira] [Commented] (KAFKA-1298) Controlled shutdown tool doesn't seem to work out of the box

[ https://issues.apache.org/jira/browse/KAFKA-1298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14362047#comment-14362047 ] Grzegorz Dubicki commented on KAFKA-1298: - I think that the controlled shutdown to

Re: [DISCUSSION] KIP-15 close(timeout) for producer

Hey Jiangjie, I think this is going to be very confusing that close(0) waits indefinitely and close(-1) waits for 0. I understand this appears in other apis, but it is a constant cause of bugs. Let's not repeat that mistake. Let's make close(0) wait for 0. We don't need a way to wait indefini

[jira] [Commented] (KAFKA-2020) I expect ReplicaNotAvailableException to have proper Javadocs

[ https://issues.apache.org/jira/browse/KAFKA-2020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14361952#comment-14361952 ] Jay Kreps commented on KAFKA-2020: -- Yeah we need to just fix that. I actually strongly su

[jira] [Commented] (KAFKA-2020) I expect ReplicaNotAvailableException to have proper Javadocs

[ https://issues.apache.org/jira/browse/KAFKA-2020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14361935#comment-14361935 ] Ewen Cheslack-Postava commented on KAFKA-2020: -- Yes, exactly. > I expect Rep

Re: [DISCUSSION] KIP-15 close(timeout) for producer

Sounds reasonable. I have updated the KIP page accordingly. On 3/12/15, 10:16 PM, "Guozhang Wang" wrote: >3) I think this is fine. >4) Hmm, error-message-only may NOT be better than blocking, as with the >code written with close(>=0), it will likely to just pollute the logs with >repeating error

Re: [VOTE] KIP-16: Replica Lag Tuning

+1 -Jay On Fri, Mar 13, 2015 at 9:54 AM, Aditya Auradkar < aaurad...@linkedin.com.invalid> wrote: > Details in the KIP, Jira and RB. > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP+16+:+Automated+Replica+Lag+Tuning > https://issues.apache.org/jira/browse/KAFKA-1546 > https://reviews.

[jira] [Commented] (KAFKA-2020) I expect ReplicaNotAvailableException to have proper Javadocs

[ https://issues.apache.org/jira/browse/KAFKA-2020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14361868#comment-14361868 ] Jay Kreps commented on KAFKA-2020: -- Is this the case where we are sending back an error c

[jira] [Commented] (KAFKA-2019) RoundRobinAssignor clusters by consumer

[ https://issues.apache.org/jira/browse/KAFKA-2019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14361672#comment-14361672 ] Jiangjie Qin commented on KAFKA-2019: - Talked with Joel and my second thought on this

[jira] [Commented] (KAFKA-1305) Controller can hang on controlled shutdown with auto leader balance enabled

[ https://issues.apache.org/jira/browse/KAFKA-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14361666#comment-14361666 ] Jiangjie Qin commented on KAFKA-1305: - I see. The risk of this approach is that contro