Re: [DISCUSSION] KIP-2: Refactor Brokers to Allow Multiple Endpoints

2015-02-12 Thread Todd Palino
Thanks, Gwen. Perfectly reasonable to split it out into a separate ticket, and I definitely want to hear some other views on this and make sure we cover the use cases (not just the ones I can think of right now) appropriately. -Todd On Thu, Feb 12, 2015 at 5:47 PM, Gwen Shapira wrote: > I REALL

[jira] [Created] (KAFKA-1951) Consumer offset checker should handle corner cases for dual commit or no offsets.

2015-02-12 Thread Jiangjie Qin (JIRA)
Jiangjie Qin created KAFKA-1951: --- Summary: Consumer offset checker should handle corner cases for dual commit or no offsets. Key: KAFKA-1951 URL: https://issues.apache.org/jira/browse/KAFKA-1951 Project

[jira] [Updated] (KAFKA-1913) App hungs when calls producer.send to wrong IP of Kafka broker

2015-02-12 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-1913: Fix Version/s: (was: 0.8.1.2) 0.8.3 > App hungs when calls producer.send to w

[jira] [Updated] (KAFKA-1724) Errors after reboot in single node setup

2015-02-12 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-1724: Fix Version/s: (was: 0.8.2.0) 0.8.3 > Errors after reboot in single node setu

[jira] [Updated] (KAFKA-1282) Disconnect idle socket connection in Selector

2015-02-12 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-1282: Fix Version/s: (was: 0.8.2.0) 0.8.3 > Disconnect idle socket connection in Se

[jira] [Updated] (KAFKA-1897) Enhance MockProducer for more sophisticated tests

2015-02-12 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-1897: Fix Version/s: (was: 0.8.2.0) 0.8.3 > Enhance MockProducer for more sophistic

[jira] [Updated] (KAFKA-1855) Topic unusable after unsuccessful UpdateMetadataRequest

2015-02-12 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-1855: Fix Version/s: (was: 0.8.2.0) 0.8.3 > Topic unusable after unsuccessful Updat

[jira] [Updated] (KAFKA-1835) Kafka new producer needs options to make blocking behavior explicit

2015-02-12 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-1835: Fix Version/s: (was: 0.8.2.0) 0.8.3 > Kafka new producer needs options to mak

[jira] [Created] (KAFKA-1950) Expose methods from SerializationTestUtils to all tests

2015-02-12 Thread Gwen Shapira (JIRA)
Gwen Shapira created KAFKA-1950: --- Summary: Expose methods from SerializationTestUtils to all tests Key: KAFKA-1950 URL: https://issues.apache.org/jira/browse/KAFKA-1950 Project: Kafka Issue Typ

Re: Review Request 29647: Patch for KAFKA-1697

2015-02-12 Thread Gwen Shapira
> On Feb. 13, 2015, 3:05 a.m., Joel Koshy wrote: > > KAFKA-1948 changes crept in to the rb, but I can clean that up. Thanks, man :) I think I need lessons on how to do merges and use the patch-review tool... - Gwen --- This is an autom

Re: [DISCUSSION] KIP-2: Refactor Brokers to Allow Multiple Endpoints

2015-02-12 Thread Gwen Shapira
I'll be happy to give the initial design a go, but will probably only get to it after Strata. So either wait a bit (there are enough KIPs to review ;) or someone else can get started. Gwen On Thu, Feb 12, 2015 at 6:55 PM, Joel Koshy wrote: > +1 on investigating it further as a separate feature

Build failed in Jenkins: Kafka-trunk #391

2015-02-12 Thread Apache Jenkins Server
See Changes: [wangguoz] KAFKA-1948; Fix ConsumerTest.testPartitionReassignmentCallback handling issue; reviewed by Gwen Shapira -- [...truncated 1209 lines...] kafka.log.LogSegmentTest > testRecovery

Re: Review Request 29647: Patch for KAFKA-1697

2015-02-12 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29647/#review72317 --- Ship it! KAFKA-1948 changes crept in to the rb, but I can clean tha

[jira] [Updated] (KAFKA-1697) remove code related to ack>1 on the broker

2015-02-12 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-1697: Attachment: KAFKA-1697_2015-02-12_18:57:36.patch > remove code related to ack>1 on the broker >

[jira] [Commented] (KAFKA-1697) remove code related to ack>1 on the broker

2015-02-12 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14319498#comment-14319498 ] Gwen Shapira commented on KAFKA-1697: - Updated reviewboard https://reviews.apache.org/

Re: Review Request 29647: Patch for KAFKA-1697

2015-02-12 Thread Gwen Shapira
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29647/ --- (Updated Feb. 13, 2015, 2:57 a.m.) Review request for kafka. Bugs: KAFKA-1697

Re: [DISCUSSION] KIP-2: Refactor Brokers to Allow Multiple Endpoints

2015-02-12 Thread Joel Koshy
+1 on investigating it further as a separate feature that will improve ops significantly (especially since an expert on the operations side has described use cases from actual experience). On Thu, Feb 12, 2015 at 05:47:50PM -0800, Gwen Shapira wrote: > I REALLY like the idea of supporting separate

Re: [DISCUSSION] KIP-2: Refactor Brokers to Allow Multiple Endpoints

2015-02-12 Thread Jiangjie Qin
+1 on separating the end points for different purposes. On 2/12/15, 5:47 PM, "Gwen Shapira" wrote: >I REALLY like the idea of supporting separate network for inter-broker >communication (and probably Zookeeper too). >I think its actually a pretty typical configuration in clusters, so I'm >surpri

Jenkins build is back to normal : KafkaPreCommit #4

2015-02-12 Thread Apache Jenkins Server
See

Re: Review Request 29647: Patch for KAFKA-1697

2015-02-12 Thread Gwen Shapira
> On Feb. 12, 2015, 2:31 p.m., Joel Koshy wrote: > > core/src/test/scala/unit/kafka/api/RequestResponseSerializationTest.scala, > > line 62 > > > > > > Is this change necessary? > > Gwen Shapira wrote: > Nope, but

Re: Review Request 29647: Patch for KAFKA-1697

2015-02-12 Thread Gwen Shapira
> On Feb. 12, 2015, 2:31 p.m., Joel Koshy wrote: > > core/src/main/scala/kafka/server/ReplicaManager.scala, line 271 > > > > > > This is good, but maybe call this canRespondNow ? Since before > > replication won't app

Re: [DISCUSSION] KIP-2: Refactor Brokers to Allow Multiple Endpoints

2015-02-12 Thread Gwen Shapira
I REALLY like the idea of supporting separate network for inter-broker communication (and probably Zookeeper too). I think its actually a pretty typical configuration in clusters, so I'm surprised we didn't think of it before :) Servers arrive with multiple cards specifically for "admin nic" vs. "c

[jira] [Comment Edited] (KAFKA-1796) Sanity check partition command line tools

2015-02-12 Thread Mayuresh Gharat (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14319346#comment-14319346 ] Mayuresh Gharat edited comment on KAFKA-1796 at 2/13/15 1:07 AM: ---

[jira] [Commented] (KAFKA-1796) Sanity check partition command line tools

2015-02-12 Thread Mayuresh Gharat (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14319346#comment-14319346 ] Mayuresh Gharat commented on KAFKA-1796: [~nehanarkhede], I went over KAFKA-1678.

[jira] [Commented] (KAFKA-1852) OffsetCommitRequest can commit offset on unknown topic

2015-02-12 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14319332#comment-14319332 ] Sriharsha Chintalapani commented on KAFKA-1852: --- Thanks [~jjkoshy] for the r

[jira] [Commented] (KAFKA-1852) OffsetCommitRequest can commit offset on unknown topic

2015-02-12 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14319327#comment-14319327 ] Sriharsha Chintalapani commented on KAFKA-1852: --- Updated reviewboard https:/

[jira] [Updated] (KAFKA-1852) OffsetCommitRequest can commit offset on unknown topic

2015-02-12 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriharsha Chintalapani updated KAFKA-1852: -- Attachment: KAFKA-1852_2015-02-12_16:46:10.patch > OffsetCommitRequest can commi

Re: Review Request 29912: Patch for KAFKA-1852

2015-02-12 Thread Sriharsha Chintalapani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29912/ --- (Updated Feb. 13, 2015, 12:46 a.m.) Review request for kafka. Bugs: KAFKA-185

Re: Review Request 30946: Fix KAFKA-1948

2015-02-12 Thread Jay Kreps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30946/#review72278 --- Ship it! Ship It! - Jay Kreps On Feb. 12, 2015, 7:36 p.m., Guozh

[jira] [Commented] (KAFKA-1797) add the serializer/deserializer api to the new java client

2015-02-12 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14319273#comment-14319273 ] Jiangjie Qin commented on KAFKA-1797: - I just realized that we removed the default val

[jira] [Assigned] (KAFKA-1796) Sanity check partition command line tools

2015-02-12 Thread Mayuresh Gharat (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayuresh Gharat reassigned KAFKA-1796: -- Assignee: Mayuresh Gharat > Sanity check partition command line tools > ---

Re: gradle testAll stuck

2015-02-12 Thread Gwen Shapira
Test takes about 8 minutes on my machine. I think testAll tests all 3 Scala versions, so it should be around 25 minutes. Why not use just "test", most of the time? On Thu, Feb 12, 2015 at 7:01 AM, Tong Li wrote: > Manikumar, yes, exactly the same issue. Commented on > https://issues.apache.org/

[jira] [Commented] (KAFKA-1824) in ConsoleProducer - properties key.separator and parse.key no longer work

2015-02-12 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14318990#comment-14318990 ] Gwen Shapira commented on KAFKA-1824: - pinging for review :) > in ConsoleProducer - p

[jira] [Commented] (KAFKA-1711) WARN Property topic is not valid when running console producer

2015-02-12 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14318989#comment-14318989 ] Gwen Shapira commented on KAFKA-1711: - Since KAFKA-1824 is open, I don't think we need

[jira] [Commented] (KAFKA-1948) kafka.api.consumerTests are hanging

2015-02-12 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14318939#comment-14318939 ] Gwen Shapira commented on KAFKA-1948: - Applied the patch and the tests are passing! Th

Re: [DISCUSSION] KIP-2: Refactor Brokers to Allow Multiple Endpoints

2015-02-12 Thread Todd Palino
The idea is more about isolating the intra-cluster traffic from the normal clients as much as possible. There's a couple situations we've seen where this would be useful that I can think of immediately: 1) Normal operation - just having the intra-cluster traffic on a separate network interface wou

Re: [DISCUSSION] KIP-2: Refactor Brokers to Allow Multiple Endpoints

2015-02-12 Thread Jun Rao
For rolling downgrading of the intra-cluster protocol, we mostly just need to reverse the steps. If none of the brokers have set wire.protocol.version to the newer version, downgrading can be done by just downgrading the jar, followed by a rolling restart. Otherwise, downgrading needs to be done in

Re: [DISCUSSION] KIP-2: Refactor Brokers to Allow Multiple Endpoints

2015-02-12 Thread Gwen Shapira
Hi, 1. We have another issue with reserving a port for inter-broker communication (at least by not advertising the endpoint). Currently brokers are pretty much "normal" consumers when replicating. Not exactly, but close. Which mean they also learn about other brokers from the registration in ZK. I

[jira] [Created] (KAFKA-1949) Update 0.8.3.0 docs with upgrade process

2015-02-12 Thread Gwen Shapira (JIRA)
Gwen Shapira created KAFKA-1949: --- Summary: Update 0.8.3.0 docs with upgrade process Key: KAFKA-1949 URL: https://issues.apache.org/jira/browse/KAFKA-1949 Project: Kafka Issue Type: Task

Re: Review Request 28769: Patch for KAFKA-1809

2015-02-12 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28769/#review72226 --- clients/src/main/java/org/apache/kafka/common/protocol/ApiVersion.j

[jira] [Commented] (KAFKA-1948) kafka.api.consumerTests are hanging

2015-02-12 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14318844#comment-14318844 ] Guozhang Wang commented on KAFKA-1948: -- One issue I found is that in ConsumerTest.tes

Re: [DISCUSSION] KIP-2: Refactor Brokers to Allow Multiple Endpoints

2015-02-12 Thread Jun Rao
Todd, Could you elaborate on the benefit for having a separate endpoint for intra-cluster communication? Is it mainly for giving intra-cluster requests a high priority? At this moment, having a separate endpoint just means that the socket connection for the intra-cluster communication is handled b

[jira] [Commented] (KAFKA-1948) kafka.api.consumerTests are hanging

2015-02-12 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14318838#comment-14318838 ] Guozhang Wang commented on KAFKA-1948: -- Created reviewboard https://reviews.apache.or

[jira] [Updated] (KAFKA-1948) kafka.api.consumerTests are hanging

2015-02-12 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1948: - Attachment: KAFKA-1948.patch > kafka.api.consumerTests are hanging > -

[jira] [Updated] (KAFKA-1948) kafka.api.consumerTests are hanging

2015-02-12 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1948: - Assignee: Guozhang Wang Status: Patch Available (was: Open) > kafka.api.consumerTests are h

Review Request 30946: Fix KAFKA-1948

2015-02-12 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30946/ --- Review request for kafka. Bugs: KAFKA-1948 https://issues.apache.org/jira/b

Re: [DISCUSS] KIP-8 Add a flush method to the new Java producer

2015-02-12 Thread Joel Koshy
Yes that is a counter-example. I'm okay either way on whether we should have just flush() or have a timeout. Bhavesh, does Jay's explanation a few replies prior address your concern? If so, shall we consider this closed? On Tue, Feb 10, 2015 at 01:36:23PM -0800, Jay Kreps wrote: > Yeah we could do

[jira] [Updated] (KAFKA-1938) [doc] Quick start example should reference appropriate Kafka version

2015-02-12 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1938: --- Attachment: lz4-compression.patch forgot to add LZ4 compression to docs. Attaching a new patch

[jira] [Resolved] (KAFKA-1938) [doc] Quick start example should reference appropriate Kafka version

2015-02-12 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps resolved KAFKA-1938. -- Resolution: Fixed > [doc] Quick start example should reference appropriate Kafka version > -

[jira] [Commented] (KAFKA-1938) [doc] Quick start example should reference appropriate Kafka version

2015-02-12 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14318628#comment-14318628 ] Jay Kreps commented on KAFKA-1938: -- Committed. Let me know if you see any issues. > [doc

[jira] [Commented] (KAFKA-1711) WARN Property topic is not valid when running console producer

2015-02-12 Thread Jelmer Kuperus (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14318458#comment-14318458 ] Jelmer Kuperus commented on KAFKA-1711: --- Issue should be reopened, the fix got rever

[jira] [Updated] (KAFKA-1938) [doc] Quick start example should reference appropriate Kafka version

2015-02-12 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1938: --- Attachment: remove-081-references-1.patch uploading new patch with small correction. > [doc]

Re: Kafka New(Java) Producer Connection reset by peer error and LB

2015-02-12 Thread Bhavesh Mistry
Hi Even, and Jay, I am not saying this is logging issue (logging is absolutely needed and can not turn off ERROR or WARN level in any env). What I am saying is there is TCP connection is establish and leaked till other side close it or producer is close or JVM exits. Imagine you have l"TCP Routi

Re: Review Request 29647: Patch for KAFKA-1697

2015-02-12 Thread Joel Koshy
> On Feb. 12, 2015, 2:31 p.m., Joel Koshy wrote: > > core/src/main/scala/kafka/server/ReplicaManager.scala, line 271 > > > > > > This is good, but maybe call this canRespondNow ? Since before > > replication won't app

Re: Review Request 29912: Patch for KAFKA-1852

2015-02-12 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29912/#review72166 --- core/src/main/scala/kafka/server/OffsetManager.scala

Re: gradle testAll stuck

2015-02-12 Thread Tong Li
Manikumar, yes, exactly the same issue. Commented on https://issues.apache.org/jira/browse/KAFKA-1948. Before this problem happens, the testAll normally still takes about half hour? Thanks Tong Li OpenStack & Kafka Community Development Building 501/B205 liton...@us.ibm.com From: Manikumar

[jira] [Commented] (KAFKA-1887) controller error message on shutting the last broker

2015-02-12 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14318312#comment-14318312 ] Sriharsha Chintalapani commented on KAFKA-1887: --- [~gwenshap] I am worried ab

[jira] [Commented] (KAFKA-1948) kafka.api.consumerTests are hanging

2015-02-12 Thread Tong Li (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14318311#comment-14318311 ] Tong Li commented on KAFKA-1948: Pulled down the latest trunk and run into this problem. I

Re: Review Request 29647: Patch for KAFKA-1697

2015-02-12 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29647/#review72156 --- Ship it! Thanks Gwen - a few minor comments that I can fix up - can

Re: gradle testAll stuck

2015-02-12 Thread Manikumar Reddy
This may be due to the recent issue reported by Gwen. https://issues.apache.org/jira/browse/KAFKA-1948 On 2/12/15, Joel Koshy wrote: > - Can you enable test logging (see the README) and see if you can > figure out which test is getting stuck or taking forever? > - A thread-dump may help. > > O

Re: gradle testAll stuck

2015-02-12 Thread Joel Koshy
- Can you enable test logging (see the README) and see if you can figure out which test is getting stuck or taking forever? - A thread-dump may help. On Thu, Feb 12, 2015 at 08:57:11AM -0500, Tong Li wrote: > > > Hi, folks, > How are you all doing? > New bee here. Run gradle --daemon t

gradle testAll stuck

2015-02-12 Thread Tong Li
Hi, folks, How are you all doing? New bee here. Run gradle --daemon testAll on 0.8.2 worked and finished in about 30 minutes. pulled down trunk and run samething, always stuck. left it run for overnight, checked in the morning still stuck. even on 0.8.2, it still takes over 30 minutes on

[jira] [Comment Edited] (KAFKA-1947) can't explicitly set replica-assignment when add partitions

2015-02-12 Thread Honghai Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14317835#comment-14317835 ] Honghai Chen edited comment on KAFKA-1947 at 2/12/15 8:57 AM: --

[jira] [Commented] (KAFKA-1947) can't explicitly set replica-assignment when add partitions

2015-02-12 Thread Honghai Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14317835#comment-14317835 ] Honghai Chen commented on KAFKA-1947: - Submit review ... https://reviews.apache.org/r/

[jira] [Updated] (KAFKA-1947) can't explicitly set replica-assignment when add partitions

2015-02-12 Thread Honghai Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Honghai Chen updated KAFKA-1947: Attachment: (was: KAFKA-1947.patch) > can't explicitly set replica-assignment when add partition

[jira] [Issue Comment Deleted] (KAFKA-1947) can't explicitly set replica-assignment when add partitions

2015-02-12 Thread Honghai Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Honghai Chen updated KAFKA-1947: Comment: was deleted (was: Created reviewboard against branch origin/trunk) > can't explicitly set

[jira] [Issue Comment Deleted] (KAFKA-1947) can't explicitly set replica-assignment when add partitions

2015-02-12 Thread Honghai Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Honghai Chen updated KAFKA-1947: Comment: was deleted (was: Created reviewboard against branch origin/trunk) > can't explicitly set

[jira] [Updated] (KAFKA-1947) can't explicitly set replica-assignment when add partitions

2015-02-12 Thread Honghai Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Honghai Chen updated KAFKA-1947: Attachment: (was: KAFKA-1947.patch) > can't explicitly set replica-assignment when add partition

[jira] [Updated] (KAFKA-1947) can't explicitly set replica-assignment when add partitions

2015-02-12 Thread Honghai Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Honghai Chen updated KAFKA-1947: Attachment: (was: KAFKA-1947.patch) > can't explicitly set replica-assignment when add partition

[jira] [Updated] (KAFKA-1947) can't explicitly set replica-assignment when add partitions

2015-02-12 Thread Honghai Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Honghai Chen updated KAFKA-1947: Attachment: (was: KAFKA-1947.patch) > can't explicitly set replica-assignment when add partition

[jira] [Updated] (KAFKA-1947) can't explicitly set replica-assignment when add partitions

2015-02-12 Thread Honghai Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Honghai Chen updated KAFKA-1947: Attachment: (was: KAFKA-1947.patch) > can't explicitly set replica-assignment when add partition

[jira] [Updated] (KAFKA-1947) can't explicitly set replica-assignment when add partitions

2015-02-12 Thread Honghai Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Honghai Chen updated KAFKA-1947: Attachment: KAFKA-1947.patch > can't explicitly set replica-assignment when add partitions > ---

[jira] [Commented] (KAFKA-1947) can't explicitly set replica-assignment when add partitions

2015-02-12 Thread Honghai Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14317832#comment-14317832 ] Honghai Chen commented on KAFKA-1947: - Created reviewboard against branch origin/trun

[jira] [Issue Comment Deleted] (KAFKA-1947) can't explicitly set replica-assignment when add partitions

2015-02-12 Thread Honghai Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Honghai Chen updated KAFKA-1947: Comment: was deleted (was: Created reviewboard against branch origin/trunk) > can't explicitly set

[jira] [Issue Comment Deleted] (KAFKA-1947) can't explicitly set replica-assignment when add partitions

2015-02-12 Thread Honghai Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Honghai Chen updated KAFKA-1947: Comment: was deleted (was: Created reviewboard against branch origin/trunk) > can't explicitly set

Review Request 30919: Patch for KAFKA-1947

2015-02-12 Thread Honghai Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30919/ --- Review request for kafka. Bugs: KAFKA-1947 https://issues.apache.org/jira/b

[jira] [Updated] (KAFKA-1947) can't explicitly set replica-assignment when add partitions

2015-02-12 Thread Honghai Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Honghai Chen updated KAFKA-1947: Attachment: KAFKA-1947.patch > can't explicitly set replica-assignment when add partitions > ---

[jira] [Commented] (KAFKA-1947) can't explicitly set replica-assignment when add partitions

2015-02-12 Thread Honghai Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14317824#comment-14317824 ] Honghai Chen commented on KAFKA-1947: - Created reviewboard against branch origin/trun

[jira] [Updated] (KAFKA-1947) can't explicitly set replica-assignment when add partitions

2015-02-12 Thread Honghai Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Honghai Chen updated KAFKA-1947: Attachment: KAFKA-1947.patch > can't explicitly set replica-assignment when add partitions > ---

[jira] [Commented] (KAFKA-1947) can't explicitly set replica-assignment when add partitions

2015-02-12 Thread Honghai Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14317822#comment-14317822 ] Honghai Chen commented on KAFKA-1947: - Created reviewboard against branch origin/trun

[jira] [Commented] (KAFKA-1947) can't explicitly set replica-assignment when add partitions

2015-02-12 Thread Honghai Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14317821#comment-14317821 ] Honghai Chen commented on KAFKA-1947: - Created reviewboard against branch origin/trun

[jira] [Updated] (KAFKA-1947) can't explicitly set replica-assignment when add partitions

2015-02-12 Thread Honghai Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Honghai Chen updated KAFKA-1947: Attachment: KAFKA-1947.patch > can't explicitly set replica-assignment when add partitions > ---

[jira] [Updated] (KAFKA-1947) can't explicitly set replica-assignment when add partitions

2015-02-12 Thread Honghai Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Honghai Chen updated KAFKA-1947: Attachment: (was: KAFKA-1947.patch) > can't explicitly set replica-assignment when add partition

[jira] [Issue Comment Deleted] (KAFKA-1947) can't explicitly set replica-assignment when add partitions

2015-02-12 Thread Honghai Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Honghai Chen updated KAFKA-1947: Comment: was deleted (was: Created reviewboard against branch origin/trunk) > can't explicitly set

[jira] [Issue Comment Deleted] (KAFKA-1947) can't explicitly set replica-assignment when add partitions

2015-02-12 Thread Honghai Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Honghai Chen updated KAFKA-1947: Comment: was deleted (was: Created reviewboard against branch origin/trunk) > can't explicitly set

[jira] [Issue Comment Deleted] (KAFKA-1947) can't explicitly set replica-assignment when add partitions

2015-02-12 Thread Honghai Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Honghai Chen updated KAFKA-1947: Comment: was deleted (was: Created reviewboard against branch origin/trunk) > can't explicitly set

[jira] [Updated] (KAFKA-1947) can't explicitly set replica-assignment when add partitions

2015-02-12 Thread Honghai Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Honghai Chen updated KAFKA-1947: Attachment: KAFKA-1947.patch > can't explicitly set replica-assignment when add partitions > ---

[jira] [Commented] (KAFKA-1947) can't explicitly set replica-assignment when add partitions

2015-02-12 Thread Honghai Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14317808#comment-14317808 ] Honghai Chen commented on KAFKA-1947: - Created reviewboard against branch origin/trun

[jira] [Updated] (KAFKA-1947) can't explicitly set replica-assignment when add partitions

2015-02-12 Thread Honghai Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Honghai Chen updated KAFKA-1947: Attachment: (was: KAFKA-1947.patch) > can't explicitly set replica-assignment when add partition

[jira] [Commented] (KAFKA-1947) can't explicitly set replica-assignment when add partitions

2015-02-12 Thread Honghai Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14317803#comment-14317803 ] Honghai Chen commented on KAFKA-1947: - Created reviewboard against branch origin/trun

[jira] [Updated] (KAFKA-1947) can't explicitly set replica-assignment when add partitions

2015-02-12 Thread Honghai Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Honghai Chen updated KAFKA-1947: Attachment: KAFKA-1947.patch > can't explicitly set replica-assignment when add partitions > ---

[jira] [Updated] (KAFKA-1947) can't explicitly set replica-assignment when add partitions

2015-02-12 Thread Honghai Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Honghai Chen updated KAFKA-1947: Attachment: KAFKA-1947.patch > can't explicitly set replica-assignment when add partitions > ---

[jira] [Commented] (KAFKA-1947) can't explicitly set replica-assignment when add partitions

2015-02-12 Thread Honghai Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14317802#comment-14317802 ] Honghai Chen commented on KAFKA-1947: - Created reviewboard against branch origin/trun

[jira] [Commented] (KAFKA-1760) Implement new consumer client

2015-02-12 Thread Hongliang Su (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14317786#comment-14317786 ] Hongliang Su commented on KAFKA-1760: - [~jkreps] do you have any docs about how to use

[jira] [Commented] (KAFKA-1947) can't explicitly set replica-assignment when add partitions

2015-02-12 Thread Honghai Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14317781#comment-14317781 ] Honghai Chen commented on KAFKA-1947: - The fix is quite directly: When has replicaAssi

[jira] [Commented] (KAFKA-1947) can't explicitly set replica-assignment when add partitions

2015-02-12 Thread Honghai Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14317775#comment-14317775 ] Honghai Chen commented on KAFKA-1947: - Created reviewboard against branch origin/trun

[jira] [Updated] (KAFKA-1947) can't explicitly set replica-assignment when add partitions

2015-02-12 Thread Honghai Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Honghai Chen updated KAFKA-1947: Attachment: KAFKA-1947.patch > can't explicitly set replica-assignment when add partitions > ---