[jira] [Updated] (KAFKA-1650) Mirror Maker could lose data on unclean shutdown.

[ https://issues.apache.org/jira/browse/KAFKA-1650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin updated KAFKA-1650: Attachment: KAFKA-1650_2014-12-18_23:41:16.patch > Mirror Maker could lose data on unclean shutdown.

[jira] [Commented] (KAFKA-1650) Mirror Maker could lose data on unclean shutdown.

[ https://issues.apache.org/jira/browse/KAFKA-1650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14253103#comment-14253103 ] Jiangjie Qin commented on KAFKA-1650: - Updated reviewboard https://reviews.apache.org/

Re: Review Request 25995: Patch for KAFKA-1650

> On Dec. 17, 2014, 1:17 p.m., Joel Koshy wrote: > > core/src/main/scala/kafka/tools/MirrorMaker.scala, line 489 > > > > > > Why not use KafkaScheduler for the offset commit task? > > Jiangjie Qin wrote: > Haven'

Re: Review Request 25995: Patch for KAFKA-1650

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25995/ --- (Updated Dec. 19, 2014, 7:41 a.m.) Review request for kafka. Bugs: KAFKA-1650

[jira] [Updated] (KAFKA-1650) Mirror Maker could lose data on unclean shutdown.

[ https://issues.apache.org/jira/browse/KAFKA-1650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin updated KAFKA-1650: Attachment: KAFKA-1650_2014-12-18_22:53:26.patch > Mirror Maker could lose data on unclean shutdown.

[jira] [Commented] (KAFKA-1650) Mirror Maker could lose data on unclean shutdown.

[ https://issues.apache.org/jira/browse/KAFKA-1650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14253071#comment-14253071 ] Jiangjie Qin commented on KAFKA-1650: - Updated reviewboard https://reviews.apache.org/

Re: Review Request 25995: Patch for KAFKA-1650

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25995/ --- (Updated Dec. 19, 2014, 6:53 a.m.) Review request for kafka. Bugs: KAFKA-1650

[jira] [Updated] (KAFKA-1650) Mirror Maker could lose data on unclean shutdown.

[ https://issues.apache.org/jira/browse/KAFKA-1650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin updated KAFKA-1650: Attachment: KAFKA-1650_2014-12-18_22:17:08.patch > Mirror Maker could lose data on unclean shutdown.

[jira] [Commented] (KAFKA-1650) Mirror Maker could lose data on unclean shutdown.

[ https://issues.apache.org/jira/browse/KAFKA-1650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14253019#comment-14253019 ] Jiangjie Qin commented on KAFKA-1650: - Updated reviewboard https://reviews.apache.org/

Re: Review Request 25995: Patch for KAFKA-1650

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25995/ --- (Updated Dec. 19, 2014, 6:17 a.m.) Review request for kafka. Bugs: KAFKA-1650

Re: Review Request 29231: Patch for KAFKA-1824

> On Dec. 19, 2014, 2:36 a.m., Eric Olander wrote: > > core/src/main/scala/kafka/tools/ConsoleProducer.scala, line 269 > > > > > > remove() returns the value assigned to the key being removed, so you > > could simply

[jira] [Commented] (KAFKA-1650) Mirror Maker could lose data on unclean shutdown.

[ https://issues.apache.org/jira/browse/KAFKA-1650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14252817#comment-14252817 ] Jiangjie Qin commented on KAFKA-1650: - Updated reviewboard https://reviews.apache.org/

Re: Review Request 25995: Patch for KAFKA-1650

> On Dec. 18, 2014, 10:42 a.m., Joel Koshy wrote: > > core/src/main/scala/kafka/tools/MirrorMaker.scala, line 614 > > > > > > Should this be fatal? i.e., fatal is normally used before exiting > > (abnormally). WARN w

[jira] [Updated] (KAFKA-1650) Mirror Maker could lose data on unclean shutdown.

[ https://issues.apache.org/jira/browse/KAFKA-1650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin updated KAFKA-1650: Attachment: KAFKA-1650_2014-12-18_18:48:18.patch > Mirror Maker could lose data on unclean shutdown.

Re: Review Request 25995: Patch for KAFKA-1650

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25995/ --- (Updated Dec. 19, 2014, 2:48 a.m.) Review request for kafka. Bugs: KAFKA-1650

Re: Review Request 29231: Patch for KAFKA-1824

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29231/#review65582 --- core/src/main/scala/kafka/tools/ConsoleProducer.scala

[jira] [Commented] (KAFKA-1824) in ConsoleProducer - properties key.separator and parse.key no longer work

[ https://issues.apache.org/jira/browse/KAFKA-1824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14252809#comment-14252809 ] Gwen Shapira commented on KAFKA-1824: - Yes, lets do that. Will help us avoid another r

Re: Review Request 29210: Patch for KAFKA-1819

> On Dec. 19, 2014, 1:23 a.m., Neha Narkhede wrote: > > core/src/test/scala/unit/kafka/admin/DeleteTopicTest.scala, line 231 > > > > > > Since the bug is about entries related to deleted topics, it will be > > good to

[jira] [Commented] (KAFKA-1806) broker can still expose uncommitted data to a consumer

[ https://issues.apache.org/jira/browse/KAFKA-1806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14252807#comment-14252807 ] Neha Narkhede commented on KAFKA-1806: -- [~lokeshbirla] I was looking for steps to rep

[jira] [Commented] (KAFKA-1824) in ConsoleProducer - properties key.separator and parse.key no longer work

[ https://issues.apache.org/jira/browse/KAFKA-1824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14252805#comment-14252805 ] Neha Narkhede commented on KAFKA-1824: -- [~gwenshap] Good catch. I wonder if we should

[jira] [Commented] (KAFKA-1824) in ConsoleProducer - properties key.separator and parse.key no longer work

[ https://issues.apache.org/jira/browse/KAFKA-1824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14252777#comment-14252777 ] Gwen Shapira commented on KAFKA-1824: - My apologies! Additional round of tests revea

[jira] [Commented] (KAFKA-1824) in ConsoleProducer - properties key.separator and parse.key no longer work

[ https://issues.apache.org/jira/browse/KAFKA-1824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14252774#comment-14252774 ] Gwen Shapira commented on KAFKA-1824: - Created reviewboard https://reviews.apache.org/

[jira] [Updated] (KAFKA-766) Isr shrink/expand check is fragile

[ https://issues.apache.org/jira/browse/KAFKA-766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-766: Fix Version/s: 0.8.3 > Isr shrink/expand check is fragile > -- > >

[jira] [Updated] (KAFKA-1824) in ConsoleProducer - properties key.separator and parse.key no longer work

[ https://issues.apache.org/jira/browse/KAFKA-1824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-1824: Attachment: KAFKA-1824.patch > in ConsoleProducer - properties key.separator and parse.key no longer

Review Request 29231: Patch for KAFKA-1824

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29231/ --- Review request for kafka. Bugs: KAFKA-1824 https://issues.apache.org/jira/b

Re: API Annotations

Yes, exactly--the goal is to just publish the javadoc on the public classes and all methods on a public class are considered public. Right now we really haven't done proper docs for the new producer--no javadoc and no examples either. This needs to get done before 0.8.2. The idea of an @Experiment

Build failed in Jenkins: Kafka-trunk #357

See Changes: [neha.narkhede] KAFKA-1824 - fix ConsoleProducer so parse.key and key.separator will work again; reviewed by Neha Narkhede -- [...truncated 1707 lines...] kafka.admin.AdminTest > testShu

Re: Review Request 29210: Patch for KAFKA-1819

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29210/#review65578 --- Overall, looks good. Have one suggestion below. core/src/test/scal

[jira] [Commented] (KAFKA-1824) in ConsoleProducer - properties key.separator and parse.key no longer work

[ https://issues.apache.org/jira/browse/KAFKA-1824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14252706#comment-14252706 ] Gwen Shapira commented on KAFKA-1824: - Thanks for the quick review [~nehanarkhede]! >

[jira] [Updated] (KAFKA-1824) in ConsoleProducer - properties key.separator and parse.key no longer work

[ https://issues.apache.org/jira/browse/KAFKA-1824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1824: - Resolution: Fixed Status: Resolved (was: Patch Available) Thanks for the patch. Pushed to

[jira] [Updated] (KAFKA-1824) in ConsoleProducer - properties key.separator and parse.key no longer work

[ https://issues.apache.org/jira/browse/KAFKA-1824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1824: - Fix Version/s: 0.8.3 > in ConsoleProducer - properties key.separator and parse.key no longer work

Re: Review Request 29211: Patch for KAFKA-1824

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29211/#review65574 --- Ship it! Ship It! - Neha Narkhede On Dec. 18, 2014, 7:08 p.m., G

Re: API Annotations

Thanks for the comments, Joe and Jay. Doing the public / private designation at package level is definitely easier than going method-by-method :) If I get your comments right, the idea is to publish java docs for the public apis on our website (or archive.apache.org) and not publish java docs for

[jira] [Updated] (KAFKA-1824) in ConsoleProducer - properties key.separator and parse.key no longer work

[ https://issues.apache.org/jira/browse/KAFKA-1824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-1824: Assignee: Gwen Shapira Status: Patch Available (was: Open) > in ConsoleProducer - properties

[jira] [Updated] (KAFKA-1824) in ConsoleProducer - properties key.separator and parse.key no longer work

[ https://issues.apache.org/jira/browse/KAFKA-1824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-1824: Attachment: KAFKA-1824.patch > in ConsoleProducer - properties key.separator and parse.key no longer

[jira] [Commented] (KAFKA-1824) in ConsoleProducer - properties key.separator and parse.key no longer work

[ https://issues.apache.org/jira/browse/KAFKA-1824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14252061#comment-14252061 ] Gwen Shapira commented on KAFKA-1824: - Created reviewboard https://reviews.apache.org/

Review Request 29211: Patch for KAFKA-1824

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29211/ --- Review request for kafka. Bugs: KAFKA-1824 https://issues.apache.org/jira/b

[jira] [Updated] (KAFKA-1819) Cleaner gets confused about deleted and re-created topics

[ https://issues.apache.org/jira/browse/KAFKA-1819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-1819: Assignee: Gwen Shapira Status: Patch Available (was: Open) > Cleaner gets confused about dele

[jira] [Commented] (KAFKA-1819) Cleaner gets confused about deleted and re-created topics

[ https://issues.apache.org/jira/browse/KAFKA-1819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14252039#comment-14252039 ] Gwen Shapira commented on KAFKA-1819: - Created reviewboard https://reviews.apache.org/

[jira] [Updated] (KAFKA-1819) Cleaner gets confused about deleted and re-created topics

[ https://issues.apache.org/jira/browse/KAFKA-1819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-1819: Attachment: KAFKA-1819.patch > Cleaner gets confused about deleted and re-created topics > -

Review Request 29210: Patch for KAFKA-1819

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29210/ --- Review request for kafka. Bugs: KAFKA-1819 https://issues.apache.org/jira/b

[jira] [Commented] (KAFKA-1806) broker can still expose uncommitted data to a consumer

[ https://issues.apache.org/jira/browse/KAFKA-1806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14251940#comment-14251940 ] lokesh Birla commented on KAFKA-1806: - Hi Neha, What is the status of fixing this iss

[jira] [Created] (KAFKA-1824) in ConsoleProducer - properties key.separator and parse.key no longer work

Gwen Shapira created KAFKA-1824: --- Summary: in ConsoleProducer - properties key.separator and parse.key no longer work Key: KAFKA-1824 URL: https://issues.apache.org/jira/browse/KAFKA-1824 Project: Kafka

[jira] [Comment Edited] (KAFKA-1823) transient unit test failure in PartitionAssignorTest

[ https://issues.apache.org/jira/browse/KAFKA-1823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14251549#comment-14251549 ] Joel Koshy edited comment on KAFKA-1823 at 12/18/14 11:43 AM: --

[jira] [Commented] (KAFKA-1823) transient unit test failure in PartitionAssignorTest

[ https://issues.apache.org/jira/browse/KAFKA-1823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14251551#comment-14251551 ] Joel Koshy commented on KAFKA-1823: --- Created reviewboard https://reviews.apache.org/r/29

[jira] [Updated] (KAFKA-1823) transient unit test failure in PartitionAssignorTest

[ https://issues.apache.org/jira/browse/KAFKA-1823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1823: -- Attachment: KAFKA-1823.patch > transient unit test failure in PartitionAssignorTest > --

[jira] [Updated] (KAFKA-1823) transient unit test failure in PartitionAssignorTest

[ https://issues.apache.org/jira/browse/KAFKA-1823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1823: -- Assignee: Joel Koshy Status: Patch Available (was: Open) > transient unit test failure in Partiti

Review Request 29203: Patch for KAFKA-1823

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29203/ --- Review request for kafka. Bugs: KAFKA-1823 https://issues.apache.org/jira/b

[jira] [Commented] (KAFKA-1823) transient unit test failure in PartitionAssignorTest

[ https://issues.apache.org/jira/browse/KAFKA-1823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14251549#comment-14251549 ] Joel Koshy commented on KAFKA-1823: --- This was caused by KAFKA-1684 - it can be reproduce

Re: Review Request 25995: Patch for KAFKA-1650

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25995/#review65477 --- core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala

Re: Review Request 25995: Patch for KAFKA-1650

> On Dec. 17, 2014, 1:17 p.m., Joel Koshy wrote: > > core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala, line > > 338 > > > > > > Can we make this a "reliable" commit - i.e., with retries up to the

Re: Review Request 27391: Fix KAFKA-1634

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27391/#review65462 --- clients/src/main/java/org/apache/kafka/common/requests/OffsetCommit