Re: Review Request 28536: Patch for KAFKA-1799

2014-11-29 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28536/#review63295 --- Thanks for the patch. Some comments below. Also, could we add a uni

[jira] [Commented] (KAFKA-1791) Corrupt index after safe shutdown and restart

2014-11-29 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14228917#comment-14228917 ] Jun Rao commented on KAFKA-1791: Thanks for attaching the log file. I couldn't reproduce t

[jira] [Updated] (KAFKA-1799) ProducerConfig.METRIC_REPORTER_CLASSES_CONFIG doesn't work

2014-11-29 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1799: --- Assignee: Manikumar Reddy Status: Patch Available (was: Open) > ProducerConfig.METRIC_R

[jira] [Updated] (KAFKA-1799) ProducerConfig.METRIC_REPORTER_CLASSES_CONFIG doesn't work

2014-11-29 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1799: --- Attachment: KAFKA-1799.patch > ProducerConfig.METRIC_REPORTER_CLASSES_CONFIG doesn't work > --

[jira] [Commented] (KAFKA-1799) ProducerConfig.METRIC_REPORTER_CLASSES_CONFIG doesn't work

2014-11-29 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14228703#comment-14228703 ] Manikumar Reddy commented on KAFKA-1799: Created reviewboard https://reviews.apach

Review Request 28536: Patch for KAFKA-1799

2014-11-29 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28536/ --- Review request for kafka. Bugs: KAFKA-1799 https://issues.apache.org/jira/b