Re: Review Request 27684: Patch for KAFKA-1743

> On Nov. 7, 2014, 7:35 p.m., Gwen Shapira wrote: > > core/src/main/scala/kafka/consumer/ConsumerConnector.scala, line 73 > > > > > > I'd add a comment on why we have two interfaces here, since its > > none-obvious and

[jira] [Commented] (KAFKA-1743) ConsumerConnector.commitOffsets in 0.8.2 is not backward compatible

[ https://issues.apache.org/jira/browse/KAFKA-1743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14203262#comment-14203262 ] Manikumar Reddy commented on KAFKA-1743: Updated reviewboard https://reviews.apach

[jira] [Updated] (KAFKA-1743) ConsumerConnector.commitOffsets in 0.8.2 is not backward compatible

[ https://issues.apache.org/jira/browse/KAFKA-1743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1743: --- Attachment: KAFKA-1743_2014-11-08_11:49:31.patch > ConsumerConnector.commitOffsets in 0.8.2 is

Re: Review Request 27684: Patch for KAFKA-1743

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27684/ --- (Updated Nov. 8, 2014, 6:20 a.m.) Review request for kafka. Bugs: KAFKA-1743

Re: Review Request 27534: Patch for KAFKA-1746

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27534/#review60460 --- system_test/utils/kafka_system_test_utils.py

[jira] [Commented] (KAFKA-1634) Improve semantics of timestamp in OffsetCommitRequests and update documentation

[ https://issues.apache.org/jira/browse/KAFKA-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14203063#comment-14203063 ] Guozhang Wang commented on KAFKA-1634: -- Updated reviewboard https://reviews.apache.or

[jira] [Updated] (KAFKA-1634) Improve semantics of timestamp in OffsetCommitRequests and update documentation

[ https://issues.apache.org/jira/browse/KAFKA-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1634: - Attachment: KAFKA-1634_2014-11-07_16:54:33.patch > Improve semantics of timestamp in OffsetCommitR

Re: Review Request 27391: Fix KAFKA-1634: Add the global retentionTime (in milis) and disable the per-offset timestamp

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27391/ --- (Updated Nov. 8, 2014, 12:54 a.m.) Review request for kafka. Bugs: KAFKA-1634

Re: Review Request 27391: Fix KAFKA-1634: Add the global retentionTime (in milis) and disable the per-offset timestamp

> On Nov. 7, 2014, 3 a.m., Joel Koshy wrote: > > core/src/main/scala/kafka/server/OffsetManager.scala, line 498 > > > > > > Actually, since we always set the retention period (for v0, v1) in > > KafkaApis do we need t

Re: Review Request 27391: Fix KAFKA-1634: Add the global retentionTime (in milis) and disable the per-offset timestamp

> On Nov. 7, 2014, 3 a.m., Joel Koshy wrote: > > core/src/main/scala/kafka/common/OffsetMetadataAndError.scala, line 22 > > > > > > Can we mark this @Deprecated as well? > > > > We should probably make the prim

Re: Review Request 27391: Fix KAFKA-1634: Add the global retentionTime (in milis) and disable the per-offset timestamp

> On Nov. 7, 2014, 3 a.m., Joel Koshy wrote: > > clients/src/main/java/org/apache/kafka/common/requests/OffsetCommitRequest.java, > > line 152 > > > > > > This confused me a bit, and I think it is because initCommonFi

[jira] [Commented] (KAFKA-1742) ControllerContext removeTopic does not correctly update state

[ https://issues.apache.org/jira/browse/KAFKA-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14202955#comment-14202955 ] Joel Koshy commented on KAFKA-1742: --- +1, although one minor change: {code} // instead of

[jira] [Created] (KAFKA-1759) transient unit test failure in PartitionAssignorTest

Jun Rao created KAFKA-1759: -- Summary: transient unit test failure in PartitionAssignorTest Key: KAFKA-1759 URL: https://issues.apache.org/jira/browse/KAFKA-1759 Project: Kafka Issue Type: Bug

Re: Review Request 27684: Patch for KAFKA-1743

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27684/#review60375 --- core/src/main/scala/kafka/consumer/ConsumerConnector.scala

Re: Review Request 27684: Patch for KAFKA-1743

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27684/#review60364 --- core/src/main/scala/kafka/consumer/ConsumerConnector.scala

Re: Review Request 27723: Patch for KAFKA-1739

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27723/#review60359 --- Ship it! - Guozhang Wang On Nov. 7, 2014, 12:26 p.m., Manikumar R

Build failed in Jenkins: Kafka-trunk #325

See Changes: [junrao] kafka-1738; Partitions for topic not created after restart from forced shutdown; patched by Jun Rao; reviewed by Neha Narkhede -- [...truncated 413 lines...] kafka.integration.P

[jira] [Commented] (KAFKA-1460) NoReplicaOnlineException: No replica for partition

[ https://issues.apache.org/jira/browse/KAFKA-1460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14202488#comment-14202488 ] Jon Riegel commented on KAFKA-1460: --- We experienced this issue with a production deploym

[jira] [Updated] (KAFKA-1738) Partitions for topic not created after restart from forced shutdown

[ https://issues.apache.org/jira/browse/KAFKA-1738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1738: --- Resolution: Fixed Status: Resolved (was: Patch Available) Thanks for the review. Double committed to

[jira] [Commented] (KAFKA-1742) ControllerContext removeTopic does not correctly update state

[ https://issues.apache.org/jira/browse/KAFKA-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14202418#comment-14202418 ] Guozhang Wang commented on KAFKA-1742: -- Thanks for the patch, looks good to me. > Co

[jira] [Commented] (KAFKA-1173) Using Vagrant to get up and running with Apache Kafka

[ https://issues.apache.org/jira/browse/KAFKA-1173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14202396#comment-14202396 ] Ewen Cheslack-Postava commented on KAFKA-1173: -- I took [~joestein]'s patch an

[jira] [Commented] (KAFKA-1173) Using Vagrant to get up and running with Apache Kafka

[ https://issues.apache.org/jira/browse/KAFKA-1173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14202395#comment-14202395 ] Ewen Cheslack-Postava commented on KAFKA-1173: -- Created reviewboard https://r

[jira] [Updated] (KAFKA-1173) Using Vagrant to get up and running with Apache Kafka

[ https://issues.apache.org/jira/browse/KAFKA-1173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewen Cheslack-Postava updated KAFKA-1173: - Attachment: KAFKA-1173.patch > Using Vagrant to get up and running with Apache Kaf

Review Request 27735: Patch for KAFKA-1173

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27735/ --- Review request for kafka. Bugs: KAFKA-1173 https://issues.apache.org/jira/b

[jira] [Commented] (KAFKA-188) Support multiple data directories

[ https://issues.apache.org/jira/browse/KAFKA-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14202355#comment-14202355 ] Jay Kreps commented on KAFKA-188: - [~chenshangan...@163.com] see my comment earlier on this

[jira] [Comment Edited] (KAFKA-493) High CPU usage on inactive server

[ https://issues.apache.org/jira/browse/KAFKA-493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14202310#comment-14202310 ] Jing Dong edited comment on KAFKA-493 at 11/7/14 5:29 PM: -- [~smede

[jira] [Commented] (KAFKA-493) High CPU usage on inactive server

[ https://issues.apache.org/jira/browse/KAFKA-493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14202310#comment-14202310 ] Jing Dong commented on KAFKA-493: - [~smeder] Thanks for the response - do you remember what

[jira] [Commented] (KAFKA-1745) Each new thread creates a PIPE and KQUEUE as open files during producer.send() and does not get cleared when the thread that creates them is cleared.

[ https://issues.apache.org/jira/browse/KAFKA-1745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14202291#comment-14202291 ] Ewen Cheslack-Postava commented on KAFKA-1745: -- [~Vishal M] I looked into thi

[jira] [Commented] (KAFKA-1733) Producer.send will block indeterminately when broker is unavailable.

[ https://issues.apache.org/jira/browse/KAFKA-1733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14202276#comment-14202276 ] Solon Gordon commented on KAFKA-1733: - Any chance of getting this into a bugfix releas

[jira] [Commented] (KAFKA-493) High CPU usage on inactive server

[ https://issues.apache.org/jira/browse/KAFKA-493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14202228#comment-14202228 ] Sam Meder commented on KAFKA-493: - Sorry, don't have that anymore - it's been too long > H

[jira] [Commented] (KAFKA-1738) Partitions for topic not created after restart from forced shutdown

[ https://issues.apache.org/jira/browse/KAFKA-1738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14202173#comment-14202173 ] schandr commented on KAFKA-1738: The patch works and thanks for the help!!!. Will this be

[jira] [Updated] (KAFKA-1667) topic-level configuration not validated

[ https://issues.apache.org/jira/browse/KAFKA-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dmytro Kostiuchenko updated KAFKA-1667: --- Attachment: KAFKA-1667_2014-11-07_14:28:14.patch > topic-level configuration not vali

Re: Review Request 27634: Patch for KAFKA-1667

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27634/ --- (Updated Nov. 7, 2014, 1:28 p.m.) Review request for kafka. Bugs: KAFKA-1667

[jira] [Commented] (KAFKA-1667) topic-level configuration not validated

[ https://issues.apache.org/jira/browse/KAFKA-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14202026#comment-14202026 ] Dmytro Kostiuchenko commented on KAFKA-1667: Updated reviewboard https://revie

[jira] [Commented] (KAFKA-1739) Remove testComplexCompressDecompress in MessageCompressionTest

[ https://issues.apache.org/jira/browse/KAFKA-1739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14201985#comment-14201985 ] Manikumar Reddy commented on KAFKA-1739: Created reviewboard https://reviews.apach

[jira] [Updated] (KAFKA-1739) Remove testComplexCompressDecompress in MessageCompressionTest

[ https://issues.apache.org/jira/browse/KAFKA-1739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1739: --- Attachment: KAFKA-1739.patch > Remove testComplexCompressDecompress in MessageCompressionTest

[jira] [Updated] (KAFKA-1739) Remove testComplexCompressDecompress in MessageCompressionTest

[ https://issues.apache.org/jira/browse/KAFKA-1739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1739: --- Assignee: Manikumar Reddy Status: Patch Available (was: Open) > Remove testComplexCompr

Review Request 27723: Patch for KAFKA-1739

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27723/ --- Review request for kafka. Bugs: KAFKA-1739 https://issues.apache.org/jira/b

[jira] [Issue Comment Deleted] (KAFKA-1749) Brokers continually throw exceptions when there are hundreds of topic being fetched by mirrormaker

[ https://issues.apache.org/jira/browse/KAFKA-1749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1749: --- Comment: was deleted (was: Created reviewboard https://reviews.apache.org/r/27722/diff/ again

[jira] [Commented] (KAFKA-1749) Brokers continually throw exceptions when there are hundreds of topic being fetched by mirrormaker

[ https://issues.apache.org/jira/browse/KAFKA-1749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14201983#comment-14201983 ] Manikumar Reddy commented on KAFKA-1749: Created reviewboard https://reviews.apach

[jira] [Updated] (KAFKA-1749) Brokers continually throw exceptions when there are hundreds of topic being fetched by mirrormaker

[ https://issues.apache.org/jira/browse/KAFKA-1749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1749: --- Attachment: KAFKA-1749.patch > Brokers continually throw exceptions when there are hundreds of

Review Request 27722: Patch for KAFKA-1749

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27722/ --- Review request for kafka. Bugs: KAFKA-1749 https://issues.apache.org/jira/b

[jira] [Commented] (KAFKA-493) High CPU usage on inactive server

[ https://issues.apache.org/jira/browse/KAFKA-493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14201913#comment-14201913 ] Jing Dong commented on KAFKA-493: - [~smeder] Do you have the hprof command you used? I can

Re: Review Request 27634: Patch for KAFKA-1667

> On Nov. 7, 2014, 5 a.m., Gwen Shapira wrote: > > core/src/test/scala/unit/kafka/integration/UncleanLeaderElectionTest.scala, > > line 144 > > > > > > String.valueOf(false) should evaluate to "false", right? Why do w

[jira] [Commented] (KAFKA-1754) KOYA - Kafka on YARN

[ https://issues.apache.org/jira/browse/KAFKA-1754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14201824#comment-14201824 ] Steve Loughran commented on KAFKA-1754: --- Thomas, yes, keytabs &c as addressed in SLI

[jira] [Comment Edited] (KAFKA-188) Support multiple data directories

[ https://issues.apache.org/jira/browse/KAFKA-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14201821#comment-14201821 ] chenshangan edited comment on KAFKA-188 at 11/7/14 9:16 AM: ass

[jira] [Commented] (KAFKA-188) Support multiple data directories

[ https://issues.apache.org/jira/browse/KAFKA-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14201821#comment-14201821 ] chenshangan commented on KAFKA-188: --- assign a new partition to the dir with the fewest pa