Re: Review Request 24676: Fix KAFKA-1583

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24676/ --- (Updated Sept. 2, 2014, 1:09 a.m.) Review request for kafka. Bugs: KAFKA-1583

[jira] [Commented] (KAFKA-1583) Kafka API Refactoring

[ https://issues.apache.org/jira/browse/KAFKA-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14117812#comment-14117812 ] Guozhang Wang commented on KAFKA-1583: -- Updated reviewboard https://reviews.apache.or

[jira] [Updated] (KAFKA-1583) Kafka API Refactoring

[ https://issues.apache.org/jira/browse/KAFKA-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1583: - Attachment: KAFKA-1583_2014-09-01_18:07:42.patch > Kafka API Refactoring > - >

Re: Review Request 24676: Fix KAFKA-1583

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24676/ --- (Updated Sept. 2, 2014, 1:07 a.m.) Review request for kafka. Bugs: KAFKA-1583

Re: Review Request 24676: Fix KAFKA-1583

> On Aug. 29, 2014, 1:42 a.m., Jun Rao wrote: > > core/src/main/scala/kafka/server/ReplicaManager.scala, line 725 > > > > > > Do we need to add the new parameter? Does it hurt to write the > > checkpoint file in uni

[jira] [Commented] (KAFKA-1616) Purgatory Size and Num.Delayed.Request metrics are incorrect

[ https://issues.apache.org/jira/browse/KAFKA-1616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14117742#comment-14117742 ] Guozhang Wang commented on KAFKA-1616: -- Updated reviewboard https://reviews.apache.or

[jira] [Updated] (KAFKA-1616) Purgatory Size and Num.Delayed.Request metrics are incorrect

[ https://issues.apache.org/jira/browse/KAFKA-1616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1616: - Attachment: KAFKA-1616_2014-09-01_14:41:56.patch > Purgatory Size and Num.Delayed.Request metrics

Re: Review Request 25155: Fix KAFKA-1616

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25155/ --- (Updated Sept. 1, 2014, 9:41 p.m.) Review request for kafka. Bugs: KAFKA-1616

Re: Review Request 25155: Fix KAFKA-1616

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25155/ --- (Updated Sept. 1, 2014, 9:40 p.m.) Review request for kafka. Bugs: KAFKA-1616

Re: Review Request 25155: Fix KAFKA-1616

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25155/ --- (Updated Sept. 1, 2014, 9:38 p.m.) Review request for kafka. Bugs: KAFKA-1616

[jira] [Comment Edited] (KAFKA-1282) Disconnect idle socket connection in Selector

[ https://issues.apache.org/jira/browse/KAFKA-1282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14117638#comment-14117638 ] nicu marasoiu edited comment on KAFKA-1282 at 9/1/14 8:55 PM: --

Re: Review Request 25155: Fix KAFKA-1616

> On Aug. 28, 2014, 11:44 p.m., Jun Rao wrote: > > core/src/main/scala/kafka/server/RequestPurgatory.scala, line 258 > > > > > > I am wonder if we should do two separate tests: (1) if enqueued() >= > > purgeInterval,

[jira] [Comment Edited] (KAFKA-1282) Disconnect idle socket connection in Selector

[ https://issues.apache.org/jira/browse/KAFKA-1282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14117638#comment-14117638 ] nicu marasoiu edited comment on KAFKA-1282 at 9/1/14 8:28 PM: --

[jira] [Comment Edited] (KAFKA-1282) Disconnect idle socket connection in Selector

[ https://issues.apache.org/jira/browse/KAFKA-1282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14117638#comment-14117638 ] nicu marasoiu edited comment on KAFKA-1282 at 9/1/14 8:26 PM: --

[jira] [Comment Edited] (KAFKA-1282) Disconnect idle socket connection in Selector

[ https://issues.apache.org/jira/browse/KAFKA-1282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14117638#comment-14117638 ] nicu marasoiu edited comment on KAFKA-1282 at 9/1/14 8:25 PM: --

[jira] [Comment Edited] (KAFKA-1282) Disconnect idle socket connection in Selector

[ https://issues.apache.org/jira/browse/KAFKA-1282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14117638#comment-14117638 ] nicu marasoiu edited comment on KAFKA-1282 at 9/1/14 8:18 PM: --

[jira] [Updated] (KAFKA-1622) project shouldn't require signing to build

[ https://issues.apache.org/jira/browse/KAFKA-1622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-1622: - Priority: Blocker (was: Major) > project shouldn't require signing to build > ---

[jira] [Comment Edited] (KAFKA-1282) Disconnect idle socket connection in Selector

[ https://issues.apache.org/jira/browse/KAFKA-1282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14117638#comment-14117638 ] nicu marasoiu edited comment on KAFKA-1282 at 9/1/14 7:58 PM: --

Re: Review Request 25236: Patch for KAFKA-1619

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25236/#review52001 --- Ship it! Shall we remove the whole perf directory as well? - Guozh

[jira] [Comment Edited] (KAFKA-1282) Disconnect idle socket connection in Selector

[ https://issues.apache.org/jira/browse/KAFKA-1282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14117638#comment-14117638 ] nicu marasoiu edited comment on KAFKA-1282 at 9/1/14 7:46 PM: --

[jira] [Comment Edited] (KAFKA-1282) Disconnect idle socket connection in Selector

[ https://issues.apache.org/jira/browse/KAFKA-1282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14117638#comment-14117638 ] nicu marasoiu edited comment on KAFKA-1282 at 9/1/14 7:30 PM: --

[jira] [Comment Edited] (KAFKA-1282) Disconnect idle socket connection in Selector

[ https://issues.apache.org/jira/browse/KAFKA-1282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14117638#comment-14117638 ] nicu marasoiu edited comment on KAFKA-1282 at 9/1/14 7:29 PM: --

[jira] [Comment Edited] (KAFKA-1282) Disconnect idle socket connection in Selector

[ https://issues.apache.org/jira/browse/KAFKA-1282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14117638#comment-14117638 ] nicu marasoiu edited comment on KAFKA-1282 at 9/1/14 6:57 PM: --

[jira] [Updated] (KAFKA-1282) Disconnect idle socket connection in Selector

[ https://issues.apache.org/jira/browse/KAFKA-1282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] nicu marasoiu updated KAFKA-1282: - Attachment: idleDisconnect.patch Wow, sorry about that:) Yes, of course, that was the intent! More

[jira] [Updated] (KAFKA-1282) Disconnect idle socket connection in Selector

[ https://issues.apache.org/jira/browse/KAFKA-1282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] nicu marasoiu updated KAFKA-1282: - Attachment: (was: Patch_updated__Configurable_max_idleness_of_a_connection_since_the_last_read

[jira] [Created] (KAFKA-1622) project shouldn't require signing to build

Joe Stein created KAFKA-1622: Summary: project shouldn't require signing to build Key: KAFKA-1622 URL: https://issues.apache.org/jira/browse/KAFKA-1622 Project: Kafka Issue Type: Bug

[jira] [Commented] (KAFKA-1282) Disconnect idle socket connection in Selector

[ https://issues.apache.org/jira/browse/KAFKA-1282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14117621#comment-14117621 ] Jun Rao commented on KAFKA-1282: Looking at the patch again, in removeEldestEntry(), shoul

[jira] Subscription: outstanding kafka patches

Issue Subscription Filter: outstanding kafka patches (128 issues) The list of outstanding kafka patches Subscriber: kafka-mailing-list Key Summary KAFKA-1620 Make kafka api protocol implementation public https://issues.apache.org/jira/browse/KAFKA-1620 KAFKA-1619 perf dir can

[jira] [Updated] (KAFKA-1619) perf dir can be removed

[ https://issues.apache.org/jira/browse/KAFKA-1619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1619: --- Assignee: Jun Rao Status: Patch Available (was: Open) > perf dir can be removed > -

Re: Review Request 25236: Patch for KAFKA-1619

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25236/ --- (Updated Sept. 1, 2014, 5:55 p.m.) Review request for kafka. Bugs: KAFKA-1619

[jira] [Commented] (KAFKA-1619) perf dir can be removed

[ https://issues.apache.org/jira/browse/KAFKA-1619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14117598#comment-14117598 ] Jun Rao commented on KAFKA-1619: Updated reviewboard https://reviews.apache.org/r/25236/di

[jira] [Updated] (KAFKA-1619) perf dir can be removed

[ https://issues.apache.org/jira/browse/KAFKA-1619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1619: --- Attachment: KAFKA-1619_2014-09-01_10:55:38.patch > perf dir can be removed > --- > >

Re: Review Request 25236: Patch for KAFKA-1619

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25236/ --- (Updated Sept. 1, 2014, 5:40 p.m.) Review request for kafka. Bugs: KAFKA-1619

Review Request 25236: Patch for KAFKA-1619

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25236/ --- Review request for kafka. Bugs: KAFKA-1619 https://issues.apache.org/jira/b

[jira] [Updated] (KAFKA-1621) Standardize --messages option in perf scripts

[ https://issues.apache.org/jira/browse/KAFKA-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps updated KAFKA-1621: - Affects Version/s: 0.8.1.1 > Standardize --messages option in perf scripts > -

[jira] [Updated] (KAFKA-1621) Standardize --messages option in perf scripts

[ https://issues.apache.org/jira/browse/KAFKA-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps updated KAFKA-1621: - Labels: newbie (was: ) > Standardize --messages option in perf scripts >

[jira] [Created] (KAFKA-1621) Standardize --messages option in perf scripts

Jay Kreps created KAFKA-1621: Summary: Standardize --messages option in perf scripts Key: KAFKA-1621 URL: https://issues.apache.org/jira/browse/KAFKA-1621 Project: Kafka Issue Type: Bug

Re: [jira] [Updated] (KAFKA-1620) Make kafka api protocol implementation public

I'm curiosity why Kafka don't implementation protocol by protocol buffer or any other tools . It's good to use by other language 2014-09-01 22:48 GMT+08:00 Anton Karamanov (JIRA) : > > [ > https://issues.apache.org/jira/browse/KAFKA-1620?page=com.atlassian.jira.plugin.system.issuetabpanels:

[jira] [Updated] (KAFKA-1620) Make kafka api protocol implementation public

[ https://issues.apache.org/jira/browse/KAFKA-1620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anton Karamanov updated KAFKA-1620: --- Reviewer: Jun Rao Assignee: Anton Karamanov Status: Patch Available (was: Open) > M

[jira] [Updated] (KAFKA-1620) Make kafka api protocol implementation public

[ https://issues.apache.org/jira/browse/KAFKA-1620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anton Karamanov updated KAFKA-1620: --- Attachment: 0001-KAFKA-1620-Make-kafka-api-protocol-implementation-pu.patch Here's a small [p

[jira] [Created] (KAFKA-1620) Make kafka api protocol implementation public

Anton Karamanov created KAFKA-1620: -- Summary: Make kafka api protocol implementation public Key: KAFKA-1620 URL: https://issues.apache.org/jira/browse/KAFKA-1620 Project: Kafka Issue Type: I