Re: Review Request 24653: Patch for KAFKA-1577

2014-08-20 Thread Sriharsha Chintalapani
> On Aug. 13, 2014, 7:44 p.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/network/SocketServer.scala, line 470 > > > > > > While this may fix the NoSuchElementException, I wonder why the error > > happened in

[jira] [Commented] (KAFKA-1577) Exception in ConnectionQuotas while shutting down

2014-08-20 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14104979#comment-14104979 ] Sriharsha Chintalapani commented on KAFKA-1577: --- Updated reviewboard https:/

[jira] [Updated] (KAFKA-1577) Exception in ConnectionQuotas while shutting down

2014-08-20 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriharsha Chintalapani updated KAFKA-1577: -- Attachment: KAFKA-1577_2014-08-20_19:57:44.patch > Exception in ConnectionQuota

Re: Review Request 24653: Patch for KAFKA-1577

2014-08-20 Thread Sriharsha Chintalapani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24653/ --- (Updated Aug. 21, 2014, 2:58 a.m.) Review request for kafka. Bugs: KAFKA-1577

[jira] [Commented] (KAFKA-687) Rebalance algorithm should consider partitions from all topics

2014-08-20 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14104897#comment-14104897 ] Joel Koshy commented on KAFKA-687: -- Updated reviewboard https://reviews.apache.org/r/23655

[jira] [Updated] (KAFKA-687) Rebalance algorithm should consider partitions from all topics

2014-08-20 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-687: - Attachment: KAFKA-687_2014-08-20_18:09:28.patch > Rebalance algorithm should consider partitions from all

Re: Review Request 23655: Patch for KAFKA-687

2014-08-20 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23655/#review51153 --- core/src/main/scala/kafka/consumer/PartitionAssignor.scala

Re: Review Request 23655: Patch for KAFKA-687

2014-08-20 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23655/ --- (Updated Aug. 21, 2014, 1:10 a.m.) Review request for kafka. Bugs: KAFKA-687

[jira] [Commented] (KAFKA-1597) New metrics: ResponseQueueSize and BeingSentResponses

2014-08-20 Thread Alexis Midon (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14104815#comment-14104815 ] Alexis Midon commented on KAFKA-1597: - [~nehanarkhede] patch updated. thanks for your

[jira] [Updated] (KAFKA-1597) New metrics: ResponseQueueSize and BeingSentResponses

2014-08-20 Thread Alexis Midon (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexis Midon updated KAFKA-1597: Attachment: (was: KAFKA-1594_ResponseQueueSize.patch) > New metrics: ResponseQueueSize and Bein

[jira] [Updated] (KAFKA-1597) New metrics: ResponseQueueSize and BeingSentResponses

2014-08-20 Thread Alexis Midon (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexis Midon updated KAFKA-1597: Attachment: (was: KAFKA-1594_ResponsesBeingSent.patch) > New metrics: ResponseQueueSize and Bei

[jira] [Updated] (KAFKA-1597) New metrics: ResponseQueueSize and BeingSentResponses

2014-08-20 Thread Alexis Midon (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexis Midon updated KAFKA-1597: Attachment: ResponsesBeingSent.patch ResponseQueueSize.patch > New metrics: Respons

[jira] [Updated] (KAFKA-1597) New metrics: ResponseQueueSize and BeingSentResponses

2014-08-20 Thread Alexis Midon (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexis Midon updated KAFKA-1597: Attachment: (was: KAFKA-1594_BeingSentResponses.patch) > New metrics: ResponseQueueSize and Bei

[jira] [Updated] (KAFKA-1597) New metrics: ResponseQueueSize and BeingSentResponses

2014-08-20 Thread Alexis Midon (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexis Midon updated KAFKA-1597: Attachment: KAFKA-1594_ResponsesBeingSent.patch rename {{BeingSentResponses}} into {{ResponsesBeing

[jira] [Commented] (KAFKA-1123) Broker IPv6 addresses parsed incorrectly

2014-08-20 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14104751#comment-14104751 ] Jun Rao commented on KAFKA-1123: 1. kafka-client doesn't depend on core. However, core alr

[jira] [Comment Edited] (KAFKA-1123) Broker IPv6 addresses parsed incorrectly

2014-08-20 Thread JIRA
[ https://issues.apache.org/jira/browse/KAFKA-1123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14101076#comment-14101076 ] Krzysztof SzafraƄski edited comment on KAFKA-1123 at 8/20/14 9:22 PM: --

[jira] [Commented] (KAFKA-1605) Producer should not require metadata.broker.list

2014-08-20 Thread Todd Palino (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14104581#comment-14104581 ] Todd Palino commented on KAFKA-1605: There are a lot of concerns with this... 1) We a

Re: Review Request 24676: WIP KAFKA-1583

2014-08-20 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24676/ --- (Updated Aug. 20, 2014, 9 p.m.) Review request for kafka. Bugs: KAFKA-1583

[jira] [Commented] (KAFKA-1583) Kafka API Refactoring

2014-08-20 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14104560#comment-14104560 ] Guozhang Wang commented on KAFKA-1583: -- Updated reviewboard https://reviews.apache.or

[jira] [Updated] (KAFKA-1583) Kafka API Refactoring

2014-08-20 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1583: - Attachment: KAFKA-1583_2014-08-20_13:54:38.patch > Kafka API Refactoring > -

[jira] [Updated] (KAFKA-1583) Kafka API Refactoring

2014-08-20 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1583: - Status: Patch Available (was: Open) > Kafka API Refactoring > - > >

Re: Review Request 24676: WIP KAFKA-1583

2014-08-20 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24676/ --- (Updated Aug. 20, 2014, 8:55 p.m.) Review request for kafka. Summary (updated

[jira] [Commented] (KAFKA-1605) Producer should not require metadata.broker.list

2014-08-20 Thread Prashant Deva (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14104429#comment-14104429 ] Prashant Deva commented on KAFKA-1605: -- it would be very helpful if you could explain

[jira] [Created] (KAFKA-1606) Reference to old zk.connect vs broker.list found in docs under Produce APIs

2014-08-20 Thread Paul Otto (JIRA)
Paul Otto created KAFKA-1606: Summary: Reference to old zk.connect vs broker.list found in docs under Produce APIs Key: KAFKA-1606 URL: https://issues.apache.org/jira/browse/KAFKA-1606 Project: Kafka

Re: Review Request 23655: Patch for KAFKA-687

2014-08-20 Thread Joel Koshy
> On Aug. 20, 2014, 3:23 p.m., Jun Rao wrote: > > core/src/main/scala/kafka/consumer/PartitionAllocator.scala, line 27 > > > > > > Could we add a comment on what the return value is, especially the > > String part? Su

[jira] [Commented] (KAFKA-1605) Producer should not require metadata.broker.list

2014-08-20 Thread Todd Palino (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14104110#comment-14104110 ] Todd Palino commented on KAFKA-1605: Upcoming work for the consumer is going to move c

Re: Which is better?

2014-08-20 Thread Philip O'Toole
If you have studied the docs yet, you should, as this is a broad question which needs background to understand the answer. But in summary, the high-level Consumer does more for you, and importantly, provides balancing between Consumers. The SimpleConsumer does less for you, but gives you more c

[jira] [Updated] (KAFKA-1524) Implement transactional producer

2014-08-20 Thread Raul Castro Fernandez (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raul Castro Fernandez updated KAFKA-1524: - Attachment: KAFKA-1524_2014-08-20_09:14:59.patch > Implement transactional produc

[jira] [Commented] (KAFKA-1524) Implement transactional producer

2014-08-20 Thread Raul Castro Fernandez (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14104085#comment-14104085 ] Raul Castro Fernandez commented on KAFKA-1524: -- Updated reviewboard https://r

Re: Review Request 24411: Patch for KAFKA-1524

2014-08-20 Thread Raul Castro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24411/ --- (Updated Aug. 20, 2014, 4:15 p.m.) Review request for kafka. Bugs: KAFKA-1524

[jira] [Commented] (KAFKA-1601) ConsoleConsumer/SimpleConsumerPerformance should be transaction-aware

2014-08-20 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14104065#comment-14104065 ] Dong Lin commented on KAFKA-1601: - Updated reviewboard https://reviews.apache.org/r/24856/

[jira] [Updated] (KAFKA-1601) ConsoleConsumer/SimpleConsumerPerformance should be transaction-aware

2014-08-20 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-1601: Attachment: KAFKA-1601_2014-08-20_08:57:29.patch > ConsoleConsumer/SimpleConsumerPerformance should be tran

Re: Review Request 24856: Patch for KAFKA-1601

2014-08-20 Thread Dong Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24856/ --- (Updated Aug. 20, 2014, 3:57 p.m.) Review request for kafka. Bugs: KAFKA-1601

Which is better?

2014-08-20 Thread pankaj ojha
Hi All, My requirement is to consume data from kafka using consumer. Which should be better to use? SimpleConsumer or HighLevel Consumer? Thanks, Pankaj Ojha

Re: Review Request 23655: Patch for KAFKA-687

2014-08-20 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23655/#review51104 --- core/src/main/scala/kafka/consumer/PartitionAllocator.scala

[jira] [Assigned] (KAFKA-1559) Upgrade Gradle wrapper to Gradle 2.0

2014-08-20 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein reassigned KAFKA-1559: Assignee: Ivan Lyutov > Upgrade Gradle wrapper to Gradle 2.0 >

[jira] [Resolved] (KAFKA-1399) Drop Scala 2.8.x support

2014-08-20 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein resolved KAFKA-1399. -- Resolution: Fixed Fix Version/s: 0.8.2 Assignee: Ivan Lyutov taken care of in KAFKA-141

[jira] [Updated] (KAFKA-1559) Upgrade Gradle wrapper to Gradle 2.0

2014-08-20 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-1559: - Resolution: Fixed Fix Version/s: 0.8.2 Status: Resolved (was: Patch Available) yup, i

[jira] [Commented] (KAFKA-1559) Upgrade Gradle wrapper to Gradle 2.0

2014-08-20 Thread Stevo Slavic (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14103893#comment-14103893 ] Stevo Slavic commented on KAFKA-1559: - I see Gradle wrapper was upgraded as part of KA

FW: fsync behaviour

2014-08-20 Thread Manjunath Shivakumar
Hi, Cross posting to devs for elaboration. Thanks, Manju From: Manjunath Shivakumar [manjunath.shivaku...@betfair.com] Sent: 20 August 2014 02:00 To: us...@kafka.apache.org Subject: fsync behaviour Hi, I wanted to understand the exact behaviour of kafka

[jira] [Commented] (KAFKA-1328) Add new consumer APIs

2014-08-20 Thread Stevo Slavic (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14103821#comment-14103821 ] Stevo Slavic commented on KAFKA-1328: - Affects 0.9.0 ?! > Add new consumer APIs > ---

[jira] [Commented] (KAFKA-1485) Upgrade to Zookeeper 3.4.6 and create "shim" for ZKCLI so system tests can run

2014-08-20 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14103592#comment-14103592 ] Joe Stein commented on KAFKA-1485: -- There are a lot of bug fixes in 3.4.6 (http://zookee

[jira] [Updated] (KAFKA-1600) Controller failover not working correctly.

2014-08-20 Thread Ding Haifeng (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ding Haifeng updated KAFKA-1600: Attachment: kafka_failure_logs.tar.gz Guozhang and Neha, Thanks for reply. In the attachment are c

[jira] [Commented] (KAFKA-1605) Producer should not require metadata.broker.list

2014-08-20 Thread Prashant Deva (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14103553#comment-14103553 ] Prashant Deva commented on KAFKA-1605: -- why not just connect to zookeeper at startup,

[jira] [Commented] (KAFKA-1605) Producer should not require metadata.broker.list

2014-08-20 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14103548#comment-14103548 ] Joe Stein commented on KAFKA-1605: -- You need the meta data request/response not just on s