[jira] [Commented] (KAFKA-1419) cross build for scala 2.11

2014-08-01 Thread Patrick Wendell (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083369#comment-14083369 ] Patrick Wendell commented on KAFKA-1419: Hey all - just chiming in from the Apache

[jira] [Commented] (KAFKA-1510) Force offset commits when migrating consumer offsets from zookeeper to kafka

2014-08-01 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083237#comment-14083237 ] Joel Koshy commented on KAFKA-1510: --- I see - my thinking was since we retry indefinitely

Re: Review Request 24196: Patch for KAFKA-1567

2014-08-01 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24196/#review49401 --- To be more precisely, in the old clients we have four stats classes:

Re: Review Request 24196: Patch for KAFKA-1567

2014-08-01 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24196/#review49385 --- core/src/main/scala/kafka/consumer/ConsumerIterator.scala

[jira] [Commented] (KAFKA-1555) provide strong consistency with reasonable availability

2014-08-01 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083141#comment-14083141 ] Guozhang Wang commented on KAFKA-1555: -- Agreed, ack=...,-2,-1,0,1,2,... with the curr

[jira] [Commented] (KAFKA-1555) provide strong consistency with reasonable availability

2014-08-01 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083075#comment-14083075 ] Jay Kreps commented on KAFKA-1555: -- I think we may be confusing a few things: 1. The guar

[jira] [Updated] (KAFKA-1567) Metric memory leaking after closing the clients

2014-08-01 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin updated KAFKA-1567: Attachment: KAFKA-1567.patch > Metric memory leaking after closing the clients > --

[jira] [Commented] (KAFKA-1567) Metric memory leaking after closing the clients

2014-08-01 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14082990#comment-14082990 ] Jiangjie Qin commented on KAFKA-1567: - Created reviewboard https://reviews.apache.org/

Re: Review Request 24006: Patch for KAFKA-1420

2014-08-01 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24006/#review49382 --- core/src/test/scala/unit/kafka/admin/AdminTest.scala

Review Request 24196: Patch for KAFKA-1567

2014-08-01 Thread Jiangjie Qin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24196/ --- Review request for kafka. Bugs: KAFKA-1567 https://issues.apache.org/jira/b

[jira] [Commented] (KAFKA-1555) provide strong consistency with reasonable availability

2014-08-01 Thread saurabh agarwal (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14082684#comment-14082684 ] saurabh agarwal commented on KAFKA-1555: Guozhang, The new semantic (ack <= -2)

Re: Review Request 23767: Fix KAFKA-1430

2014-08-01 Thread Guozhang Wang
> On Aug. 1, 2014, 5:08 p.m., Jun Rao wrote: > > core/src/main/scala/kafka/api/FetchResponse.scala, lines 28-29 > > > > > > Since we expose simple consumer as part of the api, this renaming is > > actually an api chang

[jira] [Updated] (KAFKA-1567) Metric memory leaking after closing the clients

2014-08-01 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin updated KAFKA-1567: Attachment: KAFKA-1567.patch > Metric memory leaking after closing the clients > --

[jira] [Commented] (KAFKA-1567) Metric memory leaking after closing the clients

2014-08-01 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14082640#comment-14082640 ] Jiangjie Qin commented on KAFKA-1567: - Created reviewboard against branch origin/trun

[jira] [Commented] (KAFKA-1567) Metric memory leaking after closing the clients

2014-08-01 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14082635#comment-14082635 ] Jiangjie Qin commented on KAFKA-1567: - Created reviewboard against branch origin/trun

[jira] [Updated] (KAFKA-1567) Metric memory leaking after closing the clients

2014-08-01 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin updated KAFKA-1567: Attachment: KAFKA-1567.patch > Metric memory leaking after closing the clients > --

Re: Review Request 24113: Patch for KAFKA-1562

2014-08-01 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24113/#review49359 --- Thanks for the patch. A couple of comments below. core/src/main/sc

[jira] [Commented] (KAFKA-1567) Metric memory leaking after closing the clients

2014-08-01 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14082602#comment-14082602 ] Jiangjie Qin commented on KAFKA-1567: - Created reviewboard against branch origin/trun

[jira] [Updated] (KAFKA-1567) Metric memory leaking after closing the clients

2014-08-01 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin updated KAFKA-1567: Attachment: KAFKA-1567.patch > Metric memory leaking after closing the clients > --

Re: Review Request 23767: Fix KAFKA-1430

2014-08-01 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23767/#review49317 --- core/src/main/scala/kafka/server/DelayedFetch.scala

[jira] [Commented] (KAFKA-1489) Global threshold on data retention size

2014-08-01 Thread James Oliver (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14082503#comment-14082503 ] James Oliver commented on KAFKA-1489: - +1 for Steven's strategy - I could see this bei

[jira] [Commented] (KAFKA-1489) Global threshold on data retention size

2014-08-01 Thread Steven Zhen Wu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14082487#comment-14082487 ] Steven Zhen Wu commented on KAFKA-1489: --- topic.rentetion.bytes is also less convenie

[jira] [Updated] (KAFKA-1567) Metric memory leaking after closing the clients

2014-08-01 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin updated KAFKA-1567: Description: When consumers or producers shut down, the metrics they registered in yammer registry

[jira] [Created] (KAFKA-1567) Metric memory leaking after closing the clients

2014-08-01 Thread Jiangjie Qin (JIRA)
Jiangjie Qin created KAFKA-1567: --- Summary: Metric memory leaking after closing the clients Key: KAFKA-1567 URL: https://issues.apache.org/jira/browse/KAFKA-1567 Project: Kafka Issue Type: Bug

[jira] [Commented] (KAFKA-1510) Force offset commits when migrating consumer offsets from zookeeper to kafka

2014-08-01 Thread nicu marasoiu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14082166#comment-14082166 ] nicu marasoiu commented on KAFKA-1510: -- Hi, the "|| forceCommit" on line 318 is meant